summaryrefslogtreecommitdiff
path: root/svgio
AgeCommit message (Collapse)Author
2023-06-23tdf#155833: apply transform to image even if target is equal to viewboxXisco Fauli
Change-Id: Ie820528384d096c6a332e2abd0095f68c7f64a0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153103 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 6dce36484bfcac711251710697dca961fd77ca20) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153082 Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153153
2023-06-23tdf#145896: set style to 'text/css' by defaultXisco Fauli
This is a regression from 4c31a0be1d8048bf3340acbb59248185e4b93041 "Resolves: #i125326# accept CssStyles with missing type attribute" Calling setTextCss(true) when there are no attributes is wrong, since it might have attributes like 'id'. The unittest added also covers i125326 is still fixed Change-Id: Ic5e4899211ae98c866f64f17e69a3a8cd24e4959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153279 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153310
2023-06-18tdf#155819: check marker property comes from a style sheetXisco Fauli
Since 242b7d0162d55be0945ca849c3de841fbf6cb475 "svgio: simplify code" where bIsInStyleSheet was replaced by getCssStyleParent() incorrectly Change-Id: I48632e9374f4615e32d18a141aeabec2936e6ec8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153016 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153036 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-18tdf#155733: no need to store these valuesXisco Fauli
Remove the unittest in libreoffice-7-5 since the sample file uses <filter id="myFilter"> <feGaussianBlur in="SourceGraphic" stdDeviation="5"/> </filter> which is not supported in this branch Change-Id: I1c22f8f344731eb5fbc5f77fc80267ebcdc81ed6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152740 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 9662b23182174888045726fd57bf7d93c16cf4fb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152757 Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153037 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-12-08CppunitTest_svgio: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
This suite is large enough so that avoiding the declaration/registration/definition of each test manually saves a lot of space. Change-Id: I08359c52cfbbd2ff17ec61722479cda26f308590 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143800 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-11-29SVG import: add support for semi-transparent textMiklos Vajna
<tspan fill-opacity="..."> from SVG was ignored so far, only taking RGB colors from the 'fill' attribute, but ignoring transparency. The problem is that an SVG file is imported by mapping it to drawinglayer primitives, but TextSimplePortionPrimitive2D takes a basegfx::BColor as the font color, which doesn't handle transparency. Fix the problem by rendering SVG similar to how commit 81b0d5393ca4cf2ff0954e53b05928cde047c2e0 (svx: add rendering for semi-transparent shape text, 2019-11-20) did it for shape text: wrap the text primitive in a UnifiedTransparencePrimitive2D when opacity is not 1. Note that the drawinglayer primitive works with transparency and SVG works with opacity, which is the opposite of each other, but both are 0..1 ranges. Change-Id: If5c48613b70eac662b54b8c9da835cd0a966ba89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143429 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-11-16Use BitmapEx in BitmapPrimitive2DNoel Grandin
we no longer need to wrap it in the framework XBitmap implemenation Change-Id: I0dc56ad63364e2c5a4cedd5e70d4ae7ea7eae563 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-28use more string_view in svgioNoel Grandin
Change-Id: I30d2f02941673ce33febc4e0f563e77b80a585fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140707 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-23svgio: Simplify by using replaceAllXisco Fauli
Change-Id: Id805787c5b5a812c6fd4fbfe3c3b2905578ce3bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140482 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-23tdf#151118: don't trim leading/trailing spaces in 'preserve' caseXisco Fauli
Thanks again to Mike Kaganski for spotting Change-Id: Ifd8dcf15d7714ebc4f19083fefe0d78d27d46b4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140483 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-23tdf#151118: svg: don't replace newline with space when xml:space="default"Xisco Fauli
Partially revert ddf695db44bcb23dc2f1459fd439f93c0b6d5f2a "tdf#151118: svg: fix handling of xml:space="preserve"" See discussion in https://gerrit.libreoffice.org/c/core/+/140404 Thanks to Mike Kaganski for spotting it Change-Id: Ifdd26b8de2f5cc392127f215e148599ae63036dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140444 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-22tdf#151118: svg: fix handling of xml:space="preserve"Xisco Fauli
This allows the code to be simplified a bit Change-Id: If42dd9d3ebd7860ece9ff78cb090ff1b07e1b432 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140404 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-21tdf#103888: Do not add a gap at the end of each text portionXisco Fauli
I can't think of any situation where it's needed Change-Id: I1c2c6ec3d22eb9263f3c3c20793d9fe3926b8d78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140351 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-08-30tdf#141908 Replace usage of sal_Int32 with Color in unit testscutamar
Change-Id: Ifb5ff2e6d5ed28bcb9e190d7f2deaaa970693cbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-08-18Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxxStephan Bergmann
...so that its TOOLS_WARN_EXCEPTION can be used in comphelper/source/misc/logging.cxx in a follow-up commit. (And while at it, rename from diangose_ex.h to the more appropriate diagnose_ex.hxx. The comphelper module is sufficiently low-level for this immediate use case, so use that at least for now; o3tl might be even more suitable but doesn't have a Library until now. Also, for the immediate use case it would have sufficed to only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION, TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of include/tools/diagnose_ex.h into an additional new include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move the complete include file as is.) Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-08-14tdf#104921: Cleanup Kashida insertion logicKhaled Hosny
Communicate Kashida insertion positions in an explicit way. Rest of LibreOffice communicate adjustments to character widths (e.g. for justification or spacing) using so-called DX array. DX array is an array of absolute character positions (e.g. DX[n] is the position after character n from the start of the lines, and its widths is DX[n] - DX[n-1]). This DX array is modified also when Kashidas are inserted after a given character for Arabic justification, by expanding its width. VCL would use this to know where to insert the Kashidas and how many ones. But because DX array is used for both widths adjustments and kashida insertion, this turns out to be a source of bugs since VCL has tosecond guess the DX array to find which is pure width adjustment and which also involves Kashida insertion, and the heuristics it uses are fragile. This change adds a second array of booleans that records where Kashida is inserted and communicates it all the way from where Kashida insertion is decoded in Writer and down to VCL layout. This change passes the Kashida array only when it seems necessary (e.g. during drawing but not when measuring text since the DX array is enough in this case). Hopefully no places where Kashida insertion needs to be passed down were missed. A couple of glyph and layout flags that were used for old heuristics and no longer needed and are removed. This also fixes: tdf#87731 tdf#106309 tdf#108604 tdf#112849 tdf#114257 tdf#127176 tdf#145647 tdf#146199 Change-Id: I4ed0850ef2fdc3e9143341afac649e7e7d463c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-11tdf#150323: also add markers if there is a css style parentXisco Fauli
Change-Id: Ia900726ee31b7b19e98122d40b33581c9a60dcc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138090 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-29svgio: Add support for clip-rule="evenodd"Xisco Fauli
Change-Id: I028aa88bdd72b4f87526a3d1edabd612d7686571 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137577 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-29svgio: qa: add unittest for fill-ruleXisco Fauli
Change-Id: I76c0594d634c4154bd2b63027e93934b521998d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137573 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-22elide some makeStringAndClear() callsNoel Grandin
Change-Id: Iccdb04df53bc981e2240240daddf15e9e1bb5a16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137310 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-19crashtesting: assert seen on loading moz820988-2.svgCaolán McNamara
Change-Id: I8ceab08348875cd8a88c440091ac0227012ab358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137224 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-18related: tdf#97539: SVGIO: iterate over parent's clippathsXisco Fauli
This commit reintroduces fb33451a27d8668bc14f5bcfd6ea742fc4c5b84c "tdf#97539: SVGIO: iterate over parent's clippaths" which I reverted it in 82c0a363abbceac6464b62c3571aa3225415c7db "tdf#97539; if parent is css style, look one level up" because I thought it was no longer necessary, but I was wrong. Also add a unittest Change-Id: Ib66ca0afd63e8e52be6677b6965179e092a61aa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137195 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-18tdf#126330: use correct type for symbol nodeXisco Fauli
Change-Id: Ibd4b7e021dac28469cb3ea2d30e79de8f24c88be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137201 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-15tdf#97539; if parent is css style, look one level upXisco Fauli
if the style attributes are set like <rect x="10" y="10" width="100" height="100" fill="#00D000" clip-path="url(#myClip)"/> it works, however, if it uses a css style like <rect x="10" y="10" width="100" height="100" style="fill:#00D000" clip-path="url(#myClip)"/> it fails to get the clipPath from the parent, because the css style is the direct parent, thus, check one level up Change-Id: Iff6df95c9fa9da4c2f1a986cca0ad82ab1494353 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137094 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-15svgio: simplify codeXisco Fauli
Change-Id: I100256b63fadeb4a0e4b8e4cbb67e58d2a1ce433 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137096 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-15svgio: remove recurrent checkXisco Fauli
Change-Id: Ic8d79fdcc018a488c77cc601ee0deed76c55af87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137095 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-15svgio: qa: Add test for shape with ref to clipPathXisco Fauli
Change-Id: Ifefb27db8415eb55b22f1537e1790fcd9feb3ee4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137092 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-14svgio: factor out common codeXisco Fauli
Also skip spaces before the #, Something like xlink:href=" #target" is still valid Change-Id: Ia62e58ca31bfecd283776ec84fcc4bba1836afab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137074 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-13svgio: use href along with xlink:hrefXisco Fauli
xlink:href has been deprecated. See https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href Change-Id: I622cd975c0bcc1a819831d7b9c867312ff59affa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137035 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-08svgio: Rename variable and add unittestXisco Fauli
The meaning of the name got obsolete after cded65d05a01ac34af750ddb97f1ffb51f3d638a < tdf#149893: Color names are ASCII case-insensitive > Also add a unittest for 9b0069c2833313ba9fab91f45edd354ba334f94b "SVG: Using the marker property from a style sheet is equivalent to using all three (start, mid, end).·" when this code was added Change-Id: I87e0866cbd56bbc770920b0778ce681ac9d255b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136910 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-08svgio: o3tl::starts_with() -> o3tl::equalsIgnoreAsciiCase(o3tl::trim())Xisco Fauli
display="NONE" or display=" none " are valid but display="nonet" is not Change-Id: Ib230d9365be3671a9a0fcb05be099b7afad15375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136902 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-08svgio: forgot the 'else'Xisco Fauli
Spotted right after submitting 6dd0074e5e42467a7f82e363f67ca95d04466fa9 "tdf#149913: add support for auto-start-reverse", stupid me Change-Id: Icaade6a5941f6e1cf6d612b56bbbfd4e2321a625 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136900 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-08related: tdf#149893: trim the color nameXisco Fauli
Change-Id: I50689993cbe979557a10d2d16eb2112471bef77d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136895 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-08tdf#149913: add support for auto-start-reverseXisco Fauli
See https://svgwg.org/svg2-draft/painting.html#OrientAttribute Change-Id: Iedcca7bc79a54333c0f80927364caec82ce61167 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136894 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-08svgio: use IgnoreAsciiCase when checking these valuesXisco Fauli
They are also valid when uppercase OTOH, use equalsIgnoreAsciiCase along with trim() instead of startsWithIgnoreAsciiCase since " round " should be valid but "rounded" shouldn't Change-Id: If4060a23a1cf41833264051094103e37927d14c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136881 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-07svgio: fix copy-paste nameXisco Fauli
Change-Id: Ic29fc98f70dd14b07190fd559c54c13be5777975 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136883 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-07svgio: make readLocalUrl standard-compliantXisco Fauli
See https://bugs.documentfoundation.org/show_bug.cgi?id=149880#c12 Thanks to Mike Kaganski for the references Change-Id: Idb06cf40ee992dd73120ce051d8ba4f61faaadfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136877 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2022-07-07tdf#149893: Color names are ASCII case-insensitiveXisco Fauli
See https://www.w3.org/TR/css-color-3/#html4 Change-Id: Ifdf887bad08ab606abef78fa8335bc49507f4a43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136879 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2022-07-06tdf#149880: handle url when it's inside the quotation marksXisco Fauli
Change-Id: I053323f9b48c8856d520095da0a4768ac03b0176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136847 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-27clang-tidy modernize-pass-by-value in svgioNoel Grandin
Change-Id: I48283b202a0d5b9560a587daa4ebbf86367875ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136453 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-23Make CppunitTest_svgio CPPUNIT_TEST_NAME=Test::testCssClassRedefinition robustStephan Bergmann
That recently introduced test systematically failed on my Fedora 36 machine with > /home/sbergman/lo2/core/test/source/xmltesttools.cxx:89:(anonymous namespace)::Test::testCssClassRedefinition > equality assertion failed > - Expected: 1 > - Actual : 0 > - In <>, XPath '/primitive2D/transform/textsimpleportion[1]' number of nodes is incorrect because the dumped data was > <?xml version="1.0" encoding="UTF-8"?> > <primitive2D> > <transform xy11="26" xy12="0" xy13="0" xy21="0" xy22="26" xy23="0" xy31="0" xy32="0" xy33="1"> > <mask> > <polypolygon height="100" width="50" minx="0" miny="0" maxx="50" maxy="100" path="m0 0h50v100h-50z"> > <polygon> > <point x="0" y="0"/> > <point x="50" y="0"/> > <point x="50" y="100"/> > <point x="0" y="100"/> > </polygon> > </polypolygon> > <textsimpleportion width="16" height="16" x="20" y="20" text="test" fontcolor="#ff0000" familyname="Sans"/> > </mask> > </transform> > </primitive2D> rather than the expected > <?xml version="1.0" encoding="UTF-8"?> > <primitive2D> > <transform xy11="26" xy12="0" xy13="0" xy21="0" xy22="26" xy23="0" xy31="0" xy32="0" xy33="1"> > <textsimpleportion width="16" height="16" x="20" y="20" text="test" fontcolor="#ff0000" familyname="Sans"/> > <hiddengeometry> > <polygonhairline color="#000000"> > <polygon>0,0 50,0 50,100 0,100</polygon> > </polygonhairline> > </hiddengeometry> > </transform> > </primitive2D> because in SvgSvgNode::decomposeSvgNode (svgio/source/svgreader/svgsvgnode.cxx) aSvgCanvasRange = 50x100@(0,0) vs. aContentRange = 31x11@(20,9) did not match the > if(aSvgCanvasRange.isInside(aContentRange)) branch ("no clip needed, but an invisible HiddenGeometryPrimitive2D...") but rather the > else if(aSvgCanvasRange.overlaps(aContentRange)) branch ("Clip is necessary") introducing the additional <mask> element. The size of aContentRange (and thus whether it is contained in or merely overlaps aSvgCanvasRange) is apparently affected by what actual font gets substituted for "Sans" in any given environment. The only font that is guaranteed to always be available and is not subject to --with-fonts (which isn't already demanded via gb_CppunitTest_use_more_fonts in svgio/CppunitTest_svgio.mk) appears to be "Open Symbol" (cf. extras/Package_fonts.mk), so use that (even if it doesn't have glyphs for the given text, but which should be irrelevant for this test). Change-Id: If6f6fdc481b313aa08803b4b3f406e01ff0be1ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136350 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-22tdf#149449 Add unit test for CSS class redefinition inside SVGsofftkp
Tests what happens when a CSS class is redefined with new attributes and with already defined attributes Change-Id: I5996fa4dce6c98c1792001a11387bf570d159a8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136151 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-06-22tdf#149449 Don't ignore CSS class redefinition inside SVGsofftkp
Previously if a css class was redefined like so: .cls2,.cls3{fill:#fff;}.cls-2{opacity:0.1;} the second definition of .cls-2 would get ignored and opacity would remain 1. This patch keeps track of the names of each previously defined class and makes sure to append the future redefinition instead of ignoring it. Change-Id: I20b55aea247d11774cd743505a90f1466f622b1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136109 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-06-16loplugin:moveitNoel Grandin
Change-Id: Ic593974a44d9e327e0385c7ffaaa6d42576ae01a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-14tdf#131506 tdf#143031 EMF+ Fix displaying PathGradient fillBartosz Kosiorek
With previous implementation, the EMF+ import is calculating gradient positions wrongly. It is causing warning: SvgGradientHelper got invalid SvgGradientEntries outside [0.0 .. 1.0] and the gradient was not displayed at all. This patch fixes that and gradient is displayed correctly Change-Id: I6229c516165436d0c7ae187d9eb69b5494da396f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135607 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2022-05-29we can std::move the data out of TextBreakupHelperNoel Grandin
and save some copying Change-Id: I34cbc2edfd53fcc440d1765dba471fcbb05b2b7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135088 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-03add o3tl::matchIgnoreAsciiCaseNoel Grandin
Change-Id: Iad8e1ed256d84808404bf20ed7a16b05b3db5818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133753 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-01use more string_view in variousNoel Grandin
found by examining uses of OUString::copy() for likely places Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-29use more string_view in INetURLObjectNoel Grandin
Change-Id: I4462f7cf4740fa4d1b129d76a0775f4250f41bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-27add string_view wrappers for rtl::math::stringToDoubleNoel Grandin
Change-Id: I114bec72cb933238675e539a8388a607226827cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133455 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>