summaryrefslogtreecommitdiff
path: root/svl/qa
AgeCommit message (Collapse)Author
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I0f2f81dae91f62639e79799b1bed1b2df1fd79ab
2015-10-29tdf#70833: IDNA support when exporing hyperlinks to PDFStephan Bergmann
Any URLs using non-ASCII IDNA syntax need to be resolved to ASCII-only, as PDF URI Action's URI needs to be "encoded in 7-bit ASCII." Introduce URIHelper::resolveIdnaHost (svl/urihelper.hxx), which internally uses icu::IDNA, which requires to bump the minimal --with-system-icu requirement from 4.2 to 4.6, which means ICU_RECLASSIFIED_CLOSE_PARENTHESIS is always true now. Change-Id: I0e20d9a20ed2b869fba0cc7c969721411db590b3 Reviewed-on: https://gerrit.libreoffice.org/19669 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-10-29com::sun::star->css in starmath,stoc,svgio,svlNoel Grandin
Change-Id: If4308b358a55351f6e951ebf055df076ce4ad4ce Reviewed-on: https://gerrit.libreoffice.org/19667 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-29CppunitTest_svl_urihelper needs the file UCPStephan Bergmann
...for the WNT-only file:///c:/... vs. file:///C:/... check in testNormalizedMakeRelative Change-Id: I66a0456589aabe395645bb358dbef3268e1c3816
2015-10-20loplugin:defaultparamsStephan Bergmann
Change-Id: Ia10dd1577f677a5b27571fc58b0e00ef973660b4
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-17boost->stdCaolán McNamara
Change-Id: Ifde84627578283bd057d7393eb7e5578ef5c029a
2015-09-07svl: tdf#88206 replace cppu::WeakImplHelper*Takeshi Abe
with the variadic variants. Change-Id: I7aad512c4de034ed96b9a48e797e580e605d98a6 Reviewed-on: https://gerrit.libreoffice.org/18351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-06unit test for short name ambiguity, tdf#93080Eike Rathke
Change-Id: I97f33c8db59d2fc084b5e4eb389bff3d8254d4f0
2015-07-16tools: replace boost::ptr_vector with std::unordered_mapMichael Stahl
Change-Id: I530c5f95dda9aa80654e3a2a20a2e236221e7305
2015-07-15Revert "tools: replace boost::ptr_vector with std::unordered_map"Norbert Thiebaud
This reverts commit 218be53fe00aebed43df0b041de609b30f99ce95. MacOSX breaker
2015-07-16tools: replace boost::ptr_vector with std::unordered_mapMichael Stahl
Change-Id: I530c5f95dda9aa80654e3a2a20a2e236221e7305
2015-06-29tdf#68016 Write fixture for current behaviour of SfxListenerTobias Lippert
Also: Make destructor of SfxListener more robust, so that it can be used in tests. Change-Id: I02b273ca8e527705c2d3ea3295ed0dec1c4f83ae Reviewed-on: https://gerrit.libreoffice.org/16483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-06-02the test works much better if you really use en_US as languageMarkus Mohrhard
Change-Id: Ie936bfb6ae03a6a3abd8175938555aea99790959
2015-06-02add initial IsNumberFormat testMarkus Mohrhard
Change-Id: Idfd51360bfe8d857838ee522b8a9d3d3de06952b
2015-05-19Update Apache Bugzilla’s URLAdolfo Jayme Barrientos
Change-Id: I6ef4ae530b7fb4e615100803ae6e3972d9b4545f
2015-04-15convert SFX_ITEM constants to scoped enumNoel Grandin
Change-Id: Ief8c30c356ba947727c5ab70092042816a0db99e Reviewed-on: https://gerrit.libreoffice.org/15302 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-25remove NUMBERFORMAT_ constantsNoel Grandin
.. in favour of just using the underlying constants from css::util::NumberFormat Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
2015-02-18boost->stdCaolán McNamara
Change-Id: I412137e7e7b9b2b87f401bc140a9499d1fc012c6
2015-01-26-Werror,-Wmissing-bracesStephan Bergmann
Change-Id: I86f9b9ada62687e8159497bf428e18be1442c8a6
2015-01-26merge existing date input tests to new unit test, tdf#63230Eike Rathke
2015-01-26add older problems to unit test, tdf#63230Eike Rathke
Check that various older problems remain fixed.
2015-01-26add unit test for tdf#63230Eike Rathke
All problematic dates of https://bugs.documentfoundation.org/attachment.cgi?id=79051 Muchas gracias to Isamu Mogi!
2015-01-05java: remove dead codeNoel Grandin
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2015-01-02iss is unordered_multimap, so can't rely on orderCaolán McNamara
Change-Id: Ief399439bdde047dfbaef43f2262e6212db8bd7e
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: simplify the getMSF() methodsNoel Grandin
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18Apply pimpl to svl::SharedStringPool.Kohei Yoshida
Change-Id: I351505f0c1cb25c47897e0cfffdb258f8e87081f
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-08-13java: reduce scope, make fields privateNoel Grandin
found by UCDetector Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-12java: remove useless javadoc tagsNoel Grandin
that are not conveying any useful information Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-05java: remove commented out codeNoel Grandin
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-07-23svl: fix comparison in new unit testMichael Stahl
Presumably the test should use the unused variable w, and the result should be 3 since that's how many styles were inserted. Change-Id: I34455020e1fb8c53204b6ee0632138c1077617a2
2014-07-23fdo#76754 Add return first to IndexedStyleSheets to speed up ods writingTobias Lippert
Change-Id: I6fc9fe8ce78ad9cc1a7c2fe3e13ed38ce468ce6c Reviewed-on: https://gerrit.libreoffice.org/10347 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-23fdo#76754 Add Positions by StyleSheetFamily to IndexedStyleSheetsTobias Lippert
Change-Id: I4eade2d00d145d8f65ccd70a1c6bbd0a134a1ad5 Reviewed-on: https://gerrit.libreoffice.org/10346 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-22fdo#76754 Speed up registration of new listeners to SfxBroadcasterTobias Lippert
Also change behavior for the GetListenerCount() method which now returns the count of listeners. The previous behavior is available in method GetSizeOfVector(). Change-Id: I5b03fa55a309f4ff5aea5e8830c137786fc07e89 Reviewed-on: https://gerrit.libreoffice.org/10344 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-07-22Add unittests for SfxBroadcasterTobias Lippert
Change-Id: I9ecd8fec395eafbdc2675dda9fa25ac32761123c Reviewed-on: https://gerrit.libreoffice.org/10343 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-06-19related fdo#63230: Fix unit test for fdo#44286 to run in all localesIsamu Mogi
fdo#44286 test fails depending on system language. To fix it, this commit sets output language to LANGUAGE_ENGLISH_US. Erorr message: | $ LANG=fr_LU.UTF-8 make -rs CppunitTest_svl_qa_cppunit | [build CUT] svl_qa_cppunit | /home/master/src/libreoffice/workdirs/master/svl/qa/unit/svl.cxx:403:(anonymous | namespace)::Test::testFdo44286 | equality assertion failed | - Expected: 1902-04-22 | - Actual : YYYY-04-DD | | svl.cxx:403:Assertion | Test name: (anonymous namespace)::Test::testFdo44286 | equality assertion failed | - Expected: 1902-04-22 | - Actual : YYYY-04-DD | | Failures !!! | Run: 7 Failure total: 1 Failures: 1 Errors: 0 Change-Id: I58756c7508c7f02bec9c3b7b693032265d18c6ae Reviewed-on: https://gerrit.libreoffice.org/9826 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-06-18related fdo#63230: Add unit test for fdo#44286Isamu Mogi
It fails if 6013fe19a40dd16ce435a2428f7405b51930689e is reverted. Change-Id: Iabf13b15e3c26d7ebafdc9284642183f27723d8c Reviewed-on: https://gerrit.libreoffice.org/9781 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-17fdo#38513 - Accelerate non-poolable item add / remove.Michael Meeks
For large documents we create and destroy a large number of non-poolable SfxPoolItems, which get inserted into and removed from a vector. Unfortunately the performance of this (depending on pattern) is O(N) and this insert/remove/extend pattern can happen per text span we insert. This patch makes this O(const) via a hash. This gives a 5x speedup for the above bug; 176s to 34s or so, and moves the remaining performance issues elsewhere. Unfortunately, we have to retain the ordered array to keep the binary file format code (used for editeng cut-and-paste) in place, so have to keep both a hash, and an array, and a list around for free slots. cf. fdo#79851 where there is a start at removing that. This wastes space; but not that much - for a large open document collection we have O(100's) of SfxItemPools, and O(1000's) of SfxPoolItemArray_Impls; having fixed fdo#79851 we can consolidate this. Add skeletal unit test; translate several German comments; remove un-necessary include. Change-Id: Ie0de32b1a29217560c5591c71a6cd4e26d39a531
2014-05-15fix-includes.pl: svlThomas Arnhold
Change-Id: I18fb7a677e2bb98c83f43f5af3fa988393dc23f9
2014-05-09move INetContentTypes::scan() to INetMIME::scanContentType()Chr. Rossmanith
to avoid circular dependencies between svl and tools when using INetContentType::scan functionality for future handling of data urls in urlobj.cxx Change-Id: Iad13286769e8906aebf8208e4f532151ff2f3d13 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-04-21remove comments why a file gets includedThomas Arnhold
also remove some commented out code Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-27Introduce INetContentType::scanStephan Bergmann
...for use in <https://gerrit.libreoffice.org/#/c/8737/> "new methodINetURLObject::getData() for data urls." Change-Id: Id381d7c328153fbea44c0efb80532b2961c6c2b7
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-11fdo#30770 - Speed up xslx importTobias Lippert
Conflicts: include/svl/style.hxx Change-Id: Ie3d855923c651b6e05c0054c8e30155218279045 Reviewed-on: https://gerrit.libreoffice.org/8485 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3