summaryrefslogtreecommitdiff
path: root/svl/source/items
AgeCommit message (Collapse)Author
2018-08-02Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from stoc to svx Change-Id: If562b1aa1d676d2c1cf513e953238abbb846c65c Reviewed-on: https://gerrit.libreoffice.org/58224 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-30svl: turn on clang-format for grabbagitemMiklos Vajna
I (tried to) keep these files consistent manually in the past, switching to clang-format makes sure that the recent problem with introducing inconsistencies in these files doesn't happen again. Change-Id: I94e7f846c0d3361082d74a2883486c9aa67ed362 Reviewed-on: https://gerrit.libreoffice.org/58322 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-27new loplugin:stringloop, and applied in variousNoel Grandin
look for OUString being appended to in a loop, better to use OUStringBuffer to accumulate the results. Change-Id: Ia36e06e2781a7c546ce9cbad62727aa4c5f10c4b Reviewed-on: https://gerrit.libreoffice.org/58092 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19return SfxStyleSheetIterator by std::unique_ptrNoel Grandin
std::shared_ptr overkill here Change-Id: I9bd6ee5b92f9c04e0ca48d25eba99e5c232643c7 Reviewed-on: https://gerrit.libreoffice.org/57570 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-13sw, writerfilter: various small cleanupsMiklos Vajna
Different parameter name in declaration and definition, repeating type name inside the very same line when initializing from a cast, and so on. Change-Id: I52dc29ed845fb1a780dfab586bfd67db0d4a9e54 Reviewed-on: https://gerrit.libreoffice.org/57370 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-14tdf#100894 freeze when editing calc file with bazillions of cond formattingNoel Grandin
This does not fix the root cause of this problem, which is simply that the document has a bazillion style sheets. Either the program which exported this document is broken, or our importer is not correctly de- duplicating the imported stylesheets. Anyhow, I made performance improvements until I realised that it was simply going to be impossible to display that many stylesheets in our UI. But still, this bug was useful in flushing out some performance issues. The improvements, in order of decreasing importance are: (*) Use SfxStyleSheetIterator in SvxStyleToolBoxControl::FillStyleBox to avoid an O(n^2) situation where the pool repeatedly marks all the stylesheets as not-used, and then walks the document finding out if a stylesheet is used. Which is a waste of time because we're searching the documents pool, so of course they are all used. (*) Add a virtual method to avoid dynamic_cast (*) return raw pointers instead of returning rtl::Reference by value to avoid unnecessary reference counting. SfxStyleSheetIterator Change-Id: I15ff9c1846d3ed3e6f5655fa44c762f7619d547a Reviewed-on: https://gerrit.libreoffice.org/55751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-25loplugin:passstuffbyrefNoel Grandin
Change-Id: I785e96599bbda029adf4698d11d7f981750dec07 Reviewed-on: https://gerrit.libreoffice.org/54802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-18tdf#117539 Crash after cut and paste operation of a chart stickNoel Grandin
regression from commit 3d44b720f58366398e7f59c00dba6339712a670f loplugin:useuniqueptr in SfxItemPool_Impl where I accidentally removed some fallback code. Note that this does not fix the underlying bug where some pool is not correctly set up. Also, this only fixes the bug that I introduced in the above commit, another bug in the same area has subsequently been introduced, causing a crash in a different area when performing this operation. Change-Id: Iaae3b0dc82c740b498e3735273820647ef28fd01 Reviewed-on: https://gerrit.libreoffice.org/54522 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-16NFC: unassigned variable pNewItem is always nullptrJustin Luth
In 2015 commit 2ebd79b3d214c62c0997606115ebc50700d6a760 a possible initialization of the variable was removed. So at this point pNewItem must return false. Change-Id: I5af9d8440463c96323c38a01f255c1dbb0113e09 Reviewed-on: https://gerrit.libreoffice.org/54395 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-04-19convert SFXSTYLEBIT to scoped enumNoel Grandin
drop SFXSTYLEBIT_HIERARCHY because it has no overlap with these values, it's used an extra bit in SfxCommonTemplateDialog_Impl::LoadFactoryStyleFilter Change-Id: I8ee5ecb9b5f8d2087d8eedd1f5526260ec1e4018 Reviewed-on: https://gerrit.libreoffice.org/53089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-16loplugin:useuniqueptr in SfxItemPool_ImplNoel Grandin
Change-Id: Ic3d695dd3ad4ee5ca6537f65d643d8736e3a5700 Reviewed-on: https://gerrit.libreoffice.org/52886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-11return std::unique_ptr from SfxItemSet::CloneNoel Grandin
Change-Id: Ie747b5c8ff0b82b9f8d268f9a60dbde41b5f022b Reviewed-on: https://gerrit.libreoffice.org/52712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-07Prefix SfxStyleSheetBase::pPool memberStephan Bergmann
...just that one member; came in handy when researching a failure, and don't want to loose that improvement. Change-Id: Ia5434c4bd8131c37f93d32ce840859469ac258ef Reviewed-on: https://gerrit.libreoffice.org/52553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-03-31explicitly pass false as arguments of createIteratorhimajin100000
StylePool::createIterator has default paramters,but StylePoolImpl's does not. Change-Id: I1eff95cd3dc9e9bf7bae04aa78920c2d82acabd8 Reviewed-on: https://gerrit.libreoffice.org/52160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29loplugin:virtualdown in svl,svtoolsNoel Grandin
I expect a lot of the overriding methods will be removed as soon as I run the unusedmethods plugin Change-Id: I4fb228724fcfba51a98d2113efb93cec1bc15c7c Reviewed-on: https://gerrit.libreoffice.org/52006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28Translate German variable namesJohnny_M
Akt -> Current in svl/style Change-Id: Id6f8f7b09a8ae1768708d9fd5d11003fef1e2e42 Reviewed-on: https://gerrit.libreoffice.org/51798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-27tdf#69977 improve creation of large chartsNoel Grandin
this patch only tweaks a few things around the edges. The bulk of the cost is down in the chart2 module where it creates ticks and labels. Change-Id: If73a16d2f0a7511f07eff379a9b5c1b38ef96786 Reviewed-on: https://gerrit.libreoffice.org/51931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-21Remove redundant assertMike Kaganski
We had just returned on this condition Change-Id: I822a4fe62e24442800ca17b404862818095e641d Reviewed-on: https://gerrit.libreoffice.org/51685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-20no need to construct a new object in SfxIntegerListItem::operator==Noel Grandin
looks like an obvious typo Change-Id: Icea0952ec8203725cf5ba1ec90bdddd82eca7b3c Reviewed-on: https://gerrit.libreoffice.org/51562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26Translate German variable namesJohnny_M
Akt -> Current in itemset Change-Id: I22f24505c220775fcbbcc64f6fdfc529c772dbe9 Reviewed-on: https://gerrit.libreoffice.org/50312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-25loplugin:flatten in svlNoel Grandin
Change-Id: Id5c62c00aa8349468c0d547616424b2637533e7f Reviewed-on: https://gerrit.libreoffice.org/48485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:constparamsNoel Grandin
Change-Id: I7c695073d9a9d3b7a641d6eb9fe01a47d8c3a504 Reviewed-on: https://gerrit.libreoffice.org/48392 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23Assume this wants to SAL_WARN for the sal_uInt16 range, actuallyStephan Bergmann
Change-Id: Icdda5cbc39fc2878c869ec01349135fd56a15363 Reviewed-on: https://gerrit.libreoffice.org/48349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-15More loplugin:cstylecast: svlStephan Bergmann
Change-Id: Ida9c41fab0b8b3e91d710434028dd648e6d4b135
2018-01-12More loplugin:cstylecast: svlStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I71e3b2c9b4c68183288f43999d242e95ae13584d
2018-01-11loplugin:useuniqueptr in svlNoel Grandin
Change-Id: I2fdb63517349474d90cb17ad2bd667f30840e83d Reviewed-on: https://gerrit.libreoffice.org/47727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-09loplugin:convertlong in ucb,sotNoel Grandin
Change-Id: I6fa355448834701f11b84584649dfcdecd0f7b2c Reviewed-on: https://gerrit.libreoffice.org/47596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-05Revert "GetTrueSlotId is dead"Noel Grandin
This reverts commit 4f11182566b02f9f1c1821985a94b4b4de363fbb. Turns out I was wrong, there are tons of place defining slotid<->whichid mappings. Change-Id: I2a124ecba02c45f14ee917727adb993c39994881 Reviewed-on: https://gerrit.libreoffice.org/47454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04GetTrueSlotId is deadNoel Grandin
The only place is is used is ConvertAndPutItems. Which only loops over EE_PARA* which ids. But the only things which define slotid<->whichid mappings are XATTR*, SDATTR*, SCHATTR*. Which means that this code ConvertAndPutItems is dead, and that is the last place using GetTrueSlotId. Change-Id: I3037c25c2c15087572abacc9642970936824678d Reviewed-on: https://gerrit.libreoffice.org/47377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04loplugin:unusedfieldsNoel Grandin
fix the ReturnStmt check Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8 Reviewed-on: https://gerrit.libreoffice.org/47309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-24loplugin:passstuffbyref even more return improvementsNoel Grandin
Change-Id: I2a752025cd429e4d271626402dce5d8a8b0c76d2 Reviewed-on: https://gerrit.libreoffice.org/47021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-23loplugin:passstuffbyref improved returns in vclNoel Grandin
Change-Id: I0b103df2e7ce59093869f547225c95865d33da27 Reviewed-on: https://gerrit.libreoffice.org/46916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-21new loplugin: convertlongNoel Grandin
merge the droplong and convertuintptr into one new plugin. Limit the analysis to looking at var decl's, since that seems to be safest proposition, even if that too needs some careful analysis. Change-Id: Id005baaf05cfb157ce44a06a1c81f08559a07d1f Reviewed-on: https://gerrit.libreoffice.org/46851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13tools: remove unused #include from solar.hMichael Stahl
Change-Id: I214e13add371380701ae39403d90a574a63e495d
2017-10-28clang-tidy modernize-use-equals-default in svlJochen Nitschke
SfxPoolItem has a copy constructor and its copy assignment operator is deleted. Derived classes have a implicit defined copy constructor too, if all members are copy constructible. This patch removes default able copy constructors on such items. Note: clang-tidy only finds functions defined in source, inlined functions in headers are picked manualy. Change-Id: I7e642a2ecf139420c53f6fcb39208918dd1a8d52 Reviewed-on: https://gerrit.libreoffice.org/43003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26loplugin:constmethod in svlNoel Grandin
Change-Id: If92869e19c413e11f1f299a97f96b9637aaba65d Reviewed-on: https://gerrit.libreoffice.org/43864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: svlStephan Bergmann
Change-Id: I769b091515d1e6b7d16652d11ff2b94a75584ad0
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-04svl: Remove unnecessary abstraction of SfxImpStringListTakeshi Abe
Change-Id: Idbf1bf08f89f0fd1e92ad8f0d93d325267d19416 Reviewed-on: https://gerrit.libreoffice.org/43120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-29inline SfxPoolItem copy constructorJochen Nitschke
as delegating constructor. In preparation to remove default able copy constructors of derived classes. Change-Id: I516efa70ef2a06079194aafbf630e151138c6bbc Reviewed-on: https://gerrit.libreoffice.org/42923 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-09-12clang-tidy modernize-use-emplace in svgio..svtoolsNoel Grandin
Change-Id: I4f3b0762e197d5397e723aba1dc43e3c857be145 Reviewed-on: https://gerrit.libreoffice.org/42193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08svl: assert calls of SfxPoolItem::Create/StoreMichael Stahl
Change-Id: I2d92897d558ad0914e8bbc80b4dec72d0fd00629
2017-09-08loplugin:constantparamNoel Grandin
Change-Id: Ic87f0cc863490858b7cc7e74a7f90ec31992dd53 Reviewed-on: https://gerrit.libreoffice.org/42089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-04loplugin:unnecessaryparen include c++ castsNoel Grandin
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-03SfxItemPool_Impl::nInitRefCount is always 1Jochen Nitschke
since removal of serialisation code Change-Id: I8cbd7ecd3d4bb61a8d9e6bc098f09f43c02a8f4c Reviewed-on: https://gerrit.libreoffice.org/41850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-25loplugin:unusedfieldsNoel Grandin
Change-Id: I81bcf4f56599146536ba8d66cc86fa5a08737298 Reviewed-on: https://gerrit.libreoffice.org/41556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-25loplugin:unusedmethodsNoel Grandin
Change-Id: Iaaf9092ec4d6189492906648b84494d087fed81f Reviewed-on: https://gerrit.libreoffice.org/41539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-19svl: refactor string stream helpersJochen Nitschke
functions were declared twice, in stringio.hxx and poolio.hxx. remove unicode functions as they were unused. remove duplicate function declarations in poolio.hxx. move implementations from poolio.cxx to new stringio.cxx. Change-Id: I469346a01d793d22721e62bf7e96fd01e28d560c Reviewed-on: https://gerrit.libreoffice.org/41331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-19drop unused SfxSizeItemJochen Nitschke
unused since commit 48bf5e855ae02fd1bea87938978f29ee6147285c Date: Thu Nov 16 14:30:58 2000 +0000 Remove tests for INET_PROT_FILE Change-Id: I2dc134f529675204caad78c7e50417adb55e8e4f Reviewed-on: https://gerrit.libreoffice.org/41320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-21 13:56:25 +0000