summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)Author
2017-09-04Resolves: tdf#52510 handle trailing ';' specifying empty following subformatEike Rathke
Change-Id: Ic84065f11619542fe735f45e72c9303897ea5755
2017-09-04loplugin:unnecessaryparen include c++ castsNoel Grandin
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-03SfxItemPool_Impl::nInitRefCount is always 1Jochen Nitschke
since removal of serialisation code Change-Id: I8cbd7ecd3d4bb61a8d9e6bc098f09f43c02a8f4c Reviewed-on: https://gerrit.libreoffice.org/41850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-02sw: retrieve subject name from signatureAshod Nakashian
From CryptoAPI. Change-Id: I5ec33a754f71d3617090a03887355077d0ffedd7 Reviewed-on: https://gerrit.libreoffice.org/41789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-31loplugin:constparams: svl (clang-cl)Stephan Bergmann
Change-Id: Iddeb46c10046a83708ccff82e7125c36ed27c34d
2017-08-30Unit tests for tdf#91758Eike Rathke
Change-Id: I4015a339ca18b214adca228b58319d897f0ad910
2017-08-30Force ISO date format again if ISO input, tdf#91758 follow-upEike Rathke
... and input doesn't match a date acceptance pattern, even if less than 3 digits in year. Change-Id: Ib25aa8e813c06a224cfa95ead79c0f3bf2d2d672
2017-08-30Resolves: tdf#91758 more stringent check for ISO date like looking inputEike Rathke
Already check at the end of input analysis whether it could be an ISO date to not apply x-y-z onto MDY or DMY later. For an acceptable ISO input, apart from M and D restrictions, Y-M-D year numbers must be greater than 12 in MDY order or greater than 31 in DMY order, or have at least 3 digits (possibly leading 0). Change-Id: I8d3eb7e2403421469050850e45d1db5c0be018f5
2017-08-30Related: tdf#91758 shortcut CanForceToIso8601() for MayBeIso8601() resultsEike Rathke
Change-Id: I3cd6967931abcbf806a539a19f7f9371398567c2
2017-08-30Related: tdf#91758 don't remember nCanForceToIso8601 stateEike Rathke
CanForceToIso8601() can be called twice for different DateOrder. Change-Id: I656d499b8a557814326fe71333fcb644c7d3e909
2017-08-29Avoid "ThreadSanitizer: lock-order-inversion (potential deadlock)"Stephan Bergmann
...during CppunitTest_drawinglayer_border: > WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=3780) > Cycle in lock order graph: M1066643978230284960 (0x000000000000) => M1071992002787787328 (0x000000000000) => M1066643978230284960 > > Mutex M1071992002787787328 acquired here while holding mutex M1066643978230284960 in main thread: > #0 pthread_mutex_lock compiler-rt/lib/tsan/../sanitizer_common/sanitizer_common_interceptors.inc:3800 (cppunittester+0x45abd7) > #1 osl_acquireMutex sal/osl/unx/mutex.cxx:97 (libuno_sal.so.3+0xc1f0a) > #2 osl::Mutex::acquire() include/osl/mutex.hxx:56 (libsvllo.so+0xecc78) > #3 ClearableGuard include/osl/mutex.hxx:163 (libsvllo.so+0x10409f) > #4 ResettableGuard include/osl/mutex.hxx:208 (libsvllo.so+0xfe61c) > #5 ItemHolder2::impl_addItem(EItem) svl/source/config/itemholder2.cxx:80 (libsvllo.so+0xfd5ae) > #6 ItemHolder2::holdConfigItem(EItem) svl/source/config/itemholder2.cxx:70 (libsvllo.so+0xfd4bf) > #7 SvtCTLOptions svl/source/config/ctloptions.cxx:357 (libsvllo.so+0xf9308) > #8 drawinglayer::detail::getDigitLanguage() drawinglayer/source/processor2d/getdigitlanguage.cxx:20 (libdrawinglayerlo.so+0x20882b) > #9 VclProcessor2D drawinglayer/source/processor2d/vclprocessor2d.cxx:1434 (libdrawinglayerlo.so+0x248ed3) > #10 VclPixelProcessor2D drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:77 (libdrawinglayerlo.so+0x239f5c) > #11 drawinglayer::processor2d::createBaseProcessor2DFromOutputDevice(OutputDevice&, drawinglayer::geometry::ViewInformation2D const&) drawinglayer/source/processor2d/processorfromoutputdevice.cxx:51 (libdrawinglayerlo.so+0x20f366) > #12 (anonymous namespace)::DrawinglayerBorderTest::testDoublePixelProcessing() drawinglayer/qa/unit/border.cxx:98 (libtest_drawinglayer_border.so+0x9a05) > #13 void std::__invoke_impl<void, void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&>(std::__invoke_memfun_deref, void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:227 (libtest_drawinglayer_border.so+0xc01e) > #14 std::result_of<void ((anonymous namespace)::DrawinglayerBorderTest::* const&((anonymous namespace)::DrawinglayerBorderTest*&))()>::type std::__invoke<void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&>(void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:250 (libtest_drawinglayer_border.so+0xbf0d) > #15 _ZNKSt12_Mem_fn_baseIMN12_GLOBAL__N_122DrawinglayerBorderTestEFvvELb1EEclIJRPS1_EEEDTclsr3stdE8__invokedtdefpT6_M_pmfspclsr3stdE7forwardIT_Efp_EEEDpOS8_ /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:604 (libtest_drawinglayer_border.so+0xbdeb) > #16 void std::_Bind<std::_Mem_fn<void ((anonymous namespace)::DrawinglayerBorderTest::*)()> ((anonymous namespace)::DrawinglayerBorderTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:933 (libtest_drawinglayer_border.so+0xbd5b) > #17 void std::_Bind<std::_Mem_fn<void ((anonymous namespace)::DrawinglayerBorderTest::*)()> ((anonymous namespace)::DrawinglayerBorderTest*)>::operator()<, void>() /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:991 (libtest_drawinglayer_border.so+0xbc66) > #18 std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void ((anonymous namespace)::DrawinglayerBorderTest::*)()> ((anonymous namespace)::DrawinglayerBorderTest*)> >::_M_invoke(std::_Any_data const&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:1731 (libtest_drawinglayer_border.so+0xb62a) > #19 std::function<void ()>::operator()() const /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:2127 (libtest_drawinglayer_border.so+0x12efe) > #20 CppUnit::TestCaller<(anonymous namespace)::DrawinglayerBorderTest>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175 (libtest_drawinglayer_border.so+0xadcc) > #21 CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32 (libcppunit-1.14.so.0+0xd61d2) > #22 (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:39 (libvclbootstrapprotector.so+0x1114) > #23 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614) > #24 (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89 (unobootstrapprotector.so+0x2204) > #25 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614) > #26 (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63 (unoexceptionprotector.so+0x23e9) > #27 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614) > #28 CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15 (libcppunit-1.14.so.0+0xa57ad) > #29 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614) > #30 CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86 (libcppunit-1.14.so.0+0xc4a96) > #31 CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182 (libcppunit-1.14.so.0+0xf4714) > #32 CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91 (libcppunit-1.14.so.0+0xd5750) > #33 CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 (libcppunit-1.14.so.0+0xd6d5a) > #34 CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 (libcppunit-1.14.so.0+0xd6a2e) > #35 CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 (libcppunit-1.14.so.0+0xd6d5a) > #36 CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 (libcppunit-1.14.so.0+0xd6a2e) > #37 CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47 (libcppunit-1.14.so.0+0x10282c) > #38 CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149 (libcppunit-1.14.so.0+0xf4223) > #39 CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96 (libcppunit-1.14.so.0+0x102c76) > #40 (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:316 (cppunittester+0x4bd1e8) > #41 sal_main() sal/cppunittester/cppunittester.cxx:466 (cppunittester+0x4bbe1e) > #42 main sal/cppunittester/cppunittester.cxx:373 (cppunittester+0x4bb695) > > Mutex M1066643978230284960 previously acquired by the same thread here: > #0 pthread_mutex_lock compiler-rt/lib/tsan/../sanitizer_common/sanitizer_common_interceptors.inc:3800 (cppunittester+0x45abd7) > #1 osl_acquireMutex sal/osl/unx/mutex.cxx:97 (libuno_sal.so.3+0xc1f0a) > #2 osl::Mutex::acquire() include/osl/mutex.hxx:56 (libsvllo.so+0xecc78) > #3 Guard include/osl/mutex.hxx:129 (libsvllo.so+0xf38ef) > #4 SvtCTLOptions svl/source/config/ctloptions.cxx:350 (libsvllo.so+0xf9224) > #5 drawinglayer::detail::getDigitLanguage() drawinglayer/source/processor2d/getdigitlanguage.cxx:20 (libdrawinglayerlo.so+0x20882b) > #6 VclProcessor2D drawinglayer/source/processor2d/vclprocessor2d.cxx:1434 (libdrawinglayerlo.so+0x248ed3) > #7 VclPixelProcessor2D drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:77 (libdrawinglayerlo.so+0x239f5c) > #8 drawinglayer::processor2d::createBaseProcessor2DFromOutputDevice(OutputDevice&, drawinglayer::geometry::ViewInformation2D const&) drawinglayer/source/processor2d/processorfromoutputdevice.cxx:51 (libdrawinglayerlo.so+0x20f366) > #9 (anonymous namespace)::DrawinglayerBorderTest::testDoublePixelProcessing() drawinglayer/qa/unit/border.cxx:98 (libtest_drawinglayer_border.so+0x9a05) > #10 void std::__invoke_impl<void, void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&>(std::__invoke_memfun_deref, void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:227 (libtest_drawinglayer_border.so+0xc01e) > #11 std::result_of<void ((anonymous namespace)::DrawinglayerBorderTest::* const&((anonymous namespace)::DrawinglayerBorderTest*&))()>::type std::__invoke<void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&>(void ((anonymous namespace)::DrawinglayerBorderTest::* const&)(), (anonymous namespace)::DrawinglayerBorderTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:250 (libtest_drawinglayer_border.so+0xbf0d) > #12 _ZNKSt12_Mem_fn_baseIMN12_GLOBAL__N_122DrawinglayerBorderTestEFvvELb1EEclIJRPS1_EEEDTclsr3stdE8__invokedtdefpT6_M_pmfspclsr3stdE7forwardIT_Efp_EEEDpOS8_ /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:604 (libtest_drawinglayer_border.so+0xbdeb) > #13 void std::_Bind<std::_Mem_fn<void ((anonymous namespace)::DrawinglayerBorderTest::*)()> ((anonymous namespace)::DrawinglayerBorderTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:933 (libtest_drawinglayer_border.so+0xbd5b) > #14 void std::_Bind<std::_Mem_fn<void ((anonymous namespace)::DrawinglayerBorderTest::*)()> ((anonymous namespace)::DrawinglayerBorderTest*)>::operator()<, void>() /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:991 (libtest_drawinglayer_border.so+0xbc66) > #15 std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void ((anonymous namespace)::DrawinglayerBorderTest::*)()> ((anonymous namespace)::DrawinglayerBorderTest*)> >::_M_invoke(std::_Any_data const&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:1731 (libtest_drawinglayer_border.so+0xb62a) > #16 std::function<void ()>::operator()() const /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:2127 (libtest_drawinglayer_border.so+0x12efe) > #17 CppUnit::TestCaller<(anonymous namespace)::DrawinglayerBorderTest>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175 (libtest_drawinglayer_border.so+0xadcc) > #18 CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32 (libcppunit-1.14.so.0+0xd61d2) > #19 (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:39 (libvclbootstrapprotector.so+0x1114) > #20 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614) > #21 (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89 (unobootstrapprotector.so+0x2204) > #22 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614) > #23 (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63 (unoexceptionprotector.so+0x23e9) > #24 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614) > #25 CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15 (libcppunit-1.14.so.0+0xa57ad) > #26 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20 (libcppunit-1.14.so.0+0xc7614) > #27 CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86 (libcppunit-1.14.so.0+0xc4a96) > #28 CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182 (libcppunit-1.14.so.0+0xf4714) > #29 CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91 (libcppunit-1.14.so.0+0xd5750) > #30 CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 (libcppunit-1.14.so.0+0xd6d5a) > #31 CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 (libcppunit-1.14.so.0+0xd6a2e) > #32 CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64 (libcppunit-1.14.so.0+0xd6d5a) > #33 CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23 (libcppunit-1.14.so.0+0xd6a2e) > #34 CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47 (libcppunit-1.14.so.0+0x10282c) > #35 CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149 (libcppunit-1.14.so.0+0xf4223) > #36 CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96 (libcppunit-1.14.so.0+0x102c76) > #37 (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:316 (cppunittester+0x4bd1e8) > #38 sal_main() sal/cppunittester/cppunittester.cxx:466 (cppunittester+0x4bbe1e) > #39 main sal/cppunittester/cppunittester.cxx:373 (cppunittester+0x4bb695) > > Mutex M1066643978230284960 acquired here while holding mutex M1071992002787787328 in main thread: > #0 pthread_mutex_lock compiler-rt/lib/tsan/../sanitizer_common/sanitizer_common_interceptors.inc:3800 (cppunittester+0x45abd7) > #1 osl_acquireMutex sal/osl/unx/mutex.cxx:97 (libuno_sal.so.3+0xc1f0a) > #2 osl::Mutex::acquire() include/osl/mutex.hxx:56 (libsvllo.so+0xecc78) > #3 Guard include/osl/mutex.hxx:129 (libsvllo.so+0xf38ef) > #4 ~SvtCTLOptions svl/source/config/ctloptions.cxx:370 (libsvllo.so+0xf95df) > #5 ~SvtCTLOptions svl/source/config/ctloptions.cxx:368 (libsvllo.so+0xf971c) > #6 ItemHolder2::impl_deleteItem(TItemInfo&) svl/source/config/itemholder2.cxx:136 (libsvllo.so+0xfdb69) > #7 ItemHolder2::impl_releaseAllItems() svl/source/config/itemholder2.cxx:109 (libsvllo.so+0xfd2b9) > #8 ItemHolder2::disposing(com::sun::star::lang::EventObject const&) svl/source/config/itemholder2.cxx:75 (libsvllo.so+0xfd834) > #9 non-virtual thunk to ItemHolder2::disposing(com::sun::star::lang::EventObject const&) :? (libsvllo.so+0xfd89c) > #10 cppu::OInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject const&) cppuhelper/source/interfacecontainer.cxx:300 (libuno_cppuhelpergcc3.so.3+0xba149) > #11 cppu::OMultiTypeInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject const&) cppuhelper/source/interfacecontainer.cxx:472 (libuno_cppuhelpergcc3.so.3+0xbb6a5) > #12 cppu::WeakComponentImplHelperBase::dispose() cppuhelper/source/implbase.cxx:101 (libuno_cppuhelpergcc3.so.3+0xb0de8) > #13 cppu::PartialWeakComponentImplHelper<com::sun::star::lang::XServiceInfo, com::sun::star::lang::XMultiServiceFactory, com::sun::star::util::XRefreshable, com::sun::star::util::XFlushable, com::sun::star::lang::XLocalizable>::dispose() include/cppuhelper/compbase.hxx:93 (libconfigmgrlo.so+0x116708) > #14 non-virtual thunk to cppu::PartialWeakComponentImplHelper<com::sun::star::lang::XServiceInfo, com::sun::star::lang::XMultiServiceFactory, com::sun::star::util::XRefreshable, com::sun::star::util::XFlushable, com::sun::star::lang::XLocalizable>::dispose() include/cppuhelper/compbase.hxx:? (libconfigmgrlo.so+0x116a0c) > #15 cppu::ComponentContext::disposing() cppuhelper/source/component_context.cxx:451 (libuno_cppuhelpergcc3.so.3+0x5cdc0) > #16 cppu::WeakComponentImplHelperBase::dispose() cppuhelper/source/implbase.cxx:102 (libuno_cppuhelpergcc3.so.3+0xb0e09) > #17 cppu::PartialWeakComponentImplHelper<com::sun::star::uno::XComponentContext, com::sun::star::container::XNameContainer>::dispose() include/cppuhelper/compbase.hxx:93 (libuno_cppuhelpergcc3.so.3+0x65a88) > #18 non-virtual thunk to cppu::PartialWeakComponentImplHelper<com::sun::star::uno::XComponentContext, com::sun::star::container::XNameContainer>::dispose() include/cppuhelper/compbase.hxx:? (libuno_cppuhelpergcc3.so.3+0x65d8c) > #19 (anonymous namespace)::Hook::deinitHook((anonymous namespace)::Hook*, LinkParamNone*) test/source/setupvcl.cxx:53 (libtest-setupvcl.so+0x2aa0) > #20 (anonymous namespace)::Hook::LinkStubdeinitHook(void*, LinkParamNone*) test/source/setupvcl.cxx:37 (libtest-setupvcl.so+0x27f8) > #21 Link<LinkParamNone*, void>::Call(LinkParamNone*) const include/tools/link.hxx:84 (libvcllo.so+0x983870) > #22 DeInitVCL() vcl/source/app/svmain.cxx:519 (libvcllo.so+0x10db246) > #23 ~Protector test/source/vclbootstrapprotector.cxx:31 (libvclbootstrapprotector.so+0x100a) > #24 ~Protector test/source/vclbootstrapprotector.cxx:30 (libvclbootstrapprotector.so+0x109c) > #25 CppUnit::ProtectorChain::pop() workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:56 (libcppunit-1.14.so.0+0xc46cb) > #26 CppUnit::TestResult::popProtector() workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:196 (libcppunit-1.14.so.0+0xf4873) > #27 (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:325 (cppunittester+0x4bd3df) > #28 sal_main() sal/cppunittester/cppunittester.cxx:466 (cppunittester+0x4bbe1e) > #29 main sal/cppunittester/cppunittester.cxx:373 (cppunittester+0x4bb695) > > Mutex M1071992002787787328 previously acquired by the same thread here: > #0 pthread_mutex_lock compiler-rt/lib/tsan/../sanitizer_common/sanitizer_common_interceptors.inc:3800 (cppunittester+0x45abd7) > #1 osl_acquireMutex sal/osl/unx/mutex.cxx:97 (libuno_sal.so.3+0xc1f0a) > #2 osl::Mutex::acquire() include/osl/mutex.hxx:56 (libsvllo.so+0xecc78) > #3 ClearableGuard include/osl/mutex.hxx:163 (libsvllo.so+0x10409f) > #4 ResettableGuard include/osl/mutex.hxx:208 (libsvllo.so+0xfe61c) > #5 ItemHolder2::impl_releaseAllItems() svl/source/config/itemholder2.cxx:101 (libsvllo.so+0xfd20c) > #6 ItemHolder2::disposing(com::sun::star::lang::EventObject const&) svl/source/config/itemholder2.cxx:75 (libsvllo.so+0xfd834) > #7 non-virtual thunk to ItemHolder2::disposing(com::sun::star::lang::EventObject const&) :? (libsvllo.so+0xfd89c) > #8 cppu::OInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject const&) cppuhelper/source/interfacecontainer.cxx:300 (libuno_cppuhelpergcc3.so.3+0xba149) > #9 cppu::OMultiTypeInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject const&) cppuhelper/source/interfacecontainer.cxx:472 (libuno_cppuhelpergcc3.so.3+0xbb6a5) > #10 cppu::WeakComponentImplHelperBase::dispose() cppuhelper/source/implbase.cxx:101 (libuno_cppuhelpergcc3.so.3+0xb0de8) > #11 cppu::PartialWeakComponentImplHelper<com::sun::star::lang::XServiceInfo, com::sun::star::lang::XMultiServiceFactory, com::sun::star::util::XRefreshable, com::sun::star::util::XFlushable, com::sun::star::lang::XLocalizable>::dispose() include/cppuhelper/compbase.hxx:93 (libconfigmgrlo.so+0x116708) > #12 non-virtual thunk to cppu::PartialWeakComponentImplHelper<com::sun::star::lang::XServiceInfo, com::sun::star::lang::XMultiServiceFactory, com::sun::star::util::XRefreshable, com::sun::star::util::XFlushable, com::sun::star::lang::XLocalizable>::dispose() :? (libconfigmgrlo.so+0x116a0c) > #13 cppu::ComponentContext::disposing() cppuhelper/source/component_context.cxx:451 (libuno_cppuhelpergcc3.so.3+0x5cdc0) > #14 cppu::WeakComponentImplHelperBase::dispose() cppuhelper/source/implbase.cxx:102 (libuno_cppuhelpergcc3.so.3+0xb0e09) > #15 cppu::PartialWeakComponentImplHelper<com::sun::star::uno::XComponentContext, com::sun::star::container::XNameContainer>::dispose() include/cppuhelper/compbase.hxx:93 (libuno_cppuhelpergcc3.so.3+0x65a88) > #16 non-virtual thunk to cppu::PartialWeakComponentImplHelper<com::sun::star::uno::XComponentContext, com::sun::star::container::XNameContainer>::dispose() :? (libuno_cppuhelpergcc3.so.3+0x65d8c) > #17 (anonymous namespace)::Hook::deinitHook((anonymous namespace)::Hook*, LinkParamNone*) test/source/setupvcl.cxx:53 (libtest-setupvcl.so+0x2aa0) > #18 (anonymous namespace)::Hook::LinkStubdeinitHook(void*, LinkParamNone*) test/source/setupvcl.cxx:37 (libtest-setupvcl.so+0x27f8) > #19 Link<LinkParamNone*, void>::Call(LinkParamNone*) const include/tools/link.hxx:84 (libvcllo.so+0x983870) > #20 DeInitVCL() vcl/source/app/svmain.cxx:519 (libvcllo.so+0x10db246) > #21 ~Protector test/source/vclbootstrapprotector.cxx:31 (libvclbootstrapprotector.so+0x100a) > #22 ~Protector test/source/vclbootstrapprotector.cxx:30 (libvclbootstrapprotector.so+0x109c) > #23 CppUnit::ProtectorChain::pop() workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:56 (libcppunit-1.14.so.0+0xc46cb) > #24 CppUnit::TestResult::popProtector() workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:196 (libcppunit-1.14.so.0+0xf4873) > #25 (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:325 (cppunittester+0x4bd3df) > #26 sal_main() sal/cppunittester/cppunittester.cxx:466 (cppunittester+0x4bbe1e) > #27 main sal/cppunittester/cppunittester.cxx:373 (cppunittester+0x4bb695) Change-Id: I9564fc918438a265629ef227bdd97e42ca1756f2
2017-08-28svl: populate subject and date-time when verifying signatureAshod Nakashian
Change-Id: I50eeabf3e18176cac383f48797daa771ee9dc7e4 Reviewed-on: https://gerrit.libreoffice.org/41591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-25Add check and comment for i18npool locale data using reserved formatIndexEike Rathke
Change-Id: I9401e353241973129bff764d6d7b7f94d7c9b7b0
2017-08-25loplugin:unusedfieldsNoel Grandin
Change-Id: I81bcf4f56599146536ba8d66cc86fa5a08737298 Reviewed-on: https://gerrit.libreoffice.org/41556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-25loplugin:unusedmethodsNoel Grandin
Change-Id: Iaaf9092ec4d6189492906648b84494d087fed81f Reviewed-on: https://gerrit.libreoffice.org/41539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24SAL_INFO->SAL_WARN in lstner.cxx (svl module)Julien Nabet
Since we're already in #ifdef DBG_UTIL, we can also directly use SAL_WARN Change-Id: Ic7c564f6c08e05eb9bd5928ef031f212def094aa Reviewed-on: https://gerrit.libreoffice.org/41531 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-23Android: Enable HAVE_FEATURE_NSS and package the NSS libraries with apkGautam Prajapati
This commit enables HAVE_FEATURE_NSS for Android and fixes the svl/ vcl/ and xmlsecurity/ module to use NSS. xmlsecurity/ wasn't built for Android previously, this commit enables building xmlsecurity/ for Android and disables the support of gpgme in the same module(Only for Android). It also enables the linking of NSS shared libraries with liblo-native-code.so and adds a rule to package them along with the apk. Change-Id: I7d0341688ac979ae92e9145c37dd107670417fe1 Reviewed-on: https://gerrit.libreoffice.org/41308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-19svl: refactor string stream helpersJochen Nitschke
functions were declared twice, in stringio.hxx and poolio.hxx. remove unicode functions as they were unused. remove duplicate function declarations in poolio.hxx. move implementations from poolio.cxx to new stringio.cxx. Change-Id: I469346a01d793d22721e62bf7e96fd01e28d560c Reviewed-on: https://gerrit.libreoffice.org/41331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-19drop unused SfxSizeItemJochen Nitschke
unused since commit 48bf5e855ae02fd1bea87938978f29ee6147285c Date: Thu Nov 16 14:30:58 2000 +0000 Remove tests for INET_PROT_FILE Change-Id: I2dc134f529675204caad78c7e50417adb55e8e4f Reviewed-on: https://gerrit.libreoffice.org/41320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18drop unused CntContentTypeItemJochen Nitschke
unused since commit cdae06a664bfc3279bd9f177473357cce316b9b1 Date: Fri Apr 6 11:17:10 2001 +0000 #78400# Template scanning reimplemented using UCB Change-Id: I3e742be5a7c5467628dbe5a19171c4dfcef07c58 Reviewed-on: https://gerrit.libreoffice.org/41274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Fix typosAndrea Gelmini
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-17remove unnecessary use of OUString::getStrNoel Grandin
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4 Reviewed-on: https://gerrit.libreoffice.org/38114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Removing unused serialisation codeVarun Dhall
Change-Id: I86911c77f0831d448ff803afae2a74ec55ad4dd8 Reviewed-on: https://gerrit.libreoffice.org/41233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-17Clean up uses of OUString::fromUtf8 around string literalsStephan Bergmann
Change-Id: I9a2990e49c95a01ce505f13408be8c19db1cf5d1
2017-08-17remove UL/L suffixes from integer constants in initialiser/call expressionsNoel Grandin
Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300 Reviewed-on: https://gerrit.libreoffice.org/41214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16Rename SfxItemPool GetSurrogate to CheckItemInPoolVarun Dhall
Change-Id: Ife08e05a9fcbadea86c005a2e9defb7cef9b5acc Reviewed-on: https://gerrit.libreoffice.org/41231 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-16Removing unused serialisation code from svlVarun Dhall
Change-Id: Ia22ea346610e925cc6d499b0cc4bc768a419f909 Reviewed-on: https://gerrit.libreoffice.org/41229 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-16Removing unused serialisation codeVarun Dhall
Change-Id: Id31c8de69043d393f005f83d5c7eba878af5119c Reviewed-on: https://gerrit.libreoffice.org/41149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-16assert on duplicate listener in SfxListenerNoel Grandin
To enable finding the source of the duplicate calls, I add new SAL API (only for internal use) to retrieve and symbolise stack backtraces. The theory is that it relatively cheap to just store a backtrace, but quite expense to symbolise it to strings. Note that the backtrace() library we use on Linux does not do a particularly good job, but it gives enough information that developers can use the addr2line tool to get more precise info. Explanation of fixes in the code that triggered the assert: In SwFrameHolder, we need to only call StartListening() if the pFrame member is actually changing. We also need to call EndListening() on the old values when pFrame changes. In SwNavigationPI, there is already a StartListening() call in the only place we assign to m_pCreateView. In ImpEditEngine, we need to ignore duplicates, because it is doing a ref-counting thing. By storing duplicates on the listener list, it doesn't need to keep track of which stylesheets its child nodes are using. Given that it therefore will see duplicate events, there is probably some performance optimisation opportunities here. In MasterPageObserver::Implementation::RegisterDocument, we seem to be getting called multiple times with the same SdDrawDocument, so just check if we've been registered already before calling StartListening() In SvxShape::impl_initFromSdrObject, do the same thing we do elsewhere in this class, i.e. only call StartListening() if the model has changed. Change-Id: I7eae5c774e1e8d56f0ad7bec80e4df0017b287ac Reviewed-on: https://gerrit.libreoffice.org/41045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16SfxItemSet::Equal: ignore parents if the pools are differentMichael Stahl
If there are parents, they are necessarily different pointers for different pools; the only sensible way to compare them is by-value, which is a bit tricky because the items overwritten in the child should of course be ignored. Rather than rewrite the whole function, just ignore the parents for now, because this comparison is currently used to replace compares of the serializations of item sets, and SfxItemSet::Store() completely ignores the m_pParent, so this looks like the best replacement. Change-Id: I0a4bf44d4fef49e47a3ec78bc7d977a6fcbd789d Reviewed-on: https://gerrit.libreoffice.org/41186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-08loplugin:unusedmethodsNoel Grandin
Change-Id: Id66cf12e3a59aeed1b9a7a111b841e30b248635b Reviewed-on: https://gerrit.libreoffice.org/40876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-05ofz#2867 null derefCaolán McNamara
Change-Id: If856473683685d79d88b024f7fafa2920b403bb7 Reviewed-on: https://gerrit.libreoffice.org/40792 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-04rename Anz->Cnt in svlNoel Grandin
Change-Id: Ibe9ad8c1bfbb336ee1f02edf0f619220cfcee375 Reviewed-on: https://gerrit.libreoffice.org/40744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-04svl: move DecodeHexString from vclAshod Nakashian
Change-Id: I86da993050bde20f9ff0413ad5424673647a0e5c Reviewed-on: https://gerrit.libreoffice.org/40720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-08-03rename nAnzResStrings->nResultStringsCntNoel Grandin
Change-Id: I631236b5750f1ddb9828ab5ebd4c59e7f1b81390 Reviewed-on: https://gerrit.libreoffice.org/40710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-03rename nAnzNum->nNumericsCntNoel Grandin
Change-Id: I798314c9c17f4341fa9c5fc87be4fc72a07e7d9e Reviewed-on: https://gerrit.libreoffice.org/40709 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-03rename SV_MAX_ANZ_STANDARD_FORMATE->SV_MAX_COUNT_STANDARD_FORMATSNoel Grandin
Change-Id: I83df4ecabcbc98b5a75f93e44b584291068c6e94 Reviewed-on: https://gerrit.libreoffice.org/40702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-03rename SV_MAX_ANZ_INPUT_STRINGS->SV_MAX_COUNT_INPUT_STRINGSNoel Grandin
Change-Id: Ib915eb709966b7a487e54694ae3be7e5c2d3a452 Reviewed-on: https://gerrit.libreoffice.org/40701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-03rename nAnzStrings -> nStringsCntNoel Grandin
Change-Id: I387b702a0bc785a8e9da4e0390067626c5475319 Reviewed-on: https://gerrit.libreoffice.org/40674 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02remove unnecessary use of 'this->'Noel Grandin
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02Resolves: ofz#2833 null derefCaolán McNamara
Change-Id: I021a716aa76d430a1d3c6fac2dddec4daa01e563 Reviewed-on: https://gerrit.libreoffice.org/40667 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-02normalize resource locale ctor construction mechanismsCaolán McNamara
make them all the same and share std::locales more various OModuleClient, etc, classes go away Change-Id: I7e3ff01a69332eeacd22e3078f66a60318de62d5 Reviewed-on: https://gerrit.libreoffice.org/40634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-01move resmgr to unotoolsCaolán McNamara
and the vast majority of translations is to the ui language so default ctor with that arg and now drop OModuleResourceClient Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
2017-07-31make IntlWrapper arg to GetPresentation non-implicit and non-optionalCaolán McNamara
which requires explicitly adding null in 1) SdrItemBrowserControl::SetAttributes(const SfxItemSet* pSet, const SfxItemSet* p2ndSet) where SdrItemBrowserControl is only used by SdrItemBrowser and the only use of that is within DBG_UTIL in SdrPaintView 2) SwCursorShell::GetContentAtPos( const Point& rPt, within a #ifdef DBG_UTIL block in 3) SvxSearchDialog::BuildAttrText_Impl( OUString& rStr, bool bSrchFlag ) const where the other branch uses SvxResId 4) SfxPoolItem::dumpAsXml(xmlTextWriterPtr pWriter) const 5) XFillStyleItem::dumpAsXml(xmlTextWriterPtr pWriter) const looks very much like all uses (outside the dumpers) are intended to be in the ui locale results in that INetContentTypes::GetPresentation always called with UI Locale Change-Id: I5a110c107838b4db3c355476426d6532f2b6ce52 Reviewed-on: https://gerrit.libreoffice.org/40538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-31loplugin:oncevarNoel Grandin
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28loplugin:constparams handle constructorsNoel Grandin
had to change the structure of the plugin considerably, was too messy to structure it to do the calculations on a per-function basis Change-Id: I4edee7735f726101105c607368124a08dba21086 Reviewed-on: https://gerrit.libreoffice.org/40516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27Ditch use of EditTextObject::Store() in ScGlobal::EETextObjEqual()Eike Rathke
This was the last incarnation of SfxItem binary stream serialization that is to be eliminated after clipboard use is gone. The "full" EditTextObject::operator==() in EditTextObjectImpl::operator==(), and via ContentInfo::operator==() in SfxItemSet::operator==(), also compare the SfxItemPool pointers which gets in the way here (not stored to stream hence didn't matter and maybe the reason for not having switched EETextObjEqual() to use operator==() back in the days). Introduce *::Equals() functions that do not compare pool pointers and let SfxItemSet::Equals() in that case not assume it would be operating on one pool only. Change-Id: Ifff939a92101c7f74695b676a45a7fdbb4f1d7f6 Reviewed-on: https://gerrit.libreoffice.org/40492 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-25convert UNO event ids to scoped enumNoel Grandin
I'm fairly sure there are more simplifications that could be make here. It seems like we have both an ID and a string name for all of these events, and we could probably get by with just one of those, or alternately, centralise the name<->id mapping somewhere Change-Id: I978073822ddbebce94ac5b560fea675bea905a35 Reviewed-on: https://gerrit.libreoffice.org/40392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-27 14:56:36 +0000