summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)Author
2014-05-28This needs to be debugged and understood, not just randomly "fixed"Tor Lillqvist
This reverts commit 72827968e606adcdf8c16e5381b887180975ae46. Change-Id: Ie79bb1d57d05c0a1e51733bacc1b103f44ddc153
2014-05-28Related: fdo#79142 make SetName default to ReindexingCaolán McNamara
Change-Id: I408042bc7bf1a5a955203d65d2c68ebf9527b9b5
2014-05-28Try to avoid "attempt to erase from container with a past-the-end iterator"Tor Lillqvist
I saw such an error (and the resulting abort) in CppunitTest_sw_ooxmlexport, and the helpful backtrace displayed (it was on Linux) indicated it was caused by the erase() call in SfxListener::RemoveBroadcaster_Impl(). (Obviously this was when building against the debugging C++ runtime, i.e. --enable-dbgutil.) Unfortunately this seems to be one of those random error conditions that are hard to reproduce. At least I could not. But this is hopefully an obvious improvement. Change-Id: I0f247cf8f9fd0c151aafa59c43a49c100c518f19
2014-05-27remove unnecessary use of Reference constructor in throwNoel Grandin
Convert code like this: throw IOException("xx", Reference< XInterface >(static_cast<OWeakObject*>(this)) ); to this: throw IOException("xx", static_cast<OWeakObject*>(this) ); Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27remove unnecessary use of OUString constructor when throwingNoel Grandin
Change-Id: I4a3f3f911dcfbf88696053215a2fb7a94678244c
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-23Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20Julien Nabet
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-21ODS load perf: 7% of the time re-creating sheet name strings.Michael Meeks
No need to create cached versions of stringified sheet tokens for a given grammar at great for every formula that we compile; defer until use. Is this a large cost on save ? Change-Id: I8058ed564dbdc00ff45c02cb483c1a20a48af272
2014-05-20take a shortcut on common separating ASCII charactersEike Rathke
Change-Id: I991801b9a0b7be6024612c8f29262f2ebd8e6a64
2014-05-20resolved fdo#34724 Jan1 or 1Jan without separating character is not dateEike Rathke
Change-Id: I2cf02a26b81fa634c842df455de669f1c60241bc
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-17Back out change for fdo#78119 now that we have StringContainsWord()Eike Rathke
This reverts commit 3b3b690c1f0479cfbebcfa68595f75a4994e7a5f. With the use of StringContainsWord() it is unnecessary to loop all available names.
2014-05-17resolved fdo#41166 match month and day name word instead of substringEike Rathke
Follow-up, check for ASCII first to avoid calls to i18n, and check the type flags instead of calls to CharClass methods that give unexpected results with their masks. Change-Id: I10e685998299dceb2dbcf1d87ae1de09680b8a99
2014-05-17resolved fdo#41166 match month and day name word instead of substringEike Rathke
Change-Id: I897dbcee47de574d91ba3e3b40a39a35b779fef8
2014-05-15update_pch: add svlThomas Arnhold
55s -> 28s How to find possible pch candidates: for i in `git grep -l 'gb_Library_set' -- '*.mk' | sort -u`; do if [ $(git grep 'precompiled_' $i | wc -l) == 0 ]; then echo missing: $(sed -n -e '/gb_Library_add_exception_objects/,/))/ p' $i | wc -l) files in $i else echo ok: $i fi done | sort -h -t' ' -k2 Change-Id: Ib9fe16c0afb6e6687881c987c3af7bf59b929fd4
2014-05-15fix-includes.pl: svlThomas Arnhold
Change-Id: I18fb7a677e2bb98c83f43f5af3fa988393dc23f9
2014-05-14Find places where uno::Sequence is passed by value.Noel Grandin
Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-13remove dead codeNoel Grandin
Change-Id: Ic4fb478921714429af138ca212bd7f67f408d434
2014-05-12fdo#78119 find the longest match for month nameDavid Tardon
Change-Id: Idad7b083ce5528f5c735f3a8bd091819bf043fc8
2014-05-11coverity#982701 Improper use of negative valueCaolán McNamara
Change-Id: I3c932e8386d994450f05a876b6ad76ba141bd4e9
2014-05-11Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10Julien Nabet
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-10coverity#738855 Uninitialized pointer fieldCaolán McNamara
Change-Id: If45c6b7399e19e9414a5ba24a1f6d2e5bb3f82a8
2014-05-10Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part8Julien Nabet
Change-Id: Ie16923d17541e84e0d7424fffe37caf410786abf
2014-05-09move INetContentTypes::scan() to INetMIME::scanContentType()Chr. Rossmanith
to avoid circular dependencies between svl and tools when using INetContentType::scan functionality for future handling of data urls in urlobj.cxx Change-Id: Iad13286769e8906aebf8208e4f532151ff2f3d13 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-06dflt -> defaultThomas Arnhold
Change-Id: I89f1f5771eb7d96da233a8c7386b906b2a3a9c3e
2014-05-06consistent percent sign in commentsThomas Arnhold
Change-Id: I9906b4e58fd8672e51f6aa2e56ec68bb28772500
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-04-22cppcheck: fix variable reassigned before the old value has been usedJulien Nabet
Change-Id: I866eaf946d4cd8eaa8e4b8799ddac5e0d5dc59bb
2014-04-21remove comments why a file gets includedThomas Arnhold
also remove some commented out code Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-11Introduce twip/mm100 conversion functions instead of duplicated macrosTor Lillqvist
Change-Id: Ib689e35b417e0e9016cd6a239c986e0603a99d62 Reviewed-on: https://gerrit.libreoffice.org/8837 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-04-11Use valid UNOIDL identifiers in TransliterationModulesExtraStephan Bergmann
ignoreDiacritics_CTL was introduced in LO 4.2, but is unpublished and appears to be rarely used, so changing it is hopefully OK. ignoreKashida_CTL is new in LO 4.3. Change-Id: I52c6d1e8c6b30eec4af22e3bbc72dd5874ef7151
2014-04-09Remove unused functionStephan Bergmann
Change-Id: I0d6f0d8a7ef851ef7ba1653d87db6a5bdbfb6d94
2014-04-08coverity#708261 Uninitialized scalar fieldCaolán McNamara
Change-Id: I997dad13c3b8931d1fd4eae09218b51cb4621263
2014-04-08fdo#77123: Add option ignore kashida to the searchFaisal M. Al-Otaibi
This patch will add new checkbox to ignore kashida in the search and replace dialog. Change-Id: I9e7179242751103b8418d922ade5b9145170ad15
2014-04-07Clean up function declarations and some unused functionsStephan Bergmann
Change-Id: Id7ecd49ea03f225fc350a31437c32b4a738d7199
2014-04-06coverity#708246: Unitialized scalar fieldNorbert Thiebaud
Change-Id: I3136db825bea07b4b5977b6067db91375720ebed
2014-04-06coverity#708257: Unitialized scalar fieldNorbert Thiebaud
Change-Id: Ib46e6f5cb52cd47c4c9914b2f15633f5e6af1fe6
2014-04-06coverity#708260: Unitialized scalar fieldNorbert Thiebaud
Change-Id: Iffad31bc60748fe58fe3524776dd56e907586342
2014-04-04coverity#738855 Uninitialized pointer fieldCaolán McNamara
Change-Id: I3c1528f2dd8e3bde2672ebc153c9cb5c5c0a13fd
2014-04-04svl/eitem.hxx: sal_Bool->boolNoel Grandin
Change-Id: I45dfd2429a490af3cc80f51340e0c05a91425668
2014-04-04svl/visitem: sal_Bool->boolNoel Grandin
Change-Id: I3d6ceb4dc8cea901a5b1cdcf00efa9074c75cca0
2014-04-04svl/style.hxx: sal_Bool->boolNoel Grandin
looks like I missed a couple of methods in my earlier conversion Change-Id: I07871a451bb5954feab57de0af4f7d0678f9a7b3
2014-04-04coverity#708244 Uninitialized scalar fieldCaolán McNamara
Change-Id: I99b68fd7efe69cc7ab7daa244cad4c1ac04c312d
2014-04-04cp#1000054: Avoid crashing.Muthu Subramanian
Change-Id: Iedafa35cfedce1d56468774fcb6bbfa8e42612df
2014-04-03remove unnecessary scope qualifier from sal_Bool usesNoel Grandin
i.e. convert "::sal_Bool" to "sal_Bool" Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03svl: sal_Bool->boolNoel Grandin
Change-Id: I6938314a08d061d2b07d9129742d74a989bd1385
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01Remove unused inline functionStephan Bergmann
Change-Id: Ib1e05194fd51b914da45cbdfb75e142be5d852fe
2014-04-01Remove unused inline constructorStephan Bergmann
Change-Id: I1fbf53c19c55a37d4802be0828cc13bd6bba8f67
generated by cgit (git 2.34.1) at 2025-02-23 20:38:15 +0000