summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)Author
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-08-22Remove some useless tools/debug.hxx includesMarcos Paulo de Souza
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h header was necessary in some cases because of a macro or a typedef that was needed. Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9 Reviewed-on: https://gerrit.libreoffice.org/11075 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-20fix string out-of-bounds assert on gnome627759-1.odsCaolán McNamara
i.e. on soffice --headless --convert-to pdf gnome627759-1.ods Change-Id: I01289d5afcc79b7180cc12f8ee345ac760b6a637
2014-08-18detect * with no character following as invalid format codeEike Rathke
... so adding it to the list in Format Numbers using the checkmark button is not possible. Change-Id: I57ca6a7a3617583a82a99c87291373b1fe4e246d
2014-08-18more out-of-bounds string accessesEike Rathke
Change-Id: Id5df5775e4c5bfb1c484e60e6831f6bc77158d35
2014-08-18do not even append the 0x1B in this caseEike Rathke
Change-Id: I016869b9d2230dfe6af233b1c3ae9b6de4818ce7
2014-08-18no need to set bRes=false here, it is alreadyEike Rathke
Change-Id: I80f78e0d2078c4e56d4f2ef5842b180e6080e410
2014-08-18prevent out-of-bounds string accessEike Rathke
... while entering a * star symbol format code and there's no fill character following the * yet. Change-Id: I006f125ceefccba6a95ea033fd434d98e5d4f1c2
2014-08-17remove svl/ignores.persistThomas Arnhold
Change-Id: I015274d9e9cceab5044ebda1f7318a0863729a5a
2014-08-16svl: Remove ASCII art and pointless commentsChris Laplante
Change-Id: Idd8ea0cb7e7d58a29dbfcae084558320efe5fe43 Reviewed-on: https://gerrit.libreoffice.org/10945 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-13update_pchThomas Arnhold
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-13java: reduce scope, make fields privateNoel Grandin
found by UCDetector Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-12java: remove useless javadoc tagsNoel Grandin
that are not conveying any useful information Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-11-Werror,-Wtautological-undefined-compareStephan Bergmann
("reference cannot be bound to dereferenced null pointer in well-defined C++ code; comparison may be assumed to always evaluate to true") Change-Id: I41660cb5e9a14a5c0694259f0244c789ce3d4753
2014-08-05java: remove commented out codeNoel Grandin
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-07-29drop use of SFX_ITEM_PRESENTATION_NONENoel Grandin
since none of the call sites specify it Change-Id: I9c15f0e042e21f6f78560c1962a533112d588c90
2014-07-29simplify return argument of SfxPoolItem::GetPresentationNoel Grandin
since all two of the actual call-sites only care about whether it is a valid presentation or not, not what kind of presentation it is. Change-Id: I75717c88878d37b2897741b0c833ff283b3fee59
2014-07-25fdo#39468 Make svl/ German comment cleanPhilipp Weissenbacher
I went through all files manually and checked with the tool. Change-Id: I2eba5e61a0814dd88d7c2c001cd85db8032f1b9f Reviewed-on: https://gerrit.libreoffice.org/10545 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-07-25fdo#39468 Finish German comment translation of /svl/source/itemsPhilipp Weissenbacher
Conflicts: svl/source/items/itemset.cxx Change-Id: I8d1bd1a1889eede2cdb69e06c127b96842116b1c Reviewed-on: https://gerrit.libreoffice.org/10533 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-24svl: remove some odd and obsolete debugging code related to MI_HATS_REPARIERTMichael Stahl
This was apparently disabled before the MI_HATS_REPARIERT check was removed in f03a3edf2523c208948059861e0df48567834d0d, and then yesterday something in the header inclusions changed to enable the DBG macros that still used the removed stuff, but _only_ on Windows... now clean this up. Change-Id: I4222db252f4a886b3497ca0c22dbec26eaa6c994
2014-07-24move SFX_ITEMS_DIRECT etc. definitions inside the moduleNoel Grandin
These are internal constants, they don't need to be visible to the rest of LO Change-Id: I313def85b8c404948ec9ecb3996fed03b32ff9bf
2014-07-23svl: avoid warning C4715 "not all control paths return a value"Michael Stahl
Change-Id: Id4b083b202930108c2cdfdae0a549aea29198b5c
2014-07-23svl: fix comparison in new unit testMichael Stahl
Presumably the test should use the unused variable w, and the result should be 3 since that's how many styles were inserted. Change-Id: I34455020e1fb8c53204b6ee0632138c1077617a2
2014-07-23fdo#39468 Translate German commentsPhilipp Weissenbacher
Change-Id: I305ffe07d96fb5c3edafa219dbdb8ef64f7c2f73 Reviewed-on: https://gerrit.libreoffice.org/10489 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-23fdo#76754 Add return first to IndexedStyleSheets to speed up ods writingTobias Lippert
Change-Id: I6fc9fe8ce78ad9cc1a7c2fe3e13ed38ce468ce6c Reviewed-on: https://gerrit.libreoffice.org/10347 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-23convert SfxItemState constants to a proper enumNoel Grandin
and while we're at it - use the enum type all over the place instead of passing around sal_uInt16 - don't use bitwise logic on enum values - use enum values instead of numeric constants Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-23move string IO methods out of global headerNoel Grandin
and into a module-local header. It's not like the methods have any actual relationship with the SfxPoolItem class. Change-Id: I1378364a1554642333b0c5c79d869d719b53fa0c
2014-07-23convert SfxPoolItem kind constants to an enumNoel Grandin
Change-Id: I57de8c0cebfd60fdf70c23c72ecf1e47c69d7ecd
2014-07-23simplify SfxItemPool::GetPresentationNoel Grandin
drop the ePresentation parameter, since all 4 of the callsites use SFX_ITEM_PRESENTATION_COMPLETE as the parameter value, and just inline the value into the method. Change-Id: I42c8eae82837c9f9d4edc886d7c760f57b129125
2014-07-23comments and code formatting in SfxPoolItemNoel Grandin
Change-Id: Ibf7b2f5e93748198eccbbbf54fad5f8053270003
2014-07-23fdo#76754 Add Positions by StyleSheetFamily to IndexedStyleSheetsTobias Lippert
Change-Id: I4eade2d00d145d8f65ccd70a1c6bbd0a134a1ad5 Reviewed-on: https://gerrit.libreoffice.org/10346 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-23fdo#39468 Translate German commentsPhilipp Weissenbacher
Change-Id: I7f83308125d6d17ec199bbb2edbb69259702ca77 Reviewed-on: https://gerrit.libreoffice.org/10474 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-07-22fdo#39468 Finish translating German commentsPhilipp Weissenbacher
Change-Id: I8163bd42c24a4f5a5fd4e048836d7e77d3993fe2 Reviewed-on: https://gerrit.libreoffice.org/10452 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-22fdo#76754 Speed up registration of new listeners to SfxBroadcasterTobias Lippert
Also change behavior for the GetListenerCount() method which now returns the count of listeners. The previous behavior is available in method GetSizeOfVector(). Change-Id: I5b03fa55a309f4ff5aea5e8830c137786fc07e89 Reviewed-on: https://gerrit.libreoffice.org/10344 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-07-22Add unittests for SfxBroadcasterTobias Lippert
Change-Id: I9ecd8fec395eafbdc2675dda9fa25ac32761123c Reviewed-on: https://gerrit.libreoffice.org/10343 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-07-21coverity#707210 Uncaught exceptionCaolán McNamara
Change-Id: I63013222988735f901b37584345b79659f69ad8a
2014-07-21coverity#707209 Uncaught exceptionCaolán McNamara
Change-Id: I876e25678d68cba09099776bf303a6540761d2ed
2014-07-21coverity#707208 Uncaught exceptionCaolán McNamara
Change-Id: I7fe87d012acbd7bac9736ee5ff8c6abc0da3d129
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-13fdo#81309: Adjust references during sort.Kohei Yoshida
Change-Id: I2b98610f6b774400ecfaffe2905201c27fcab33f
2014-07-10Translate German comments (continued)Philipp Weissenbacher
Change-Id: Ia33f8b85120381c75bcb3696845dfab1fd8b61fc Reviewed-on: https://gerrit.libreoffice.org/10151 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-10fdo#75757: remove inheritance to std::vectorTakeshi Abe
This also fixes possible memory leaks of SfxAllEnumValue_Impl which may occur in SfxAllEnumItem::RemoveValue() of the original implementation. Change-Id: I5f458c546575d9e1f88b1167ae561537963c7b95 Reviewed-on: https://gerrit.libreoffice.org/10167 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-10Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: I1dd003bc984a11d6d71c92aae44accc9d358db0c
2014-07-08Drop unused nSfxFlagValTakeshi Abe
It has gone at 0e73ffc339ff51fc610de5fcbad0aef813610f36. Change-Id: I98fcdfe4861e47fbd33ff620971f247bee89290e
2014-07-07fix crash on loading fdo70673-1.odsCaolán McNamara
rStr is NaN Change-Id: I8206ab322a08d558cf5f05750efd700875b2134c
2014-07-03work around nonsense -Werror=maybe-uninitialized, fdo#80166 follow-upEike Rathke
Change-Id: I0f9cf74550e43d174bf6ac75e70c51ab7f51ccf8
2014-07-02resolved fdo#80166 check input against date acceptance pattern plausibilityEike Rathke
... to prevent confusion of #.### input with D.M that then later is discarded as invalid date input instead of accepted as valid numeric input. Change-Id: I178e28b7ef3b26d04eecc73e5e5c61ee41f89e32
2014-07-01New loplugin:stringconcatStephan Bergmann
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-06-30Make sure IMPL_STATIC_LINK's type matches Link::pFunc's typeStephan Bergmann
...to avoid -fsanitize=function warnings in Link::Call. Change-Id: I837b35bd3052716fbb41bf4f893961257d1f9b2c
2014-06-30Translate German comments in filerec.cxx and doxygen-ify.Jeroen Nijhof
Change-Id: Iebe05867395ca5674242b18038b53d5362869d07 Reviewed-on: https://gerrit.libreoffice.org/9956 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>