summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)Author
2018-05-05Fix typoAndrea Gelmini
Change-Id: I24a82ffcd060c72aeddddd76c4c5fe667d75f79b Reviewed-on: https://gerrit.libreoffice.org/53833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-04Use the currently active locale if no format passedEike Rathke
No format passed doesn't necessarily mean the init/system locale, use the locale set at SvNumberFormatter::IsNumberFormat() Change-Id: Ief1025fa14145396ba096842e2f3341496ce4ce8 Reviewed-on: https://gerrit.libreoffice.org/53829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-04Avoid number scanner overhead for all General formatsEike Rathke
Change-Id: If28276a1f707c3eb462a013b5604a92ce56038d2 Reviewed-on: https://gerrit.libreoffice.org/53792 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-05-04Avoid number scanner overhead for the 0 General formatEike Rathke
Change-Id: Iec25db8caaccacfef760f269dd1a349f51455052 Reviewed-on: https://gerrit.libreoffice.org/53791 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-05-04Revert "Revert "Resolves: tdf#116579 consider both work locale and format...""Eike Rathke
This reverts commit f5a56c367fba1c42b4f9719b10ff3e86ad5e2ab1. Now that Basic is fixed to set the proper NfEvalDateFormat ... Change-Id: I448edd733b0370b22ff5d8c27fe2c993597c9f8f Reviewed-on: https://gerrit.libreoffice.org/53788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-03Revert "Resolves: tdf#116579 consider both work locale and format locale ↵Stephan Bergmann
date patterns" This reverts commit dfb9138b8b5a239b46f189a717999bcaff19aa79, which caused CppunitTest_basic_macros to fail with > macro result for weekday.vb > macro returned: > Test Results > ============ > > Failed: : the return WeekDay is: 1 > Failed: : the return WeekDay is: 3 > Failed: : the return WeekDay is: 7 > Failed: : the return WeekDay is: 2 > Failed: : the return WeekDay is: 6 > Tests passed: 1 > Tests failed: 5 etc.
2018-05-02Resolves: tdf#116579 consider both work locale and format locale date patternsEike Rathke
If a format was set its locale's date acceptance patterns overwrote the work locale's patterns for the current input. Take both into account, with precedence depending on the NfEvalDateFormat set at SvNumberFormatter. Change-Id: Ie6e837447610d71eb9b8227e602d13d414cad612
2018-04-19convert SFXSTYLEBIT to scoped enumNoel Grandin
drop SFXSTYLEBIT_HIERARCHY because it has no overlap with these values, it's used an extra bit in SfxCommonTemplateDialog_Impl::LoadFactoryStyleFilter Change-Id: I8ee5ecb9b5f8d2087d8eedd1f5526260ec1e4018 Reviewed-on: https://gerrit.libreoffice.org/53089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-16loplugin:useuniqueptr in FSStorageNoel Grandin
Change-Id: Ib7d175905e3fc597e3350d6673cf4f4cc49c96f9 Reviewed-on: https://gerrit.libreoffice.org/52888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-16loplugin:useuniqueptr in SfxItemPool_ImplNoel Grandin
Change-Id: Ic3d695dd3ad4ee5ca6537f65d643d8736e3a5700 Reviewed-on: https://gerrit.libreoffice.org/52886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-11return std::unique_ptr from SfxItemSet::CloneNoel Grandin
Change-Id: Ie747b5c8ff0b82b9f8d268f9a60dbde41b5f022b Reviewed-on: https://gerrit.libreoffice.org/52712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-07Prefix SfxStyleSheetBase::pPool memberStephan Bergmann
...just that one member; came in handy when researching a failure, and don't want to loose that improvement. Change-Id: Ia5434c4bd8131c37f93d32ce840859469ac258ef Reviewed-on: https://gerrit.libreoffice.org/52553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-03-31explicitly pass false as arguments of createIteratorhimajin100000
StylePool::createIterator has default paramters,but StylePoolImpl's does not. Change-Id: I1eff95cd3dc9e9bf7bae04aa78920c2d82acabd8 Reviewed-on: https://gerrit.libreoffice.org/52160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29loplugin:virtualdown in svl,svtoolsNoel Grandin
I expect a lot of the overriding methods will be removed as soon as I run the unusedmethods plugin Change-Id: I4fb228724fcfba51a98d2113efb93cec1bc15c7c Reviewed-on: https://gerrit.libreoffice.org/52006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28Translate German variable namesJohnny_M
Akt -> Current in svl/style Change-Id: Id6f8f7b09a8ae1768708d9fd5d11003fef1e2e42 Reviewed-on: https://gerrit.libreoffice.org/51798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-27tdf#69977 improve creation of large chartsNoel Grandin
this patch only tweaks a few things around the edges. The bulk of the cost is down in the chart2 module where it creates ticks and labels. Change-Id: If73a16d2f0a7511f07eff379a9b5c1b38ef96786 Reviewed-on: https://gerrit.libreoffice.org/51931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-21Remove redundant assertMike Kaganski
We had just returned on this condition Change-Id: I822a4fe62e24442800ca17b404862818095e641d Reviewed-on: https://gerrit.libreoffice.org/51685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-20no need to construct a new object in SfxIntegerListItem::operator==Noel Grandin
looks like an obvious typo Change-Id: Icea0952ec8203725cf5ba1ec90bdddd82eca7b3c Reviewed-on: https://gerrit.libreoffice.org/51562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-07use more Color in sfx2..svtoolsNoel Grandin
Change-Id: Idd951841ce7e9c4b4e5229bc24efe5c7b8042617 Reviewed-on: https://gerrit.libreoffice.org/50817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05Make LibreOffice buildable on Haiku.Kacper Kasper
* Obviously VCL wiring is missing, but most components do build. Change-Id: Ie853ada1423a8f4c2b647be59cd47a7730c42978 Reviewed-on: https://gerrit.libreoffice.org/50293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-02Resolves: tdf#115351 convert boolean equivalent format codes to proper BooleanEike Rathke
Because Excel does not know a Boolean number format, BOOLEAN is saved to Excel as "TRUE";"TRUE";"FALSE" with implicit conditions [>0] and [<0]. This when loaded has no boolean property. Then saved to ODF it is loaded as [>0]"TRUE";[<0]"TRUE";"FALSE" with explicit conditions, which has identical meaning. Convert both equivalent format codes to proper BOOLEAN when reading. Locale dependent representations are treated the same, e.g. "WAHR";"WAHR";"FALSCH" Change-Id: I49383d71fce972fdd7ad9b19ce3bc150d02aba62 Reviewed-on: https://gerrit.libreoffice.org/50642 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-28convert COL_ constants to be of type ColorNoel Grandin
Change-Id: I0e25c8950ac26b851ff42f71e1471fcbe4770d48 Reviewed-on: https://gerrit.libreoffice.org/50373 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27replace Color(COL_*) with COL_*Noel Grandin
using git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)" | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g" and then some manual fixup where the resulting expression no longer compiled Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4 Reviewed-on: https://gerrit.libreoffice.org/50372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26Translate German variable namesJohnny_M
Akt -> Current in itemset Change-Id: I22f24505c220775fcbbcc64f6fdfc529c772dbe9 Reviewed-on: https://gerrit.libreoffice.org/50312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-21New loplugin:nestedunnamedStephan Bergmann
Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c Reviewed-on: https://gerrit.libreoffice.org/50048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-16Factor out Spanish "mar" tests to use checkSpecificNumberFormats()Eike Rathke
Change-Id: Ie2618ffeea49e45d7bd7d35238a1edbcc5887fa5
2018-02-16Prepare to add specific number format index to test againstEike Rathke
Change-Id: I1c01c9afe4a2479bd8e595b84816febe8e9e5947
2018-02-16svl: fix loplugin:staticanonymous warningMiklos Vajna
Change-Id: Ib983a8f4305dc916e077407d712883de6d05649a
2018-02-16Unit test tdf#114833 do not officiously force Y-M-D if D-M-Y is applicableEike Rathke
Change-Id: I2c78a06169526b079fd1463df23b09bacb50588b
2018-02-16Resolves: tdf#114833 do not officiously force Y-M-D if D-M-Y is applicableEike Rathke
Change-Id: Idbfecf0ff08843db9970a301ab3c3a7317c08cda
2018-02-16ofz#6311 still problems with SdrEdgeObj listening to same obj at start as endCaolán McNamara
Change-Id: Ibd80b484788779b73943b28a5f36e51ebcacec30 Reviewed-on: https://gerrit.libreoffice.org/49821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-14svl: clear temporary copies of passwords in SvlPasswordHelperMichael Stahl
This is an obvious place to start, but there might be more copies elsewhere. Change-Id: I3c3ea6cb54f40fe5c21c3128b55aeaad1ff74b42 Reviewed-on: https://gerrit.libreoffice.org/49669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-07tdf#115483 svl xmloff sc sw: verify all ODF 1.2 protection-key hashesMichael Stahl
ODF 1.2 has added some mandatory requirements for protection-key hashes which did not exist in ODF 1.1. This affects sections and indexes in ODT documents, as well as spreadsheets and sheets in ODS documents. 1. Accept the following hashed passwords: * UTF16 LE/BE encoded StarOffice-SHA1, OOo legacy and allowed by ODF 1.1 * UTF8 encoded proper SHA1, as required by ODF 1.2 * UTF8 encoded SHA256, as required by ODF 1.2 - specified either with the wrong URL used in the ODF 1.2 spec or the correct URL from the W3C spec, see OFFICE-3702 * Excel+SHA1 double-hash, only in Calc, see OFFICE-2112 2. Round-trip any of the above as-is * for SHA256 only write the URL from the ODF 1.2 spec 3. Generate only UTF16 LE encoded SHA1 for now, so that older LO releases can still verify the password * some time in the future, switch to generating some valid ODF 1.2 hash More changes are necessary in Calc, which can actually preserve different hashes for the same passwords in its runtime data model, whereas Writer just has a single buffer without even any metadata. For the Calc unit tests we need one document per hash because the protection-key attribute can be set on the entire spreadsheet, which is an unique element in the document. There are further uses of SvlPasswordHelper for change-tracking passwords, but apparently those are stored in settings.xml, so ODF has no requirements for them, so let's leave that as it is. Change-Id: Icb720b14ae9c0d9c04d2e082769ae2b74e3af8aa Reviewed-on: https://gerrit.libreoffice.org/49352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-25Simplify logic in cjkoptionsJulien Nabet
Following https://cgit.freedesktop.org/libreoffice/core/commit/?id=6a579702b1128372aa30c86156996e57ba73b2c8 Change-Id: I5e2528bc69065260dfce7ac8c29ba4aa76905bbe Reviewed-on: https://gerrit.libreoffice.org/48554 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-25ofz: out-of-memoryCaolán McNamara
Change-Id: If1c9ade3268f4ebadfdad771fe3b35641dca210d Reviewed-on: https://gerrit.libreoffice.org/48506 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25loplugin:flatten in svlNoel Grandin
Change-Id: Id5c62c00aa8349468c0d547616424b2637533e7f Reviewed-on: https://gerrit.libreoffice.org/48485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:emptyif (clang-cl)Stephan Bergmann
Change-Id: I8ddf764f9e155c037e25855b7d6efc49eb494179 Reviewed-on: https://gerrit.libreoffice.org/48483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24loplugin:constparamsNoel Grandin
Change-Id: I7c695073d9a9d3b7a641d6eb9fe01a47d8c3a504 Reviewed-on: https://gerrit.libreoffice.org/48392 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-23Assume this wants to SAL_WARN for the sal_uInt16 range, actuallyStephan Bergmann
Change-Id: Icdda5cbc39fc2878c869ec01349135fd56a15363 Reviewed-on: https://gerrit.libreoffice.org/48349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23More loplugin:cstylecast on WindowsStephan Bergmann
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-22ofz#5535 max decimal places for rtl_math_round is 20Caolán McNamara
Change-Id: I636e086c51ceb70bdac72acfbabe99ad29003cdb Reviewed-on: https://gerrit.libreoffice.org/48268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-15More loplugin:cstylecast: svlStephan Bergmann
Change-Id: Ida9c41fab0b8b3e91d710434028dd648e6d4b135
2018-01-13loplugin:useuniqueptr in svlNoel Grandin
Change-Id: I89aa05b3c59ca3ad680d35899400957a399ccf0e Reviewed-on: https://gerrit.libreoffice.org/47795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-12More loplugin:cstylecast: svlStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I71e3b2c9b4c68183288f43999d242e95ae13584d
2018-01-11loplugin:useuniqueptr in svlNoel Grandin
Change-Id: I2fdb63517349474d90cb17ad2bd667f30840e83d Reviewed-on: https://gerrit.libreoffice.org/47727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-09loplugin:convertlong in ucb,sotNoel Grandin
Change-Id: I6fa355448834701f11b84584649dfcdecd0f7b2c Reviewed-on: https://gerrit.libreoffice.org/47596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-05Revert "GetTrueSlotId is dead"Noel Grandin
This reverts commit 4f11182566b02f9f1c1821985a94b4b4de363fbb. Turns out I was wrong, there are tons of place defining slotid<->whichid mappings. Change-Id: I2a124ecba02c45f14ee917727adb993c39994881 Reviewed-on: https://gerrit.libreoffice.org/47454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04GetTrueSlotId is deadNoel Grandin
The only place is is used is ConvertAndPutItems. Which only loops over EE_PARA* which ids. But the only things which define slotid<->whichid mappings are XATTR*, SDATTR*, SCHATTR*. Which means that this code ConvertAndPutItems is dead, and that is the last place using GetTrueSlotId. Change-Id: I3037c25c2c15087572abacc9642970936824678d Reviewed-on: https://gerrit.libreoffice.org/47377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04loplugin:unusedfieldsNoel Grandin
fix the ReturnStmt check Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8 Reviewed-on: https://gerrit.libreoffice.org/47309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-11 15:26:37 +0000