summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)Author
2016-11-13drop useless semicolonsDavid Tardon
Change-Id: I039f8ff491b42ea9c3936bf13922df8095434228
2016-11-13revert unintentionally committed linesDavid Tardon
Change-Id: I5cb355af20f18e63fdfe45e5946a9281fd1fa084
2016-11-13add missing dependencyDavid Tardon
Change-Id: I72696c82d9a96709746060ae18bd497da8715d35
2016-11-10make comphelper::sequenceToContainer a little smarterNoel Grandin
so we don't have to specify the source type Change-Id: I4106705a39874a8043f0f294a11374404d6cfc3a Reviewed-on: https://gerrit.libreoffice.org/30713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09tdf#102507 Add qa test of left aligned denominatorLaurent Balland-Poirier
New behavior of format # ?/??? gives for 3.5 3 1/2 instead of 3 1/ 2 Change-Id: I87f4a71fb13d8424017d557213bb4d279de28af5 Reviewed-on: https://gerrit.libreoffice.org/30167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04use aggregate initialisation instead of memset for arraysJochen Nitschke
Change-Id: I084dee370e5c1096e51b8ff4073443c719688469 Reviewed-on: https://gerrit.libreoffice.org/30517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03Revert "remove unnecessary casts"Noel Grandin
This reverts commit fa80dae9a79a7414af8adcb91bc04dfff13bbb63. because current Clang master complains with /home/noel/libo3/svl/source/items/itemset.cxx:189:26: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs] va_start( pArgs, nNull ); ^ /home/noel/libo3/svl/source/items/itemset.cxx:176:89: note: parameter of type 'sal_uInt16' (aka 'unsigned short') is declared here SfxItemSet::SfxItemSet(SfxItemPool& rPool, sal_uInt16 nWh1, sal_uInt16 nWh2, sal_uInt16 nNull, ...)
2016-11-03remove unnecessary castsJochen Nitschke
Which IDs are always sal_uInt16 and likely passed from defines Change-Id: I134358289ccd338ef1ff6ba963e25a524e790f4e Reviewed-on: https://gerrit.libreoffice.org/30498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03bin nranges.*, move remaining functions into itemset.cxxJochen Nitschke
Change-Id: I1b88d98e00415e9c32a48486912d577a00fbfbda Reviewed-on: https://gerrit.libreoffice.org/30486 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01add an assert to check for ref-counts > 16 bitsNoel Grandin
after commit 87c518593de59dbf4c0f5f45c720b14a05aeca9e sc: remove antique reference counting hacks from ScDocumentPool In theory, nothing should be trying to save items like this anymore, but lets make the error more obvious in case something is. Change-Id: I89b3637168c072d20e214a8f6338f6336d44d891 Reviewed-on: https://gerrit.libreoffice.org/30467 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-11-01simplify loop to O(n)Jochen Nitschke
Change-Id: Ib14da0201730e213f15f4f46b539fc843bfbe750 Reviewed-on: https://gerrit.libreoffice.org/30454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31loplugin:oncevar in svl..svxNoel Grandin
Change-Id: I80b11a7b698de4b84d7a2f4c7dc62b2e4fd8bb01 Reviewed-on: https://gerrit.libreoffice.org/30438 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31fix use of is_sorted_untilNoel Grandin
fix for "comparison doesn't meet irreflexive requirements, assert(!(a < a))" as a consequence of author Jochen Nitschke <j.nitschke+logerrit@ok.de> commit e75561bd19faa332c077ec249a397d056fae63f2 bin SfxUShortRanges, inline and rewrite only usage seems that std::is_sorted_until has stronger requirements than we actually want here, so open-code a similar algorithm Change-Id: I126584d9146137b9ac699dad85fd9691490dc30d Reviewed-on: https://gerrit.libreoffice.org/30435 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-10-30bin SfxUShortRanges, inline and rewrite only usageJochen Nitschke
only use was to merge 2 range tables in SfxItemSet::MergeRange of which one table always contained a single range. rewrite the merge algorithm (SfxUShortRanges += operator). sort new range into the table of ranges and merge overlapping ranges afterwards. Not as optimal as the original code but it's short, maintainable and works without 'goto' inline the DBG_CHECK_RANGES macro Change-Id: I991c050f069d44fe72b3ea374863f5f26e7099e9 Reviewed-on: https://gerrit.libreoffice.org/30299 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-29silence false positive warnings in non DBG_UTIL buildsJochen Nitschke
Change-Id: I80428ebe570584fc7a31581207da0b27a16949af Reviewed-on: https://gerrit.libreoffice.org/29244 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-28svl: more SfxPoolItem assertsMichael Stahl
Change-Id: Ic73fe09fc401359f043269fc8e5a1910fc8ddb02
2016-10-28svl: SfxPoolItem reference counting assertionsMichael Stahl
Change-Id: Ice2ec9a4592a1fad36913ae7d089aa8c63dfc669
2016-10-27loplugin:expandablemethods in stoc..svlNoel Grandin
Change-Id: I7dd701ef07a14f70589b87154bfeeda7530b628f Reviewed-on: https://gerrit.libreoffice.org/30316 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-27remove unused variableJochen Nitschke
aSet unused since 2ebd79b3d214c62c0997606115ebc50700d6a760 loplugin:constantfunction: svl Change-Id: I48faf8775465ec1d5e3df94343a4373a87d03e6d Reviewed-on: https://gerrit.libreoffice.org/30310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-26svl: the compiler can generate the same SfxGrabBagItem copy ctor itselfMiklos Vajna
Change-Id: I54f94e8ec710ca117ecdf33ebe97a0e5f07c59ec Reviewed-on: https://gerrit.libreoffice.org/30283 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-26untangle .cxx include in itemset.cxxJochen Nitschke
Change-Id: I0102ad82d82c8f0e9f8939512bae83424613c54e Reviewed-on: https://gerrit.libreoffice.org/30281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-24tdf#103060 Format "GGG" as the era name of a locale-dependent calendarTakeshi Abe
by default, as Excel does. This change applies to "GG" and "G" as well. Note that nothing changes for Italian locale, in which "GGG" stays as a placeholder for day of week. Change-Id: Iad68f6a9548b7229930c0e0c518fdb29bfaa026f Reviewed-on: https://gerrit.libreoffice.org/29724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-20loplugin:expandablemethodds in svxNoel Grandin
Change-Id: I45447b6f5cf7e17d6e81e8c931b07b26d41b9a8c Reviewed-on: https://gerrit.libreoffice.org/30057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19replace <<= with assign for <<= with rhs AnyJochen Nitschke
queryAggregation and queryInterface return Any Change-Id: Ib8e3e742bd66f7419cad583988b247bb628f7b4a Reviewed-on: https://gerrit.libreoffice.org/29912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-17let LanguageTag::convertToLocale() decide when to create a temporaryEike Rathke
Change-Id: Id4e718eb23d4acf2ee7bddc4da1cd4e8e811be78
2016-10-15clang-cl loplugin: svlStephan Bergmann
The DdeInternal::Cli/SrvCallback functions apparently had broken signatures for 64-bit Windows (32-bit DWORD vs. 64-bit ULONG_PTR parameters), but I assume that was actually harmless, as I think that, for Windows x86-64, those arguments are pushed on the stack right-to-left (regardless of CALLBACK), and they are the last arguments, and SrvCallback doesn't look at them at all, and CliCallback only looks at the lower 32-bit DWORD of the first one (nInfo1). Change-Id: Id77749dd2d29180e2d11b0ae2ad248ac1a7f1bdf Reviewed-on: https://gerrit.libreoffice.org/29848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14DdeInternal::InfCallback is unusedStephan Bergmann
...since b5863b83d212ae344cefe0aefdfd4caddaded02b "Remove classes DdeServiceList & DdeTopicList" Change-Id: I9cd90cb6b50f72966210c0035034cdc6b6d2230c Reviewed-on: https://gerrit.libreoffice.org/29819 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14loplugin:countusersofdefaultparams in sot..svtoolsNoel Grandin
Change-Id: Ifce19de3518f3eaf5a1b6439f9053feee4a33c14
2016-10-12improve commentNoel Grandin
Change-Id: Ia45916169c10b1c8bb712c9c21ce2df6cda37245
2016-10-10tdf#36038 Import extended LCID from ExcelLaurent Balland-Poirier
Extended LCID were only supported for Thai. This commit import also for some other numerals and calendars. Change-Id: Id92a0ee2a32c5722e9674fe0ac5ff7028c84bca6 Reviewed-on: https://gerrit.libreoffice.org/28809 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-10tdf#36038 Export to Excel extended LCIDLaurent Balland-Poirier
Number format: extend export to Excel of long LCID for other languages and calendars than only Thai and Buddhist Change-Id: I826347302d14caa5b4463d28cd25f2c36ebfef5d Reviewed-on: https://gerrit.libreoffice.org/28666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-10-10tdf#89307: Removed SvRef::operator T*()Jacek Fraczek
Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-08svl: convert DBG_ASSERTs to assertMichael Stahl
Change-Id: Ied13d6588e1c6677898a8151fa881804c3c58ff1
2016-10-08svl: convert some DBG_ASSERT to assertMichael Stahl
Change-Id: Id859f5584b52849d5a40e0f9946e0bf58761fbcb
2016-10-07tdf#102370 Correctly export to Excel exponent without signLaurent Balland-Poirier
Exponent without sign in scientific notation is coded in Excel with a minus sign replacing plus sign: 0.00E-00 for instance This format is already correctly treated in Calc but was not correctly exported to Excel or ODF Change-Id: Ide117b04e0eb887c6cdd6699ae8ec723d1d29d50 Reviewed-on: https://gerrit.libreoffice.org/29198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-10-07svl: remove #include windows.h from svdde.hxxMichael Stahl
Move Win32 stuff over to DdeInternal class where it can be better encapsulated. Change-Id: Ia3d4c72cf7ad1b7d54bef5d175c579cd426407e7
2016-10-07Revert "More blind fix for --enable-pch Windows builds"Michael Stahl
This reverts commit 1b613450f85d052b7343eacefd79abbfe4f35e2f.
2016-10-07More blind fix for --enable-pch Windows buildsStephan Bergmann
Change-Id: I8e7c79a4d3a9d6c226f9d112c59ada5a7f76c7a4
2016-10-07Make _WIN32-only DDE code use proper HCONVStephan Bergmann
...instead of various integer types. Revealed that the GetConvId functions were unused. Change-Id: I6c6427bd8c14166e58bed3405084e3919bdc97f9
2016-10-07Remove unused include fileStephan Bergmann
Change-Id: Id1a1dcc1d8d06e6a90861976cbb5616ec65ff234
2016-10-07loplugin:staticmethods: svlStephan Bergmann
Change-Id: I5cadb5e19790a941c719253966bc65d54e2b60bd
2016-10-06Replace DdeString conversion opreator with proper functionStephan Bergmann
Change-Id: Ia6a9b40ea33dd9bff8322d8cff1692926f6d1db0
2016-10-05tdf#102507 Left aligned denominatorLaurent Balland-Poirier
In denominator, move blanks at the end of string to have denominator left aligned Change-Id: Ic7ce45dc1ba8c343232a0d4fa1bed2bde58a0bc2 Reviewed-on: https://gerrit.libreoffice.org/29267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-05Replace DdeData conversion operators with proper functionsStephan Bergmann
Change-Id: I866bdcbf1b6a5cda4472b6655ace866a3d5a8983
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-03add more dumpAsXml()Noel Grandin
and make it format the output nicely, so I don't have to use 'xmllint --format' before I can read it. Change-Id: I065ee93193f3c6c7bab87212ab96021fb0d7c5ed Reviewed-on: https://gerrit.libreoffice.org/29407 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01Fix typosAndrea Gelmini
Change-Id: I1e0e6f1b99090f26a6cd657ee9019bf2fa906dd9 Reviewed-on: https://gerrit.libreoffice.org/29436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01Revert "don't write item right before destruction"Jochen Nitschke
triggers warnings in the dtor if RefCount isn't reset. revert till we have better ref counts and don't need debug code in dtor. This reverts commit b74d2433c856d6d172d9588f4b6d59c31ec02853. Change-Id: I1835885d94e15339aa7602037d850e1524fd9662 Reviewed-on: https://gerrit.libreoffice.org/29427 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
generated by cgit (git 2.34.1) at 2025-02-20 06:55:52 +0000