Age | Commit message (Collapse) | Author |
|
To insert separators, literal strings between digits and other,
the formatter operates backwards on the string obtained from
doubleToUString() cleaned of the decimal separator. The number of
decimals returned by doubleToUString() may be less than the
decimals of the number format as entered by the user, which lead
to separators inserted at wrong positions. This wrong behavior was
triggered respectively made more obvious by
commit 0f6203edf74832f84d8263d7a544d679203a4efc
CommitDate: Wed Jan 13 14:47:57 2016 +0100
tdf#96918 display accurate integer double values up to (2^53)-1
which for integer values returns at most 15 decimals ('0' in this
case).
Before operating on the decimals' part ensure that the number of
decimals matches the digits requested, and if shorter append
trailing '0' characters for the required amount so the separators
(and other strings) are inserted at the correct positions.
Change-Id: Ic02652699ea7d6fae3b2b3348f6f7d183319e043
Reviewed-on: https://gerrit.libreoffice.org/55039
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Need to incrementally migrate the remaining places (ODF, OOXML signing)
to CNG, then flip the default. SVL_CRYPTO_CNG=1 is needed till then.
(The testcase passes with and without the fix when SVL_CRYPTO_CNG is not
specified; it fails without the fix when SVL_CRYPTO_CNG is specified.)
Change-Id: Ide9d3b109bbd955a9cb83b18bba6aa72269f4d34
Reviewed-on: https://gerrit.libreoffice.org/55030
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
(*) if we are already throwing a Wrapped*Exception, get the
exception using cppu::getCaughtexception.
(*) when catching and then immediately throwing UNO exceptions,
use cppu::getCaughtException to prevent exception slicing
(*) if we are going to catch an exception and then
immediately throw a RuntimeException, rather throw a
WrappedTargetRuntimeException and preserve the original exception information.
Change-Id: Ia7a501a50ae0e6f4d05186333c8517fdcb17d558
Reviewed-on: https://gerrit.libreoffice.org/54692
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I785e96599bbda029adf4698d11d7f981750dec07
Reviewed-on: https://gerrit.libreoffice.org/54802
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
regression from
commit 3d44b720f58366398e7f59c00dba6339712a670f
loplugin:useuniqueptr in SfxItemPool_Impl
where I accidentally removed some fallback code.
Note that this does not fix the underlying bug where some pool is not
correctly set up.
Also, this only fixes the bug that I introduced in the above commit,
another bug in the same area has subsequently been introduced, causing
a crash in a different area when performing this operation.
Change-Id: Iaae3b0dc82c740b498e3735273820647ef28fd01
Reviewed-on: https://gerrit.libreoffice.org/54522
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
That block of code at the top of the file started out as
#include "precompiled_svl.hxx"
#ifdef WNT
# include <prewin.h>
# include <postwin.h>
# undef ERROR
#endif
in d2a16264ec6cb1ca5e8178096b72053a357cb3fb "Initial unit test skeleton, copied
and modified from sc", so assume the leftover #undef is unnecessary cargo-cult
by now.
Change-Id: I39637518d1507352b1eb2ed19168013d9fe635ac
Reviewed-on: https://gerrit.libreoffice.org/54499
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I28d0260531132216c5f0bd187d400ed47cc43326
Reviewed-on: https://gerrit.libreoffice.org/54498
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I391ea52f5137975073a674ac1ad380277fe99846
Reviewed-on: https://gerrit.libreoffice.org/54381
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
In 2015 commit 2ebd79b3d214c62c0997606115ebc50700d6a760 a
possible initialization of the variable was removed. So
at this point pNewItem must return false.
Change-Id: I5af9d8440463c96323c38a01f255c1dbb0113e09
Reviewed-on: https://gerrit.libreoffice.org/54395
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
libnumbertext_numbertext package doesn't exist...
Change-Id: I5fc7c9c2386c10a10f2980655292ab12beb1a977
|
|
... based on libnumbertext integrated since commit
f1579d3d6c5f5f3a651825e035b93bee7a4f43c6.
[NatNum12] gives cardinal number names (one, two, three, ...)
[NatNum13] gives ordinal number names (first, second, third, ...)
[NatNum14] gives ordinal indicators (1st, 2nd, 3rd, ...)
Change-Id: Ie2afdeeb82da1b36e9755c02d7b2276c77be9c72
Reviewed-on: https://gerrit.libreoffice.org/54186
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
The one in tools/solar.h is the only one needed.
Change-Id: I7a4e041694fb61329d16f300be4f986eb8d4ec48
Reviewed-on: https://gerrit.libreoffice.org/54202
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I24a82ffcd060c72aeddddd76c4c5fe667d75f79b
Reviewed-on: https://gerrit.libreoffice.org/53833
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
No format passed doesn't necessarily mean the init/system locale,
use the locale set at SvNumberFormatter::IsNumberFormat()
Change-Id: Ief1025fa14145396ba096842e2f3341496ce4ce8
Reviewed-on: https://gerrit.libreoffice.org/53829
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: If28276a1f707c3eb462a013b5604a92ce56038d2
Reviewed-on: https://gerrit.libreoffice.org/53792
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: Iec25db8caaccacfef760f269dd1a349f51455052
Reviewed-on: https://gerrit.libreoffice.org/53791
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
This reverts commit f5a56c367fba1c42b4f9719b10ff3e86ad5e2ab1.
Now that Basic is fixed to set the proper NfEvalDateFormat ...
Change-Id: I448edd733b0370b22ff5d8c27fe2c993597c9f8f
Reviewed-on: https://gerrit.libreoffice.org/53788
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
date patterns"
This reverts commit dfb9138b8b5a239b46f189a717999bcaff19aa79, which caused
CppunitTest_basic_macros to fail with
> macro result for weekday.vb
> macro returned:
> Test Results
> ============
>
> Failed: : the return WeekDay is: 1
> Failed: : the return WeekDay is: 3
> Failed: : the return WeekDay is: 7
> Failed: : the return WeekDay is: 2
> Failed: : the return WeekDay is: 6
> Tests passed: 1
> Tests failed: 5
etc.
|
|
If a format was set its locale's date acceptance patterns
overwrote the work locale's patterns for the current input. Take
both into account, with precedence depending on the
NfEvalDateFormat set at SvNumberFormatter.
Change-Id: Ie6e837447610d71eb9b8227e602d13d414cad612
|
|
drop SFXSTYLEBIT_HIERARCHY because it has no overlap with these values,
it's used an extra bit in
SfxCommonTemplateDialog_Impl::LoadFactoryStyleFilter
Change-Id: I8ee5ecb9b5f8d2087d8eedd1f5526260ec1e4018
Reviewed-on: https://gerrit.libreoffice.org/53089
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ib7d175905e3fc597e3350d6673cf4f4cc49c96f9
Reviewed-on: https://gerrit.libreoffice.org/52888
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic3d695dd3ad4ee5ca6537f65d643d8736e3a5700
Reviewed-on: https://gerrit.libreoffice.org/52886
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ie747b5c8ff0b82b9f8d268f9a60dbde41b5f022b
Reviewed-on: https://gerrit.libreoffice.org/52712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...just that one member; came in handy when researching a failure, and don't
want to loose that improvement.
Change-Id: Ia5434c4bd8131c37f93d32ce840859469ac258ef
Reviewed-on: https://gerrit.libreoffice.org/52553
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
and fix fallout
Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee
Reviewed-on: https://gerrit.libreoffice.org/52206
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
|
|
StylePool::createIterator has default paramters,but StylePoolImpl's does not.
Change-Id: I1eff95cd3dc9e9bf7bae04aa78920c2d82acabd8
Reviewed-on: https://gerrit.libreoffice.org/52160
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
I expect a lot of the overriding methods will be removed as soon as I
run the unusedmethods plugin
Change-Id: I4fb228724fcfba51a98d2113efb93cec1bc15c7c
Reviewed-on: https://gerrit.libreoffice.org/52006
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Akt -> Current in svl/style
Change-Id: Id6f8f7b09a8ae1768708d9fd5d11003fef1e2e42
Reviewed-on: https://gerrit.libreoffice.org/51798
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
|
|
this patch only tweaks a few things around the edges. The bulk of the
cost is down in the chart2 module where it creates ticks and labels.
Change-Id: If73a16d2f0a7511f07eff379a9b5c1b38ef96786
Reviewed-on: https://gerrit.libreoffice.org/51931
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
We had just returned on this condition
Change-Id: I822a4fe62e24442800ca17b404862818095e641d
Reviewed-on: https://gerrit.libreoffice.org/51685
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
looks like an obvious typo
Change-Id: Icea0952ec8203725cf5ba1ec90bdddd82eca7b3c
Reviewed-on: https://gerrit.libreoffice.org/51562
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Idd951841ce7e9c4b4e5229bc24efe5c7b8042617
Reviewed-on: https://gerrit.libreoffice.org/50817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Obviously VCL wiring is missing, but most components do build.
Change-Id: Ie853ada1423a8f4c2b647be59cd47a7730c42978
Reviewed-on: https://gerrit.libreoffice.org/50293
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Because Excel does not know a Boolean number format, BOOLEAN is
saved to Excel as
"TRUE";"TRUE";"FALSE"
with implicit conditions [>0] and [<0]. This when loaded has no
boolean property. Then saved to ODF it is loaded as
[>0]"TRUE";[<0]"TRUE";"FALSE"
with explicit conditions, which has identical meaning.
Convert both equivalent format codes to proper BOOLEAN when
reading. Locale dependent representations are treated the same,
e.g. "WAHR";"WAHR";"FALSCH"
Change-Id: I49383d71fce972fdd7ad9b19ce3bc150d02aba62
Reviewed-on: https://gerrit.libreoffice.org/50642
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I0e25c8950ac26b851ff42f71e1471fcbe4770d48
Reviewed-on: https://gerrit.libreoffice.org/50373
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
using
git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)"
| xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g"
and then some manual fixup where the resulting expression no longer
compiled
Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4
Reviewed-on: https://gerrit.libreoffice.org/50372
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Akt -> Current in itemset
Change-Id: I22f24505c220775fcbbcc64f6fdfc529c772dbe9
Reviewed-on: https://gerrit.libreoffice.org/50312
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c
Reviewed-on: https://gerrit.libreoffice.org/50048
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ie2618ffeea49e45d7bd7d35238a1edbcc5887fa5
|
|
Change-Id: I1c01c9afe4a2479bd8e595b84816febe8e9e5947
|
|
Change-Id: Ib983a8f4305dc916e077407d712883de6d05649a
|
|
Change-Id: I2c78a06169526b079fd1463df23b09bacb50588b
|
|
Change-Id: Idbfecf0ff08843db9970a301ab3c3a7317c08cda
|
|
Change-Id: Ibd80b484788779b73943b28a5f36e51ebcacec30
Reviewed-on: https://gerrit.libreoffice.org/49821
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
This is an obvious place to start, but there might be more copies
elsewhere.
Change-Id: I3c3ea6cb54f40fe5c21c3128b55aeaad1ff74b42
Reviewed-on: https://gerrit.libreoffice.org/49669
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
ODF 1.2 has added some mandatory requirements for protection-key hashes
which did not exist in ODF 1.1.
This affects sections and indexes in ODT documents, as well as
spreadsheets and sheets in ODS documents.
1. Accept the following hashed passwords:
* UTF16 LE/BE encoded StarOffice-SHA1, OOo legacy and allowed by ODF 1.1
* UTF8 encoded proper SHA1, as required by ODF 1.2
* UTF8 encoded SHA256, as required by ODF 1.2
- specified either with the wrong URL used in the ODF 1.2 spec
or the correct URL from the W3C spec, see OFFICE-3702
* Excel+SHA1 double-hash, only in Calc, see OFFICE-2112
2. Round-trip any of the above as-is
* for SHA256 only write the URL from the ODF 1.2 spec
3. Generate only UTF16 LE encoded SHA1 for now, so that older LO
releases can still verify the password
* some time in the future, switch to generating some valid ODF 1.2 hash
More changes are necessary in Calc, which can actually preserve
different hashes for the same passwords in its runtime data model,
whereas Writer just has a single buffer without even any metadata.
For the Calc unit tests we need one document per hash because the
protection-key attribute can be set on the entire spreadsheet, which
is an unique element in the document.
There are further uses of SvlPasswordHelper for change-tracking passwords,
but apparently those are stored in settings.xml, so ODF has no
requirements for them, so let's leave that as it is.
Change-Id: Icb720b14ae9c0d9c04d2e082769ae2b74e3af8aa
Reviewed-on: https://gerrit.libreoffice.org/49352
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Following https://cgit.freedesktop.org/libreoffice/core/commit/?id=6a579702b1128372aa30c86156996e57ba73b2c8
Change-Id: I5e2528bc69065260dfce7ac8c29ba4aa76905bbe
Reviewed-on: https://gerrit.libreoffice.org/48554
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: If1c9ade3268f4ebadfdad771fe3b35641dca210d
Reviewed-on: https://gerrit.libreoffice.org/48506
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id5c62c00aa8349468c0d547616424b2637533e7f
Reviewed-on: https://gerrit.libreoffice.org/48485
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8ddf764f9e155c037e25855b7d6efc49eb494179
Reviewed-on: https://gerrit.libreoffice.org/48483
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|