summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)Author
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Harmless missing breaks in switchStephan Bergmann
The fallthrough will only happen if eCodeType is anything but NF_KEY_MMM..., in which case the following cases will fall through to the end of the switch, too. Change-Id: I2fea503a0ce919dad645e3749b2173676fda5373
2016-05-09tdf#88657 calculate denominator lengthLaurent Balland-Poirier
Get length of denominator which could be different from numerator length Change-Id: I9f5c10917185eb029d52efbc0f20be5f81c74d10 Reviewed-on: https://gerrit.libreoffice.org/24712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-09convert SfxStyleFamily to scoped enumNoel Grandin
and update the RSC compiler to accept such In the process fix some confusion in SD where it was confusing SfxStyleFamily and the index of the relevant family (which other parts of the code in SVL use) Change-Id: I1efc9f85fbed8ab76eafe8f6e1ada411753ae5f9
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-03tdf#97835 No decimal separtor for empty decimalLaurent Balland-Poirier
If decimal part is empty (with #) decimal separator should not be added. It was not removed if there was text after value. Change-Id: I891cad8b6bec0f27f4cef8aea80c5dad264f062d Reviewed-on: https://gerrit.libreoffice.org/24586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-03tdf#61996 Skip quoted text in number formatLaurent Balland-Poirier
Quoted text should be detected and skiped before detecting conditions Change-Id: I1c78fed7f543fb335fbb8ec9ed50d9ab9dd10aa7 Reviewed-on: https://gerrit.libreoffice.org/24550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-03tdf#31449 Correctly test if fraction has no integer partLaurent Balland-Poirier
Test if fraction format has no integer part is modified to take into account all cases: ??/?? or ##/## and do not detect false positive like ? ??/?? Change-Id: Ia8677a5ad496e5df56ce6bf1290323555e46ba0a Reviewed-on: https://gerrit.libreoffice.org/24540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-01Fix typosAndrea Gelmini
Change-Id: Ifb7c33d6052efe5ea8a1e0e10b3178073cd29ca0 Reviewed-on: https://gerrit.libreoffice.org/24536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-22SfxUndoAction::dumpAsXml: show address of undo itemsMiklos Vajna
The order of undo items on the undo stack is: the newest item is the first. But for grouped items SfxListUndoAction is a list, so newest elements go to the end of the list. It's easy to get confused without seeing the exact addresses. Change-Id: I5c336f2317e4f5869b9fd227c800b2e15d0644ff Reviewed-on: https://gerrit.libreoffice.org/24295 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-21Fix typosAndrea Gelmini
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I4a86e2484adfafb53831b9e1e9971514f017ce36
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15remove tools/solarmutex.hxxNoel Grandin
Deprecated in favour of comphelper::SolarMutex Change-Id: I159077562660de5df25601fa471447f4b64a2cf1 Reviewed-on: https://gerrit.libreoffice.org/24079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13loplugin:passstuffbyref in svlNoel Grandin
Change-Id: I1434d96ae800d8e155262831472cf632d640b4c5
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-11clang-tidy performance-unnecessary-value-param in svlNoel Grandin
Change-Id: I8abc272d12e62e25be358dc4c73008971f1cd609
2016-04-11cppcheck: silence warnings assertWithSideEffectJochen Nitschke
Mark some class methods as pure. warnings look like this: > dbaccess/source/core/api/RowSetBase.cxx > 593 assertWithSideEffect 398 warning Assert statement calls > a function which may have desired side effects: 'isAfterLast'. Change-Id: I1b69340c3714be4678b599fa9a8ca933122aa857 Reviewed-on: https://gerrit.libreoffice.org/23981 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-06remove some dead bits of DDENoel Grandin
Change-Id: Ieb1d4e23f1a62b56d14a655a676d9c7d5f33c51c Reviewed-on: https://gerrit.libreoffice.org/23849 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05loplugin:nullptrStephan Bergmann
Change-Id: Iabc4df52491adff974de4656f626ab19848dd3f0
2016-04-05tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I removed OSL_DEBUG_LEVEL > 1 conditionals, replaced DBG_ASSERT to standard assert(..) and used SAL_INFO() in some places Change-Id: Ib6d6065e3f141e60f865fef1faacdb5598e12431 Reviewed-on: https://gerrit.libreoffice.org/23073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-04loplugin:constantparam in i18nlangtagNoel Grandin
Change-Id: I3d7cbac7ca58f3de9771a1221196f851255f3fb9 Reviewed-on: https://gerrit.libreoffice.org/23802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04loplugin:constantparam in svlNoel Grandin
Change-Id: I6c336034a12fda493825b4a8388d3bde6bead910 Reviewed-on: https://gerrit.libreoffice.org/23729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-30Use const_iterator when possible (svl except svdde)Julien Nabet
Change-Id: Ie19467a020d1839146d5a6324e54ccf223d99dd6 Reviewed-on: https://gerrit.libreoffice.org/23603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-29cid#1357162: Logically dead codeStephan Bergmann
...after 07da25064f75cdf7163669f9bf860a9ee2f8b33c "loplugin:constantparam in svl" Change-Id: I6f7cc3ca0822de079c0855ee46f66368bd78e0b7
2016-03-17Revert "tdf#98458 sw: make search in shape text optional"Jan Holesovsky
Actually there seems to be a simpler solution to the immediate performance problem which I'll commit next. It still might be necessary to introduce the search switch at some stage, but first let's see if there are complaints. This reverts commit 8e0b08c3053ed5472409b1ea7e02653aad38f7d6.
2016-03-17loplugin:constantparam in svlNoel Grandin
Change-Id: If23e43beb401047825641817e09d7fdeb904f9d9 Reviewed-on: https://gerrit.libreoffice.org/23317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17tdf#98458 sw: make search in shape text optionalMiklos Vajna
Instead of forcing it silently on everyone, add a new search option and enable it only in case it's requested, as shape search is expensive for large documents. (Regression from commit bdc1824ea7acfa2fe9d71cdbe57882acce155577.) Change-Id: Ibb6e76ad5c870dfd63b36429e16ef6d572f5f1fd
2016-03-16loplugin:constantfunction in ucbhelperNoel Grandin
Change-Id: I80e00b5ac2621378801f89532ed88b377ef72b60 Reviewed-on: https://gerrit.libreoffice.org/23297 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-10Avoid reserved identifiersStephan Bergmann
Change-Id: I815c839b19e5b2d7d5b5bab821614ad953006de2
2016-03-10Avoid reserved identifierStephan Bergmann
Change-Id: Iea66c7230f4570d6a2b88a514958788eb4105ffb
2016-03-09remove unused NOT_POOLABLE enum valueNoel Grandin
and simplify the resulting SfxItemInfo field down to a single bool Change-Id: I73e24e83d39afc7660ac85872ba96bc790713cb2 Reviewed-on: https://gerrit.libreoffice.org/23058 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-09loplugin:constantparam in svlNoel Grandin
Change-Id: Iefc441262cbdc6f115ea4ca5a673456b59477e13
2016-03-07loplugin:unuseddefaultparamsNoel Grandin
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795 Reviewed-on: https://gerrit.libreoffice.org/22971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07tdf#97703 removed empty setUp/tearDown methodsChirag Manwani
Change-Id: I244d481bce4723d172e26c0d31aab0a541334604 Reviewed-on: https://gerrit.libreoffice.org/22959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07loplugin:unuseddefaultparam in variousNoel Grandin
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0 Reviewed-on: https://gerrit.libreoffice.org/22900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-01loplugin:unuseddefaultparam in svlNoel Grandin
Change-Id: Ifc82563c8930332d460df4d97935ba6e9946689f
2016-02-26add SvxSearchItem::GetWildcard() SetWildcard()Eike Rathke
Change-Id: I0aeb7fbcedad381a385ffe6649ac51e8c961ca11
2016-02-24let SvxSearchItem use SearchOptions2Eike Rathke
And all those places that interface to SvxSearchItem. Change-Id: I08915824a596cd0f247a89f44e4684cd22b98082
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-19new loplugin: find write-only fieldsNoel Grandin
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717 Reviewed-on: https://gerrit.libreoffice.org/22498 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-12tdf#95857 Sort out German plurals ...danielt998
Made a start in removing the incorrect 'Infos' German plural Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60 Reviewed-on: https://gerrit.libreoffice.org/22301 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-11[API CHANGE] add operator==/!= to UNO structsNoel Grandin
this is useful now that we are storing UNO structs in std::vector Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369 Reviewed-on: https://gerrit.libreoffice.org/22257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09UIDNA_CHECK_CONTEXTO is only available in ICU >= 49Stephan Bergmann
...unlike the rest of the createUTS46Instance stuff, which is available in 4.6. While it is desirable to have that check here, it probably doesn't make much of a difference in practice, and Rico Tzschichholz would like to have this working on Ubuntu 12.04, where only ICU 4.8.1 is available. Change-Id: I5bbd2ed296c6e068e175e7f8353cea37ed4d9e44
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08tdf#88205 Delete 'uno::Sequence' in svlkerem
Change-Id: I5f2d79bedcea2712070c4e50b6f9e6d0d0112920 Reviewed-on: https://gerrit.libreoffice.org/22193 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-28 20:44:31 +0000