summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)Author
2014-03-15fdo#71491: Adjust reference during undo of drag-n-drop of cell range.Kohei Yoshida
Also with this commit, the signature of SvtListener::Notify() changes, by dropping the first argument which nobody uses. This change was necessary in order to call it directly without needing to pass any broadcaster instance. Change-Id: I6a1e97f0fb1e070d1d8f7db614690b04c9e8024e
2014-03-14708253 Uninitialized pointer fieldCaolán McNamara
Change-Id: I9d00dd3020d7bc75b6047cf20da3926f10b3632a
2014-03-14coverity#708255 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ic7fad54a0e39d007668e3fd3e2a857f9f9956d7d
2014-03-14coverity#708265 Uninitialized pointer fieldCaolán McNamara
Change-Id: I48afa08c5e1bb8a615901177e5baed20ea86d28e
2014-03-14coverity#708269 Uninitialized pointer fieldCaolán McNamara
Change-Id: If92b091d06e6de6f137d38a9fa28d4c8604b368c
2014-03-14coverity#708271 Uninitialized pointer fieldCaolán McNamara
Change-Id: If6acc11a32b5be1092f0de7c747159ee447edf7c
2014-03-13coverity#708824 Unused pointer valueCaolán McNamara
Change-Id: I2993b61d5556abd039f30c39938b6726fd2b1197
2014-03-13Related: fdo#30770 fix rtf cut/paste crashCaolán McNamara
regression since 0c17ccc493d0c7a80f37600dae76a09a119bef78 Change-Id: I15396ad4d0906c7c3b27c318d73455ac494ae754
2014-03-13sfx2,svl: prefer passing OUString and OString by referenceNoel Grandin
Change-Id: I9833265f6e635a057cea2c4a945cc73809b1e2ef
2014-03-11fdo#39468 Translate German commentsTobias Lippert
Change-Id: I051092f2ffb76a6ef400acd51514189ff20dad7d Reviewed-on: https://gerrit.libreoffice.org/8486 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-11fdo#30770 - Speed up xslx importTobias Lippert
Conflicts: include/svl/style.hxx Change-Id: Ie3d855923c651b6e05c0054c8e30155218279045 Reviewed-on: https://gerrit.libreoffice.org/8485 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-11callcatcher: update unused codeCaolán McNamara
Change-Id: Ie7acb237728af27df27d87c3f46a3eaa9cd14654
2014-03-10svl: simplify deprecated XTypeProvider.getImplementationIdStephan Bergmann
Change-Id: Ib1e59f755e0472efe0448d1976cdfba13c64ff18
2014-03-10coverity#1079295 Uninitialized pointer fieldCaolán McNamara
Change-Id: Iddae1fca0664e2d0106f7cc13dc2d9b89d57b1e4
2014-03-10coverity#1079294 Uninitialized pointer fieldCaolán McNamara
Change-Id: I3605699642a1fb5e42a8ea7347bc0009e8f9141a
2014-03-10coverity#1079293 Uninitialized pointer fieldCaolán McNamara
Change-Id: I20f844b98e922ccd351a28d9b47554c796876d14
2014-03-10coverity#1079292 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ic78aa75bccda1f63d97eb8489d5d64c936c37b16
2014-03-10coverity#1079291 Uninitialized pointer fieldCaolán McNamara
Change-Id: I75ce5ab5583ed3e4009582bae531db24b66be9f8
2014-03-06coverity#1190371 Uninitialized scalar fieldCaolán McNamara
Change-Id: I69d49b13e6e0df81107eb9364adecf87e3b9786c
2014-03-05Work around unfortunate libstdc++ interpretation of C++ cmath requirementsStephan Bergmann
...that causes a call to std::abs with a short argument to effectively select the double overload (via a template added with <http://gcc.gnu.org/git/ ?p=gcc.git;a=commit;h=8c0edf5c2aad076cbc805299ed82845ae049f4f6> "include/c_std/cmath (abs(_Tp)): Add"), see <http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-toc.html#2192> "Validity and return type of std::abs(0u) is unclear" for details. The workaround is to use int instead of short arguments (and make sure the integral overloads of std::abs from cstdlib are available). Change-Id: If95363f9a54abb9cb1a57fd4828c4b91c12bc4be
2014-03-05remove unused code SfxGrabBagItem::SetGrabBagNoel Grandin
Change-Id: If41ef729da5799ebaa4ea238c6d2c4f1087ac487
2014-03-05debug only code SfxItemPool::GetMasterPool() constNoel Grandin
Change-Id: Ia3c53e64f6e39618b4cc85fae5f213e67041a725
2014-03-03remove unused code svl::SharedStringPool::SharedStringPool()Noel Grandin
Change-Id: I497cb89d0b204b9de9c31f86837664d107e55033
2014-03-01Set the default cell border line width to 0.75 pt in Calc.Kohei Yoshida
0.75 pt provides a better interop with Excel documents. Change-Id: Ic1d2cbbe4e35dc0793a0e35d3836261d91138f7c
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-25Remove visual noise from svlAlexander Wilms
Change-Id: Ib914ec8d161e24f4e3e1fb8e7684a780d3ae6209 Reviewed-on: https://gerrit.libreoffice.org/8319 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2014-02-25svl: don't forget about big-endian parts in filerec.cxxDouglas Mencken
Fixes: (build error) filerec.cxx:591: error: no match for 'operator>>' Change-Id: I412cc9121c50830069e8e71c35dfb4f8ce475357 Reviewed-on: https://gerrit.libreoffice.org/8206 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-25Replace deprecated std::auto_ptr with boost::scoped_ptrTakeshi Abe
Change-Id: I8e11ffe888aac8887c4c0875c41de51f343debae
2014-02-24Remove some temporaries around calls to SvNumberFormatter methodsMatteo Casalin
Change-Id: Ib03c97a52df120bac1ac9b2b9d2e52431ead1027
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20Add SvStream::ReadCharAsBoolStephan Bergmann
Change-Id: I9dc0525e04de5ae79205872b779dcd0115a9cc14
2014-02-20svl: sal_Bool -> boolStephan Bergmann
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-19coverity#738853 Uninitialized scalar fieldCaolán McNamara
Change-Id: I01e72000f9e624b73351306e7d52c0ba18cbd8e1
2014-02-19coverity#738854 Uninitialized scalar fieldCaolán McNamara
Change-Id: Iace6e3f93f05342d7b1652e8118be01a142b82cc
2014-02-18Stick to a single O[U]String hash functionStephan Bergmann
8f8bc0dcf3bc253ae49159d52db049767f476ced "Move string hash function into String class" had introduced a new getHash64 that, besides returning sal_uInt64 instead of just sal_Int32, didn't do sampling of only a handful of characters, but always computed the hash over all characters (as the usage in SfxItemSet and SdPage appears to require for either performance or approximated correctness). However, it would be advantageous to keep the stable URE interface as small as possible. Now, O(1) sampling was apparently considered state of the art when the rtl string classes were first created, closely copying java.lang.String, which at that time demanded sampling for hashCode(), too---but never sampling more than 15 characters, with the obvious (in hindsight, at least) performance catastrophes, so they changed it to O(n) somewhere along the way. Based on that, this commit changes the existing hash functions to not do sampling any more, and removes the newly introduced -64 variants again. (Where the extended value range of sal_uInt64 compared to sal_Int32 was hopefully not vital to the existing uses.) The old implementation used sampling only for strings of length >= 256, so I did a "make check" build with an instrumented hash function that flagged all uses with inputs of length >= 256, and grepped workdir/{Cppunit,Junit,Python}Test for hits. Of the 2849 hits encountered, 2845 where in the range from 256 to 295 characters, and only the remaining four where of 2472 characters. Those four were from CppunitTest_sc_subsequent_filters_test, importing long text into a cell, causing ScDocumentImport::setStringCell to call svl::SharedStringPool::intern, which internally uses an unordered_set. These results appear to justify the change. Change-Id: I78fcc3b0f07389bdf36a21701b95a1ff0a0d970f
2014-02-18coverity#984145 Uninitialized scalar fieldCaolán McNamara
Change-Id: I08d4de5fc4cbc56feda0f57f95ae76cd25b124e3
2014-02-17ucbhelper: sal_Bool -> boolStephan Bergmann
Change-Id: Iee327c3dd75bebb35d99de01eaa7103956e08974
2014-02-13SimplificationStephan Bergmann
Change-Id: I949bf3cb9c3b26a8c2de6bde20cef63d7630fc54
2014-02-13-Werror,-Wunused-variableStephan Bergmann
Change-Id: I91ab5f87f859b855c858a41afd218f57b03ad3a2
2014-02-13n#757432: Styles (rename &) copy to different decks.Muthu Subramanian
While copying slides to different slide decks, styles were not being copied if there is already one with the same name. This patch renames and copies those to keep the formatting intact. Change-Id: I66f71493f1fd658eed43e39aa7ae7ee7b5463b34
2014-02-12remove SvStream::operator>> methodsNoel Grandin
in favour of ReadXXX methods. Change-Id: Ic2c0a7b6b92ff4c236ae99b39d77f3d935b301e3 Reviewed-on: https://gerrit.libreoffice.org/7915 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-12more SvStream:operator>> conversionNoel Grandin
Convert the template based read_lenPrefixed methods to regular methods. Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019 Reviewed-on: https://gerrit.libreoffice.org/7895 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12convert SvStream::operator>> methods to ReadXXX methodsNoel Grandin
First, I updated the clang rewriter to do the conversion. Then I lightly hand-tweaked the output for the few places where the rewriter messed up, mostly when dealing with calls on "this". Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9 Reviewed-on: https://gerrit.libreoffice.org/7879 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-11coverity#440944 Logically dead codeCaolán McNamara
Change-Id: Ie01738985311c915ca9f2d8dd47ca6cb96d1b26c
2014-02-05SfxItemSet::operator == should return boolStephan Bergmann
...and need not be virtual Change-Id: I8cf38c4942526c6ca66595fdc3297be750ec09a0
2014-02-04convert specialised SvStream::operator>> methods to ReadXXX methodsNoel Grandin
as preparation for converting the SvStream::operator>> methods on primitive types Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9 Reviewed-on: https://gerrit.libreoffice.org/7798 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-30fdo#63154 Removed unused solar.h ref. in linguc., sfx2, starmath, svl and svxAlexandre Vicenzi
Change-Id: I241661119371b75804fcf9215ff5e5da2a5b9265 Reviewed-on: https://gerrit.libreoffice.org/7732 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-29bool improvementsStephan Bergmann
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
2014-01-28bool improvementsStephan Bergmann
Change-Id: I6cf511b92383f3cd60923620518b9233b82850c0
2014-01-23Let C++ inline functions return bool instead of sal_BoolStephan Bergmann
...to improve diagnosing misuses of boolean expressions in client code (cf. compilerplugins/clang/implicitboolconversion.cxx). This change should be transparent to client code. Missing overloads of insert() for bool have been added to OStringBuffer and OUStringBuffer (which required dropping one !VALID_CONVERSION check that would now pick that overload, but would be flagged by compilerplugins/clang/pointertobool.cxx). Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
generated by cgit (git 2.34.1) at 2025-01-04 09:27:34 +0000