summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)Author
2014-01-23Let C++ inline functions return bool instead of sal_BoolStephan Bergmann
...to improve diagnosing misuses of boolean expressions in client code (cf. compilerplugins/clang/implicitboolconversion.cxx). This change should be transparent to client code. Missing overloads of insert() for bool have been added to OStringBuffer and OUStringBuffer (which required dropping one !VALID_CONVERSION check that would now pick that overload, but would be flagged by compilerplugins/clang/pointertobool.cxx). Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-22convert more SvStream::operator<< callsNoel Grandin
.. to more explicit SvStream::Write* calls This was done using another run of the clang rewriter, and then a lot of hand tweaking to fix all the places where the rewriter did not play nice with various macros. Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18 Reviewed-on: https://gerrit.libreoffice.org/7494 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22Clean up SfxItemSet::PutStephan Bergmann
* Make inherited overloads visible via "using" in SfxAllItemSet. * The overload with SfxItemSet argument: ** need not be virtual (verified by temporarily marking it SAL_FINAL); ** should apparently return bool. Change-Id: I5c57ec3d757d3d32a3e23be12964e7ebb81e6211
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-21bool improvementsStephan Bergmann
Change-Id: I5c72b0bc34d87312437ae32a506567c3fb3bfa19
2014-01-21bool improvementsStephan Bergmann
Change-Id: I28697ffd7902321730435e15fcf3018c78a61c5f
2014-01-17Translate German ("kein break") comments to English ("no break").Sven Wehner
Change-Id: Ibbc706d1c3cd36e21da2a15077392f9d75ba39fd Reviewed-on: https://gerrit.libreoffice.org/7498 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-16convert SvStream::operator<< overloads to more explicit methodsNoel Grandin
This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16fdo#54938: Convert svx and svl to cppu::supportsService...Marcos Paulo de Souza
...final season Change-Id: Ie51ac231def4a8a6e2681b81de7580798c95eed2
2014-01-10Use boolStephan Bergmann
Change-Id: I38f7ec288b907e889c71821cfbfac46a9688ba0c
2014-01-10SfxItemSet::Set should return boolStephan Bergmann
Change-Id: Icb38319f1307e94ce5c6d43b999a08db1fc38d85
2014-01-10SfxPoolItem::operator ==, != should return boolStephan Bergmann
...and SfxEnumItemInterface::HasBoolValue, too. Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
2014-01-10re-write SvStream operator<< to non-overloaded methodsNoel Grandin
This is the actual re-write. Use a clang rewriter to rewrite SvStream::operator<< to methods like WriteuInt32. Note that the rewriter is not perfect, and I hand-tweaked the output. In particular, I had to adjust places doing things like (*this) << 1; Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a Reviewed-on: https://gerrit.libreoffice.org/7342 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-07Fix typo in my commitNoel Grandin
Fix typo in my commit 82625bb98e256b83351328d3bf2a14e3dd244eef "remove unnecessary sal_Unicode casts in OUStringBuffer::append calls" Change-Id: I593c6a8ce5be3d4e2783acd3800626d7eb9a0480
2014-01-07remove unnecessary sal_Unicode casts in OUStringBuffer::append callsNoel Grandin
Convert code like: buf.append( static_cast<sal_Unicode>('!') ); to: buf.append( '!' ); Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2013-12-27cppcheck: fix var reassignedJulien Nabet
Change-Id: I10bb64672d02626814c162b09b8bdd615f7fcad8
2013-12-23fix crash when erasing entry while iterating through vectorMarkus Mohrhard
Broadcast might result in calling Remove on the same object which erases the entry from the listeners vector. If we create a copy we can still iterate through the vector as all iterators are still valid.
2013-12-23iterators are not pointersEike Rathke
Change-Id: Ic9809beead66cf0d0e6a6a28bb97b220fb667578
2013-12-21Make the broadcasting work even when about to destruct.Jan Holesovsky
Change-Id: Idba9302e1ec5234d3d472cda047c09ba52afd328
2013-12-21Don't call EndListening() on already destructed listeners.Jan Holesovsky
Change-Id: I9bda35f2246de9d37077dda33c710b89ee008e5a
2013-12-21Speedup destruction of sheets with too many listeners & broadcasters.Jan Holesovsky
Listeners and broadcasters are M:N relationship. If you want to destruct them, you easily end up in O(M*N) situation; where for every listener, you iterate all broadcasters, to remove that one listener. To avoid that, announce to the broadcasters that they are going to die, and the listeners do not have to bother with removing themselves from the broadcaster. The broadcaster will not broadcast anything after the PrepareForDesctruction() call anyway. Change-Id: I68d78b23e73bcbb944de9139448b2c20dfa14f62
2013-12-20typo fixesAndras Timar
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-19svl: whitespace fixes in grabbagitemMiklos Vajna
Change-Id: I363e8c0f1a51a18bf0ad0ac4f931107137fd1c58
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17remove unnecessary double calls to OUString constructorNoel Grandin
Change-Id: Ib2690e3ec9987b97363687b61fe8ddae4ace9058
2013-12-12simplify - use OUString::startsWith where possibleNoel Grandin
Convert code like if( !aStr.isEmpty() && aStr[0] == 'x' ) to if( aStr.startsWith("x") ) Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
2013-12-12Don't hold css::uno::Type instances by pointerStephan Bergmann
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the arrays of such need to be initialized dynamically anyway, also change their name members to proper OUStrings while at it. Plus some const clean-up. Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-11Revert "Don't hold css::uno::Type instances by pointer"Stephan Bergmann
This reverts commit 90f91088d238469b4a2262c91de3117ba40f5bde for now: Ach, old GCC doesn't like plain string literals to initialize members of OUString type... Change-Id: I50563a00406259bb5d41831e2a2796762450d097
2013-12-11Don't hold css::uno::Type instances by pointerStephan Bergmann
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the arrays of such need to be initialized dynamically anyway, also change their name members to proper OUStrings while at it. Plus some const clean-up. Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-10Typos (mainly "propably")Julien Nabet
Change-Id: Ifeecd82f98f9be9f90d293a7b68691f91d7bbc34
2013-12-10svl: remove SfxDateTimeItem, which is actually unusedMichael Stahl
... since 2f44516d6c3fce6ebe372214ce4bfa11875bd3d1 Change-Id: I25905a69464a43e12fcbb4770c8b0e171ab3271b
2013-12-10editeng: fix more 32-bit Time breakageMichael Stahl
SfxDateTimeItem and SvxExtTimeField need to use 64-bit integer to store Time as well. These classes also have binary serialization Load()/Save() methods but they are unlikely to be used in a persistent way, just for the clipboard. The problem is easy to reproduce in Impress: Insert->Field->Time(fixed) (regression from 9830fd36dbdb72c79703b0c61efc027fba793c5a) Change-Id: I5946c5b94dd5a509805b6dc40461bbd910caffc4
2013-12-10n#753460: Copying slides having same master page name.Muthu Subramanian
Has part feature of getting hashes of SdPages. (Misses hashing text, images, etc).
2013-11-26Resolves: #i123753# WaE: fix unoedhlp.hxx declaration of 'nId'...Herbert Dürr
shadowing a member of SimpleHint Happy new times: Now even simple compiler warning fixes need their own issue. (cherry picked from commit 5cd09cc74da93da4c91c665822b6ab9a0d704a7a) Conflicts: svl/inc/svl/smplhint.hxx svl/source/notify/smplhint.cxx Change-Id: I445126425a22778cf7aaf33d3a34977903e59f84
2013-11-23rigth -> right (other occurences)Julien Nabet
Change-Id: Ic899aa36b1b18237f90295eaa04ea83450958c87
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-15Band-aid fix for SvtBroadcaster::BroadcastStephan Bergmann
...after 18d07b2affbbbfb2ff9152d3ad8d1744fe75ab47 "Rework SvtListener and SvtBroadcaster internals" broke the case where SvtBroadcaster::Add/Remove is called from within SvtBroadcaster::Broadcast, and at least CppunitTest_sc_ucalc started to fail. It should be evaluated whether the original SvtBroadcaster logic to handle this was better than taking a copy here. Change-Id: Ie47bccb8c5789e405349a9c8b89f30b1dba3cfba
2013-11-14Optimize SvtBroadcaster for insertion.Kohei Yoshida
This helps file load performance at the slight overhead during editing. That said, the overhead during editing is only in theory (not measured) and shouldn't be that much even in theory. Change-Id: If22ea34acb0cda311575ac3ed8ce1a8eb69ae33a
2013-11-14No need to individually remove listeners when being destroyed.Kohei Yoshida
Otherwise a crash would ensue. Change-Id: I9a52524cc205765d059745e9f7e914b636667cb6
2013-11-14Rework SvtListener and SvtBroadcaster internals.Kohei Yoshida
The old code was simply awkward. Change-Id: I1a58a9af86c100be238d306570b40f70c5100314
2013-11-14make l10n buildable separatelyBjoern Michaelsen
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/Module_filter.mk
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-11Mutex access to the global theIndexTable.Kohei Yoshida
Change-Id: I31e2cf3a479e385aa0fca4678a3a2c7fa6cc4b5f
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-10clean up #ifdef ICC codeMichael Stahl
According to the dmake documentation, ICC refers to Visual Age C++ for OS/2, which is not a supported compiler (or platform). Change-Id: Ic9e23bc7c44de110a3a312bd007beda3b660927d
2013-11-08Make INetURLObject-from-OUString ctor explicitStephan Bergmann
...and clean up call sites. Change-Id: I7219a33652835e82fdc44e9e801a7e62868e4f38
2013-11-08remove unnecessary use of OUString constructor in SVL moduleNoel Grandin
Change-Id: Ib3c2f2b43895fe45e9efff888bbd81d8be5969e4
2013-11-06Make TransformInput() a non-member function.Kohei Yoshida
Change-Id: Ieb077b6ce661e2885d6010519f137235a048f9df
2013-11-06Add mutex to guard the shared string pool content.Kohei Yoshida
Change-Id: I0eb97d0fbeaefd8a1c86d240ed8bd7f208fb662e
2013-11-06check string boundsCaolán McNamara
as demonstrated by fdo54887-1.ods Change-Id: I2d5568126c58c831446b4c4b050ffed193f7921d
generated by cgit (git 2.34.1) at 2024-12-29 12:46:14 +0000