summaryrefslogtreecommitdiff
path: root/svtools/source/contnr
AgeCommit message (Collapse)Author
2016-08-12loplugin:unusedenumconstants in package..svtoolsNoel Grandin
Change-Id: I8136b93b9303ebecafd791159e813c335b1bc172 Reviewed-on: https://gerrit.libreoffice.org/28052 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11loplugin:countusersofdefaultparams in svl..unodevtoolsNoel Grandin
Change-Id: Ie3d2cf29e99b8a51b80246aafa23a92e6c3404b2 Reviewed-on: https://gerrit.libreoffice.org/28017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01tdf#93845: Style Preview Checkbox for Styles & Formatting sidebarSusobhan Ghosh
Change-Id: Id5862339bbe0c80002dfd99cbf19d981d1d42682 Reviewed-on: https://gerrit.libreoffice.org/27706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-29Related: tdf#99324 accel underlines don't appear in hyperlink dialogCaolán McNamara
Change-Id: Ib16b239c88b1d1157fc18bc62b5f01c52e896a48
2016-07-29Related: tdf#99324 accel underlines don't appear in options dialogCaolán McNamara
Change-Id: I47cb6df2118ea86dea7225842dcdc4c1dafc439f
2016-07-29this NOCOMMAND is never definedCaolán McNamara
Change-Id: I6a2ae90182eaeb534176dd0a2591bfe0c2242a5c
2016-07-29loplugin:countusersofdefaultparams in store..svtoolsNoel Grandin
Change-Id: I15b4400bddc5a4d0e3de5dfffe18b7e493f97df6 Reviewed-on: https://gerrit.libreoffice.org/27580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-18Resolves: tdf#100823 crash during PopupMenu dtorCaolán McNamara
Change-Id: I6d9aed05a76311a13470c9072543609f5a87501d
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I3b52f6a392b6f6dcc8e3d528dc61bf49c510737d
2016-07-05when disposing popup menus, don't leave dangling pointersNoel Grandin
Change-Id: Ia1b49937ba0693a567097367b99b75a3011666bf Reviewed-on: https://gerrit.libreoffice.org/26960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-06-24loplugin:singlevalfields in svtoolsNoel Grandin
Change-Id: I80fe1d4646af2b8d8e6362a25f6cda4b7ac29eab Reviewed-on: https://gerrit.libreoffice.org/26603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-20Convert PART to scoped enumNoel Grandin
Change-Id: If4c2849beb207593d3d450ae3846ed24eaf66ca4 Reviewed-on: https://gerrit.libreoffice.org/26173 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-18uitest: add initial version of wrapper for tree list boxMarkus Mohrhard
The tree list will also be the first case where we need non-vcl::Window based children. We should create one child for each entry to make it possible to interact with them correctly. Change-Id: I49e1ddf7b271946fd595ebfe2f4f2d0c8a535fdc
2016-06-08remove "object is disposed" warning in OBroadcastHelperVar::removeListenerNoel Grandin
doesn't add anything of value. Change-Id: Ie2dea7c43570640284771c992d0072ab61de425e Reviewed-on: https://gerrit.libreoffice.org/25871 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08Convert ButtonValue to scoped enumNoel Grandin
Change-Id: Ia882914fb99844f21ce89d7218321933ef084b22 Reviewed-on: https://gerrit.libreoffice.org/26036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02loplugin:unuseddefaultparamsNoel Grandin
Change-Id: I0fe173534dc2e70c3d507eae757a91e48a26acfc Reviewed-on: https://gerrit.libreoffice.org/25757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert ControlType to scoped enumNoel Grandin
Change-Id: Iaa13c3e7030296a97bab144103745867d43b4b19 Reviewed-on: https://gerrit.libreoffice.org/25554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert SelectionMode to scoped enumNoel Grandin
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26Resolves: tdf#96279 set correct parents for password dialogsCaolán McNamara
otherwise on Dialog::Execute before it becomes visible and a password dialog is needed the new dialog will automatically look for a parent, but will be parented by the main window because the dialog it should be a parent of is not visible yet. Change-Id: Ia34e43d7ef2b204b348f2eb5aab542ee8ffe840e
2016-05-26tdf#89329: use unique_ptr for pImpl in svlbitmXisco Fauli
Change-Id: If047546c953a5f3bf7af3f99fb7f9d604e0bdba8 Reviewed-on: https://gerrit.libreoffice.org/25476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in svtabbxXisco Fauli
Change-Id: I40a826f6430532769590e6c34d8a98997127fc2e Reviewed-on: https://gerrit.libreoffice.org/25477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in treelistboxXisco Fauli
Change-Id: I5ba1638c905893f62d6d24d7c88cbb66aaa7c786 Reviewed-on: https://gerrit.libreoffice.org/25480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in fileviewXisco Fauli
Change-Id: Ief2fd163cc024b4a654a32c24cef832c68ad5e96 Reviewed-on: https://gerrit.libreoffice.org/25482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in ivctrlXisco Fauli
Change-Id: Idd525be5934e752c3bed5e2d79c36c2305b4441f Reviewed-on: https://gerrit.libreoffice.org/25485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16convert IconChoice flags to scoped enumNoel Grandin
and removed unused entries Change-Id: Ibe7ebb7723d9418893a2e2768e2a84eb16d1a046 Reviewed-on: https://gerrit.libreoffice.org/24970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16convert SvImpLBox flags to scoped enumNoel Grandin
and remove the dead ones Change-Id: Iac72c4a4e16290936a9965afb8c637d181bccb2d Reviewed-on: https://gerrit.libreoffice.org/24965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Give unique, comprehensible names to idles tdf#97087Muhammet Kara
Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-13convert SHOWTRACK to scoped enumNoel Grandin
Change-Id: Ibf06f6c79f80d7265ae3239c1ea0088118e92e21 Reviewed-on: https://gerrit.libreoffice.org/24894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13Typo: ExcecuteContextMenuAction->ExecuteContextMenuActionJulien Nabet
Change-Id: Ifb121344a8f235d71bab33c03808e3f44d7bee7c Reviewed-on: https://gerrit.libreoffice.org/24942 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I8fcd7bf2583c935e060a29e43c88614681d81d13
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13loplugin:passstuffbyref in svtoolsNoel Grandin
Change-Id: Ie166eaef65e56fafe4e57a5559b587d7558d7aa4
2016-04-12lp#1569589: a more honest attempt at disposing SvtFileView_ImplBjoern Michaelsen
Dunno yet if that completely fixes the story -- the reference here are quite messy: ownership isnt exactly obvious. Change-Id: I54d71ac724590e85549bd152c963fdc8de46746e Reviewed-on: https://gerrit.libreoffice.org/24040 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I481621d58b94163e32f9b5f19187d8ad587f2b1d
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11loplugin:constantparamNoel Grandin
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-04-04loplugin:constantparam in svtoolsNoel Grandin
Change-Id: Iceb1b57997e0369946150ef0764b71da59a6b7a6 Reviewed-on: https://gerrit.libreoffice.org/23725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-28tdf#90795 Fix Hyperlink Dialog for HiDPIChirag Manwani
Change-Id: I30964d3bd3b5c4433e72be45bfa0202661248051 Reviewed-on: https://gerrit.libreoffice.org/23347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-03-23loplugin:constantparm in svtoolsNoel Grandin
Change-Id: I637efc68d02da527cf543d7e7bfbf51e5e70a1ad
2016-03-18convert SvButtonState to scoped enumNoel Grandin
Change-Id: I601f9e2fe33e85cf3f7dc52ee20d68202bd2b09d
2016-03-18convert SvLBoxButtonKind to scoped enumNoel Grandin
Change-Id: Ia8e19473132cf95837acc499c5831b5ca8786a68
2016-03-18drop unused params from SvLBoxItem and all it's subclassesNoel Grandin
looks like this is fallout from commit ac7acb0a "Merged SvTreeListBox and SvLBox." (in year 2012) Change-Id: Iaebeae64fc7cd3ba11f5f45b53bcb65bf906e906
2016-03-17loplugin:constantparam in svtoolsNoel Grandin
Change-Id: I1a3c4a36e29a6712c589ffd3aaada593880d978d Reviewed-on: https://gerrit.libreoffice.org/23304 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16coverity#1355502 Dereference before null checkCaolán McNamara
Change-Id: I2833454ca4afd9e11a6c0c4fb1386f0dbb0d13d8