Age | Commit message (Collapse) | Author |
|
Unipoll tries to simplify behavior of the Kit process by processing
events in a single thread, more sensibly. We do this for other key
events, so it's important that key-derived dispatches eg.
SID_BACKSPACE which we use to simulate composition input are also
synchronous.
Change-Id: I12dbb104419a0aecd184ec312bfadec3a947d48b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87928
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Keep the behaviour as before when a unit test is running, though.
Otherwise CppunitTest_sd_tiledrendering fails. (Yes, I know, this is
the wrong thing to do, so sue me.)
Change-Id: Iae969eee800994b937d32646cfdf50f8132ae185
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87131
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
We reduce the number of swatches per row from 12 to 4 and increase
their size suitably so that the thing still fits in the sidebar in the
iOS app on an iPad in portrait orientation.
Change-Id: Ie81e5b54e88a02c6866de27448b5be72e97d9a16
Reviewed-on: https://gerrit.libreoffice.org/85620
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: I785f8af1eec54f36721a354c4d3f82d8b86ceb86
Reviewed-on: https://gerrit.libreoffice.org/84419
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/84519
Tested-by: Jenkins
Reviewed-on: https://gerrit.libreoffice.org/84759
|
|
Change-Id: Ie6d088217c066ec3091fb28925947175cf62634f
(cherry picked from commit 21b68c4cd7ce108cf334607ced0b20e7b5914c20)
Reviewed-on: https://gerrit.libreoffice.org/84754
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
Unfortunately the "Table Design" panel has a "ValueSet" control with
images constructed with the function "CreateDesignPreview". I have no
other choice to export the images to base64 and send it to client.
Perhaps later we can optimize the function "CreateDesignPreview", to
accept SVG pattern or something related.
Change-Id: I34bc8374ffd2a16fbb8fbc2fcd6a41a96bda57a5
Reviewed-on: https://gerrit.libreoffice.org/83538
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
|
|
Change-Id: Ia263f9f7c78dbf48143678fc2f577402fb1ce998
Reviewed-on: https://gerrit.libreoffice.org/83309
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
The client side requires the data of the selected item to apply CSS
border styles.
Change-Id: I19f662329e4cfce45e32f82dcf9398dc9c3ecaec
Reviewed-on: https://gerrit.libreoffice.org/81418
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
|
|
The ValueSet control has an item list with a pair properties "(pos,id)".
The "POS" parameter is the item "ID" not the position in the list and
to not modify doc_sendDialogEvent function, let's have same uniform
parameter for the action "SELECT".
Change-Id: I5ce2cf0433bebcd77954f271c4aa09b0b446c0ab
Reviewed-on: https://gerrit.libreoffice.org/81387
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
|
|
The ValueSet control is used in Layouts panel inside Sidebar of the
impress document. Once the LO server sends the UI data to the client side
that is transformed to mobile view using Mobile Wizard framework.
The loleaflet client side has to send commands for the user interactions
like to touch an item.
e.g. Send "WindowId SELECT ID=300"
The unit test simulates the scenario, so the ValueSet control executes
the action.
Change-Id: Ib6ec5db6ce2777e819f81a9dae74c4641bb7053b
Reviewed-on: https://gerrit.libreoffice.org/81141
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
|
|
In order to create a container element at client side dialog
using DialogWizard. It is required to send the items of the
valueset control.
Change-Id: Ib0fdc444c7126e6888e37c8a01f8e7f04c641d18
Reviewed-on: https://gerrit.libreoffice.org/81001
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
|
|
which benefits LOOL since we can delay creating the image until
we know the dpi setting of the display we are going to write to.
Achieved by
perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" )
followed by
git grep -nP '\bImage\s*\(\s*BitmapEx\s*\('
followed by commenting out the BitmapEx(OUString) constructor and seeing
what needed adjusting.
Reviewed-on: https://gerrit.libreoffice.org/64760
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/64860
Tested-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 89161e4d5835b93f0942e960a116a0d3863cc55c)
Change-Id: I3224e11937d720fa484b0d659d25673a9e809267
Reviewed-on: https://gerrit.libreoffice.org/79844
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* FuInsertChart as a memeber in ScTabViewShell
stores instance is needed to react on the dialog's result
* CreationWizardUnoDlg converted to XAsynchronousExecutableDialog
added dialog close handler which notifies listeners
In the Online dialog become dead after closing, additional
PostUserEvent was needed to kill the dialog after real close
(without it user needed to select any cell to close dialog)
* Reuse in Writer
Change-Id: I9fe123d5c189d568f0edb4d36173a224a820a8a3
Reviewed-on: https://gerrit.libreoffice.org/79654
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
unless its been explicitly requested
Change-Id: Id9f34b68404cb3bdcaea641583980fa14453f2d1
Reviewed-on: https://gerrit.libreoffice.org/75648
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit a60b4e1866ec48ca5de36e4138817f20b369d942)
Reviewed-on: https://gerrit.libreoffice.org/76926
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
This improves support for Online HiDPI scenarios.
Change-Id: I1d4d13d8877b761cabaefa028dcd50d8345d9893
Reviewed-on: https://gerrit.libreoffice.org/74241
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
Reviewed-on: https://gerrit.libreoffice.org/67906
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 54b2615e0d209f815b3d503523fd4c517dc6b5cd)
Change-Id: Icb98dac73dea5f5cb18e1ca34e37e9d9bf84782e
Reviewed-on: https://gerrit.libreoffice.org/67921
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
* Add an enum and some methods to DocumentToGraphicRenderer
to differentiate between the doc/module types:
isWriter(), isCalc(), isImpress()
* Put some checks for module/doc type
* The result seems ok for a Calc document of multiple sheets
with hundreds of pages
Change-Id: Idf3e1966d4239df30a48a947a95c9085c25ee1bb
Reviewed-on: https://gerrit.libreoffice.org/66605
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/69815
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/74195
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
And use that in sfx2 Redaction code to be independent of
the document/module type
Change-Id: Ic206f7a10a27d8d44566df34a10d009a34adf0a5
Reviewed-on: https://gerrit.libreoffice.org/65971
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/69813
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/74190
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Writer pages always have an offset inside the root frame, and this is
visible in the generated metafile as well. The offset is minimal for a
small window and a single page, but the vertical offset increases with
every page. Make this information visible, so sfx2 can compensate this.
This is somewhat similar to what SfxObjectShell::DoDraw_Impl() does, but
that works for the first page only (use case is thumbnail generation),
while this is 0 offset for Calc/Impress and a proper offset for all
Writer pages.
Change-Id: I1075c98faf74f9e77c916572b4d63d40fbd80ab1
Reviewed-on: https://gerrit.libreoffice.org/65850
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Reviewed-on: https://gerrit.libreoffice.org/74188
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
The crash affects Windows, not Linux where an error popup appears instead (MacOs?)
It seems the fact the url was empty triggers an exception in ucbhelper::Content ctr
So let's put the lines in the try catch and log the exception.
See comments of bugtracker for slight more details.
Change-Id: I60e55be488632ff6e0106fde832a818c6431f58e
Reviewed-on: https://gerrit.libreoffice.org/71321
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/71593
|
|
regression from
commit 7ea01578eed8459678369d0256de016930b3af40
Date: Fri Oct 19 13:04:43 2018 +0200
loplugin:staticvar in soltools..svx
turns out using std::lower_bound as a binary search is rather painful.
Change-Id: Ide6f5cf4ff91a8832daa43a7fec2f5cfc97fc94a
Reviewed-on: https://gerrit.libreoffice.org/67951
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit bdc9bdccb61130355784800f99b4fd726d6c424d)
Reviewed-on: https://gerrit.libreoffice.org/67957
|
|
Change-Id: I639fd1c593e7cc440de5d2038562e64eab1a5af6
Reviewed-on: https://gerrit.libreoffice.org/67167
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
since...
commit 8780fa41dcd164af244742461f4e57a4bcf4c7a4
Date: Tue Oct 30 12:23:36 2018 +0100
svtools: fix lost replacement grpahic when updating it via OLE fails
EmbeddedObjectRef::UpdateReplacementOnDemand is called by a chart during
EmbeddedObjectRef::GetReplacement which resets mpImpl->pGraphic to null
Change-Id: Id473b807582164eeb1791a26f6e0005a240f5989
Reviewed-on: https://gerrit.libreoffice.org/67128
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Jenkins
|
|
Change-Id: I439bf27b3f57838d9d0ea19605fd1b684ad4f777
Reviewed-on: https://gerrit.libreoffice.org/66475
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I8a9ec82d46a3df04554c139264755c8f28f5e897
Reviewed-on: https://gerrit.libreoffice.org/66336
Tested-by: Jenkins
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ieb6e62ca83921abed6b6432d70c6717dadfaaa34
Reviewed-on: https://gerrit.libreoffice.org/65090
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 0fa14d58457e9418ff756a0efd66e365c4403a67)
Reviewed-on: https://gerrit.libreoffice.org/65184
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
otherwise it crashes/aborts in Window::dispose() with this backtrace:
ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28
at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28)
ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154
at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154)
ucrtbased.dll!abort() Line 61
at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(61)
vcllo.dll!SalAbort(const rtl::OUString & rErrorText, bool bDumpCore) Line 309
at c:\lo\src\core\vcl\source\app\salplug.cxx(309)
vcllo.dll!Application::Abort(const rtl::OUString & rErrorText) Line 270
at c:\lo\src\core\vcl\source\app\svapp.cxx(270)
vcllo.dll!vcl::Window::dispose() Line 275
at c:\lo\src\core\vcl\source\window\window.cxx(275)
vcllo.dll!SystemWindow::dispose() Line 114
at c:\lo\src\core\vcl\source\window\syswin.cxx(114)
vcllo.dll!Dialog::dispose() Line 647
at c:\lo\src\core\vcl\source\window\dialog.cxx(647)
vcllo.dll!VclReferenceBase::disposeOnce() Line 43
at c:\lo\src\core\vcl\source\outdev\vclreferencebase.cxx(43)
tklo.dll!VclPtr<vcl::Window>::disposeAndClear() Line 206
at c:\lo\src\core\include\vcl\vclptr.hxx(206)
tklo.dll!UnoWrapper::WindowDestroyed(vcl::Window * pWindow) Line 294
at c:\lo\src\core\toolkit\source\helper\unowrapper.cxx(294)
vcllo.dll!vcl::Window::dispose() Line 233
at c:\lo\src\core\vcl\source\window\window.cxx(233)
vcllo.dll!SystemWindow::dispose() Line 114
at c:\lo\src\core\vcl\source\window\syswin.cxx(114)
vcllo.dll!WorkWindow::dispose() Line 129
at c:\lo\src\core\vcl\source\window\wrkwin.cxx(129)
vcllo.dll!VclReferenceBase::disposeOnce() Line 43
at c:\lo\src\core\vcl\source\outdev\vclreferencebase.cxx(43)
tklo.dll!VclPtr<OutputDevice>::disposeAndClear() Line 206
at c:\lo\src\core\include\vcl\vclptr.hxx(206)
tklo.dll!VCLXWindow::dispose() Line 947
at c:\lo\src\core\toolkit\source\awt\vclxwindow.cxx(947)
fwklo.dll!`anonymous namespace'::XFrameImpl::disposing() Line 2184
at c:\lo\src\core\framework\source\services\frame.cxx(2184)
cppuhelper3MSC.dll!cppu::WeakComponentImplHelperBase::dispose() Line 105
at c:\lo\src\core\cppuhelper\source\implbase.cxx(105)
fwklo.dll!cppu::PartialWeakComponentImplHelper<com::sun::star::lang::XServiceInfo,com::sun::star::frame::XFrame2,com::sun::star::awt::XWindowListener,com::sun::star::awt::XTopWindowListener,com::sun::star::awt::XFocusListener,com::sun::star::document::XActionLockable,com::sun::star::util::XCloseable,com::sun::star::frame::XComponentLoader,com::sun::star::frame::XTitle,com::sun::star::frame::XTitleChangeBroadcaster,com::sun::star::beans::XPropertySet,com::sun::star::beans::XPropertySetInfo>::dispose() Line 90
at c:\lo\src\core\include\cppuhelper\compbase.hxx(90)
fwklo.dll!`anonymous namespace'::XFrameImpl::close(unsigned char bDeliverOwnership) Line 1716
at c:\lo\src\core\framework\source\services\frame.cxx(1716)
fwklo.dll!framework::Desktop::impl_closeFrames(bool bAllowUI) Line 1743
at c:\lo\src\core\framework\source\services\desktop.cxx(1743)
fwklo.dll!framework::Desktop::terminate() Line 233
at c:\lo\src\core\framework\source\services\desktop.cxx(233)
comphelper.dll!comphelper::OOfficeRestartManager::notify(const com::sun::star::uno::Any & __formal) Line 109
at c:\lo\src\core\comphelper\source\misc\officerestartmanager.cxx(109)
tklo.dll!`anonymous namespace'::AsyncCallback::Notify_Impl(`anonymous-namespace'::AsyncCallback * __formal, void * p) Line 105
at c:\lo\src\core\toolkit\source\awt\asynccallback.cxx(105)
tklo.dll!`anonymous namespace'::AsyncCallback::LinkStubNotify_Impl(void * instance, void * data) Line 97
at c:\lo\src\core\toolkit\source\awt\asynccallback.cxx(97)
vcllo.dll!Link<void *,void>::Call(void * data) Line 84
at c:\lo\src\core\include\tools\link.hxx(84)
vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1935
at c:\lo\src\core\vcl\source\window\winproc.cxx(1935)
vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2486
at c:\lo\src\core\vcl\source\window\winproc.cxx(2486)
vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 285
at c:\lo\src\core\vcl\inc\salframe.hxx(285)
vclplug_winlo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4068
at c:\lo\src\core\vcl\win\window\salframe.cxx(4068)
vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5721
at c:\lo\src\core\vcl\win\window\salframe.cxx(5721)
vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5828
at c:\lo\src\core\vcl\win\window\salframe.cxx(5828)
user32.dll!UserCallWinProcCheckWow()
user32.dll!CallWindowProcW()
opengl32.dll!wglWndProc()
user32.dll!UserCallWinProcCheckWow()
user32.dll!DispatchMessageWorker()
vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 410
at c:\lo\src\core\vcl\win\app\salinst.cxx(410)
vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 441
at c:\lo\src\core\vcl\win\app\salinst.cxx(441)
vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 512
at c:\lo\src\core\vcl\win\app\salinst.cxx(512)
vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 441
at c:\lo\src\core\vcl\source\app\svapp.cxx(441)
vcllo.dll!Application::Yield() Line 506
at c:\lo\src\core\vcl\source\app\svapp.cxx(506)
vcllo.dll!Dialog::Execute() Line 1041
at c:\lo\src\core\vcl\source\window\dialog.cxx(1041)
vcllo.dll!SalInstanceDialog::run() Line 881
at c:\lo\src\core\vcl\source\app\salvtables.cxx(881)
vcllo.dll!weld::DialogController::run() Line 1364
at c:\lo\src\core\include\vcl\weld.hxx(1364)
svtlo.dll!svtools::executeRestartDialog(const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & context, weld::Window * parent, svtools::RestartReason reason) Line 101
at c:\lo\src\core\svtools\source\dialogs\restartdialog.cxx(98)
cuilo.dll!OfaTreeOptionsDialog::OKHdl_Impl(Button * __formal) Line 735
at c:\lo\src\core\cui\source\options\treeopt.cxx(735)
cuilo.dll!OfaTreeOptionsDialog::LinkStubOKHdl_Impl(void * instance, Button * data) Line 704
at c:\lo\src\core\cui\source\options\treeopt.cxx(704)
vcllo.dll!Link<Button *,void>::Call(Button * data) Line 84
at c:\lo\src\core\include\tools\link.hxx(84)
vcllo.dll!Button::Click::__l2::<lambda>() Line 125
at c:\lo\src\core\vcl\source\control\button.cxx(125)
vcllo.dll!std::_Invoker_functor::_Call<void <lambda>(void) &>(Button::Click::__l2::void <lambda>(void) & _Obj)
vcllo.dll!std::invoke<void <lambda>(void) &>(Button::Click::__l2::void <lambda>(void) & _Obj)
vcllo.dll!std::_Invoker_ret<void,1>::_Call<void <lambda>(void) &>(Button::Click::__l2::void <lambda>(void) & <_Vals_0>)
vcllo.dll!std::_Func_impl_no_alloc<void <lambda>(void),void>::_Do_call()
vcllo.dll!std::_Func_class<void>::operator()()
vcllo.dll!Control::ImplCallEventListenersAndHandler(VclEventId nEvent, const std::function<void __cdecl(void)> & callHandler) Line 321
at c:\lo\src\core\vcl\source\control\ctrl.cxx(321)
vcllo.dll!Button::Click() Line 125
at c:\lo\src\core\vcl\source\control\button.cxx(125)
vcllo.dll!OKButton::Click() Line 1737
at c:\lo\src\core\vcl\source\control\button.cxx(1737)
vcllo.dll!PushButton::Tracking(const TrackingEvent & rTEvt) Line 1260
at c:\lo\src\core\vcl\source\control\button.cxx(1260)
vcllo.dll!vcl::Window::EndTracking(TrackingEventFlags nFlags) Line 320
at c:\lo\src\core\vcl\source\window\window2.cxx(320)
vcllo.dll!ImplHandleMouseEvent(const VclPtr<vcl::Window> & xWindow, MouseNotifyEvent nSVEvent, bool bMouseLeave, long nX, long nY, unsigned __int64 nMsgTime, unsigned short nCode, MouseEventModifiers nMode) Line 703
at c:\lo\src\core\vcl\source\window\winproc.cxx(703)
vcllo.dll!ImplHandleSalMouseButtonUp(vcl::Window * pWindow, const SalMouseEvent * pEvent) Line 1998
at c:\lo\src\core\vcl\source\window\winproc.cxx(1998)
vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2336
at c:\lo\src\core\vcl\source\window\winproc.cxx(2336)
vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 285
at c:\lo\src\core\vcl\inc\salframe.hxx(285)
vclplug_winlo.dll!ImplHandleMouseMsg(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 3120
at c:\lo\src\core\vcl\win\window\salframe.cxx(3120)
vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5475
at c:\lo\src\core\vcl\win\window\salframe.cxx(5475)
vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5828
at c:\lo\src\core\vcl\win\window\salframe.cxx(5828)
user32.dll!UserCallWinProcCheckWow()
user32.dll!CallWindowProcW()
opengl32.dll!wglWndProc()
user32.dll!UserCallWinProcCheckWow()
user32.dll!DispatchMessageWorker()
vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 410
at c:\lo\src\core\vcl\win\app\salinst.cxx(410)
vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 483
at c:\lo\src\core\vcl\win\app\salinst.cxx(483)
vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 512
at c:\lo\src\core\vcl\win\app\salinst.cxx(512)
vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 441
at c:\lo\src\core\vcl\source\app\svapp.cxx(441)
vcllo.dll!Application::Yield() Line 506
at c:\lo\src\core\vcl\source\app\svapp.cxx(506)
vcllo.dll!Dialog::Execute() Line 1041
at c:\lo\src\core\vcl\source\window\dialog.cxx(1041)
cuilo.dll!OfaTreeOptionsDialog::Execute() Line 2040
at c:\lo\src\core\cui\source\options\treeopt.cxx(2040)
cuilo.dll!CuiVclAbstractDialog_Impl::Execute() Line 112
at c:\lo\src\core\cui\source\factory\dlgfact.cxx(112)
sfxlo.dll!SfxApplication::OfaExec_Impl(SfxRequest & rReq) Line 1361
at c:\lo\src\core\sfx2\source\appl\appserv.cxx(1361)
sfxlo.dll!SfxStubSfxApplicationOfaExec_Impl(SfxShell * pShell, SfxRequest & rReq) Line 1248
at c:\lo\src\core\workdir\sditarget\sfx2\sdi\sfxslots.hxx(1248)
sfxlo.dll!SfxShell::CallExec(void(*)(SfxShell *, SfxRequest &) pFunc, SfxRequest & rReq) Line 207
at c:\lo\src\core\include\sfx2\shell.hxx(207)
sfxlo.dll!SfxDispatcher::Call_Impl(SfxShell & rShell, const SfxSlot & rSlot, SfxRequest & rReq, bool bRecord) Line 356
at c:\lo\src\core\sfx2\source\control\dispatch.cxx(356)
sfxlo.dll!SfxDispatcher::Execute_(SfxShell & rShell, const SfxSlot & rSlot, SfxRequest & rReq, SfxCallMode eCallMode) Line 854
at c:\lo\src\core\sfx2\source\control\dispatch.cxx(854)
sfxlo.dll!SfxDispatcher::Execute(unsigned short nSlot, SfxCallMode nCall, const SfxItemSet * pArgs, const SfxItemSet * pInternalArgs, unsigned short nModi) Line 913
at c:\lo\src\core\sfx2\source\control\dispatch.cxx(913)
sfxlo.dll!SfxDispatchController_Impl::dispatch(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & aArgs, const com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> & rListener) Line 774
at c:\lo\src\core\sfx2\source\control\unoctitm.cxx(774)
sfxlo.dll!SfxOfficeDispatch::dispatch(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & aArgs) Line 225
at c:\lo\src\core\sfx2\source\control\unoctitm.cxx(225)
fwklo.dll!framework::MenuBarManager::Select(Menu * pMenu) Line 896
at c:\lo\src\core\framework\source\uielement\menubarmanager.cxx(896)
fwklo.dll!framework::MenuBarManager::LinkStubSelect(void * instance, Menu * data) Line 832
at c:\lo\src\core\framework\source\uielement\menubarmanager.cxx(832)
vcllo.dll!Link<Menu *,bool>::Call(Menu * data) Line 84
at c:\lo\src\core\include\tools\link.hxx(84)
vcllo.dll!Menu::Select() Line 362
at c:\lo\src\core\vcl\source\window\menu.cxx(362)
vcllo.dll!Menu::ImplCallSelect(void * __formal) Line 2140
at c:\lo\src\core\vcl\source\window\menu.cxx(2140)
vcllo.dll!Menu::LinkStubImplCallSelect(void * instance, void * data) Line 2136
at c:\lo\src\core\vcl\source\window\menu.cxx(2136)
vcllo.dll!Link<void *,void>::Call(void * data) Line 84
at c:\lo\src\core\include\tools\link.hxx(84)
vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1935
at c:\lo\src\core\vcl\source\window\winproc.cxx(1935)
vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2486
at c:\lo\src\core\vcl\source\window\winproc.cxx(2486)
vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 285
at c:\lo\src\core\vcl\inc\salframe.hxx(285)
vclplug_winlo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4068
at c:\lo\src\core\vcl\win\window\salframe.cxx(4068)
vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5721
at c:\lo\src\core\vcl\win\window\salframe.cxx(5721)
vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5828
at c:\lo\src\core\vcl\win\window\salframe.cxx(5828)
user32.dll!UserCallWinProcCheckWow()
user32.dll!CallWindowProcW()
opengl32.dll!wglWndProc()
user32.dll!UserCallWinProcCheckWow()
user32.dll!DispatchMessageWorker()
vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 410
at c:\lo\src\core\vcl\win\app\salinst.cxx(410)
vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 441
at c:\lo\src\core\vcl\win\app\salinst.cxx(441)
vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 512
at c:\lo\src\core\vcl\win\app\salinst.cxx(512)
vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 441
at c:\lo\src\core\vcl\source\app\svapp.cxx(441)
vcllo.dll!Application::Yield() Line 506
at c:\lo\src\core\vcl\source\app\svapp.cxx(506)
vcllo.dll!Application::Execute() Line 422
at c:\lo\src\core\vcl\source\app\svapp.cxx(422)
sofficeapp.dll!desktop::Desktop::Main() Line 1619
at c:\lo\src\core\desktop\source\app\app.cxx(1619)
vcllo.dll!ImplSVMain() Line 199
at c:\lo\src\core\vcl\source\app\svmain.cxx(199)
vcllo.dll!SVMain() Line 234
at c:\lo\src\core\vcl\source\app\svmain.cxx(234)
sofficeapp.dll!soffice_main() Line 169
at c:\lo\src\core\desktop\source\app\sofficemain.cxx(169)
soffice.bin!sal_main() Line 48
at c:\lo\src\core\desktop\source\app\main.c(48)
soffice.bin!main(int argc, char * * argv) Line 47
at c:\lo\src\core\desktop\source\app\main.c(47)
soffice.bin!invoke_main() Line 79
at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(79)
soffice.bin!__scrt_common_main_seh() Line 288
at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(288)
soffice.bin!__scrt_common_main() Line 331
at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(331)
soffice.bin!mainCRTStartup() Line 17
at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp(17)
kernel32.dll!BaseThreadInitThunk()
ntdll.dll!RtlUserThreadStart()
Change-Id: I0518c48e48a50b99a2a1eaf17335e116d63bc587
Reviewed-on: https://gerrit.libreoffice.org/65007
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 12edea426a31f57a9d5b1c65b34fb1336c5534e9)
Reviewed-on: https://gerrit.libreoffice.org/65095
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
and put back original SvTreeListBox a11y factory use
Change-Id: I4ad8ce29d8fed6ec5d44e9a1d641919a89226b79
Reviewed-on: https://gerrit.libreoffice.org/63501
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 47897fdd936d9b6e9ac8cb6110c79352ab080df7)
Reviewed-on: https://gerrit.libreoffice.org/63770
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Iabe571aa8f00492902c499094bea8365a3e17fca
Reviewed-on: https://gerrit.libreoffice.org/63623
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 40710c488de3e4eef585c5a5276c9a0943d36f2e)
Reviewed-on: https://gerrit.libreoffice.org/63769
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: If18c80fc64e55d797953e24e40e5d5e62bd9c625
Reviewed-on: https://gerrit.libreoffice.org/63453
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 492ea7e08571e466e37f870b7642a79df55c2e92)
Reviewed-on: https://gerrit.libreoffice.org/63768
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
most of the removal is ripple effect from removing
SvxIconChoiceCtrl_Impl::EditEntry
which became dead after
commit 630b5db9a10cd49d24d5e563374bd68f1fe670f5
Date: Tue Nov 13 08:40:07 2018 +0200
loplugin:singlevalfields in svtools
Change-Id: Ibfaa7c925cc5549a4858cc62c59d848aab72f460
Reviewed-on: https://gerrit.libreoffice.org/63481
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I954c12d9e1c493be6ac8c7b15076077b5bff5b74
Reviewed-on: https://gerrit.libreoffice.org/62811
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
which seems a bit excessive
Change-Id: If0ab5a33bfbbd399e270f3e140c9d44d843985aa
Reviewed-on: https://gerrit.libreoffice.org/63422
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I8889ce8a7d2309b54454cfe4c6421282e1c6e755
Reviewed-on: https://gerrit.libreoffice.org/63434
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I00333677db711761510a35dfae5ce70d61fb9491
Reviewed-on: https://gerrit.libreoffice.org/63397
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic3f4388ea2ca92d9e97d4a9e066eea07c7de79e5
Reviewed-on: https://gerrit.libreoffice.org/63363
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6bb8a875f18df3cb7054fa65285eb3cafc1648ac
Reviewed-on: https://gerrit.libreoffice.org/63316
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ibb94b2b16afbcca84dd55ae51fde6fd27afede3a
Reviewed-on: https://gerrit.libreoffice.org/63297
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
This changes the condition to only select row if it's not selected yet;
previously, because of the always-true condition or'ed, SelectRow was
always executed.
Change-Id: Id12b640518f3d72810e997735216db336d79f7f6
Reviewed-on: https://gerrit.libreoffice.org/63267
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Iefc820a4c4bb87fe113f97b085d8e89f30ff2db5
Reviewed-on: https://gerrit.libreoffice.org/63261
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
... which is apparently not needed anymore for #i41635. The revert allows
to properly skip "deselect" accessible event when there's no selection
previously.
Also removed the other identical correction, which was added in commit
4883fd31141c3598b25a123033297f847cd18552.
Change-Id: I87c629d679b5c253a3864061074bfde77507fb12
Reviewed-on: https://gerrit.libreoffice.org/63231
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I7340a561e0df0c781fd834388deb4b9f83800f9b
Reviewed-on: https://gerrit.libreoffice.org/63221
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Id2df31daa596a18c79af5fc6ea162deb6e24d5af
Reviewed-on: https://gerrit.libreoffice.org/62958
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I04a146d3d8a428ac1678827dc883525c40240a44
Reviewed-on: https://gerrit.libreoffice.org/62787
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I188d9e9b53e00acfbae3c7acd54de28f084c4b3f
Reviewed-on: https://gerrit.libreoffice.org/62985
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2b9ea77b48673af3575a3142feea5bed84f75d74
Reviewed-on: https://gerrit.libreoffice.org/62950
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: If2c89f0f53615f6200b6cd1fb6267cc9b47df927
Reviewed-on: https://gerrit.libreoffice.org/62884
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Also fix an infinite recursion when VCLXHatchWindow::getTypes() called
VCLXHatchWindow::getTypes() when initializing its static.
Change-Id: I19b8b1e1b367ddf636f905fb141c7690e21f67f8
Reviewed-on: https://gerrit.libreoffice.org/62825
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This sets the FreetypeFont pointer of the FreetypeFontInstances
to nullptr when clearing the cache.
And it changes the interface functions of SalLayoutGlyphs to some
variant different from std::vector.
I don't know if we should prefer the mutable or the const font
instance. With mutable at least one can invalidate the font
instance when checking the IsValid(), so we can get rid of our
referenced font instance.
Change-Id: I6070cfcb3c549dbad3383bd4ec2b05b30645b753
Reviewed-on: https://gerrit.libreoffice.org/62688
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
almost nobody checks it, so rather just assert
Change-Id: Ic3ad4c04c4f6013db3e8757559d3a773df020a1d
Reviewed-on: https://gerrit.libreoffice.org/62684
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|