summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2014-03-05fdo#75260: Correctly draw double lines for both Writer and Calc.Kohei Yoshida
Fix all sorts of incorrect double line handling in drawinglayer in order to draw thick-thin double line types correctly. Also change handling of border lines in writer tables. There are still some outstanding issues but it's much better than how it was before. Also realized that Word and Excel handle simple thin double lines differently; Word varies widths of all of the lines and the gap whereas Excel only has one fixed size for its double line. For this reason I decided to add a separate double line type (DOUBLE_THIN) to handle Excel's double line. (cherry picked from commit 2c62596cf264ef10749d8bfdb2bb2ebef2d98fbc) Conflicts: cui/source/tabpages/border.cxx sc/qa/unit/subsequent_export-test.cxx sc/source/ui/view/tabvwsha.cxx sw/source/core/layout/paintfrm.cxx xmloff/source/style/bordrhdl.cxx Conflicts: cui/source/tabpages/border.cxx sw/source/core/layout/paintfrm.cxx xmloff/source/style/bordrhdl.cxx Change-Id: Iaaa353b6e4f998b524262bea59260b4333e0cdb4
2014-02-12fdo#51180 reset (Multi)Selection on Clear()Lionel Elie Mamane
Change-Id: I06dde63093eab4e5e1c692f6363aca70b89de96a Reviewed-on: https://gerrit.libreoffice.org/7429 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-20fdo#73487: Better pixelization of lines for on-screen rendering.Kohei Yoshida
Conflicts: drawinglayer/source/processor2d/vclpixelprocessor2d.cxx drawinglayer/source/processor2d/vclpixelprocessor2d.hxx Change-Id: I95d087a1f4841bfb7f665bcfebecd4c22c817958
2014-01-17fdo#73487: Overhaul cell borders to make them look sane.Kohei Yoshida
Change-Id: I207db352e017214f61baa947ef8f34662c724087
2014-01-03Make CalcFocusRect look rightStephan Bergmann
...at least for its (only, it appears) uses at the left of the "Insert - Hyperlink" dialog and at the left of a Database window. As aBmpRect and aTextRect never extend aBoundRect (and aTextRect always leaving a gap left and right towards aBoundRect, it appears, with the text abbreviated with an ellipsis if it would be too wide), there should be no need to eventually adjust "the focus rectangle [to] not touch the text," and for calculating the top of the focus rect aBoundRect can be used just as well as aBmpRect. (Though for calculating the bottom, aBoundRect apparently stretches "too far" compareed to aTextRect; whatever... The offsets look somewhat "magic" anyway, but appear to produce the desired visual results.) Change-Id: Ic324561294fb6172c0d02a697fc261717e01c87c Reviewed-on: https://gerrit.libreoffice.org/6165 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 143bb92761f54cb7b8e41e5ac83bd274d4f7079b) Signed-off-by: Eike Rathke <erack@redhat.com>
2014-01-03fdo#72156: GraphicObject: Added missing delete of streamUlrich Kitzinger
Change-Id: I1b84941b0e4b17d5819b1e4af0da9ce3f673710f Signed-off-by: Ulrich Kitzinger <ulkitz@hotmail.de> (cherry picked from commit cc36dfc9bf4f327c359d171d8d05f0ede049164e) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2013-10-18n#812793: clrChange applying for EMFsMuthu Subramanian
Also fixed alpha clrChanges.
2013-10-18Re-set bitmap mask after applying the duotone filter.Muthu Subramanian
2013-10-18n#820077: Import images with duotone filter.Muthu Subramanian
(Modified cherry-pick from: 8b716072410bcfd252739fb953d5ac198e27a895)
2013-10-08WaE [-Wstrict-overflow] assuming signed overflow does not occurEike Rathke
... when assuming that (X - c) <= X is always true ... or that (X + c) < X is always false Change-Id: Ib2313827cd6358ced0141b41cba753896b676e28 (cherry picked from commit ca576e0804324bbb36b697543cbe992e34d4b951) Reviewed-on: https://gerrit.libreoffice.org/6158 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-09-01fdo#68689 Sub-divide ruler ticks into 1/8 insted of 1/10 for inchTomaž Vajngerl
Change-Id: Ied2a6982d5564228b0ce7fecb89723f3742b6d0d Reviewed-on: https://gerrit.libreoffice.org/5726 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-07-29update pchThorsten Behrens
Change-Id: I2509f22be4f853bdf0ba78804a0052864ec7ee94
2013-07-26targetted clean of redundant header piece from 62badf3828Michael Meeks
Change-Id: Ic1240114d667fb7797afae4847427cc889f3cb48 (cherry picked from commit 03993b47c522dcc71f7cd73ee21df3de9650080d)
2013-07-22Resolves: #i122418# Added workaround to not use GetBitmap on windowsNorbert Thiebaud
(cherry picked from commit 136976efb17b8617a83c7f26601cd04031b51e7f) Change-Id: I9c3aeae76c155c9050404f67adeb91106502c3f1 Reviewed-on: https://gerrit.libreoffice.org/5011 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-15i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.Michael Stahl
Add IsUTC member to: com.sun.star.util.DateTime com.sun.star.util.DateTimeRange com.sun.star.util.Time Add new stucts with explicit time zones: com.sun.star.util.DateTimeWithTimezone com.sun.star.util.DateWithTimezone com.sun.star.util.TimeWithTimezone Adapt the sax::Converter to read/write timezones, and fix the unit test. Everything else just uses default (no time zone), this commit is just to fix the API. STRUCT: /UCR/com/sun/star/util/DateTime nFields1 = 7 != nFields2 = 8 Registry2 contains 1 more fields STRUCT: /UCR/com/sun/star/util/DateTimeRange nFields1 = 14 != nFields2 = 15 Registry2 contains 1 more fields STRUCT: /UCR/com/sun/star/util/Time nFields1 = 4 != nFields2 = 5 Registry2 contains 1 more fields Conflicts: sc/source/filter/oox/unitconverter.cxx Reviewed-on: https://gerrit.libreoffice.org/4833 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 652ccbdf3111766fadc379a8cf4650b744e1e19c) i#108348: fix TimeZone -> Timezone in struct names (cherry picked from commit 604aae1fd240254fe851d93dc35b5408bd13296c) Signed-off-by: Michael Stahl <mstahl@redhat.com> Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu> Signed-off-by: Michael Meeks <michael.meeks@suse.com> Conflicts: forms/source/xforms/convert.cxx offapi/type_reference/offapi.rdb reportdesign/source/core/sdr/RptObject.cxx sc/source/filter/oox/unitconverter.cxx
2013-07-15fix fdo#66586 Revert "fdo#46808, create IDL fortree::DefaultTreeDataModel"Noel Power
This reverts commit fcd01fba69db6de6cfc983fae65b6ba6764de0d6. Service DefaultTreeDataModel actually doens't exist ( and we can't find when/where it used to :-( ) The treecontrolpeer.cxx change to use the new service also had the undesired effect of throwing an exception when the UnoTreeControl model is inserted ( previously this failed silently ) The net effect is the dialog control is malformed and not initialised correctly (cherry picked from commit df9f26c22a59ae2309201d2709ea5f8a0ecbf247) also partial revert of f50553593613cbefb7f197fed66498bb6556a39a on DefaultTreeDataModel.idl so the revert above would apply Change-Id: Id76cc12a5360f6435bd39ca86020655feba20c9f Reviewed-on: https://gerrit.libreoffice.org/4865 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-06-14Resolves: fdo#65569 dropdown list missing from built-in fpickerCaolán McNamara
regression since a8c2cb0e6d0b9b301887be176694592f8ecda0c4 the different ctors have different defaults around whether they show the dropdown or not. Change-Id: I3d1bb423c8a25b81ffb26981b63af7498f99e70a (cherry picked from commit 6a4e3194bb16b595885e2814c92ace8911f9a5f3)
2013-06-09Remove remnants of help agentCaolán McNamara
it was removed with 66714f1888eaccef4eb5341971278ae7dfafa16b but gobs of code (and UI) still existed to collect the help id and give it to the missing help agent with various UI visible options and buttons to control the help agent which isn't there Change-Id: I625da27b3046d481e43f4d35d32cc7063a1c6291
2013-05-31prompt to restart office when required for experimental featuresCaolán McNamara
Change-Id: I43051ec6b0efeaebcf4a28940f70913423b8ea9f (cherry picked from commit 7ce2a89f4f8fa84232896766276cb3433ada239c)
2013-05-22UI Controller Factory fixesAriel Constenla-Haile
- "ModuleName" --> "ModuleIdentifier": the IDL definition for css::frame::PopupMenuControllerFactory and css::frame::StatusbarControllerFactory tells to use a property named "ModuleIdentifier", but in the code it is named "ModuleName" - Undocumented css::frame::ToolbarControllerFactory - Fix service name of ToolbarControllerFactory (ToolbarControllerFactory instead of ToolBarControllerFactory) - Convert the three service factories to new style, and use these new-style services in the source code - Implement multiple inheritance: added new css::frame::XUIControllerFactory - Added a (true) base class and implemented the three factories in a single file (cherry picked from commit acc7fed28f54f836b0923180431a0c180f91e98c) Conflicts: framework/inc/pch/precompiled_framework.hxx framework/inc/uielement/toolbarmanager.hxx framework/inc/uifactory/popupmenucontrollerfactory.hxx framework/inc/uifactory/statusbarcontrollerfactory.hxx framework/inc/uifactory/uicontrollerfactory.hxx framework/source/uielement/addonstoolbarmanager.cxx framework/source/uielement/menubarmanager.cxx framework/source/uielement/popupmenucontroller.cxx framework/source/uielement/statusbarmanager.cxx framework/source/uielement/toolbarmanager.cxx framework/source/uifactory/popupmenucontrollerfactory.cxx framework/source/uifactory/statusbarcontrollerfactory.cxx framework/source/uifactory/uicontrollerfactory.cxx framework/source/unotypes/fwk.xml offapi/com/sun/star/frame/PopupMenuControllerFactory.idl offapi/com/sun/star/frame/StatusbarControllerFactory.idl offapi/com/sun/star/frame/makefile.mk svtools/source/uno/toolboxcontroller.cxx Change-Id: Ia8580539badf650a84bc6e57a6b832071e011f0a (cherry picked from commit 8b050d1e91a6623fb2770421e564a74d6259d816)
2013-05-22Related: #i121442# Adapt existing code in other modulesAriel Constenla-Haile
(cherry picked from commit 6c640ee420df6f7c9f3ab981e49ee304f1d2319e) Conflicts: reportdesign/source/ui/misc/statusbarcontroller.cxx sfx2/inc/sfx2/stbitem.hxx svtools/inc/svtools/statusbarcontroller.hxx svtools/source/uno/statusbarcontroller.cxx Change-Id: If03a201214a4afe09efa4e3e996aded9b6a57bdf (cherry picked from commit 25ec90bfa85ab829e47f442742c63dd41960b973)
2013-05-20vcl: all EnableAutoSize methods take a bool.Michael Meeks
Change-Id: I6f974d6b82f6bb77996d20219b5c0ceb78596c5c
2013-05-20add experimental option for sidebar to 'Advanced' pane.Michael Meeks
2013-05-20Related: #ii122198# added ColorValueSetColumnCount entry to configurationArmin Le Grand
default is 12 (cherry picked from commit dc9abefa2d01377b14bef15463e360d9a7e9bdc2) Conflicts: officecfg/registry/schema/org/openoffice/Office/Common.xcs svtools/inc/svtools/accessibilityoptions.hxx svtools/source/inc/configitems/accessibilityoptions_const.hxx Change-Id: Ic035b34bbcde426fa8fb76df16f84786908e18fa
2013-05-20Related: #i122041# More unifications for FillStylesArmin Le Grand
better defaults and better preview visualizations (cherry picked from commit 35c9acfc98fc98399005815e0464b1944f327d4e) Conflicts: officecfg/registry/schema/org/openoffice/Office/Common.xcs svtools/inc/svtools/accessibilityoptions.hxx svtools/inc/svtools/valueset.hxx svtools/source/config/accessibilityoptions.cxx svtools/source/control/ctrlbox.cxx svtools/source/control/valueset.cxx svtools/source/inc/configitems/accessibilityoptions_const.hxx svx/inc/svx/dlgctrl.hxx svx/inc/svx/xtable.hxx svx/source/dialog/dlgctrl.cxx svx/source/tbxctrls/SvxColorValueSet.cxx svx/source/xoutdev/xtabdash.cxx svx/source/xoutdev/xtable.cxx vcl/inc/ilstbox.hxx vcl/inc/vcl/combobox.hxx vcl/inc/vcl/lstbox.hxx vcl/inc/vcl/settings.hxx vcl/source/app/settings.cxx vcl/source/control/combobox.cxx vcl/source/control/ilstbox.cxx vcl/source/control/lstbox.cxx Change-Id: I905b6814cb796a35aa23fedb9ce716f77e2bfda0
2013-05-20Resolves: #i122041# Unified and centralized control for Color ValueSetsArmin Le Grand
(cherry picked from commit 68e707bbc6fe23881b822e6efab8a2933343dc1a) Conflicts: cui/source/inc/backgrnd.hxx cui/source/inc/cuitabarea.hxx cui/source/tabpages/backgrnd.cxx cui/source/tabpages/tpcolor.cxx sd/source/ui/view/drviews6.cxx svx/Package_inc.mk svx/inc/svx/colrctrl.hxx svx/source/sidebar/tools/ColorControl.cxx svx/source/tbxctrls/colorwindow.hxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx Change-Id: Ie06fe355846b737ec8aae9aade4d408232c83193 Related: #i122041# Add a11y values for defining behaviour of ColorValueSets (cherry picked from commit 401e8f2db607081e62eaaa1f08a8cd8971a3f637) Conflicts: cui/source/tabpages/backgrnd.cxx officecfg/registry/schema/org/openoffice/Office/Common.xcs sc/source/ui/miscdlgs/tabbgcolordlg.cxx svtools/inc/svtools/accessibilityoptions.hxx svtools/source/inc/configitems/accessibilityoptions_const.hxx vcl/inc/vcl/bitmap.hxx vcl/source/gdi/bitmap4.cxx Change-Id: If9d0db5f22974cad1ac886eca3719ca92ca7f240
2013-05-16resolved fdo#56772 keep track of HTML ON/OFF tokensEike Rathke
Regression introduced with 11cbcb8b08b540b144a5df744e9fba0b6ba8144a followed by 56d6589368c2e88cffec0c2e518f7c90863eeae6 Deep from svtools/source/svhtml/parhtml.cxx HTMLParser::_GetNextToken() only a HTML_TABLEDATA_OFF was generated for <td .../> without a matching HTML_TABLEDATA_ON (actually same for all <XXX/> ON/OFF tokens). This confuses a state machine that doesn't keep track of such unexpected closures and also expects all attributes of an element at an ON token. Only the parser knows this is actually one token but needs to generate separate ON/OFF tokens. These bugs mentioned in the original code and commits are still fixed with this change: https://bugs.freedesktop.org/show_bug.cgi?id=34666 https://bugs.freedesktop.org/show_bug.cgi?id=36080 https://bugs.freedesktop.org/show_bug.cgi?id=36390 Change-Id: I2b3190d297a35ee3dfda95f9a4841f7c53ed4a92
2013-05-15Spelling "separate" (etc) correctly is hardTor Lillqvist
2013-05-15svtools FormattedField: don't reparse value from text after ReFormatLionel Elie Mamane
If our format is lossy / not a bijection (as is e.g. our default date format, because of 2-digit year), then reparsing the string that came from the format leads to data loss (the value is changed to something else). The existing code tried to do that, by calling Modify() and then setting m_bValueDirty to false. However, this fails because listeners are called while m_bValueDirty is true. If any of them calls e.g. GetValue(), the reparse happens. Change-Id: I272f377927f83c71ede1eb80eafbc689f36fb17a
2013-05-14Remove obsolete RestrictedPath env var supportStephan Bergmann
Change-Id: Ia4ea7d60d7b69c863c1e891887060265e73e1cb6
2013-05-13added Udmurt [udm-RU] to language listAndras Timar
Change-Id: Ief2413fda7ecbf4cc73bc0d2bf483f9a6c16cca8
2013-05-11added N'ko [nqo-GN] to language list, fdo#64331Eike Rathke
RTL and CTL Change-Id: Ifdce9e3e08a715dcf493c4103479c5fd64a42d74
2013-05-09make conversions between BitmapColor and sal_uInt8 explicitHerbert Dürr
Implicit conversions are a dangerous cause of confusion as seen in http://markmail.org/thread/a4copx2di7cxeowg and require tricky rewrites to work around them, this change cleans them up and disables them. (cherry picked from commit 2d9d5c8d6beb7fb0a7dafa0c1c4d10a25d7200fd) Conflicts: filter/source/graphicfilter/egif/egif.cxx filter/source/graphicfilter/epbm/epbm.cxx filter/source/graphicfilter/epgm/epgm.cxx filter/source/graphicfilter/ipbm/ipbm.cxx filter/source/graphicfilter/ipsd/ipsd.cxx sd/source/ui/slidesorter/view/SlsButtonBar.cxx svtools/source/filter/igif/gifread.cxx svtools/source/filter/jpeg/jpeg.cxx svtools/source/filter/wmf/winwmf.cxx svtools/source/graphic/grfmgr2.cxx vcl/inc/vcl/bmpacc.hxx vcl/inc/vcl/salbtype.hxx vcl/source/gdi/bitmap.cxx vcl/source/gdi/bitmap3.cxx vcl/source/gdi/outdev2.cxx Change-Id: I1d163c66782c2750aeee00725dbb2b614507c0d4 (cherry picked from commit ff80c37b18b941712fb967a0c1d48813b47c0583)
2013-05-09fdo#63154: Remove _CL and _LF from solar.hMarcos Paulo de Souza
And use RTL_CHAR_{CR,LF} from rtl/string.h Conflicts: vcl/source/app/dbggui.cxx Change-Id: I05b0325006845e48eb5483485a9042aa7b0cd22a Reviewed-on: https://gerrit.libreoffice.org/3740 Reviewed-by: Andras Timar <atimar@suse.com> Tested-by: Andras Timar <atimar@suse.com>
2013-05-08cppcheck: variables reassigned before using old valueJulien Nabet
Change-Id: I5108253859eac682ab423843f8812c8c8c6ce9fa
2013-05-07officecfg: remove Package_cppheaderMichael Stahl
Instead include generated headers directly from workdir. Change-Id: I9d2bcc07175d2bbc16d3cc548c2245e7a4fb0c65
2013-05-06remove usage of RTL_CONSTASCII_USTRINGPARAMLuboš Luňák
Mechanical removal of usage together with OUString ctor, done by compiler plugin. Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-02Resolves: #i117461# set row count to 0 and add further checkJürgen Schmidt
Patch By: Tsutomu Uchino Review By: jsc (cherry picked from commit d56225de586f878acd2f953bcf3208fe9a3c79a3) Change-Id: I91ea7add253a5c40272ee112d207fcf510cd3935
2013-04-30Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks
2013-04-27some eco-activismThomas Arnhold
Change-Id: Ib447cd8633c3102ee78c919cfbeabcc88018b130
2013-04-27Bin ugly (ab)use of preprocessor in headersTor Lillqvist
The time when it made sense to use "clever" #ifdefs to, for performance or compiler reasons, conditionally bypass private parts of a class declaration passed a decade or longer ago. Still more of this in sw and sc. People working on those modules might want to do it too, or not. Change-Id: I1053139ca5e5e2631f7b22d99d3bada54fc337be Reviewed-on: https://gerrit.libreoffice.org/3627 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-26EmbeddedObjectRef: guard against div by zeroMiklos Vajna
With this, if dc92bac5df72ecca123472a5e945b1864a17f457 fails, it won't crash, just the assertion will fail. Change-Id: I9830094088819cade7cf47d1f25d34bb6eb52ae6
2013-04-25fix scrolling performance of listboxes with hundreds of entriesCaolán McNamara
make it approximately infinitely faster a) add a method AdjustEntryHeightAndRecalc that just does AdjustEntryHeight and RecalcViewData and replace all the places that do the two of those together with that utility b) in our SetFont now only call AdjustEntryHeightAndRecalc if the new font is different to the old font, ignoring color which doesn't have a bearing on row size. c) where we originally called SetFont(GetFont()), which would have triggered AdjustEntryHeightAndRecalc, now call the new AdjustEntryHeightAndRecalc explicitly. The performance problem apparently a regression from ac7acb0ab1329913b0cec79790adcde0263960be where we seem to now end up drawing on ourself and calling SetFont on ourself rather than on a pImpl without an overridden SetFont. So when we redraw on scrolling we triggered a cascade of calculations and force text layout of every row. Change-Id: I3c284c360f06ac383e8c38045fc4c2946f505b35
2013-04-25PCH quickfixStephan Bergmann
Change-Id: I457288d881ba74db2127e8543b0de70b6498002d
2013-04-25fdo#62088: Fix regression introduced by the DateTime incompatible change.Jan Holesovsky
It is not good to mess with the stream operators, more so when the size of the data changes ;-) Change-Id: Id02b83224496a28575f4e12196892de198793983
2013-04-25update pchThomas Arnhold
Change-Id: I67e73438312f2a672e71762ee6707ec5d425bb47
2013-04-24add border width to optimal size when presentCaolán McNamara
Change-Id: I37c396c3c61521e140d290fd8f17220f60c43284
2013-04-24Don't point to inc directories that don't exist any longerTor Lillqvist
Change-Id: If783897a60a545baf3968c5eeccf80a1e186bc51
2013-04-24gbuild: drop empty use_packages callsDavid Tardon
Change-Id: I8e9f70eb5d929c98b4379416c2259a74e31d587f Reviewed-on: https://gerrit.libreoffice.org/3503 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24gbuild: drop uses of removed packagesDavid Tardon
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac Reviewed-on: https://gerrit.libreoffice.org/3502 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>