summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2015-02-10Use "!=" instead of "<" to compare current it with end itJulien Nabet
Change-Id: Ic2ed4b935ecf1d63065bc5147e62d510e73bd5c5
2015-02-09svtool/GraphicManager: properly decrease mnUsedSize on unregister opsPierre-Eric Pelloux-Prayer
mnUsedSize was never decreased causing the cache to pretending to be full, which caused lots of needless work (image loading, id creation (which are basically a crc of all bytes of an image, ...)) Change-Id: I1e0a6a07631435346c3509822fae43a067d33303 Reviewed-on: https://gerrit.libreoffice.org/14389 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Zolnai Tamás <zolnaitamas2000@gmail.com> Tested-by: Zolnai Tamás <zolnaitamas2000@gmail.com>
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: Ia503ee8012ca9a2a6128c657961176968073f37f
2015-02-07tdf#88836: UI: in-form navigation bar icons goneZolnai Tamás
Regression from: 6419c745e5e9802da264250d5e131fb9a3b6e4de Revert it and use IsEmpty() instead of operator!(). Change-Id: Icc4f5dbba848a1d4ef807e598f0aa3b940459c82
2015-02-06shared_ptr<T>(new T(args)) -> make_shared<T>(args)Caolán McNamara
and boost:make_shared->std::make_shared Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d
2015-02-05convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara
and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-02-05Updated all precompiled headers.Ashod Nakashian
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-03Avoid downcastStephan Bergmann
Change-Id: I0170c1ecd7f6f037640eaa26f5477fdf4852c54f
2015-02-02coverity#1266460 Argument cannot be negativeCaolán McNamara
Change-Id: I715b27b507926e2670cc094d4ebaa429e502232c
2015-02-01coverity#1267678 this is surely backwards (gold)Caolán McNamara
surely we clone from the source and return the newly created entry. Presumably this doesn't break all the time because aCloneLink is generally set ? coverity#1267678 Resource leak Change-Id: I3e02dfaef371e006f1510b186cdd881c991ef2cf
2015-01-30coverity#1267679 Dereference before null checkCaolán McNamara
Change-Id: Ic3487f204a0a3f826cf6a2441b5c410a8fc1b0b6
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-27UBSan-detected overflow when nWidthPixel is LONG_MAX and rCurrentZoom is 1Stephan Bergmann
...from the call to SetColumnWidth( nId, LONG_MAX ); in BrowseBox::AutoSizeLastColumn(), e.g. happens when opening the Gallery in Draw. Change-Id: I151ae557d9d2bec52ecb0bd92b870fb0b91d7242
2015-01-26Make sure _nEventId gets reset after calling RemoveUserEventStephan Bergmann
Change-Id: I8f90fb809d5275e8a74964776f01f4d563f2e657
2015-01-26coverity#1266460 Argument cannot be negativeCaolán McNamara
and coverity#1266463 Argument cannot be negative coverity#1266466 Argument cannot be negative Change-Id: I4e910fa189be3b6cb8e9a6163a0d24dfcc1ef7d8
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-25fdo#84592 Improve SvTreeListBox class with alternating rows.Palenik Mihály
It is possible to set alternating rows. Expert Configuration dialog use it. This bug was fixed earlier, but after this feature didn't work. Change-Id: I3602a6b03db32d6f43ec163de2427f4a018c7779 Reviewed-on: https://gerrit.libreoffice.org/14164 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-01-25coverity#440858 Argument cannot be negativeCaolán McNamara
Change-Id: Ia2725c54ef5850e5c66a79fbe54956769582b013
2015-01-22Revert "fdo#88475 BrowseBox/grid: reposition data cursor to current row ↵Lionel Elie Mamane
after paint" (and its later fixup) This reverts commits e8a68c1f50f32a0f9d8bcdf16c1270c319910baa e60b589952985edff12b1a28392ce6fa0ca8d9be It was a work-around for the real underlying issue, which was that the result of dbaccess::ResultSet::isFirst() et al were clobbered by moves made by its clones. The BrowseBox has two different cursors: 1) One for data to edit (which is kept on the current/active row) 2) One for data to *paint* The second is a clone of the first. The real underlying issue is fixed by: commit d7c9a1d9d65fe8b1a56c5c280d2ca6640a549d2f Author: Lionel Elie Mamane <lionel@mamane.lu> Date: Thu Jan 22 10:49:42 2015 +0100 fdo#88475 RowSetBase: reposition cache before interrogating it Change-Id: I28d62673fdf10ee6507d38bb7c79c08e4b40902f
2015-01-20Some more loplugin:cstylecast: svtoolsStephan Bergmann
Change-Id: I8d8b48b297fa3ce0bb9a81dd396cbdb253b84a80
2015-01-19fixup previous commit:Lionel Elie Mamane
OSL_ENSURE does not execute in non-debug builds (and is deprecated). Do not try to seek back if paint did not seek. This happens in particular when there is no data source attached (and thus trying to seek fails). Change-Id: I3f4908c4dcae2bb120bf58c1218e3386c40d5721
2015-01-19Ruler ticks spacing consistent with lowDPI monitors. Draw ticks with widthdbeurle
Change-Id: Id636fa87ac7fd4a8c33d65bd72822768bc94b592 Reviewed-on: https://gerrit.libreoffice.org/13987 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2015-01-16fdo#88475 BrowseBox/grid: reposition data cursor to current row after paintLionel Elie Mamane
Change-Id: I0deee2c3cfdb111b178c4254d7b0544c4ce5c966
2015-01-16remove unnecessary parenthesesNoel Grandin
left over from "SVStream operator>> to Write method" conversion Change-Id: I619eb743d7890d5c70d0a94e51ce263567fa6f3b
2015-01-14do TODO: replace ImplCallEventListeners() by CallEventListeners() in vclCaolán McNamara
Change-Id: If47baad0ec31f18fcb55c7db86fb2a316dd0807f
2015-01-14GetData is a hopelessly generic nameCaolán McNamara
when you want to find the uses of it Change-Id: I580c194f0fd200505d3df99089afc0872921a67b
2015-01-14HiDPI changes to ruler to respect screen DPIdbeurle
Change-Id: I4cbb303b395ad60d4935bff55fbaea08f13334a0 Reviewed-on: https://gerrit.libreoffice.org/13867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-13eliminate unnecessary macroEike Rathke
Change-Id: I0dceccbe1275298b43f50296da075ae95694d39a
2015-01-13simplify Date/Time/DateTime conversion codeNoel Grandin
add constructors to Date/DateTime/Time, that take the css::util counterparts, to simplify code converting between these type Change-Id: I4b03da02c63f65b6ec18cb4d6ecc3859bdef1ff7 Reviewed-on: https://gerrit.libreoffice.org/13855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2015-01-12convert SETTINGS_ #defines to 'enum class'Noel Grandin
and dump the ones that nothing is listening to Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
2015-01-12fdo#84938: replace DATACHANGED_ constants with 'enum class'Noel Grandin
and drop DATACHANGED_DATETIME because no-one is using it Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-12fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I46b9293eed0cba2ebca119cc1fb0a6334ea66308 Reviewed-on: https://gerrit.libreoffice.org/13844 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-09fdo#84938: convert POLY_OPTIMIZE_ #defines to 'enum class'Noel Grandin
Change-Id: I163bd3f521473c5357c23c3ce4978f984be7b6fe
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-07fdo#84938: convert COMPRESSMODE_ #defines to 'enum class'Noel Grandin
Change-Id: Ica501fc73e7e5f9dbd30dd9da3f337b2dc7e6f02
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07fdo#84938: convert VCL_INPUT_ #defines to 'enum class'Noel Grandin
Change-Id: I155e45f58974a2b946c4a7703b350bcbfbad342e
2015-01-06fdo#84938: convert CTRL_STATE_ #defines to 'enum class'Noel Grandin
Change-Id: I1451180d258315a310a048b27510b4b58fa9145c
2015-01-05Some loplugin:revisibility clean-upStephan Bergmann
Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2015-01-05fdo#84938: replace NUMBERFORMAT_INT_ constants with 'enum class'Noel Grandin
Change-Id: I9c67de31f5571b282adc132d973b79bccb35fdc9
2015-01-04A bit of cleanup.Jan Holesovsky
Change-Id: Ia7c5cf07dba7f65ee65dab67a0a32975c8026dce
2015-01-02Fix simple typos.Andrea Gelmini
Change-Id: I1fdbe47ed7a6e05d2cf20f4c296bffad4bbc6599 Reviewed-on: https://gerrit.libreoffice.org/13719 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02Remove unnecessary comphelper::string::getTokenStephan Bergmann
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
2014-12-28Rework TabBar D&D tab move triangles and make them HiDPI awareTomaž Vajngerl
Change-Id: Ia4165880b0b08b5ca26fe7004f961cd17b3d3e27
2014-12-28HiDPI: TabBar resizer changes size depending on DPI scale factorTomaž Vajngerl
Change-Id: I36a6d22f87b0d96cdbdadd683cd3abeb12e28c77
2014-12-27Cleanup and simplify TabDrawer & remove maPolyTomaž Vajngerl
Change-Id: Ib11a610bafcc54516b873304f778ee92603d5c31
2014-12-25fdo#87596 Draw tab fill color when selected on the tab bottomTomaž Vajngerl
Change-Id: I02bcdf88063d272cb9eb9e89cbee61d30f4f01d6
2014-12-24callcatcher: update unusedcodeCaolán McNamara
Change-Id: I0b75dabfcb4a53dbbe361a34a6d9661a5b4aedd2