summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert SelectionMode to scoped enumNoel Grandin
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27Convert GRAPHIC to scoped enumNoel Grandin
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea Reviewed-on: https://gerrit.libreoffice.org/25534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26Resolves: tdf#96279 set correct parents for password dialogsCaolán McNamara
otherwise on Dialog::Execute before it becomes visible and a password dialog is needed the new dialog will automatically look for a parent, but will be parented by the main window because the dialog it should be a parent of is not visible yet. Change-Id: Ia34e43d7ef2b204b348f2eb5aab542ee8ffe840e
2016-05-26tdf#89329: use unique_ptr for pImpl in transferXisco Fauli
Change-Id: Ia28a7bd63c8f3a06ef2fd508619bae3a31af450c Reviewed-on: https://gerrit.libreoffice.org/25479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26loplugin:unusedmethodsNoel Grandin
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda Reviewed-on: https://gerrit.libreoffice.org/25431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in addresstemplateXisco Fauli
Change-Id: I3e2cac86101e8a82eefacbe937cf40139fa77090 Reviewed-on: https://gerrit.libreoffice.org/25473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in hyperlabelXisco Fauli
Change-Id: I697eb48591c53ba27c99fc86baa4b8b33e7c9fd1 Reviewed-on: https://gerrit.libreoffice.org/25474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in roadmapwizardXisco Fauli
Change-Id: I37c24d830ae702579fe14ecba627d7f1d363eef6 Reviewed-on: https://gerrit.libreoffice.org/25475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in svlbitmXisco Fauli
Change-Id: If047546c953a5f3bf7af3f99fb7f9d604e0bdba8 Reviewed-on: https://gerrit.libreoffice.org/25476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in svtabbxXisco Fauli
Change-Id: I40a826f6430532769590e6c34d8a98997127fc2e Reviewed-on: https://gerrit.libreoffice.org/25477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in treelistboxXisco Fauli
Change-Id: I5ba1638c905893f62d6d24d7c88cbb66aaa7c786 Reviewed-on: https://gerrit.libreoffice.org/25480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in wizardmachineXisco Fauli
Change-Id: Ie29a95fb913a7141ad6789db236f12c73c283a58 Reviewed-on: https://gerrit.libreoffice.org/25481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in fileviewXisco Fauli
Change-Id: Ief2fd163cc024b4a654a32c24cef832c68ad5e96 Reviewed-on: https://gerrit.libreoffice.org/25482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in inettbcXisco Fauli
Change-Id: I1205acb2823db95cc75c0b559581d278646b616a Reviewed-on: https://gerrit.libreoffice.org/25484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in htmlcfgXisco Fauli
Change-Id: Ic85c082f1e6f6934efbe2c0aa73ee4e5d48c58bf Reviewed-on: https://gerrit.libreoffice.org/25483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in ivctrlXisco Fauli
Change-Id: Idd525be5934e752c3bed5e2d79c36c2305b4441f Reviewed-on: https://gerrit.libreoffice.org/25485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26Convert MtfConversion to scoped enumNoel Grandin
Change-Id: I694fe139531a10467265b028ad15df0eda6d723a Reviewed-on: https://gerrit.libreoffice.org/25442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25vcl: replace boost::dynamic_bitset with boost::optional<std::bitset>Michael Stahl
The getTTCoverage either leaves the bitset empty or inits it with 128 bits, so it's not particularly dynamic. Change-Id: Iac0aa6a023acc54da86d681e75ca550faf91ef26 Reviewed-on: https://gerrit.libreoffice.org/25456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-25Convert BMP_FORMAT to scoped enumNoel Grandin
Change-Id: I751ab762b6e6f961e9e73a8a2ca92a3f5a5eb1c8 Reviewed-on: https://gerrit.libreoffice.org/25189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25Convert AUTOCOMPLETE to scoped enumNoel Grandin
Change-Id: I201c8f8b41855b2777f0e7131aeaf33cafb82804 Reviewed-on: https://gerrit.libreoffice.org/25438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Convert SnapType to scoped enumNoel Grandin
Change-Id: I3980c2999bab191bb9357c883868db17db79e81f Reviewed-on: https://gerrit.libreoffice.org/25353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24too much debug spew, SAL_INFO thisCaolán McNamara
Change-Id: Ia4e69fa0ffad14564d021b86fdbb0d3d3b8c71b8
2016-05-24Revert "remove some manual ref-counting"Noel Grandin
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24ruler: close the polygon when drawing indent handle (gtk3, gl)Tomaž Vajngerl
Change-Id: I9d1d20f889f73c73a1b861485a956a25f743e245
2016-05-23resort restart reasonsCaolán McNamara
Change-Id: Ie7b57e7f3266f0f1c3576e82de3c949760c2916d Reviewed-on: https://gerrit.libreoffice.org/25358 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-23tdf#99211 Use the restart dialog for notifications about restartirem
Change-Id: I97a10cddafc464ccbdd37902c5d24b73246f5c3f Reviewed-on: https://gerrit.libreoffice.org/24877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-22Convert DragMode to scoped enumNoel Grandin
Change-Id: I68dafefc74bad355047738605defd97f3c6bebcd Reviewed-on: https://gerrit.libreoffice.org/25209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19loplugin:unusedmethods in slideshow to svtoolsNoel Grandin
Change-Id: Icf0056e13c88d7d347e668adaeddd4ed72af85cf Reviewed-on: https://gerrit.libreoffice.org/25141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy clang-analyzer-alpha.core.IdenticalExprNoel Grandin
Change-Id: I110d8d63d5a6657c18aba97227c046027eb8f7f4 Reviewed-on: https://gerrit.libreoffice.org/25086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19loplugin:unusedmethods in toolsNoel Grandin
Change-Id: I26a4ce6e849615d6d24632650ca03c40ab16502e Reviewed-on: https://gerrit.libreoffice.org/25089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18tdf#95954: Reasonable background for roadmap widgetKatarina Behrens
also move setting control font/text style to ApplySettings func Change-Id: Iec71ebb42424e0d29fb5c5e155773b61bfcf2313 Reviewed-on: https://gerrit.libreoffice.org/25054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-16convert IconChoice flags to scoped enumNoel Grandin
and removed unused entries Change-Id: Ibe7ebb7723d9418893a2e2768e2a84eb16d1a046 Reviewed-on: https://gerrit.libreoffice.org/24970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16convert SvImpLBox flags to scoped enumNoel Grandin
and remove the dead ones Change-Id: Iac72c4a4e16290936a9965afb8c637d181bccb2d Reviewed-on: https://gerrit.libreoffice.org/24965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Give unique, comprehensible names to idles tdf#97087Muhammet Kara
Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-13convert SHOWTRACK to scoped enumNoel Grandin
Change-Id: Ibf06f6c79f80d7265ae3239c1ea0088118e92e21 Reviewed-on: https://gerrit.libreoffice.org/24894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13Typo: ExcecuteContextMenuAction->ExecuteContextMenuActionJulien Nabet
Change-Id: Ifb121344a8f235d71bab33c03808e3f44d7bee7c Reviewed-on: https://gerrit.libreoffice.org/24942 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-12use unique_ptrDavid Tardon
Change-Id: I49f08a066f3a5f6f3479060d8a528a7cfdfdc02c
2016-05-12avoid crash when using the New Slide toolbar popup in ImpressDavid Tardon
Change-Id: I5aeb77fa8764179699d884647e8734d413752130
2016-05-12do not try to use obj. that is already being disposedDavid Tardon
Change-Id: Ibb25e5bfc3e161be9fdac124b5a107a6d180bf1e
2016-05-12Convert RulerType to scoped enumNoel Grandin
Change-Id: I2233b70e5413bfa3156011e1b3306d539003795b Reviewed-on: https://gerrit.libreoffice.org/24879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert RulerExtra to scoped enumNoel Grandin
Change-Id: I81f5380e27a741ab6049bcec6b4136d8f2d1169a Reviewed-on: https://gerrit.libreoffice.org/24878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert RULER_MARGIN to scoped enumNoel Grandin
Change-Id: Ia8711614fdb9090faeebfe294cbb064ded20b5fb Reviewed-on: https://gerrit.libreoffice.org/24874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert RULER_BORDER to scoped enumNoel Grandin
Change-Id: Ia8dcffe817e6f7a5f8470ce08c25103c527d221d Reviewed-on: https://gerrit.libreoffice.org/24854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert RULER_DRAGSIZE to scoped enumNoel Grandin
Change-Id: Iddf7562273072eb4d5d60efc730d5c40bfc79f46 Reviewed-on: https://gerrit.libreoffice.org/24852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11convert RULER_INDENT to scoped enumNoel Grandin
Also separate out the INVISIBLE flag into it's own bit, because the constant is shared with other fields. Also fix some dubious code in SVX that was setting stuff on the field that meant nothing. Change-Id: If460be575eee38b8e9f01af4d73f93f6426c604f Reviewed-on: https://gerrit.libreoffice.org/24853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>