summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2016-12-12coverity#1371265 Missing move assignment operatorCaolán McNamara
Change-Id: I5b7c6992e92e4d096b8230774ed8f4bfaaad5831
2016-12-12coverity#1397046 Unchecked return valueCaolán McNamara
Change-Id: I7f8988a7cf5f3d815a20cac249b3753d732994e1
2016-12-12coverity#1397056 Dereference null return valueCaolán McNamara
Change-Id: Ieda3afdbdbcc8aa21f6584edc21738c4edb84000
2016-12-11OSL_TRACE -> SAL in sfx2..svxNoel Grandin
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e Reviewed-on: https://gerrit.libreoffice.org/31799 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-09tdf#104495: prevent autotext to crash when drag&dropJulien Nabet
See bt https://bugs.documentfoundation.org/attachment.cgi?id=129407 For non regression, I retested tdf#91125 since the delete comes from https://cgit.freedesktop.org/libreoffice/core/commit/?id=06ecf7d2aebe64226142ee27c2512351960f8bb1 Change-Id: I7ce833ffce20f1f159242014ba8ffe0ce5b7b11c Reviewed-on: https://gerrit.libreoffice.org/31773 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-12-08convert OSL_ENSURE to assert in AccessibleEventNotifierNoel Grandin
and fix the places that trigger it Change-Id: I97a04cff25ab5aa1d42c79a971d15ba742bf384e Reviewed-on: https://gerrit.libreoffice.org/31760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08convert SFX_HINT to scoped enumNoel Grandin
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08ImplWallpaper to use std::unique_ptrMark Page
Also remove ImplWallpaper::operator==, that does not make sense since members are unique Change-Id: I69d32d91ba33691eb1f86e70ce3c53fa2761e34b Reviewed-on: https://gerrit.libreoffice.org/31666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-05convert FSysStyle to o3tl::typed_flagsNoel Grandin
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-04Remove write-only fieldUlrich Gemkow
Change-Id: I45502d73939e99cd3d72c9d8aaa17dc820e78207 Reviewed-on: https://gerrit.libreoffice.org/31590 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-02loplugin:unnecessaryoverride (dtors) in svtoolsStephan Bergmann
Change-Id: I5b0f4b335cd383702324ff6ea04581476309ca70
2016-11-29Use derived classes' methods instead of Pair::A/BMike Kaganski
Change-Id: I7ffd9a23dbd00672630bc8412e95525a920c5065 Reviewed-on: https://gerrit.libreoffice.org/31379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-11-29Rewrite some (trivial) assignments inside if/while conditions: svtoolsStephan Bergmann
Change-Id: If7843583924d2ecebe65aef1843e510fa974d877
2016-11-29Drop a bunch of font metrics flagsKhaled Hosny
These flags mean nothing these days, there are either always true or always false, since we no longer support bitmap or Type 1 fonts. Change-Id: Ie14ca480225a6346d868a44e58e7666c3a06931d Reviewed-on: https://gerrit.libreoffice.org/31346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-11-29Use Size::Width/Height instead of inherited Pair::A/BStephan Bergmann
Change-Id: Ie0346d5ec054fbe7eff1d4b73814a5e2b9f654c2
2016-11-29loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-28tdf#104215: Remove the out-of-borders ruler checkMike Kaganski
It is not called for out-of-borders points anyway, unless there is a table border on page border, in which case the cursor shows that dragging should be possible. Change-Id: If5cecbcd0799c74012c525588c0d2fce5d79ffd6 Reviewed-on: https://gerrit.libreoffice.org/31309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-25convert HTMLCFG constants to o3tl::typed_flagsNoel Grandin
Change-Id: I0859fdc3e737ab0714e994f1326123e93e93affb
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-24use o3tl::typed_flags in ConfigurationListener::ConfigurationChangedNoel Grandin
Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e
2016-11-21add missing deps on ui filesDavid Tardon
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-18tdf#103960: The import of UCS2 data uses a different code path.Jan Holesovsky
The commit b297f7bbfed83f87398231740e910afe6ebfbb97 was too eager from this point of view, we shouldn't use SetSrcEncoding for UCS2 because in that case we end up with RTL_TEXTENCODING_DONTKNOW in eSrcEnc. Change-Id: Id8bcb08aee17c8258c074b481345a2795939edc0
2016-11-17Fix tdf#103855 add language codes and names to language lists from extensionsMartin Hosken
Rationale for changes to languagetag.hxx can be found in the bug tdf#103855. Change-Id: I7fa7c8a3f7b219ce08df69a3965f544ae156beab Reviewed-on: https://gerrit.libreoffice.org/30882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-17loplugin:unusedfieldsNoel Grandin
Change-Id: Id2dbbf384637223db3d334d95332251832918003 Reviewed-on: https://gerrit.libreoffice.org/30927 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: I367c2096b3c0d508bca1e207c78c2f955f51e263 Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30921 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15Fix typosSamuel Mehrbrodt
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15tdf#88827 - double-thin border: MINGAPWIDTH is a valid widthJustin Luth
double-thin borders are available in the UI starting from 0.5pt. The actual minumum (as seen in a round-trip), is 1.10pt. (Each thin line is ~ .50pt, the gap is ~ .05pt, and then some approximations and rounding show it as 1.10 - at least that is how I understood it). 1.15pt is the first point at which the gap is larger than the minimum - and double_thins with a minimum gap were considered invalid, and thus were not imported. With this fix, double-thin borders created with a size less than 1.15pt are valid and visible on import. Change-Id: I6da2a40d13ed83281de403b22b3acbea4288ac60 Reviewed-on: https://gerrit.libreoffice.org/30857 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2016-11-11use std::unique_ptrCaolán McNamara
Change-Id: I68e3e498fa4abeca66501897fe5975b44611259c
2016-11-11coverity#1371312 Missing move assignment operatorCaolán McNamara
Change-Id: I4484f270e33e479c954c8421a46d52f3d81ec4dc
2016-11-11use std::unique_ptrCaolán McNamara
Change-Id: I5efcfe9ae2d94b34150127917c07dc920fd0e71a
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-07Revert "Reverts a commit series that cripple windows ci."Caolán McNamara
with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-07loplugin:unnecessaryvirtual in sfx2..svtoolsNoel Grandin
Change-Id: Ib34e14806f7cc9a97ecfd68687ab17ee5c1f022b Reviewed-on: https://gerrit.libreoffice.org/30652 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-06NewMenuController: Remove duplicate async dispatch handlingMaxim Monastirsky
Change-Id: I881e6781c5ba82b0b998891532f8b7c281567b73
2016-11-05Reverts a commit series that cripple windows ci.Norbert Thiebaud
Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
2016-11-04move ColorListBox beside sole thing that uses itCaolán McNamara
Change-Id: Ia458ded8881c415badd5d75bddad0daca57a1a25
2016-11-04unify color selectorsCaolán McNamara
Note: this removes the use of auto-color from writer's asian text grid, because its always invisible as far as I can see in practice. Change-Id: Ie850790d740a4d56c43015e493e093678cef3b4e
2016-11-04loplugin:unusedmethodsNoel Grandin
Change-Id: Ie1f840c3ec9a2d5888f95cf05e531a8a9464bf2e Reviewed-on: https://gerrit.libreoffice.org/30524 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03tdf#88821: Implement support for <meta charset="..."> for HTML import.Jan Holesovsky
The editengine HTML import was not handling it at all, and consequently not setting the right encoding when importing HTML in Calc. Change-Id: I3ca3dd20f36cfb579fb7ae4cd3da63a69d97601e
2016-11-03tdf#88821: Set the encoding correctly for HTML files with a BOM.Jan Holesovsky
BOM (Byte Order Mark) in the HTML file changed the underlying eSrcEnc encoding, but did not actually update the rtl_TextToUnicodeConverter hConv. Subsequent changes of eSrcEnc in SetSrcEncoding() (triggered by 'content="application/xhtml+xml; charset=UTF-8"' in the HTML file) were then ignored (eSrcEnc was already set to UTF-8), and the parser was happily using the old (Windows-1250) hConv. Change-Id: If432d59891d51c6abe3517e325ed73057d0f8610
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-31loplugin:oncevar in svl..svxNoel Grandin
Change-Id: I80b11a7b698de4b84d7a2f4c7dc62b2e4fd8bb01 Reviewed-on: https://gerrit.libreoffice.org/30438 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-30cppcheck unreadVariable: diffJochen Nitschke
since initial commit 27a1e85b656bad222f113f650b03397aa3bc59d3 Change-Id: I46a973fdd6b565117030a3ae218928807e9bac41 Reviewed-on: https://gerrit.libreoffice.org/30406 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
generated by cgit (git 2.34.1) at 2024-07-13 22:32:13 +0000