summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2022-01-14Resolve tdf#124572 - Draw a faint line between tabsHeiko Tietze
Change-Id: I6cbbefe1cb16599ae81fc6dcb5a51ef1ca2db6f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128407 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-10use less SvStream::Flush()Noel Grandin
Flush() turns into a sync() on the device, which is pretty slow. Most of the time all we actually want to do is to flush the internal buffers from the SvStream. So expose the FlushBuffer method and use that where possible. And also means we don't need the mbDontFlushOnClose flag on SvStream any more. Change-Id: Ibe089b88b325f0fdc565200a97ce72cd26b7fcfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-02Introduce OUString::unacquired(const OUStringBuffer&)Mike Kaganski
... and avoid OUStringBuffer::toString when the temporary is used for checking current buffer content Change-Id: I114178f3e74ca3e4a3e517763f9eaab4797b7deb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-01-01osl::Mutex->std::mutex in Svt*OptionsNoel Grandin
Change-Id: I329849310f289e0fe7a886bbf3855f8d569767c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-25use comphelper::WeakComponentImplHelper in ValueSetAccNoel Grandin
and remove unnecessary use of SolarMutex, the fields are already protected by mutex and the locked region doesn't call into vcl. Change-Id: Ia010674b14fafe2bfac27956af71fb557a4df212 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127408 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21Fix typo and removed duplicated commentAndrea Gelmini
Change-Id: Id8dd9ff12fe62f5225112eebc681bf840e69f7a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127280 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-20osl::Mutex->std::mutex in AcceleratorExecuteNoel Grandin
Change-Id: Ib95f4bf1d5f09e8647ce8f35e8165c6858247fd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-19use more cppu::BaseMutexNoel Grandin
Change-Id: Iddd7438161ead93b27cf8e8058ca5b1eae3d8001 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-18Resolves: tdf#145853 Add Interslavic Latin|Cyrillic to language listEike Rathke
Interslavic Latin {art-x-interslv} 0x06AD Interslavic Cyrillic {art-Cyrl-x-interslv} 0x06AE Change-Id: I487d6593db89af038555a192674298e2dabf5582 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127018 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-12-17tdf#146250 fix SvxHtmlOptions::IsDefaultTextEncodingNoel Grandin
regression from commit da9bba7cc3c243e936daea689fea64ecaf110f35 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Jul 26 10:10:17 2021 +0200 use officecfg for SvxHtmlOptions spotted by himajin100000 Change-Id: Id237f7c4d6d816539141de97a19add0a993d92ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-12Small simplificationMike Kaganski
Change-Id: I9a6d134b9af46e84560a9f6160c4f9fa1d2631ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126696 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-11tdf#146173: combine non-BMP characters' surrogates correctlyMike Kaganski
Change-Id: Ib3af1f9e461f133d2f5b09b9db4fb87c1ede0b9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126658 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-10tdf#146048: detect UTF-16 without BOMMike Kaganski
Change-Id: I3c1742cdf88dfa08cf35d9f95875d4d3d6af09db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126596 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-10Generally determine Rdb content from gb_*_set_componentfile callsStephan Bergmann
...instead of by listing the content somewhat redundantly in the Rdb_*.mk files, to avoid duplication of logic for components that are only built conditionally (and thus should only be included conditionally in the corresponding Rdb). To achieve that, add an "rdb" parameter to gb_ComponentTarget_ComponentTarget (and to the gb_*_set_componentfile macros that internally call gb_ComponentTarget_ComponentTarget), which is used to make the appropriate gb_Rdb_add_component call internally from within gb_ComponentTarget_ComponentTarget. (As a special case, gb_CppunitTest_set_componentfile shall not call gb_Rdb_add_component, as that has already been done by the corresponding gb_Library_set_componentfile call, so allow the gb_ComponentTarget_ComponentTarget "rdb" parameter to be empty to support that special case.) Most Rdb_*.mk files are thus mostly empty now. One exception is i18npool/Rdb_saxparser.mk, which duplicates some of the Rdb_services content as needed during the build in CustomTarget_i18npool/localedata. 1c9a40299d328c78c035ca63ccdf22c5c669a03b "gbuild: create services.rdb from built components" had already tried to do something similar (in addition to other things) under a new --enable-services-rdb-from-build option. However, that approach had four drawbacks that this approach here addresses (and which thus partly reverts 1c9a40299d328c78c035ca63ccdf22c5c669a03b): 1 Rdb_services shall not contain the component files of all libraries that are built. While that commit filtered out the component files that go into Rdb_ure/services (ure/Rdb_ure.mk), it failed to filter out the component files that go into others like Rdb_postgresql-sdbc (connectivity/Rdb_postgresql-sdbc.mk). 2 The code added by that commit to Makefile.gbuild codified the knowledge that there is an Rdb_services, which is brittle. 3 The code added by that commit to solenv/gbuild/Rdb.mk codified the knowledge (for gb_Rdb__URECOMPONENTS) that there is an Rdb_ure/services, which is brittle. 4 Introducing an --enable-services-rdb-from-build option needlessly provided two different ways how the content of Rdb_services is assembled. The changes done here would leave --enable-services-rdb-from-build as a misnomer, as it no longer controls how Rdb_services is assembled. I thus renamed it to --enable-customtarget-components, as that is apparently what it still does now. Change-Id: Ia5e8df4b640146c77421fcec6daa11a9cd260265 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126577 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-01tdf#145964 related: also drop special-casing in TransferableHelper::SetStringMike Kaganski
Follow-up to commit 5fb9f4ffa9284c7248e2e82210506babaad4044d Change-Id: I46d5ea404f77ac5ff67b6ee6a42afee13274a481 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126174 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-26loplugin:stringliteraldefine in stoc,svtoolsNoel Grandin
Change-Id: Ifd583582fa7bf7366a1f8d482eefd64b30228ca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125867 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-25sw: allow viewing OLE objects in protected sectionsMiklos Vajna
The problem was that we don't allow even opening embedded objects in protected sections, which means the content of multi-page embedded objects can't even be viewed in protected sections, which probably goes too far. Fix this relaxing the condition in SwEditWin::MouseButtonDown() to allow launching the OLE object on double-click, and then make sure that the native data is not updated in SfxInPlaceClient_Impl::saveObject() and the replacement image is not updated in svt::EmbedEventListener_Impl::stateChanged(). This is complicated by only the Writer layout knowing if a given OLE object is anchored in a protected frame, so pass down a callback to sfx2/ and svtools/ to check if the OLE object is protected. Not copying the protected bit has the benefit of behaving correctly if the section turns into non-protected: copying would not work properly, as SfxInPlaceClient is created on demand, so not re-created when the protectedness of the section is changed. Change-Id: Ib3a8f2092d27dc1ebd3ef355c95a4a473988b163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125815 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-11-24Resolves: tdf#145840 call ToggledDavsHdl on setting checkbox stateCaolán McNamara
Change-Id: Ia2a735255b94fd3a097081950e2145e07b4b3b63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125783 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-23O[U]String::replaceAt overloads that take string_viewNoel Grandin
which results in lots of nice string_view improvements picked up by the plugins Change-Id: Ib0ec3887816b3d4436d003b739d9814f83e244b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-22tdf#132470 tabbar: revert back to bold font on visible tabJustin Luth
This is a partial regression to LO 6.3's commit fad98c8641342a77241124dd98e0cb781daef4ad. The current sheet is always selected, which is fairly distinctive. However, it is possible to select multiple sheets, and the current one should be distinctly marked to differentiate it from the other selected sheets. Change-Id: Ib160535cccebcfcabee94d17e5941cc3cd23bb15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125601 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-11-19gtk3: default to an explicit constrain-to for PopoversCaolán McNamara
with the intent to do the same replacement with GtkWindow under X11 for gtk3 that we do in MenuButtons for the popover with direct popovers when the constraint is GTK_POPOVER_CONSTRAINT_NONE Change-Id: I629c30b44a9e362ba0d924bb229930b5f0dc7ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125540 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-19rtl::Static->thread-safe static in svtoolsNoel Grandin
Change-Id: I437259b4a70ec575e937821b9b1adc001723f29c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125492 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-17Remove newly redundant breakStephan Bergmann
...after 0047e38da8bdfe09360cc2a658283ad5e18986e7 "svtools: HTMLParser: don't insert EOF into strings" Change-Id: Ib7d47030f215504a86bbfc10d9c35b5a19a7314b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125375 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-16svtools: HTMLParser: don't insert EOF into stringsMichael Stahl
It's not a valid Unicode code point. Change-Id: I96103f4c505047bdf0451619937b8e1b2efb127f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125307 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-16ofz#40766 svtools, sw: HTMLParser: really stop inserting control charsMichael Stahl
35d248cab1f0d4800f72abb5cb6afb56f40d9083 forgot to fix one place where control characters were in a presumed XML declaration. Another place looks missing where comments are handled, but it's not clear if these can be passed on to Writer. Revert the previous fix from commit b3325ef8cdfc2c82eec34e747106f75a9fccb7e4. Change-Id: I11ad13de9122533626e512ce0384051e3e5bd97f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125306 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-15add a rule to enforce always-show-image of True if an image is usedCaolán McNamara
If not set, then gtk3 will show the image if there is no text, but only the text if there's an image. For simplicity sake just enforce it as true if an image is referenced. Change-Id: Id4bb9140ba83e7e07e0d8ec5e3c29aece49b9087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-15Resolves: tdf#140250 don't share adjustments between differerent spinbuttonsCaolán McNamara
Change-Id: Ib684c746ff3176cf45ea9364efc12f2d6dde1f70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-11Handle UNO command aliases in ToolBoxesSzymon Kłos
This allows to use ".uno:InsertSlide" which is an alias for ".uno:InsertPage" in the notebookbar. Change-Id: Ia52488b65e308a62b686e77b38cba3675deece73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124952 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125046 Tested-by: Jenkins
2021-11-09tdf#145158: pre-multiply the value by factor before conversionMike Kaganski
Otherwise it is rounded before multiplying. Prior to the regressing commit cfff893b9c82843a90aac4ecdb3a3936721b74a0, it was calculating in twips, and was only converted to points by dividing by 20 in the end, which allowed to keep some precision. Change-Id: I142371dc630584f3fe64b5bfd5b592d46226ce32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124895 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-07Resolves: tdf#145386 Use "Default" for LANGUAGE_PROCESS_OR_USER_DEFAULTEike Rathke
There's no, specifically not in Writer, handling of the LCID 0x0400 LANGUAGE_PROCESS_OR_USER_DEFAULT language/locale concept other than the number formatter mapping it to LANGUAGE_SYSTEM. Use the LANGUAGE_SYSTEM "Default" string in UI (status bar, status menu, language list) but keep the LCID, and don't append the resolved locale string as it is also displayed both in the Font Western and CJK listboxes. This ends up as two list entries, like * Default - English (UK) first entry * Default last entry of which the second would be selected. Change-Id: I8d9e4171bee6bbe9d1c9dcfb7a5fa8fc92ea1a2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124449 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-11-03loplugin:constparamsNoel Grandin
Change-Id: Iebeb531fad5cc819b536788925cf8508737198b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124599 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-02keep showing focus rect on the first element during highlightCaolán McNamara
for the case nothing is selected but non-hover shows the bare focus rect to indicate focus is in the valueset though nothing is truly selected Change-Id: Ibe7fa38711f935126e1c0803c395b43b9720ca6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124575 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-02mbDrawSelection is always true when evaluatedCaolán McNamara
Change-Id: I043e68d5a5a6af8814f1db0f61f1cd95078ad11c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124570 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31Prepare for removal of non-const operator[] from Sequence in svtoolsMike Kaganski
Change-Id: I614a97e5e2328c787ce19612a88839e234d54382 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124396 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-31uniformly allow focus into GtkToolbarCaolán McNamara
Change-Id: I110daf882d9196cf7552e43a157ba4ae73fd670b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-29pass DX array around using o3tl::span instead of pointerNoel Grandin
so we get bounds checking in debug mode Note that I cannot just pass around the std::vectors involved because there is a place in editeng which calls with a subset of a vector. Change-Id: I5088a139593c27bf9cbe5d843ab4b0048ac6d508 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124330 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-27make fat valueset selection rectangles solidCaolán McNamara
as used in writer's bullets and numbering valuesets Change-Id: I4ac028fa9ef71163f29024352bb4fb7aeef0865a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124273 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-27draw valuesets with a visual difference between selected and mouse hoverCaolán McNamara
similar to the select a template dialog in impress use: * ActiveColor for selected + hover * HighlightColor for selected or hover, with some transparency for hover Change-Id: I0b6dd9ff36a51e9ce3d8bc6deac3f35794a7d429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124262 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-27if the mouse move is a leave event ignore the crossing positionCaolán McNamara
and just consider it as "mouse out of window" Change-Id: I1910804a94608952de6f646560a3104d62b5a67b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124265 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-27remove highlight when mouse tracking is finishedCaolán McNamara
don't just move it to the selected element, remove it Change-Id: Iea6259d75436169a845e283fb168d4306b5eca73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124260 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-27don't second guess the theme colors in valuesetsCaolán McNamara
Change-Id: I2215ad1d1d1791e27914e0f1dcec32c6827f4f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124235 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-27dont draw highlighted value with focus, only focus the selected valueCaolán McNamara
Change-Id: I63dc0ffd157d79e998156439f88a87c1ecfbea3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124233 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-27don't second guess the theme colors in valuesetsCaolán McNamara
Change-Id: Ie13242800c9a171a93d266601fed11bf2d62f942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124209 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26ValueSet doesn't use WB_NOPOINTERFOCUS anymoreCaolán McNamara
Change-Id: I5d1b1240518aa97d229d56545e353259d226f1e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26grab focus if clicked on anywhere, not just on a specific valueCaolán McNamara
Change-Id: I03b47080707c469d49e6cd9148573522d7f79da9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124232 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26don't do any work if we'll ignore it afterwardsCaolán McNamara
Change-Id: Id8a8dbeb2164e291324ddcb2409c0d7f05d5774a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124231 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-23Fix typo to complete commit 25278dc22ff6Andrea Gelmini
Change-Id: I78f0d443365e23501b43fe0f1d9e32d503c1e9f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124085 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-10-23Prefix just nDataRowHeight in brwbox so we can fix a typoJulien Nabet
The other variable members should also be prefixed but I don't have an IDE to do it easily Change-Id: Ifce210a4de89ed4d7f05126e33555da231553283 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124089 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-19Related: tdf#145173 Add English (Israel) {en-IL} 0xB409 to language listEike Rathke
Change-Id: I0c1d89a8869e3788f18851ae004bac24275923b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123829 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-19Use MsLangId::getConfiguredSystemUILanguage()Eike Rathke
Change-Id: Ia9344c44a71be656a731ab8735dd8e959e520592 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123789 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-23 00:16:46 +0000