summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2017-02-03TyposJulien Nabet
Change-Id: Ic54695e86b4b462419fa7d5ded7b1ddb19ee8ed5 Reviewed-on: https://gerrit.libreoffice.org/33904 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-02Fix some typosSamuel Mehrbrodt
Change-Id: Ide3786aad5589e2d430a4e3890d51117b145e51d Reviewed-on: https://gerrit.libreoffice.org/33842 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-02convert method names in tools::SvRef to be more like our other..Noel Grandin
reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02unnecessary use of OUStringBuffer in throwing exceptionsNoel Grandin
Change-Id: Iec1473264426f19c31e72260dfce9494389e474f Reviewed-on: https://gerrit.libreoffice.org/33788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02convert BmpCombine to scoped enum and drop unusedNoel Grandin
Change-Id: Ic67474683a25a25e5753777f4bbbeded6ceba414 Reviewed-on: https://gerrit.libreoffice.org/33793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01loplugin:useuniqueptr extend to check local varsNoel Grandin
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30tdf#105448 add Sibe [nco-PG] to language listEike Rathke
Change-Id: If7dfeaa0dd4cf4d164147b8b866f7c493a5af669
2017-01-30tdf#105448 add Manchu [mnc-CN] to language list (CTL)Eike Rathke
Change-Id: Ia19da31a3df0a7d196997eedef07d8a28aa2e72c
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27Remove some '#ifdef AWT_DIALOG' noiseStephan Bergmann
...that sat there ever since 4bda34677755729bd3a10353ea5b7bb9998ccc9b "initial checkin - frame for dialogs usuable as UNO service" Change-Id: I3c8f6fe74d05e5d25950251997354475da02832d
2017-01-27tweak the scoping here a littleCaolán McNamara
Change-Id: Idb257e3aee7d3f0316f34d34866eb2484390a798
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25loplugin: unnecessary destructor svl..svtoolsNoel Grandin
Change-Id: Ie96dda7194c83ba88693f8c91899c732d704a4bd Reviewed-on: https://gerrit.libreoffice.org/33515 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23use rtl::Reference in SvUnoImageMapNoel Grandin
instead of manual acquire/release Change-Id: Ia17a1cca542ef0008fe32f2dbfcfce1ecd3161a2
2017-01-23use rtl::Reference in TransferableDataHelper_ImplNoel Grandin
instead of manual acquire/release Change-Id: I0d7d71a76c84f61f87399d7b7d93be0e50ccae16
2017-01-23use rtl::Reference in RulerNoel Grandin
instead of manual acquire/release Change-Id: I7815a0a3c01fce57b4798ac1dbf501e20444c61d
2017-01-21move GetXGraphic to its only userCaolán McNamara
Change-Id: I72ec4a7e72ca3355a97f987fab70b3e3a8e45168
2017-01-21function argument cleanupJochen Nitschke
fix for cppcheck funcArgOrderDifferent > Function 'SearchRow' argument order different: > declaration 'nRow, nRight, nLeft, nPref, bRight, bSimple' > definition 'nRow, nLeft, nRight, , bRight, bSimple' remove unused nPref argument swap arguments where nTop was obviously bigger than nBottom or nLeft bigger than nRight use std::swap no logic change intended Change-Id: I65fd313636edcd8bca8fde2ca9b35de90d1e8ad4 Reviewed-on: https://gerrit.libreoffice.org/33372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-20don't need an intermediate ImageCaolán McNamara
Change-Id: I2700c30000b440a0646d43bb5712fe683747b34b
2017-01-19drop now unusd private:resource/.../image urlsCaolán McNamara
Change-Id: Ic456113b295c3b90316d2792b630c44892ac20a7
2017-01-19New loplugin:dynexcspec: Add @throws documentation, svtoolsStephan Bergmann
Change-Id: I274142728ea25be094343e3489758314e371a857
2017-01-18svtools: load BitmapEx resources instead of Image onesCaolán McNamara
Change-Id: Ifc852b1cb886b30abdf1061b73c2b600334264c6
2017-01-18there's no need for this nutso redefineCaolán McNamara
both BMP_PLUGIN resources point to the same plugin.png ultimately Change-Id: Ifa1cc00698f749ba84f17a79074c73e080e1d356
2017-01-18unused resourcesCaolán McNamara
Change-Id: Ia3f5a4ed5cb1eb9fefeb3a4fe5b5a14f2e260a6a
2017-01-18new loplugin: useuniqueptr: svl..svtoolsNoel Grandin
Change-Id: Ia4d5b37ee3cf67318e3cc01525e4b733af60d038 Reviewed-on: https://gerrit.libreoffice.org/33251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17replace #ifdef SOLARIS with #ifdef __sunMichael Stahl
Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-16Resolves: tdf#104950 add English (Malaysia) [en-MY] to language listboxEike Rathke
Change-Id: I3a6865fa61e4bd0089214f110087ce0fff194e64
2017-01-13better fix for tdf#101563: Export to PDF creates huge PDF filesNoel Grandin
Change-Id: Idda6a5ac824090e620fc6577fc82d5c5f1234b7e Reviewed-on: https://gerrit.libreoffice.org/33037 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13coverity#1371198 Missing move assignment operatorCaolán McNamara
Change-Id: I89a718a245ea36f33c47f8044280bf7e46c0f66a
2017-01-11fold ImplConstruct into ctors and reduce to necessaryCaolán McNamara
ImplConstruct sets mnAnimationLoopCount, but is always followed by ImplAssignGraphicData which overwrites it so we can omit that ImplConstruct sets mnDataChangeTimeStamp, but is always followed by ImplAssignGraphicData which always calls ImplAfterDataChange which overwrites it so we can omit that Change-Id: I2304dc1ea590071a83ca30768426f721c1bd259c Reviewed-on: https://gerrit.libreoffice.org/32953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-10mpGlobalMgr must already exist if we're copying from another GraphicObjectCaolán McNamara
Change-Id: I7befa3bf8c80ed71d13a1481569bb046036cbd21
2017-01-10post ctor, pre dtor there is always a mpMgr and its mpGlobalMgrCaolán McNamara
move the ImplEnsureGraphicManager calls to be the first thing in the ctor to ensure that its also always available during the ctoring, this is hopefully a good change Change-Id: Iccddee7cac152df66dec0039df207a7575e1fa54
2017-01-10mpGlobalMgr has to exist at GraphicObject dtor timeCaolán McNamara
Change-Id: I75d82c041aa5a01bab3dceecaaa132ce9172862b Reviewed-on: https://gerrit.libreoffice.org/32899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2017-01-10mpGlobalMgr is the only manager possibleCaolán McNamara
Change-Id: Ic7e20c9c198cfdab73647b009af3e269aabf680f Reviewed-on: https://gerrit.libreoffice.org/32898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2017-01-10move the ImplRegisterObj outside ImplSetGraphicManager and rename itCaolán McNamara
Change-Id: I1eded3ee41787b9a3339e01cf6e1157724bba1a6
2017-01-10ImplSetGraphicManager only called from ctors now where mpMgr is nullptrCaolán McNamara
Change-Id: Ib275f4c803d74eaf45409e78a6c786dac159af6b
2017-01-10GraphicManagerDestroyed would just set the default manager againCaolán McNamara
which is the only one that could already be set. Seeing as the manager is always there if a Graphic exists then the maObjList must be empty at the dtor time Change-Id: Id447d1e62a4b94b0ef986edf3cc05629c90e511b
2017-01-10unfold and unindent else causeCaolán McNamara
Change-Id: I22131a477547ac08b0c6b762353c9796f80c3666
2017-01-10the only GraphicManager is the mpGlobalMgr, so simplify accordinglyCaolán McNamara
Change-Id: I5b237e27815e138cdcab75b1b9f657882ae8a37b
2017-01-10collapse !mpMgr || mpMgrCaolán McNamara
Change-Id: Id93b2da5665c47b1e8941d2f7428fe078c6227f7
2017-01-10first GraphicManager* arg of ImplSetGraphicManager is thus always nullCaolán McNamara
Change-Id: I3da98280d3c1d95663e6e43ce7a5ca82c001c334
2017-01-09replace C-style casts with const_castJochen Nitschke
Change-Id: Ica6522b4bfe2aa4517469e89cabe5d4d057cb6b7 Reviewed-on: https://gerrit.libreoffice.org/32657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-09second arg of deformed copy ctor isn't usedCaolán McNamara
except in the qa test Change-Id: I84d1a06194e4c11b218c417663f12195c9f76526 Reviewed-on: https://gerrit.libreoffice.org/32890 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09New loplugin:externvar: svtoolsStephan Bergmann
Change-Id: I2fc934db85c133f69b4e1092b50fc8e053798c4d
2017-01-09non debug warning -Wmaybe-uninitializedCaolán McNamara
Change-Id: I16c04585ee2c411ae362230590a06bdc9e22443d
2017-01-09Related: coverity#1371305 unnecessary inheritenceCaolán McNamara
SvDataCopyStream used to do extra Load/Save things that are long gone, so there is no reason for the common base anymore Change-Id: Ib321021002adb480bb96298f199141dc3fe2ec2b Reviewed-on: https://gerrit.libreoffice.org/32851 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-17 23:32:22 +0000