summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2013-06-30Clean String and sal_Bool in toolsNorbert Thiebaud
Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655 Reviewed-on: https://gerrit.libreoffice.org/4627 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-29remove OUString wrap for string literalsThomas Arnhold
For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29remove some createFromAscii usageThomas Arnhold
there are a lot more of them: git grep 'createFromAscii[^)]*"' Change-Id: Ibc2e9cae208d8b9c91667bb3b177c6bd6d3a9424
2013-06-28remove toolkit/unohlp.hxx hackThomas Arnhold
Change-Id: Idb9971d848870f4d00dbf77e80e48bf7dfde8913 Reviewed-on: https://gerrit.libreoffice.org/4601 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-27Resolves: #i122586# recalcuate width when scrolling to last columnJürgen Schmidt
(cherry picked from commit febd0946e8c2686f0a679d3f32fbb39f5ef1c295) Change-Id: Ia1aba1eddf9035504677d10a7414f9a498b952e1
2013-06-24Add missing copy&paste of SfxAppToolBoxControl_Impl::SelectAriel Constenla-Haile
(cherry picked from commit 47204c74d9e52f54f6983af19b66af2a96b42e61) Conflicts: framework/inc/uielement/popuptoolbarcontroller.hxx svtools/inc/svtools/toolboxcontroller.hxx Change-Id: I304d17c662450f29eeffb17f576b418986f3fb0a
2013-06-24blasted pch includesCaolán McNamara
Change-Id: I2a518445dfd06086cbd1acaece45a3ed9de0ce7b
2013-06-23Resolves: #i121542# Unify the Menu APIAriel Constenla-Haile
(cherry picked from commit 399946b82f5efec19cd82d1c320d5aa9295d235d) Conflicts: chart2/source/controller/main/ChartController_Window.cxx framework/source/uielement/langselectionmenucontroller.cxx framework/source/uielement/popupmenucontroller.cxx framework/source/uielement/recentfilesmenucontroller.cxx framework/source/uielement/toolbarsmenucontroller.cxx odk/examples/DevelopersGuide/GUI/UnoMenu.java odk/examples/DevelopersGuide/GUI/UnoMenu2.java odk/examples/cpp/StatusbarController/SelectionModeStatusbarController/SelectionModeStatusbarController.cxx offapi/com/sun/star/awt/MenuBar.idl offapi/com/sun/star/awt/MenuEvent.idl offapi/com/sun/star/awt/MenuItemStyle.idl offapi/com/sun/star/awt/MenuItemType.idl offapi/com/sun/star/awt/MenuLogo.idl offapi/com/sun/star/awt/PopupMenu.idl offapi/com/sun/star/awt/PopupMenuDirection.idl offapi/com/sun/star/awt/XMenu.idl offapi/com/sun/star/awt/XMenuBar.idl offapi/com/sun/star/awt/XMenuBarExtended.idl offapi/com/sun/star/awt/XMenuExtended.idl offapi/com/sun/star/awt/XMenuExtended2.idl offapi/com/sun/star/awt/XMenuListener.idl offapi/com/sun/star/awt/XPopupMenu.idl offapi/com/sun/star/awt/XPopupMenuExtended.idl offapi/com/sun/star/awt/makefile.mk offapi/type_reference/types.rdb svtools/inc/svtools/popupmenucontrollerbase.hxx svtools/source/uno/popupmenucontrollerbase.cxx svx/source/tbxctrls/extrusioncontrols.cxx toolkit/inc/pch/precompiled_toolkit.hxx toolkit/inc/toolkit/awt/vclxmenu.hxx toolkit/inc/toolkit/helper/listenermultiplexer.hxx toolkit/source/awt/vclxmenu.cxx Change-Id: I3d9a1e109b9ff35901a3075b44a4c27e7c12b5c7 Related: #i121542# css::awt::XPopupMenu::execute() needs a Rectangle (cherry picked from commit c01a6f4f370b72f0751cf4f5c11310682e2b3248) Conflicts: odk/examples/DevelopersGuide/GUI/UnoMenu2.java offapi/type_reference/types.rdb toolkit/inc/toolkit/awt/vclxmenu.hxx Change-Id: I2cccc95086fe3d1522d03346e3c577fb2f21f621
2013-06-21coverity#707543 : Unitialized scalar variableNorbert Thiebaud
Change-Id: I601b8cd42932fcba9b98a5736faa9d38525b093a Reviewed-on: https://gerrit.libreoffice.org/4406 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-06-19Resolves: #i122418# Added workaround to not use GetBitmap on windowsArmin Le Grand
(cherry picked from commit 136976efb17b8617a83c7f26601cd04031b51e7f) Conflicts: vcl/inc/vcl/bitmap.hxx vcl/inc/vcl/bitmapex.hxx vcl/source/gdi/bitmap4.cxx vcl/source/gdi/bitmapex.cxx Change-Id: I9c3aeae76c155c9050404f67adeb91106502c3f1
2013-06-18fdo#43460 include,registry,svtools,svx,unodevtools: use isEmpty()Jelle van der Waa
Change-Id: I6e35b91092239275694eec3666b076f7ff7e54f6 Reviewed-on: https://gerrit.libreoffice.org/4335 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-06-18Related: #i122120# corrected flag for drawing checkerboards...Armin Le Grand
adapted previews, added to configuration (cherry picked from commit c17e634e125f524d153e1ad8febff6d11b810ee4) Conflicts: officecfg/registry/schema/org/openoffice/Office/Common.xcs svtools/inc/svtools/accessibilityoptions.hxx svtools/source/inc/configitems/accessibilityoptions_const.hxx vcl/inc/vcl/settings.hxx Change-Id: I3f4fd9525e31cd816599b963ecd2fa42b1f666d7
2013-06-17cppcheck: fix some uninitMemberVar in svtools partJulien Nabet
Change-Id: Icee2501b2a33afddaa3d08186bb806acf785bf4c
2013-06-17Resolves: #i122388# Corrected old fix to mentioned boundsArmin Le Grand
(cherry picked from commit 65dd87d8f010a9c9d1b277f9b1839378b549d06f) Change-Id: I01318b3f96b23196f54335782ef9c946bf2b1ef9
2013-06-17Resolves: #i74211# Correct crop of bitmap data when...Armin Le Grand
logical size and MapMode do not match real pixel size (cherry picked from commit a24965371f7e881671182bc51432c08cbf667b56) Conflicts: svtools/inc/svtools/grfmgr.hxx svtools/source/graphic/grfmgr.cxx svx/inc/svx/svdhdl.hxx svx/inc/svx/svdograf.hxx svx/source/svdraw/svdhdl.cxx Change-Id: Icfb9091b55e50081e8daf697c9f00f5b5a10531a
2013-06-16Add UI for fine dashed border typeMiklos Vajna
Commit 7d632ff29e601c2e680c4a689997fbf552592a4b added document model / layout support for this, but UI was lacking. First, add a new item to the list box in SvxBorderTabPage::FillLineListBox_Impl(). Second, handle MAP_TWIP unit in svtools::GetDashing() for STYLE_FINE_DASHED. Pick up some values that give visually the fine dashed result when painted. (The original values from 2f0d406911f9790a434e46bc82ea36bb8ae714e7 in other cases seem to be a bit consistent already anyway.) Change-Id: Ibf1ed235d51515b065d23a6a5d5eef433162899f
2013-06-14Resolves: fdo#65569 dropdown list missing from built-in fpickerCaolán McNamara
regression since a8c2cb0e6d0b9b301887be176694592f8ecda0c4 the different ctors have different defaults around whether they show the dropdown or not. Change-Id: I3d1bb423c8a25b81ffb26981b63af7498f99e70a
2013-06-13Resolves: #i121532# unified getting the blended selection colorArmin Le Grand
(cherry picked from commit dd4bed5d1151db2a45dbbfe9eff61875f8f4835d) Conflicts: svtools/inc/svtools/optionsdrawinglayer.hxx svtools/source/config/optionsdrawinglayer.cxx sw/source/core/crsr/viscrs.cxx Change-Id: I21167b58a9b81f5fa15c7def5fb4b6023f91f32b
2013-06-13Resolves: #i121504# Support for alpha channel in clipboard for all systemsArmin Le Grand
(cherry picked from commit ef3931ff410117e1237b3bef7bc090e8b83b9519) Conflicts: automation/source/server/statemnt.cxx basic/source/runtime/methods.cxx canvas/source/vcl/devicehelper.cxx canvas/source/vcl/spritedevicehelper.cxx drawinglayer/source/processor2d/vclhelperbufferdevice.cxx drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx drawinglayer/source/tools/converters.cxx dtrans/source/win32/dtobj/FmtFilter.cxx editeng/source/items/bulitem.cxx extensions/source/scanner/sanedlg.cxx external/gcc3_specific/makefile.mk filter/source/graphicfilter/eos2met/eos2met.cxx filter/source/graphicfilter/ios2met/ios2met.cxx filter/source/msfilter/msdffimp.cxx fpicker/source/office/iodlg.cxx framework/source/fwe/classes/addonsoptions.cxx framework/source/fwe/helper/actiontriggerhelper.cxx sc/source/filter/excel/xiescher.cxx sc/source/ui/docshell/docsh.cxx sc/source/ui/inc/viewfunc.hxx sd/source/ui/app/sdxfer.cxx sd/source/ui/unoidl/unopage.cxx sd/source/ui/view/sdview3.cxx sfx2/source/appl/fileobj.cxx sfx2/source/appl/linkmgr2.cxx sfx2/source/dialog/filedlghelper.cxx sfx2/source/dialog/intro.cxx sfx2/source/doc/docinf.cxx sot/inc/sot/formats.hxx sot/source/base/formats.cxx svtools/bmpmaker/bmpcore.cxx svtools/bmpmaker/bmpsum.cxx svtools/inc/svtools/transfer.hxx svtools/source/filter/filter.cxx svtools/source/filter/wmf/emfwr.cxx svtools/source/filter/wmf/enhwmf.cxx svtools/source/filter/wmf/winwmf.cxx svtools/source/filter/wmf/wmfwr.cxx svtools/source/graphic/graphic.cxx svtools/source/graphic/provider.cxx svtools/source/misc/transfer.cxx svx/inc/svx/xoutbmp.hxx svx/source/sdr/overlay/overlaymanagerbuffered.cxx svx/source/xoutdev/_xoutbmp.cxx sw/source/core/view/viewsh.cxx sw/source/filter/ww1/w1filter.cxx sw/source/filter/ww8/ww8par.hxx sw/source/ui/dochdl/swdtflvr.cxx toolkit/source/awt/vclxbitmap.cxx toolkit/source/helper/vclunohelper.cxx vcl/Library_vcl.mk vcl/Package_inc.mk vcl/aqua/source/dtrans/DataFlavorMapping.cxx vcl/aqua/source/dtrans/OSXTransferable.cxx vcl/aqua/source/dtrans/PictToBmpFlt.cxx vcl/aqua/source/dtrans/PictToBmpFlt.hxx vcl/inc/vcl/alpha.hxx vcl/inc/vcl/bitmap.hxx vcl/inc/vcl/bitmapex.hxx vcl/inc/vcl/pngwrite.hxx vcl/inc/vcl/salbtype.hxx vcl/inc/vcl/wall.hxx vcl/source/gdi/animate.cxx vcl/source/gdi/bitmap2.cxx vcl/source/gdi/bitmapex.cxx vcl/source/gdi/bmpconv.cxx vcl/source/gdi/cvtsvm.cxx vcl/source/gdi/impgraph.cxx vcl/source/gdi/impimagetree.cxx vcl/source/gdi/metaact.cxx vcl/source/gdi/wall.cxx Change-Id: I79938bc412c048c3d4e64f430f216e73bec16167
2013-06-12added Tibetan_India [bo-IN] to language list, fdo#40713Eike Rathke
Change-Id: Ied426ee153ccd1a71e3cd0fbb4b417ac8b9b82e4
2013-06-10mingw64: use integers able to contain a size in svtoolsFridrich Štrba
Change-Id: Id5505f75a2331be682b74d085a7959fc4bf07df8
2013-06-07XubString->OUStringCaolán McNamara
Change-Id: I9404ef0d53a74e09a0db9781d004fcd0c573dd78
2013-06-07fdo#63866 Hid useless checkboxesJason Hulme
Added functions to SvTreeListBox and SvLBoxButton to allow entries with hidden checkboxes Change-Id: Ia5a1deabea6c01aad5e4010612ac453c669258a6 Reviewed-on: https://gerrit.libreoffice.org/4169 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-06-06remove unused BMP_OLEOBJ image and define.Michael Meeks
Change-Id: I809cca8dab246c7b528309fd74fb73a9d0bd418f
2013-06-06Some more modules at least building with mingw64Fridrich Štrba
Change-Id: I3ea039655aecb7885bb310b1f2c29d66f9f7bb4f
2013-06-07sal_Bool to boolTakeshi Abe
Change-Id: I58efb9d026203c77d3806552bd4280a4d16d5111
2013-06-06Remove remnants of help agentCaolán McNamara
it was removed with 66714f1888eaccef4eb5341971278ae7dfafa16b but gobs of code (and UI) still existed to collect the help id and give it to the missing help agent with various UI visible options and buttons to control the help agent which isn't there Change-Id: I625da27b3046d481e43f4d35d32cc7063a1c6291
2013-06-06Slowly, but surely going on compiling for mingw64Fridrich Štrba
Change-Id: I590aa6a854a040281bf73d5be768c05d4906a984
2013-06-05fdo#56412 Movement of embedded objects is opposite to the change directionabdulmajeed ahmed
not a perfect solution but best we can get without large rework. Change-Id: I4a8c6eb611dd88cb29999b10b80a914c66a11c1c
2013-06-05use uno::Reference#clear() method...Noel Grandin
...instead of assigning an empty value. Reduces code noise. Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-06-05fdo#46808, Convert some XMultiservice in framework moduleNoel Grandin
Change-Id: Id4dd0bafd40cf96271527c9c970c4ab31527644c
2013-06-05remove unused componentcontext.hxx includesNoel Grandin
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-05fdo#46808, Convert various comphelper::ComponentContextNoel Grandin
..to regular XComponenContext Change-Id: I08f9092ae818db5c1e37880625b83607c860680b
2013-05-31prompt to restart office when required for experimental featuresCaolán McNamara
Change-Id: I43051ec6b0efeaebcf4a28940f70913423b8ea9f
2013-05-29fdo#60724 change spelling error REMOVEABLE -> REMOVABLE IIThomas Arnhold
Change-Id: I0057b9174af6a83f3fde0e27c3a91a4aeca95873 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-05-28fdo#46808, Convert ui:*AcceleratorConfiguration to new styleNoel Grandin
The services already existed, they just needed IDL files. API CHANGE: The return type of XUIConfigurationManager#getShortcutManager() is now XAcceleratorConfiguration instead of XInterface. This should not be a problem because XUIConfigurationManager is unpublished and the client code was relying on the service returning that type. Change-Id: I399fe35de3394b02a4166b75eb7ff93b28be8bef
2013-05-26svt::ToolboxController clean-upAriel Constenla-Haile
Some small clean-up to use the PopupMenu ToolbarController (cherry picked from commit e1687ce159e787d98f79d29a3d2131cca4b6ec71) Conflicts: svtools/inc/svtools/toolboxcontroller.hxx svtools/source/uno/toolboxcontroller.cxx Change-Id: Ie5e0397c32352d52cf2664bdbab920923e74bd03
2013-05-23Resolves: #i120858# Change "Farsi" with "Persian"Ariel Constenla-Haile
Changes done on UI code and IDL, not in comments (cherry picked from commit fa88b1f1e227ad7530f6595d802a6ed1f5d54cb4) Conflicts: scp2/source/ooo/module_langpack.ulf wizards/com/sun/star/wizards/letter/LocaleCodes.java Change-Id: I9f66f697789965af79c1ea6db08c8e43f099ddf8
2013-05-22fdo#46808, Convert XMultiServiceFactory to XComponentContextNoel Grandin
Change-Id: Ib5e6fb4d6a4ff8f2bd315f19bde5028be2c569ea
2013-05-22Use the new type-checking Reference constructor to reduce code noiseNoel Grandin
Also create a Clang compiler plugin to detect such cases. Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 Reviewed-on: https://gerrit.libreoffice.org/4001 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-21UI Controller Factory fixesAriel Constenla-Haile
- "ModuleName" --> "ModuleIdentifier": the IDL definition for css::frame::PopupMenuControllerFactory and css::frame::StatusbarControllerFactory tells to use a property named "ModuleIdentifier", but in the code it is named "ModuleName" - Undocumented css::frame::ToolbarControllerFactory - Fix service name of ToolbarControllerFactory (ToolbarControllerFactory instead of ToolBarControllerFactory) - Convert the three service factories to new style, and use these new-style services in the source code - Implement multiple inheritance: added new css::frame::XUIControllerFactory - Added a (true) base class and implemented the three factories in a single file (cherry picked from commit acc7fed28f54f836b0923180431a0c180f91e98c) Conflicts: framework/inc/pch/precompiled_framework.hxx framework/inc/uielement/toolbarmanager.hxx framework/inc/uifactory/popupmenucontrollerfactory.hxx framework/inc/uifactory/statusbarcontrollerfactory.hxx framework/inc/uifactory/uicontrollerfactory.hxx framework/source/uielement/addonstoolbarmanager.cxx framework/source/uielement/menubarmanager.cxx framework/source/uielement/popupmenucontroller.cxx framework/source/uielement/statusbarmanager.cxx framework/source/uielement/toolbarmanager.cxx framework/source/uifactory/popupmenucontrollerfactory.cxx framework/source/uifactory/statusbarcontrollerfactory.cxx framework/source/uifactory/uicontrollerfactory.cxx framework/source/unotypes/fwk.xml offapi/com/sun/star/frame/PopupMenuControllerFactory.idl offapi/com/sun/star/frame/StatusbarControllerFactory.idl offapi/com/sun/star/frame/makefile.mk svtools/source/uno/toolboxcontroller.cxx Change-Id: Ia8580539badf650a84bc6e57a6b832071e011f0a
2013-05-21Related: #i121442# Adapt existing code in other modulesAriel Constenla-Haile
(cherry picked from commit 6c640ee420df6f7c9f3ab981e49ee304f1d2319e) Conflicts: reportdesign/source/ui/misc/statusbarcontroller.cxx sfx2/inc/sfx2/stbitem.hxx svtools/inc/svtools/statusbarcontroller.hxx svtools/source/uno/statusbarcontroller.cxx Change-Id: If03a201214a4afe09efa4e3e996aded9b6a57bdf
2013-05-20vcl: all EnableAutoSize methods take a bool.Michael Meeks
Change-Id: I6f974d6b82f6bb77996d20219b5c0ceb78596c5c
2013-05-20add experimental option for sidebar to 'Advanced' pane.Michael Meeks
2013-05-20Related: #ii122198# added ColorValueSetColumnCount entry to configurationArmin Le Grand
default is 12 (cherry picked from commit dc9abefa2d01377b14bef15463e360d9a7e9bdc2) Conflicts: officecfg/registry/schema/org/openoffice/Office/Common.xcs svtools/inc/svtools/accessibilityoptions.hxx svtools/source/inc/configitems/accessibilityoptions_const.hxx Change-Id: Ic035b34bbcde426fa8fb76df16f84786908e18fa
2013-05-20Related: #i122041# More unifications for FillStylesArmin Le Grand
better defaults and better preview visualizations (cherry picked from commit 35c9acfc98fc98399005815e0464b1944f327d4e) Conflicts: officecfg/registry/schema/org/openoffice/Office/Common.xcs svtools/inc/svtools/accessibilityoptions.hxx svtools/inc/svtools/valueset.hxx svtools/source/config/accessibilityoptions.cxx svtools/source/control/ctrlbox.cxx svtools/source/control/valueset.cxx svtools/source/inc/configitems/accessibilityoptions_const.hxx svx/inc/svx/dlgctrl.hxx svx/inc/svx/xtable.hxx svx/source/dialog/dlgctrl.cxx svx/source/tbxctrls/SvxColorValueSet.cxx svx/source/xoutdev/xtabdash.cxx svx/source/xoutdev/xtable.cxx vcl/inc/ilstbox.hxx vcl/inc/vcl/combobox.hxx vcl/inc/vcl/lstbox.hxx vcl/inc/vcl/settings.hxx vcl/source/app/settings.cxx vcl/source/control/combobox.cxx vcl/source/control/ilstbox.cxx vcl/source/control/lstbox.cxx Change-Id: I905b6814cb796a35aa23fedb9ce716f77e2bfda0
2013-05-20Resolves: #i122041# Unified and centralized control for Color ValueSetsArmin Le Grand
(cherry picked from commit 68e707bbc6fe23881b822e6efab8a2933343dc1a) Conflicts: cui/source/inc/backgrnd.hxx cui/source/inc/cuitabarea.hxx cui/source/tabpages/backgrnd.cxx cui/source/tabpages/tpcolor.cxx sd/source/ui/view/drviews6.cxx svx/Package_inc.mk svx/inc/svx/colrctrl.hxx svx/source/sidebar/tools/ColorControl.cxx svx/source/tbxctrls/colorwindow.hxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx Change-Id: Ie06fe355846b737ec8aae9aade4d408232c83193 Related: #i122041# Add a11y values for defining behaviour of ColorValueSets (cherry picked from commit 401e8f2db607081e62eaaa1f08a8cd8971a3f637) Conflicts: cui/source/tabpages/backgrnd.cxx officecfg/registry/schema/org/openoffice/Office/Common.xcs sc/source/ui/miscdlgs/tabbgcolordlg.cxx svtools/inc/svtools/accessibilityoptions.hxx svtools/source/inc/configitems/accessibilityoptions_const.hxx vcl/inc/vcl/bitmap.hxx vcl/source/gdi/bitmap4.cxx Change-Id: If9d0db5f22974cad1ac886eca3719ca92ca7f240
2013-05-16resolved fdo#56772 keep track of HTML ON/OFF tokensEike Rathke
Regression introduced with 11cbcb8b08b540b144a5df744e9fba0b6ba8144a followed by 56d6589368c2e88cffec0c2e518f7c90863eeae6 Deep from svtools/source/svhtml/parhtml.cxx HTMLParser::_GetNextToken() only a HTML_TABLEDATA_OFF was generated for <td .../> without a matching HTML_TABLEDATA_ON (actually same for all <XXX/> ON/OFF tokens). This confuses a state machine that doesn't keep track of such unexpected closures and also expects all attributes of an element at an ON token. Only the parser knows this is actually one token but needs to generate separate ON/OFF tokens. These bugs mentioned in the original code and commits are still fixed with this change: https://bugs.freedesktop.org/show_bug.cgi?id=34666 https://bugs.freedesktop.org/show_bug.cgi?id=36080 https://bugs.freedesktop.org/show_bug.cgi?id=36390 Change-Id: I2b3190d297a35ee3dfda95f9a4841f7c53ed4a92
2013-05-15Spelling "separate" (etc) correctly is hardTor Lillqvist
2013-05-15svtools FormattedField: don't reparse value from text after ReFormatLionel Elie Mamane
If our format is lossy / not a bijection (as is e.g. our default date format, because of 2-digit year), then reparsing the string that came from the format leads to data loss (the value is changed to something else). The existing code tried to do that, by calling Modify() and then setting m_bValueDirty to false. However, this fails because listeners are called while m_bValueDirty is true. If any of them calls e.g. GetValue(), the reparse happens. Change-Id: I272f377927f83c71ede1eb80eafbc689f36fb17a