summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2014-10-17coverity#1247633 Uncaught exceptionCaolán McNamara
Change-Id: I4058089f45b39ddacc56ccf2259ce6e939abe4ee
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-14Resolves: fdo#84887 TabBar::ImplShowPage crashCaolán McNamara
Change-Id: I84250c6a40baeabd0d12958dfe0aea346d2b4fc8
2014-10-14fdo#84938 - replace LIST_ACTION constants with enumNoel Grandin
Change-Id: I21c05ada0a793b1e3ddf87481e66b60b83529767
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMapChris Sherlock
To do this, I've made FontCharMap a friend class for ImplFontCharMap, and have moved the functions directly into FontCharMap. In this patch, I am attempting to stop the direct use of ImplFontCharMap by anything other than FontCharMap. However, FontCharMap itself requires a refcounter, so we will use FontCharMapPtr to access the font character map. Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9 Reviewed-on: https://gerrit.libreoffice.org/11823 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09Resolves: fdo#82270 Grabbing focus can invalidate the entriesCaolán McNamara
Change-Id: Ie9b4f936cebdcf2a37e66abef456c6b0c0e26201
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-05FDO#80652 (part) help for page CMIS file accessOlivier Hallot
This commit adds a help button to CMIS dialog Change-Id: Ic4f826c4ee5fa31a94e3d22974a0e13bf460a249 Reviewed-on: https://gerrit.libreoffice.org/11801 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2014-10-03cid#1194925 Resource leakNoel Grandin
reorganise the code to keep coverity happy Change-Id: I18fc2dfd17f97edf1d17c57caaed4cc9d2fedd13
2014-10-03coverity#704318 Logically dead codeCaolán McNamara
Change-Id: I591188e0323bb75c55cad9a078eea188f79b3a03
2014-10-03rename SvRef::AddRef to AddFirstRefNoel Grandin
to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-03fdo#84592 Fix wrong background color in listsSamuel Mehrbrodt
Change-Id: Ie154bfb15a19ae98b2bc4eb6626240a00cf182d4
2014-10-02Improved striped rows implementationSamuel Mehrbrodt
Some renaming, use variable for row background when not striped Change-Id: I5b36fc751aa163dbb127406d7aefad01974fa371
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30Improve SvTreeListBox classPalenik Mihály
It is possible to set alternating rows. Expert Configuration dialog use it. Change-Id: Ie43a87ca05be73fdb345fa4866f31c2c36b7cdf1 Reviewed-on: https://gerrit.libreoffice.org/11663 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-30Some glue for using std::unique_ptr with the Boost Pointer Container LibraryStephan Bergmann
Change-Id: Ie975e963ed64fb96542a9771f85eef72d8266496
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-29MSVC 2012 apparently isn't ready yet for std::vector<std::unique_ptr<T>>Stephan Bergmann
...producing error messages about trying to access private undefined unique_ptr copy ctor etc. Partial revert of 014e7933af751bfe0a03867373b82efa806f3a3d "svtools: std::auto_ptr -> std::unique_ptr: ...changing HTMLOptions to std::vector<std::unique_ptr<...>> because boost::ptr_vector<...>::push_back only supports auto_ptr, not unique_ptr," going the awkward std::unique_ptr x(...); push_back(x.get()); x.release(); route instead (which could be simplified if boost::ptr_vector::push_back ever started to support unique_ptr). Change-Id: I15693030a0bbfdedbfdfbe76ede5d0c74f4e5b41
2014-09-29svtools: std::auto_ptr -> std::unique_ptrStephan Bergmann
...changing HTMLOptions to std::vector<std::unique_ptr<...>> because boost::ptr_vector<...>::push_back only supports auto_ptr, not unique_ptr. Change-Id: Ie5f92bc40ce5425dc1c634b17addc2b0dd9bbda3
2014-09-29loplugin: cstylecastNoel Grandin
Change-Id: Iea517d2287bded4a702c73dfdd1f182023425d67
2014-09-28border_width from 12 to 6, as the rest of dialogsAdolfo Jayme Barrientos
Second pass. Change-Id: Ic4702d2ca7a9d54ee4712dcd073006f16b2d5d1d Reviewed-on: https://gerrit.libreoffice.org/11669 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-28Restore missing title in addresstemplatedialog.uiAdolfo Jayme Barrientos
... to what its .src-based equivalent had before fbb1f977 Change-Id: I7db16afe06fca160d798bc1eeac43d6b90c1e1ad Reviewed-on: https://gerrit.libreoffice.org/11667 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-26remove unnecessary casts in misc calls to SvStream.Write*Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ib80032e8626f5476a89b958f590441994594f4e4
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26remove pointless commentsNoel Grandin
Change-Id: I8edfe830b8f6ca7f1809332870e06d1d286b90e8
2014-09-26remove unnecessary casts'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
2014-09-26Resolves: fdo#83943 avoid infinite recursionCaolán McNamara
when attempting to make a cell visible when the parent simply isn't large enough to show any part of the cell Change-Id: I987c9b3be30a66a5e1e27ad9e452f2ca65330d9e
2014-09-23loplugin: cstylecast, update PTR_CAST macro to use static_castNoel Grandin
I introduce a template method into the PTR_CAST machinery to maintain constness. There is now a FIXME in sd/../docshell.cxx because I needed to use a dynamic_cast there to work around the games it appears to be playing with OLE in-place activation. Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, dropping the GCC-extension, unnecessary use of typeof from tools/rtti.hxx Change-Id: Iba5ace1aa27e02b34fcc91af1e658c43371afd03
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-22html: add applyEvents to HTML outputTomaž Vajngerl
Change-Id: I8cc2d752673254c0f23f63030a8fa7d4d288c0a9
2014-09-22Extend HTMLWriter: flush the stack, more values for attribute(..)Tomaž Vajngerl
Change-Id: I733426ba5f82ee25751387f88942dbc66689821d
2014-09-18callcatcher: update unused codeCaolán McNamara
Change-Id: I3010bdd736c15a086f3ce61cacbb34159f0b2abf
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-17add Kven Finnish [fkv-NO] to language list, fdo#83332Eike Rathke
Change-Id: I3faa39ebc32e909bd2e7eeee6ae67c6f3148fb7c
2014-09-17callcatcher: update unused codeCaolán McNamara
Change-Id: I2ddda0600ee876e9886ee3221f0ac5ad515fbd22
2014-09-16Remove shadows in tabs to make them look more flat.Tomaž Vajngerl
Change-Id: I7c125c10538a641ec723d95be987ad77cdebc9ba
2014-09-16Make tab label padding dependent on font height.Tomaž Vajngerl
Change-Id: I7de52945bdf3062174b49e12e2f05075632c7e4a
2014-09-16Change tabs (sheets in Calc) to better looking rectangle shape.Tomaž Vajngerl
Change-Id: Ib0b2812792ac7447bfb1d9e3d4d404bc5d5afb0b
2014-09-14convert Edit autocomplete Hdl to boost signals2Luboš Luňák
Here it also keep track of the connection, as it needs to be explicitly disconnected in one place. Change-Id: Id3e2882106ae55c2d880898956a36f84d3ce70ef
2014-09-13Resolves: fdo#82259 more fonts that lie or have no os/2 tableCaolán McNamara
Seems to be that the default mac fonts are way messy than the MS or Linux ones tend to me Change-Id: Ia0ed6f9fcc650bea9466c4127f6faf7adba72d44
2014-09-13USCRIPT_LAO->USCRIPT_MALAYALAMCaolán McNamara
Change-Id: I5ae275532ccb3e77acd2422f1d6b90078fe95a9e
2014-09-13Related: fdo#82259 GungSeo has no OS/2 tableCaolán McNamara
Change-Id: Idf2431927d8f501f87301d01a7bb884f1445125f
2014-09-13do HardCodedScriptName before getting Font CapabilitiesCaolán McNamara
Change-Id: I3f3f14b3b24abbbdb40f8eb6655d42b12d920999
generated by cgit (git 2.34.1) at 2025-01-19 14:21:44 +0000