summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2016-06-12convert more DBG_ASSERT(false to SAL_WARNNoel Grandin
Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55 Reviewed-on: https://gerrit.libreoffice.org/26195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12convert DBG_ASSERT(false, to SAL_WARN(Noel Grandin
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c Reviewed-on: https://gerrit.libreoffice.org/26187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12remove some unnecessary castingNoel Grandin
Change-Id: I451df09db58256fed68ce8537b2d8eb4b6ab6942 Reviewed-on: https://gerrit.libreoffice.org/26184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-10Convert set of #define to enum class in helpoptXisco Fauli
Change-Id: Ic6c31f810fa9e2ab64390702c85fcb4e3db5fad3 Reviewed-on: https://gerrit.libreoffice.org/26140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-09Try to get rid of svt::ContextMenuHelperMaxim Monastirsky
Change-Id: I7b43e417607b20c300e3c18e7da76a6173a18b7d Reviewed-on: https://gerrit.libreoffice.org/26098 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-08tdf#96099 Remove various smart pointer typedefsMark Page
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f Reviewed-on: https://gerrit.libreoffice.org/26014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08remove "object is disposed" warning in OBroadcastHelperVar::removeListenerNoel Grandin
doesn't add anything of value. Change-Id: Ie2dea7c43570640284771c992d0072ab61de425e Reviewed-on: https://gerrit.libreoffice.org/25871 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08Convert ButtonValue to scoped enumNoel Grandin
Change-Id: Ia882914fb99844f21ce89d7218321933ef084b22 Reviewed-on: https://gerrit.libreoffice.org/26036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06#i124867#: jpg options shows initially wrong estimated file sizeDamjan Jovanovic
File main/svtools/source/filter/exportdialog.cxx ExportDialog::GetGraphicStream() creates the compressed file from which the file size is obtained, calling GetFilterData() to obtain the properties used to save it. GetFilterData() returns image properties, like JPEG colormode and quality, PNG compression/interlacing/translucence, BMP color and RLE coding, etc. In the case of JPEG, the quality is read from maSbCompression.GetThumbPos(). The problem is that in ExportDialog::updateControls(), maSbCompression.SetThumbPos() is called AFTER GetGraphicStream(), meaning the stream is created with the old thumb position. This patches it to call GetGraphicStream() later, immediately before using that stream, so that its properties such as compression are updated first and the size is calculated correctly. Reported by: myspaces at hotmail dot fr Patch by: me (cherry picked from commit 48cf17d5fac7e77aa82caa454cd0f26cd10faaa0)
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f Reviewed-on: https://gerrit.libreoffice.org/25806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02drop some more RTL_CONSTASCII_USTRINGPARAMNoel Grandin
Change-Id: I528b0ecb5282178d8e727471beb126cb7d3f2eb4
2016-06-02loplugin:unuseddefaultparamsNoel Grandin
Change-Id: I0fe173534dc2e70c3d507eae757a91e48a26acfc Reviewed-on: https://gerrit.libreoffice.org/25757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01typo (-Werror,-Wuninitialized)Stephan Bergmann
Change-Id: I26fec96cc5cce0aa400cbdd7a1e706085f9c575a
2016-06-01tdf#89329: use unique_ptr for pImpl in toolbarmenuXisco Fauli
Change-Id: I2adafe082bd83edc31777f11f66313a51fde7d81 Reviewed-on: https://gerrit.libreoffice.org/25478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Convert VCL_MESSAGE to scoped enumNoel Grandin
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933 Reviewed-on: https://gerrit.libreoffice.org/25720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert ControlType to scoped enumNoel Grandin
Change-Id: Iaa13c3e7030296a97bab144103745867d43b4b19 Reviewed-on: https://gerrit.libreoffice.org/25554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31loplugin:unusedmethodsNoel Grandin
Change-Id: Ifeb818227a960cab8fd2e8e7352468efbfe1232c Reviewed-on: https://gerrit.libreoffice.org/25668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert PrinterSupport to scoped enumNoel Grandin
Change-Id: I2bde7261b8e8f31e6dd5a02cd4130156a04b8a7f Reviewed-on: https://gerrit.libreoffice.org/25657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31Convert GfxLinkType to scoped enumNoel Grandin
Change-Id: Iae074ef0927a55f1fbf401cb66f4f183213f547c Reviewed-on: https://gerrit.libreoffice.org/25656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Convert SelectionMode to scoped enumNoel Grandin
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27Convert GRAPHIC to scoped enumNoel Grandin
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea Reviewed-on: https://gerrit.libreoffice.org/25534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26Resolves: tdf#96279 set correct parents for password dialogsCaolán McNamara
otherwise on Dialog::Execute before it becomes visible and a password dialog is needed the new dialog will automatically look for a parent, but will be parented by the main window because the dialog it should be a parent of is not visible yet. Change-Id: Ia34e43d7ef2b204b348f2eb5aab542ee8ffe840e
2016-05-26tdf#89329: use unique_ptr for pImpl in transferXisco Fauli
Change-Id: Ia28a7bd63c8f3a06ef2fd508619bae3a31af450c Reviewed-on: https://gerrit.libreoffice.org/25479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26loplugin:unusedmethodsNoel Grandin
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda Reviewed-on: https://gerrit.libreoffice.org/25431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in addresstemplateXisco Fauli
Change-Id: I3e2cac86101e8a82eefacbe937cf40139fa77090 Reviewed-on: https://gerrit.libreoffice.org/25473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in hyperlabelXisco Fauli
Change-Id: I697eb48591c53ba27c99fc86baa4b8b33e7c9fd1 Reviewed-on: https://gerrit.libreoffice.org/25474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in roadmapwizardXisco Fauli
Change-Id: I37c24d830ae702579fe14ecba627d7f1d363eef6 Reviewed-on: https://gerrit.libreoffice.org/25475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in svlbitmXisco Fauli
Change-Id: If047546c953a5f3bf7af3f99fb7f9d604e0bdba8 Reviewed-on: https://gerrit.libreoffice.org/25476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in svtabbxXisco Fauli
Change-Id: I40a826f6430532769590e6c34d8a98997127fc2e Reviewed-on: https://gerrit.libreoffice.org/25477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in treelistboxXisco Fauli
Change-Id: I5ba1638c905893f62d6d24d7c88cbb66aaa7c786 Reviewed-on: https://gerrit.libreoffice.org/25480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in wizardmachineXisco Fauli
Change-Id: Ie29a95fb913a7141ad6789db236f12c73c283a58 Reviewed-on: https://gerrit.libreoffice.org/25481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in fileviewXisco Fauli
Change-Id: Ief2fd163cc024b4a654a32c24cef832c68ad5e96 Reviewed-on: https://gerrit.libreoffice.org/25482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in inettbcXisco Fauli
Change-Id: I1205acb2823db95cc75c0b559581d278646b616a Reviewed-on: https://gerrit.libreoffice.org/25484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in htmlcfgXisco Fauli
Change-Id: Ic85c082f1e6f6934efbe2c0aa73ee4e5d48c58bf Reviewed-on: https://gerrit.libreoffice.org/25483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#89329: use unique_ptr for pImpl in ivctrlXisco Fauli
Change-Id: Idd525be5934e752c3bed5e2d79c36c2305b4441f Reviewed-on: https://gerrit.libreoffice.org/25485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26Convert MtfConversion to scoped enumNoel Grandin
Change-Id: I694fe139531a10467265b028ad15df0eda6d723a Reviewed-on: https://gerrit.libreoffice.org/25442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25vcl: replace boost::dynamic_bitset with boost::optional<std::bitset>Michael Stahl
The getTTCoverage either leaves the bitset empty or inits it with 128 bits, so it's not particularly dynamic. Change-Id: Iac0aa6a023acc54da86d681e75ca550faf91ef26 Reviewed-on: https://gerrit.libreoffice.org/25456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-25Convert BMP_FORMAT to scoped enumNoel Grandin
Change-Id: I751ab762b6e6f961e9e73a8a2ca92a3f5a5eb1c8 Reviewed-on: https://gerrit.libreoffice.org/25189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25Convert AUTOCOMPLETE to scoped enumNoel Grandin
Change-Id: I201c8f8b41855b2777f0e7131aeaf33cafb82804 Reviewed-on: https://gerrit.libreoffice.org/25438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Convert SnapType to scoped enumNoel Grandin
Change-Id: I3980c2999bab191bb9357c883868db17db79e81f Reviewed-on: https://gerrit.libreoffice.org/25353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24too much debug spew, SAL_INFO thisCaolán McNamara
Change-Id: Ia4e69fa0ffad14564d021b86fdbb0d3d3b8c71b8
2016-05-24Revert "remove some manual ref-counting"Noel Grandin
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24ruler: close the polygon when drawing indent handle (gtk3, gl)Tomaž Vajngerl
Change-Id: I9d1d20f889f73c73a1b861485a956a25f743e245
2016-05-23resort restart reasonsCaolán McNamara
Change-Id: Ie7b57e7f3266f0f1c3576e82de3c949760c2916d Reviewed-on: https://gerrit.libreoffice.org/25358 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-23tdf#99211 Use the restart dialog for notifications about restartirem
Change-Id: I97a10cddafc464ccbdd37902c5d24b73246f5c3f Reviewed-on: https://gerrit.libreoffice.org/24877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>