summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2015-03-27coverity#1267678 this is surely backwards (gold)cp-4.4-branch-pointCaolán McNamara
surely we clone from the source and return the newly created entry. Presumably this doesn't break all the time because aCloneLink is generally set ? coverity#1267678 Resource leak Change-Id: I3e02dfaef371e006f1510b186cdd881c991ef2cf (cherry picked from commit 9f1ecd3ac35f06746fe2a12ca52899f664679de5) Reviewed-on: https://gerrit.libreoffice.org/15022 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-03-07tdf#88847: Fields of query design can be moved to the left onlyJulien Nabet
Part of code 1299 ImplHeadItemList::iterator it = mpItemList->begin(); 1300 ::std::advance( it, nPos ); 1301 ImplHeadItem* pItem = *it; 1302 mpItemList->erase( it ); 1303 if ( nNewPos < nPos ) <-- case move to left 1304 nPos = nNewPos; 1305 it = mpItemList->begin(); 1306 ::std::advance( it, nPos ); 1307 mpItemList->insert( it, pItem ); So in move to right case, we erase and insert pItem at the same place We just have to use nNewPos in all cases regression from bd24a310be1459510b760b812838cb87923853c5 Also add back "ImplUpdate" call erroneously removed in merge commit 67d2af6fac2d9bad52a6b1f6e0cbd1229eb88a42 (there is an ImplUpdate call in each parent of that merge commit) Change-Id: I100b0c6874b366f777c5d38470fcee7a9a7326df (cherry picked from commit 63050dccbc50f148cd788730faa53d822d37e54f) Reviewed-on: https://gerrit.libreoffice.org/14786 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-03-02More improvements of graphic cache size handlingZolnai Tamás
* ImplFillSwappedGraphicObject method is part of the old caching mechanism which interferes with the newer one, so remove this method. * Use Graphic size directly becuase in some case it does not match with the GraphicObject's size. * Assertions to avoid underflow of mnUsedSize Change-Id: I3381f49ca05e3e5d565848c8af24c78e7b9ac3af (cherry picked from commit ab00ac3e88e0a28d0e38c5968c23014a6a8fb194) Reviewed-on: https://gerrit.libreoffice.org/14699 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-11tdf#87303: svtools: relax the security a bit for embedded objectsMichael Stahl
CVE-2014-3575 was about updating linked objects, there is no security issue with embedded objects so always allow updating the preview image for them. (regression from d005acae3aa315921f2c331612131626c470bd22) Change-Id: I6e4d013ddf4fbe08c5968c680bbe143dd0473a4b (cherry picked from commit 6aea0829f8650922f5422f2f2b2e432968d11b9b) Reviewed-on: https://gerrit.libreoffice.org/14424 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-10svtool/GraphicManager: properly decrease mnUsedSize on unregister opsPierre-Eric Pelloux-Prayer
mnUsedSize was never decreased causing the cache to pretending to be full, which caused lots of needless work (image loading, id creation (which are basically a crc of all bytes of an image, ...)) Change-Id: I1e0a6a07631435346c3509822fae43a067d33303 Reviewed-on: https://gerrit.libreoffice.org/14389 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Zolnai Tamás <zolnaitamas2000@gmail.com> Tested-by: Zolnai Tamás <zolnaitamas2000@gmail.com> (cherry picked from commit c7e907f58f8d0791ee304b42de769f43102522e9)
2015-02-09tdf#88836: UI: in-form navigation bar icons goneZolnai Tamás
Regression from: 6419c745e5e9802da264250d5e131fb9a3b6e4de Revert it and use IsEmpty() instead of operator!(). (cherry picked from commit 905d4db48a0b98f540c8abc3e12fb80be4826029) Conflicts: vcl/source/gdi/impgraph.cxx Change-Id: Icc4f5dbba848a1d4ef807e598f0aa3b940459c82 Reviewed-on: https://gerrit.libreoffice.org/14357 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-01-19fdo#88475 BrowseBox/grid: reposition data cursor to current row after paintLionel Elie Mamane
Squash with (from master): fixup previous commit: OSL_ENSURE does not execute in non-debug builds (and is deprecated). Do not try to seek back if paint did not seek. This happens in particular when there is no data source attached (and thus trying to seek fails). Change-Id: I3f4908c4dcae2bb120bf58c1218e3386c40d5721 Change-Id: I0deee2c3cfdb111b178c4254d7b0544c4ce5c966 Reviewed-on: https://gerrit.libreoffice.org/13953 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-25fdo#87596 Draw tab fill color when selected on the tab bottomTomaž Vajngerl
Change-Id: I02bcdf88063d272cb9eb9e89cbee61d30f4f01d6 (cherry picked from commit 2a20bf5105181d51aab40bdd4ce8c09615a0e599) Reviewed-on: https://gerrit.libreoffice.org/13648 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-12-22fdo#56970 Show insert tab at the correct position when RTL is onTomaž Vajngerl
Change-Id: I1e7e751123fa3c3f365e5342211a0b75395a1711
2014-12-17Tab bar: multiply the size of the plus icon if HiDPI is detectedTomaž Vajngerl
Change-Id: I6efaac9bd21ab986af77fed1a949d3d2b380e922
2014-12-16OneDrive binding settingsMihai Varga
Change-Id: I72c97931098c1a029d39532e3433c0aeaba73e3f (cherry picked from commit fc1bfd9e6d774917bd90d67b1135402d2d33ef6b)
2014-12-11Remove resizable:False property from dialogs containing GtkEntry.Jan Holesovsky
As agreed with Adolfo (and others) at the Design hangout on 2014-12-10. Change-Id: Ibe0e8075566523e746866b9d2c15c348c345d2df
2014-12-03rulers: Make the numbers a bit smaller, and always with odd size.Jan Holesovsky
Change-Id: Id27bb0435d00f2026ff8c82ed246ca67947e9e42
2014-11-27don't access contents of empty string, e.g. with kde96709-1.htmlCaolán McNamara
Change-Id: Ifa6db0dc7b5c67b65c5bc17c16fb3a61793c833a (cherry picked from commit 69a16331d0c60ae3d0f376d2265e83ab805ec13b)
2014-11-22fdo#86573: Impress does not show pictures anymoreZolnai Tamás
Regression from: 286e2f5c6ec829bc0987b1be7016699f7ef03e5e Sometimes SdrGrafObj import the image file just as a preview (with low resolution) and late when the real picture is needed it just throws this preview and tries to load the image again. This preview works only with package URL so in this case we should not forget that URL. Plus two other related potential image loss situation: - SetUserData() is called with empty image URL - Image preview is thrown when we actually have no package URL from we can import the image again. Change-Id: Ib21f400eb6d28133e8598e6b201209e5dd1a976f (cherry picked from commit f0b28806eebb1477066d44de49b5d1d61a8e84cf)
2014-11-22Don't use a hard coded limit for size based auto swap out.Zolnai Tamás
Now the graphic cache settings shows the real memory usage for the users, so we can bequeth the decision of the limit to them. Default is 200 MB. See also: dbdacc73ae154237314d599194cc686bd738a9bf Change-Id: I463d31254f6f1836e1584d5acd692f38a97bfe39 (cherry picked from commit a87b1b07b91960601c7f39e2b40eba8ad50b1667)
2014-11-20Dispose document when doneStephan Bergmann
Change-Id: I7b15220568717e159f119e79da0016cbc88873cf
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18Missing parenthesesZolnai Tamás
Change-Id: Id6c096d09b984039d54a1d152cf0da594aaf203d
2014-11-18This test become unreferenced by accidentZolnai Tamás
See: c454a0cd0cc7b315b1353b151a2e95654df72c69 and 46eb0952f1e2d75b427bdcd553c33027f1e44e8f Change-Id: I811f1c52f8a9fba28bc4f38fd1ad34826b2bd45e
2014-11-18Fix broken GraphicObjectTestZolnai Tamás
Change-Id: I3f7e0ccd5697a4ca6026bec60210e24af25fb92f
2014-11-18Be precise here, maximum value means it is still allowed to haveZolnai Tamás
Change-Id: I90c559c59b307aac6f7adac49ea38b0d9b68ad58
2014-11-18Be honest about the maximum cache sizeZolnai Tamás
Implementation uses a multiplicator of ten. I guess the intention here was that to calculate cache size based on the size of the inserted images and not based on the real memory usage (potentionally more instances of one image), which seems a bad idea because it covers the real memory usage from the users (who will be suprised when LO's memory usage increases tenfold of the set value). It seems better to use the exact value in the implementation and increase the default value on the user interface instead. Change-Id: Ie3c0568d3518922d3a9931f894eebb9e7e5515ed
2014-11-17loplugin:unreffunStephan Bergmann
Change-Id: Ifc7377fe1bb68b21e462818248706f53347b39b1
2014-11-17WaE: unused variablesTor Lillqvist
Change-Id: I82570a716a0dba6c466bc754ce66ac53e7c17efa
2014-11-17WaE: Unreferenced function definition [loplugin:unreffun]Tor Lillqvist
Change-Id: I55d6d1d403622e5ec04c29dd407274cf9db20c40
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17"#pragma hdrstop" looks quite obsoleteMichael Stahl
Change-Id: Id4b01f02d5d90215164c07b8076498df65978fa3
2014-11-16Test for size based auto swap out mechanismZolnai Tamás
Change-Id: Iff0942b9b545f27dd74b73bee3f8ac785539867d
2014-11-16vcl: let the ModalDialog ctor take an OUStringMiklos Vajna
Change-Id: I839435338f4acf80c40896b6c86f7ef122f5449d
2014-11-14coverity#1242527 Arguments in wrong orderCaolán McNamara
doesn't seem to matter too much, I guess its only the top left corner that really matters for tooltips. This is the vertical scrollbar as used in e.g. writer->view->datasources Change-Id: I5bd6e563a9f02edae9ca166f073556c55878826c
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-13coverity#1251580 Unchecked return valueCaolán McNamara
Change-Id: I5dcbd2289fc853bad2c0969fb3b202a1e7398a5a
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-09fdo#86050 Let LibreOffice add scrollbars to widgets only when necessaryAdolfo Jayme Barrientos
Change-Id: I1a930a413c071d4d0c8855315dc85339e01b7d9b Reviewed-on: https://gerrit.libreoffice.org/12322 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-07Update notes about swappingZolnai Tamás
Change-Id: I6b9f5f9c4a0bc87376a469835a50dc2cf598479e
2014-11-07Optimize ImplCheckSizeOfSwappedInGraphics() a bitZolnai Tamás
Store used size as a member so we don't need to recalculate it all the time and no need to use a size map. Change-Id: I1f929c5d3a56f545cef123bda087ecaf8ca0be4a
2014-11-07Why to have this compromise, do that what we say the users we do.Zolnai Tamás
Change-Id: Ia599644ff1f7591ac84bdca988883eaf5860297e
2014-11-07Swapping Graphic is a privilage of GraphicObject.Zolnai Tamás
This means more things: * Graphic won't swap out itself, so those classes which uses Graphic without GraphicObject won't need to deal with swapping. * When a Graphic is queried from GraphicObject the caller won't need to deal with swapping, because GraphicObject swaps it in before return. * GraphicObject will swap in the Graphic always when a swapping dependent data is queried (e.g. whole graphic, transformed graphic or AnimationNotifyHdl) Change-Id: I2bf6e37291ec94146f10aac4a35084682437ed16
2014-11-07Paint background images always via drawinglayerZolnai Tamás
Painting via GraphicObject is obsolete. See fdo#68927 where the problem was the quality of svg graphics, it seems a good idea to extend this improvement to all graphic type. Change-Id: I57a26d4fcfea8e4f666504a90281365e8a9a7e1d
2014-11-07Remove these useless static bool variables.Zolnai Tamás
Change-Id: I7a8ad7814231f129d5d1146ceb36eb2c22b2aff1
2014-11-07Ignore the swapped in graphic, but use its sizeZolnai Tamás
Change-Id: I75f17ab5e55119965fcede2b220979cefc1e26ab
2014-11-07Assign graphic data also during auto swap inZolnai Tamás
Change-Id: I09b8d11027f4a1e8470b81677388d4a573b372a6
2014-11-07Avoid an image loss situation of auto swappingZolnai Tamás
Before an image data is used GraphicObject should be swapped in. When a GraphicObject is swapped in auto swapping mechanism is triggered which can swap out some of the images. We should avoid to swap out the same image on which the swap in method was called before because the caller code assumes that the image data is there. Change-Id: Ia4addc370742aea5fbf185cf87e3c062a5ebf5be
2014-11-07Make SetSwapState() an internal methodZolnai Tamás
So we can be sure it is always called when user data changed. Change-Id: If107907afffb85a7a57817f5807847a5c028416c
2014-11-07Avoid using null pointer as a special indicatorZolnai Tamás
When ImpGraphic::ImplSwapOut() is called with null pointer it was assumed that it is becase the graphic is a link and so we don't need to swap out it actually (we can load it anytime using the link), only clear the graphic's internal data. The problem with that it can happen that ImplSwapOut() is called with null pointer accidentally on a non-link graphic object which leads to that we loose the graphic. Seems more robust to use an explicit indicator (GRFMGR_AUTOSWAPSTREAM_LINK) for links swapout. indicator Change-Id: Icf31524a192c7866278ba6a13eb85648aa69f554
2014-11-07Always call ImplAfterDataChange() when data is changedZolnai Tamás
Call it inside ImplAssignGraphicData() which assign GraphicObject members using Graphic's data. With that ImplAfterDataChange() method also called in constructors. It's important to call ImplAfterDataChange(), because this will trigger the auto swaping mechanism. Change-Id: I45af91f8df2fb5b0143fcc5eb05e82e4d408d0bc
generated by cgit (git 2.34.1) at 2024-05-30 04:53:43 +0000