summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2017-11-23Make loplugin:unnecessaryparen look through implicitStephan Bergmann
...similar to how <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent" does for loplugin:simplifybool Change-Id: I23eef400af71c582d380c9bae6546ce06e8a1e18 Reviewed-on: https://gerrit.libreoffice.org/45122 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22replace check of eof and GetError with goodCaolán McNamara
Change-Id: I7d9f04262ab5420e9a14813fa1274bb9d01e3291 Reviewed-on: https://gerrit.libreoffice.org/45076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22drop duplicate methodCaolán McNamara
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22loplugin:flatten in svtoolsNoel Grandin
almost completely automatically rewritten, only had to tweak the indentation on a couple of lines. Change-Id: Ieec92e5b602d180d7ec556e3421ce3c835c1f646 Reviewed-on: https://gerrit.libreoffice.org/45072 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22loplugin:simplifybool re-activate the !! warningNoel Grandin
Change-Id: Iac7d82a1c228734177be536e9a6c41803c03637b Reviewed-on: https://gerrit.libreoffice.org/45035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21Render lock symbol with sheet name, tdf#95880 follow-upEike Rathke
Visually somewhat cleaner, plus may have benefits in RTL context or could be easier adapted. Change-Id: Iec75879e05c9c6bb602d3a368fb8eba59d1c8a13 Reviewed-on: https://gerrit.libreoffice.org/45012 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-11-20tdf#95880 Add a lock mark on protected sheet tab.Gulsah Kose
Change-Id: Ic9ec598d9bfdf98336cc4a11af21502ca7a1e4fb Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/44558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-19clang-tidy modernize-use-equals-default in svtoolsJochen Nitschke
no need to explicit delete SvtScriptedTextHelper_Impl assinment operator because it's implicit deleted anyway. Change-Id: I8463345e9035fc0466a22ed6648eb5b2614ed1b5 Reviewed-on: https://gerrit.libreoffice.org/44927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15drop now unused ToolPanelOptCaolán McNamara
Change-Id: I26c93567f58b7b459eedbad85b5f3bfe554c8557 Reviewed-on: https://gerrit.libreoffice.org/44769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-14Resolves: tdf#113835 add Fon [fon-BJ] to language listEike Rathke
Change-Id: Iee741421d8f6a9a2b9b14439612890426cdf4712
2017-11-14Fix typosAndrea Gelmini
Change-Id: I53b47cab5cbc603bf11adcda8ac2a8373eef26a8 Reviewed-on: https://gerrit.libreoffice.org/44695 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-13SotClipboardFormatId::STRING_TSVC "Unformatted text [TSV-Calc]", tdf#113571Eike Rathke
In preparation to solve tdf#113571 *AND* keeping tdf#32213 fixed we need two separate unformatted text formats to distinguish between in-Calc on-cell paste and external or in-cell paste. Change-Id: Ic81a0c17d0643af2f5f4be50e67b690fd8846388
2017-11-11A user object id is *NOT* a SotClipboardFormatIdEike Rathke
Do not try to squeeze it into such.. especially if SotClipboardFormatId::... enum identifiers are used in a user object id context that is completely not related to the identifier name this is totally confusing. commit fb14be5f8f74f83ba89e15f891ddf1f753dcc62f Date: Thu Mar 12 14:53:28 2015 +0200 create new 'enum class' SotClipboardFormatId to unify types overdid with that. Change-Id: I34b570be9f52b7b94ca8af6b23983393ac3a3a55 Reviewed-on: https://gerrit.libreoffice.org/44612 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-09rename AvoidConfig to FuzzingCaolán McNamara
cause that's what its really used for and a couple of cases are not specifically about avoiding config but avoiding uninteresting disk acccess and what not Change-Id: I4c6454f98388579fcd0bf9798321d30408ab65ee Reviewed-on: https://gerrit.libreoffice.org/44491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-08ofz#4115 Integer-overflowCaolán McNamara
Change-Id: Ibeb62c6df8fe1e200b97ea179d747e735a4ebf3a Reviewed-on: https://gerrit.libreoffice.org/44451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-08ofz#4113 Null-dereference READCaolán McNamara
Change-Id: If586bd265e323b5c2a308c2e853456c2778e8cb0 Reviewed-on: https://gerrit.libreoffice.org/44448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-06ofz infinite loopCaolán McNamara
Change-Id: Iae9faaa86e4b3edb9a1fdfe9c6b67eee211c19a9 Reviewed-on: https://gerrit.libreoffice.org/44361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-06ofz infinite loopCaolán McNamara
Change-Id: I9eab92f72618a062455e9e17d9a262f28d8bb740 Reviewed-on: https://gerrit.libreoffice.org/44332 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-05Replace remaining lists by vectors in svtoolsJulien Nabet
Change-Id: I3b85f4853d305fec2efe1fa351466c56d11473c9 Reviewed-on: https://gerrit.libreoffice.org/44303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03[API CHANGE] tdf#65393 Import signature line images from ooxmlSamuel Mehrbrodt
showing whether the signature behind the signature line is valid or not. Change-Id: Ia6cca62812019f26d55d234cac767a9b4b7c8175 Reviewed-on: https://gerrit.libreoffice.org/40980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-03loplugin:constparam in vcl,svtoolsNoel Grandin
Change-Id: I7a3eb2bfda869e9e66db919f929ead60cf8890a4 Reviewed-on: https://gerrit.libreoffice.org/44209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03ofz: crash with empty aParserStatesCaolán McNamara
Change-Id: Ie3f327605ce795da30f915969177f21a7d38824c Reviewed-on: https://gerrit.libreoffice.org/44232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-03vcl: remove sgf/sgv ancient gfx filtersThorsten Behrens
Change-Id: Ib02986e5b3d54d65982836e22ebcb70eb7a0e7b3 Reviewed-on: https://gerrit.libreoffice.org/44216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-03Infinite loop in ooo32227-1.rtf with calc rtf filterCaolán McNamara
Change-Id: I068b205c844296379b5641356e4087b17f0a3535 Reviewed-on: https://gerrit.libreoffice.org/44218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-31loplugin:constantparam in svl,svtoolsNoel Grandin
Change-Id: I0d7c1dff2646e483c866f547224c60838b221c4b Reviewed-on: https://gerrit.libreoffice.org/44083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30loplugin:constantparam in vclNoel Grandin
Change-Id: Ic32e4098dcdae5ca5d7fe2749badedabda86a90d Reviewed-on: https://gerrit.libreoffice.org/44043 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-28Related tdf#95694: Enable papersize & orientation listboxesKatarina Behrens
when called from File > Printer Properties > Properties. Anything else doesn't make sense, user opens this dialog in order to be able to edit the settings Change-Id: I9559829551e6d6144da972757ab98afa5696bbfa Reviewed-on: https://gerrit.libreoffice.org/43823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-26vcl: make MapMode constructor explicitMichael Stahl
Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988
2017-10-26rename createOnShotInstance->createOneShotInstanceNoel Grandin
Change-Id: I8848784cd867714019f90bb7fc57ca7289e51f81 Reviewed-on: https://gerrit.libreoffice.org/43873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26Use the canonical abbreviation "pc" of pica, instead of "pi"Takeshi Abe
like as fixed at 8a5b178eb9f680fadcc8faa2e277623e8304b723. This change affects e.g. the string of the tooltip appearing when changing document margin in Writer by dragging ruler, after choosing pica as the unit in context menu. Change-Id: I55d2cea8b30016e2578c6a112f54e26d62741b44 Reviewed-on: https://gerrit.libreoffice.org/43819 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-10-26Refactor font substitute removing (vcl/svtools)Julien Nabet
+ replace list by vector for maFontSubstList Change-Id: I4d5668611212358c759fa5cf26f5341311551298 Reviewed-on: https://gerrit.libreoffice.org/43855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26Fix memory leakTakeshi Abe
Change-Id: I2638a8440601264ff00221ead28a71c891abae16 Reviewed-on: https://gerrit.libreoffice.org/43860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-24loplugin:finalclasses in svtoolsNoel Grandin
Change-Id: I596342a3d32e116ac5994b60a5bd8717d4f6a5dd Reviewed-on: https://gerrit.libreoffice.org/43733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-24tdf#113368: fix crash when closing dialog opened with BasicJulien Nabet
See bt https://bugs.documentfoundation.org/attachment.cgi?id=137222 3 0x00007fffebe196b7 in vcl::Window::GrabFocus() (this=0x0) at /tinderbox/buildslave/source/libo-master/vcl/source/window/window.cxx:3003 4 0x00007fffee473602 in FileControl::GetFocus() (this=0x28760b0) at /tinderbox/buildslave/source/libo-master/svtools/source/control/filectrl.cxx:177 5 0x00007fffebe1c99b in vcl::Window::CompatGetFocus() (this=0x28760b0) at /tinderbox/buildslave/source/libo-master/vcl/source/window/window.cxx:3694 6 0x00007fffebd62672 in vcl::Window::ImplGrabFocus(GetFocusFlags) (this=0x28760b0, nFlags=GetFocusFlags::NONE) at /tinderbox/buildslave/source/libo-master/vcl/source/window/mouse.cxx:377 7 0x00007fffebe196b7 in vcl::Window::GrabFocus() (this=0x28760b0) at /tinderbox/buildslave/source/libo-master/vcl/source/window/window.cxx:3003 8 0x00007fffebe0bfc5 in vcl::Window::dispose() (this=0x28778b0) at /tinderbox/buildslave/source/libo-master/vcl/source/window/window.cxx:449 9 0x00007fffebe6536c in Control::dispose() (this=0x28778b0) at /tinderbox/buildslave/source/libo-master/vcl/source/control/ctrl.cxx:65 10 0x00007fffebe6a4b6 in Edit::dispose() (this=0x28778b0) at /tinderbox/buildslave/source/libo-master/vcl/source/control/edit.cxx:265 11 0x00007fffebfa5ac0 in VclReferenceBase::disposeOnce() (this=0x2877bc8) at /tinderbox/buildslave/source/libo-master/vcl/source/outdev/vclreferencebase.cxx:42 12 0x00007fffee41f948 in VclPtr<Edit>::disposeAndClear() (this=0x28762c0) at /tinderbox/buildslave/source/libo-master/include/vcl/vclptr.hxx:208 13 0x00007fffee472f0e in FileControl::dispose() (this=0x28760b0) at /tinderbox/buildslave/source/libo-master/svtools/source/control/filectrl.cxx:89 Change-Id: I97fd3679a8692893047c22ff3e452a5c3e3f25c3 Reviewed-on: https://gerrit.libreoffice.org/43731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-23loplugin:includeform: svtoolsStephan Bergmann
Change-Id: I7a25c2db8c097ae4512c8a8b7d8a272905b46e50
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-21loplugin:redundantcast handle dynamic_castNoel Grandin
Change-Id: I7855c76e820efce96778b1c19ec71dffcc4b4abb Reviewed-on: https://gerrit.libreoffice.org/43621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-20svtools: SvTreeListEntry's copy ctor is unnecessaryTakeshi Abe
Change-Id: Idce8773d96e30dacfc9ce13fdb9b399c2a8bf341 Reviewed-on: https://gerrit.libreoffice.org/43485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-18use std::unique_ptr in SvTreeListNoel Grandin
Change-Id: Ibfba32d6855532aeb42c45f493a4f01f7d0cd4ee Reviewed-on: https://gerrit.libreoffice.org/43475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-06use rtl::Reference in SvXMLEmbeddedObjectHelperNoel Grandin
instead of manual ref-counting Change-Id: I559ebb3871dd3dd4a160bd83a259e36dd2f7b4d6 Reviewed-on: https://gerrit.libreoffice.org/43200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-06Revert "remove handing of deprecated Storage path option"Noel Grandin
This reverts commit b71fdc67ed1efd421b9b1c747708958e8e09f73c. since Jochen indicates that there is a bug in it Change-Id: I786a7885a308cb43b99d9930ed385a75bbcd9495 Reviewed-on: https://gerrit.libreoffice.org/43192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-05remove handing of deprecated Storage path optionJochen Nitschke
The only user of StoragePath was TemplateFolderCacheImpl::openCacheStream which uses TempPath for the cache file now. Change-Id: Ia21b5aa804222f28a3af3779a0ecc4789c1860b3 Reviewed-on: https://gerrit.libreoffice.org/41087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-03convert TPB_DISPLAY_NAME constants to scoped enumNoel Grandin
Change-Id: I0e4f9ce3392e48fc82c232ba3e6581f3b0d9af9f Reviewed-on: https://gerrit.libreoffice.org/43083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03new loplugin:blockblockNoel Grandin
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-01simplify some OUString compareTo callsMuhammet Kara
to either startsWith or == or != Change-Id: I595dd9d89d32134827980c4ba10f88584430137d Reviewed-on: https://gerrit.libreoffice.org/42988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-01Resolves: tdf#112656 don't reset to default font if a custom font was setCaolán McNamara
the list has been laid out with the smaller custom font, including calculating the bounding box of the entry, then rendered with the default larger font Change-Id: I2ae569c9857d4e1016cbf55da4c3334c63dcf5f6 Reviewed-on: https://gerrit.libreoffice.org/42910 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-09-30Translate German comments and debug strings (leftovers)Johnny_M
Change-Id: I4ab8fbae47037f6e21c51713d1c51aaa5dc61f40 Reviewed-on: https://gerrit.libreoffice.org/42967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-05 04:11:50 +0000