summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2016-10-24tdf#103259 Add java not found error for macYousuf Philips
Change-Id: Ia52316b8868c8124dcb322b44e9600a33a13df28 Reviewed-on: https://gerrit.libreoffice.org/29920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-23Rovas is not a language, it's a scriptAndras Timar
Change-Id: I55f3076926891b48321c943bd0090b9b747f663d Reviewed-on: https://gerrit.libreoffice.org/30174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-10-21loplugin:expandablemethodds in include/svtoolsNoel Grandin
Change-Id: I679b7985861203496813782138d1cf965fbc427b Reviewed-on: https://gerrit.libreoffice.org/30107 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20loplugin:expandablemethodds in svxNoel Grandin
Change-Id: I45447b6f5cf7e17d6e81e8c931b07b26d41b9a8c Reviewed-on: https://gerrit.libreoffice.org/30057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19'>>=' with rhs Any is a copy assignmentJochen Nitschke
replace '>>=' operator with '=' where return value is not checked and simplify. (note: switches lhs with rhs) Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8 Reviewed-on: https://gerrit.libreoffice.org/30004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19replace <<= with assign for <<= with rhs AnyJochen Nitschke
queryAggregation and queryInterface return Any Change-Id: Ib8e3e742bd66f7419cad583988b247bb628f7b4a Reviewed-on: https://gerrit.libreoffice.org/29912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18loplugin:unusedmethodsNoel Grandin
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-15clang-cl loplugin: svtoolsStephan Bergmann
Change-Id: I3271529ffe48ebafd203b759a72741a9bdbba506 Reviewed-on: https://gerrit.libreoffice.org/29846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14loplugin:countusersofdefaultparams in sot..svtoolsNoel Grandin
Change-Id: Ifce19de3518f3eaf5a1b6439f9053feee4a33c14
2016-10-13move this monstrosity to the last place its usedCaolán McNamara
Change-Id: I4691f20143406249afc8da1a6dfa901224f4a62d
2016-10-12no Browse is loaded from .src anymoreCaolán McNamara
Change-Id: I72e87433fef1a27c6bcac2746d9d366335797800
2016-10-12no EditBrowseBox is loaded from .src anymoreCaolán McNamara
Change-Id: I70c4cfa85a4a4379ee80e73066193676ca83b5b0
2016-10-11improve comment about non-BMP code points in RTFMichael Stahl
Change-Id: If906fdea692ca4a4df4f7110f42b7360d8b845da
2016-10-11Comment about state of non-BMP Unicode chars in RTFStephan Bergmann
Change-Id: I90051425c52f42f69cd61436979a50b875cca710
2016-10-11remove some conversion operator methodsNoel Grandin
which, in these cases, only serve to make the code harder to read Change-Id: Ic9bcf42545b4fcfd60a535fb63956092d392f469 Reviewed-on: https://gerrit.libreoffice.org/29685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11loplugin:unnnecessaryoverride in svtoolsNoel Grandin
Change-Id: I49773d9054205c223744495768e1cb05dd7b087d Reviewed-on: https://gerrit.libreoffice.org/29671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-07Fix mis-merge in commentStephan Bergmann
...introduced with bf3caf8afaec110857a32cd129ee9d85fcb24970 "INTEGRATION: CWS adarefilterteam29: #i20264# Applied patch from tono@openoffice.org for writing in local charsets" Change-Id: I411af51f447f820dfd4a85506d6e12dbff8f298f
2016-10-07Clean up RTFOutFuncs interfaceStephan Bergmann
Change-Id: I934f2375474035504b4ba9612af4f45a7d05ce9b
2016-10-07New rtl::splitSurrogates, remove code duplicationStephan Bergmann
Change-Id: Ic96b64244f817196ccdfe06b97f7f31291adf372
2016-10-07Minor performance improvement of previous patchStephan Bergmann
Change-Id: Ia6c9d4ab15a81c6afd051f24e50983bc2af6d019
2016-10-07rhbz#1382401: Support surrogate pairs in HTMLOutFuncsStephan Bergmann
Change-Id: Ib578f758e4f5f355a79a014c2ad4660924dd34a4
2016-10-07loplugin:staticmethods: svtoolsStephan Bergmann
Change-Id: I0d44473c34131d7e843a40ade7261c0022104bfa
2016-10-07merge copies of flushing code togetherCaolán McNamara
and give it descriptive name cause it confused me as to what it did Change-Id: I37b761ab917a75c8364db9c3f7b4896c2dd217bc
2016-10-07might as well rearrange these flushes to all look the sameCaolán McNamara
no logic change intended Change-Id: I0f2552ad604d83eea46822aba137cc780c3be60a
2016-10-07for 0 len arg, the source might as well be nullptr for these flushing casesCaolán McNamara
Change-Id: I59a3c04d0cbeb92cd0d9348c2ed0cf65cb5683d4
2016-10-06I can't see any evidence of any remaining magenta mask using image resourcesCaolán McNamara
Change-Id: I12865d743daa3e6479edb60584d5bd01f88e818d
2016-10-06ImageList just reads and discards the MaskColor, so drop itCaolán McNamara
Change-Id: I243e739fea28e3f38b91534182cc54c2aa660f0e
2016-10-06these other IMAGE_STDBTN_COLOR defines do nothingCaolán McNamara
Change-Id: If35bd52f973dc89b05afd283a4a89998c491b862
2016-10-05convert the last two lonely FixedInfos to FixedTextCaolán McNamara
Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
2016-10-05Split some stuff from ToolbarMenu to a base classMaxim Monastirsky
i.e. implement "todo: move to new base class that will replace SfxPopupWindow" Change-Id: I1b300e1e0c6423bf27d9dae7d75703b988afb154
2016-10-05PopupWindowController: Tearoff supportMaxim Monastirsky
Change-Id: I2baaaa13f3d127dc1619c971b66091d3326fafbc
2016-10-05PopupWindowController: Small cleanupMaxim Monastirsky
Change-Id: Iedbc8ddaf97f515fecc012322f0c1621317de076
2016-10-05PopupWindowController: Use ImplInheritanceHelperMaxim Monastirsky
Change-Id: I82b9ebf69b6b35b3a5e1e8a5dc5bb84eff1feb19
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-01Fix typosAndrea Gelmini
Change-Id: I9701cc93a9f4315e71c133237fdd96ef6964c8ff Reviewed-on: https://gerrit.libreoffice.org/29438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01svtools: don't store "vcl" Graphic as a pointerTomaž Vajngerl
Change-Id: Icf8a5fa72ef66659bbc9c70355d430ff6bf545fc Reviewed-on: https://gerrit.libreoffice.org/29412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-09-30loplugin:constantparamNoel Grandin
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c Reviewed-on: https://gerrit.libreoffice.org/29321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-29fix the buildMarkus Mohrhard
Change-Id: I95d98ec792c8741ee9d22ff174b388bb59cc7638
2016-09-29add introspection support for SvSimpleTableMarkus Mohrhard
This is the second part of the UI test tutorial. The tutorial shows how to add introspection support to a new vcl::Window based UI object. Change-Id: I2b3ed68d313749787869c7e85f2e27c9d01fff4a
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-22loplugin:unusedmethods in chart2..svxNoel Grandin
Change-Id: Ifb6045885049733415895f58cdd911256f48323c Reviewed-on: https://gerrit.libreoffice.org/29187 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22Remove NumberFormatCodeWrapperMaarten Bosmans
This class only adds a level of indirection, without any useful functionality. Change-Id: I806e1b9241caf025c62c12c93aad3101daac874a Reviewed-on: https://gerrit.libreoffice.org/29134 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20loplugin:unusedfieldsNoel Grandin
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24 Reviewed-on: https://gerrit.libreoffice.org/29078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16loplogin:singlevalfields in include/Noel Grandin
Change-Id: I27842162fcf82120ecb811ee8e89e187430931fc Reviewed-on: https://gerrit.libreoffice.org/28931 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15Make sure some history is preserved for posterityTor Lillqvist
Change-Id: Ie74f12ee6fda9f8bcba540d52ce7ec53236998bf
2016-09-15Make OGenericUnoDialog::destoryDialog non-virtualStephan Bergmann
...it is only ever called: * either from dtors, where the virtual-ness doesn't acutally help (and would trigger loplugin:fragiledestructor if that were enabled) * or, in module filter, from executeDialog members of (final) classes directly derived from OGenericUnODialog without overriding destroyDialog Change-Id: If9a7370385a27952189423e5632b3f01e18ddbb5
2016-09-14cid#1372878 modulo by zeroNorbert Thiebaud
Change-Id: I37ed251597f44d382fde96c39ff9d07e4d14c50a Reviewed-on: https://gerrit.libreoffice.org/28859 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-09-13tdf#74377 Keyboard shortcuts for context menusMaxim Monastirsky
Configurable through the options dialog. The default behavior depends on the current vclplug (hide for gtk2/3 and OS X, show otherwise). Menus currently affected by this change: - SfxDispatcher based context menus - chart2 context menus - vcl's Edit control context menu - Several MenuBarManager based toolbar dropdowns. Change-Id: Iad9fb99dc90e01c17cba9c07c1a2b262b920e11d Reviewed-on: https://gerrit.libreoffice.org/28849 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>