summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-09svtools: Simplify ImageMap with std::unique_ptrTakeshi Abe
Change-Id: I49b3c21ff4d8177fb75197d6641040be0ace6324 Reviewed-on: https://gerrit.libreoffice.org/46149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08loplugin:salcall vcl builder methodsNoel Grandin
these don't need to be SAL_CALL, and the function pointer definition was not annotated SAL_CALL either Change-Id: I3082d3d34c53dc723ad8d2083010fd0de0e89a1e Reviewed-on: https://gerrit.libreoffice.org/46067 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-04Add Plautdietsch [pdt-CA] to language listboxEike Rathke
Change-Id: Icf2307649858721a7cde38e8fa892fc3cb1ff08c
2017-12-04new loplugin salcall: remove unnecessary SAL_CALLNoel Grandin
In this first commit, I use the plugin to verify the consistency of our SAL_CALL annotations. The point being to make the next commit more mechanical in nature, purely using the rewriter. There are various chunks of unix-only code that have never had to be compiled by MSVC, hence the inconsistencies. In bridges, I had to inline some typedefs to make the verification code happy, since it cannot see into typedefs. Change-Id: Iec6e274bed857febf7295cfcf5e9f21fe4a34da0 Reviewed-on: https://gerrit.libreoffice.org/45502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-01tdf#102160 make 'Other CMIS' string localizableAndras Timar
Change-Id: I58cf9eea05f15223e32ff1542b946c5962041e6c Reviewed-on: https://gerrit.libreoffice.org/45577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-12-01tdf#114098 Show vertical scrollbarXisco Fauli
Change-Id: I03b94d6860e559a4074a3a23fcc0407f22c21df4 Reviewed-on: https://gerrit.libreoffice.org/45686 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30tdf#114124 Translate 'PNG Bitmap' string in Calc Paste dropdownGabor Kelemen
Change-Id: I8356f241d0742276cf32aa301c35055a7f3c5898 Reviewed-on: https://gerrit.libreoffice.org/45447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30loplugin:unnecessaryparen: signed numeric literalsStephan Bergmann
Change-Id: I75c8224452ca9c3711a2ccaca9ecf549fa59cb64 Reviewed-on: https://gerrit.libreoffice.org/45549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-29tdf#111801 added hover state to tabledesign sidebarKshitij Pathania
Change-Id: I1ceb806c6423964346c97d7b1ef6dcac46698902 Reviewed-on: https://gerrit.libreoffice.org/42882 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-11-28loplugin:countusersofdefaultparams in sfx2..svtoolsNoel Grandin
Change-Id: I65ae5305f9cec14069fd7aef6613e981dbbed846 Reviewed-on: https://gerrit.libreoffice.org/45382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-27loplugin:unnecessaryparen: Warn about parentheses around literalsStephan Bergmann
...that are not composed of multiple tokens, like ("foo" "bar"). Also don't yet warn about Boolean literals, which are sometimes wrapped in parentheses to silence unreachable-code warnings. To avoid multiple warnings about code like f((0)) switch to generally using a set of ParenExpr to keep track of which occurrences have already been handled. Change-Id: I036a25a92836ec6ab6c56ea848f71bc6d63822bc Reviewed-on: https://gerrit.libreoffice.org/45317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27loplugin:unnecessaryparen check for (f1()).f2Noel Grandin
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-25coverity#1421068 Uncaught exceptionCaolán McNamara
see if using copy ctor rather than default dtor keeps it happy Change-Id: I539271a569fa769a4cb33f71b8bf871dee810abf Reviewed-on: https://gerrit.libreoffice.org/45248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23Make loplugin:unnecessaryparen look through implicitStephan Bergmann
...similar to how <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent" does for loplugin:simplifybool Change-Id: I23eef400af71c582d380c9bae6546ce06e8a1e18 Reviewed-on: https://gerrit.libreoffice.org/45122 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22replace check of eof and GetError with goodCaolán McNamara
Change-Id: I7d9f04262ab5420e9a14813fa1274bb9d01e3291 Reviewed-on: https://gerrit.libreoffice.org/45076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22drop duplicate methodCaolán McNamara
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22loplugin:flatten in svtoolsNoel Grandin
almost completely automatically rewritten, only had to tweak the indentation on a couple of lines. Change-Id: Ieec92e5b602d180d7ec556e3421ce3c835c1f646 Reviewed-on: https://gerrit.libreoffice.org/45072 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22loplugin:simplifybool re-activate the !! warningNoel Grandin
Change-Id: Iac7d82a1c228734177be536e9a6c41803c03637b Reviewed-on: https://gerrit.libreoffice.org/45035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-21Render lock symbol with sheet name, tdf#95880 follow-upEike Rathke
Visually somewhat cleaner, plus may have benefits in RTL context or could be easier adapted. Change-Id: Iec75879e05c9c6bb602d3a368fb8eba59d1c8a13 Reviewed-on: https://gerrit.libreoffice.org/45012 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-11-20tdf#95880 Add a lock mark on protected sheet tab.Gulsah Kose
Change-Id: Ic9ec598d9bfdf98336cc4a11af21502ca7a1e4fb Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/44558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-19clang-tidy modernize-use-equals-default in svtoolsJochen Nitschke
no need to explicit delete SvtScriptedTextHelper_Impl assinment operator because it's implicit deleted anyway. Change-Id: I8463345e9035fc0466a22ed6648eb5b2614ed1b5 Reviewed-on: https://gerrit.libreoffice.org/44927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15drop now unused ToolPanelOptCaolán McNamara
Change-Id: I26c93567f58b7b459eedbad85b5f3bfe554c8557 Reviewed-on: https://gerrit.libreoffice.org/44769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-14Resolves: tdf#113835 add Fon [fon-BJ] to language listEike Rathke
Change-Id: Iee741421d8f6a9a2b9b14439612890426cdf4712
2017-11-14Fix typosAndrea Gelmini
Change-Id: I53b47cab5cbc603bf11adcda8ac2a8373eef26a8 Reviewed-on: https://gerrit.libreoffice.org/44695 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-13SotClipboardFormatId::STRING_TSVC "Unformatted text [TSV-Calc]", tdf#113571Eike Rathke
In preparation to solve tdf#113571 *AND* keeping tdf#32213 fixed we need two separate unformatted text formats to distinguish between in-Calc on-cell paste and external or in-cell paste. Change-Id: Ic81a0c17d0643af2f5f4be50e67b690fd8846388
2017-11-11A user object id is *NOT* a SotClipboardFormatIdEike Rathke
Do not try to squeeze it into such.. especially if SotClipboardFormatId::... enum identifiers are used in a user object id context that is completely not related to the identifier name this is totally confusing. commit fb14be5f8f74f83ba89e15f891ddf1f753dcc62f Date: Thu Mar 12 14:53:28 2015 +0200 create new 'enum class' SotClipboardFormatId to unify types overdid with that. Change-Id: I34b570be9f52b7b94ca8af6b23983393ac3a3a55 Reviewed-on: https://gerrit.libreoffice.org/44612 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-09rename AvoidConfig to FuzzingCaolán McNamara
cause that's what its really used for and a couple of cases are not specifically about avoiding config but avoiding uninteresting disk acccess and what not Change-Id: I4c6454f98388579fcd0bf9798321d30408ab65ee Reviewed-on: https://gerrit.libreoffice.org/44491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-08ofz#4115 Integer-overflowCaolán McNamara
Change-Id: Ibeb62c6df8fe1e200b97ea179d747e735a4ebf3a Reviewed-on: https://gerrit.libreoffice.org/44451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-08ofz#4113 Null-dereference READCaolán McNamara
Change-Id: If586bd265e323b5c2a308c2e853456c2778e8cb0 Reviewed-on: https://gerrit.libreoffice.org/44448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-06ofz infinite loopCaolán McNamara
Change-Id: Iae9faaa86e4b3edb9a1fdfe9c6b67eee211c19a9 Reviewed-on: https://gerrit.libreoffice.org/44361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-06ofz infinite loopCaolán McNamara
Change-Id: I9eab92f72618a062455e9e17d9a262f28d8bb740 Reviewed-on: https://gerrit.libreoffice.org/44332 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-05Replace remaining lists by vectors in svtoolsJulien Nabet
Change-Id: I3b85f4853d305fec2efe1fa351466c56d11473c9 Reviewed-on: https://gerrit.libreoffice.org/44303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03[API CHANGE] tdf#65393 Import signature line images from ooxmlSamuel Mehrbrodt
showing whether the signature behind the signature line is valid or not. Change-Id: Ia6cca62812019f26d55d234cac767a9b4b7c8175 Reviewed-on: https://gerrit.libreoffice.org/40980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-03loplugin:constparam in vcl,svtoolsNoel Grandin
Change-Id: I7a3eb2bfda869e9e66db919f929ead60cf8890a4 Reviewed-on: https://gerrit.libreoffice.org/44209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03ofz: crash with empty aParserStatesCaolán McNamara
Change-Id: Ie3f327605ce795da30f915969177f21a7d38824c Reviewed-on: https://gerrit.libreoffice.org/44232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-03vcl: remove sgf/sgv ancient gfx filtersThorsten Behrens
Change-Id: Ib02986e5b3d54d65982836e22ebcb70eb7a0e7b3 Reviewed-on: https://gerrit.libreoffice.org/44216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-03Infinite loop in ooo32227-1.rtf with calc rtf filterCaolán McNamara
Change-Id: I068b205c844296379b5641356e4087b17f0a3535 Reviewed-on: https://gerrit.libreoffice.org/44218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-31loplugin:constantparam in svl,svtoolsNoel Grandin
Change-Id: I0d7c1dff2646e483c866f547224c60838b221c4b Reviewed-on: https://gerrit.libreoffice.org/44083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30loplugin:constantparam in vclNoel Grandin
Change-Id: Ic32e4098dcdae5ca5d7fe2749badedabda86a90d Reviewed-on: https://gerrit.libreoffice.org/44043 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-28Related tdf#95694: Enable papersize & orientation listboxesKatarina Behrens
when called from File > Printer Properties > Properties. Anything else doesn't make sense, user opens this dialog in order to be able to edit the settings Change-Id: I9559829551e6d6144da972757ab98afa5696bbfa Reviewed-on: https://gerrit.libreoffice.org/43823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-26vcl: make MapMode constructor explicitMichael Stahl
Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988
2017-10-26rename createOnShotInstance->createOneShotInstanceNoel Grandin
Change-Id: I8848784cd867714019f90bb7fc57ca7289e51f81 Reviewed-on: https://gerrit.libreoffice.org/43873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26Use the canonical abbreviation "pc" of pica, instead of "pi"Takeshi Abe
like as fixed at 8a5b178eb9f680fadcc8faa2e277623e8304b723. This change affects e.g. the string of the tooltip appearing when changing document margin in Writer by dragging ruler, after choosing pica as the unit in context menu. Change-Id: I55d2cea8b30016e2578c6a112f54e26d62741b44 Reviewed-on: https://gerrit.libreoffice.org/43819 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-10-26Refactor font substitute removing (vcl/svtools)Julien Nabet
+ replace list by vector for maFontSubstList Change-Id: I4d5668611212358c759fa5cf26f5341311551298 Reviewed-on: https://gerrit.libreoffice.org/43855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26Fix memory leakTakeshi Abe
Change-Id: I2638a8440601264ff00221ead28a71c891abae16 Reviewed-on: https://gerrit.libreoffice.org/43860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-13 11:10:46 +0000