summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2020-02-21Drop o3tl::optional wrapperStephan Bergmann
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-21loplugin:unusedmethodsNoel Grandin
Change-Id: I2194158d555958f0192d8d6c18e4c093608b8fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20loplugin:singlevalfieldsNoel Grandin
Change-Id: I9ff752b06facfbb04c10c8f9b46b650143b02ca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89117 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20Remove some unused includesMiklos Vajna
Change-Id: I28b007cff3a99bc40901ecdeaecacf42b4521574 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89058 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-19can avoid including svtools/ctrlbox.hxxCaolán McNamara
Change-Id: I953089dd1416cd24721241fff3a6d21354211a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18Resolves: tdf#130757 Add Minangkabau [min-ID] to language listEike Rathke
Change-Id: I901e64c223723bf2eac908dda80796a7a2799147 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88985 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-18move svmedit.hxx internal to svtoolsCaolán McNamara
Change-Id: I52469e2029f292e7d5e9002cb9d098c14576a00d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88892 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara
Change-Id: Id3e20d4eebb02f0022b138dfcd835ea70f1417f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88891 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara
Change-Id: Ibacffee0520d7525d552820713f3d4d620e1f156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18move SVTXFormattedField, SVTXCurrencyField, SVTXNumericField to toolkitCaolán McNamara
Change-Id: If22200a4f342d4d779c612dbace61a4cf99471ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88866 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17remove some unnecessary button.hxx includesCaolán McNamara
and update pches Change-Id: I61ca0be7a838e4eec6c41e0ece58d8a6b0e64c37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17Drop needless junit and python make conditionalsJan-Marek Glogowski
JunitTest and PythonTest modules check for these themself. Change-Id: Ia453bc99571738b01cc8f161f346cb6c37b2e429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88832 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-02-16use fwd decls of StatusBarCaolán McNamara
Change-Id: Ib7ba9978e348a824a23310f9a4e6cfb6b7c18f0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88811 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16use fwd declsCaolán McNamara
Change-Id: I06a4049d84d3ef755b713c045f686361782bdfc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88807 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16move TreeControlPeer to toolkitCaolán McNamara
Change-Id: Id5298615f0f3dad6e61955e23367c0345b33f2b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88813 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14remove recently unused functionsCaolán McNamara
Change-Id: Ie7645d7f9b8350d3a993c40541747dc8ac817ab9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88730 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14use fwd decl of SpinFieldCaolán McNamara
Change-Id: Ifea23e791ec53448a8591583f283b87430ef38c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14split StringToMetric and TextToValue into fieldvalue.hxxCaolán McNamara
Change-Id: I5d1102f7a50a7a246df9f6de8b7a6df6557eb54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88682 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14split out MetricField value conversion functionsCaolán McNamara
Change-Id: I67a33bd2a5cb06dc66e471918b5c378044a2eff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14use forward decls to reduce including unnecessary headersCaolán McNamara
Change-Id: Iaa25ac1ac99e0dcf09bce21f4bad8cb9b5568a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14move VCLXFileControl to toolkitCaolán McNamara
Change-Id: I39bb417fe7e033a8f368fa04d4a30b2388bcddfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13factor out dialog hacksCaolán McNamara
Change-Id: Iceefc8d739fb93b97adfa1e35d8308f0c48f02e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88600 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12clang-analyzer-deadcode.DeadStoresNoel Grandin
Change-Id: Ifa384933569b27d0d08eb479bb95b799163ae386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88450 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-11fix svtools' sVendor for langpack install for DebianRene Engelhard
after a21987977eae34eaf02fa109201c802f77ea68d1 Change-Id: I4bd2b37e3f006209f55bccca9fe117b0c0c4efbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87908 Tested-by: Jenkins Tested-by: Rene Engelhard <rene@debian.org> Reviewed-by: Rene Engelhard <rene@debian.org>
2020-02-11cypress: mobile: Font size combobox is broken on core/master.Caolán McNamara
so https://cgit.freedesktop.org/libreoffice/online/commit/?id=08d6c3fdf9bac4ad8318151ab1402690eb950f52 isn't needed Change-Id: I8836969ae064342835287a63065e591f083f2220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10Resolves: tdf#130550 Add Ligurian [lij-IT] to language listEike Rathke
Change-Id: I6a83bd754ebebf877d6638d5672194aefcf179bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88372 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-09Fix typoAndrea Gelmini
Change-Id: Ic5cca7e798240af9581782820409938755a5d920 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88318 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08cid#1458164 silence Unchecked return valueCaolán McNamara
Change-Id: If5c77b40195e7f6599fa24c1317c22507043de32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-08replace some more copy/clear with swapNoel Grandin
Change-Id: I6501dd59682d2605e9b9856c2deaa02a873ce641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07rename URLBox back to SvtURLBoxCaolán McNamara
Change-Id: Icd90eeb492002c45ddd8ff562a6da411abead122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07SvtURLBox is now unusedCaolán McNamara
Change-Id: Iab78b3803272ceb62c4df74241b64f23b1437b03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88184 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07move some headers inside svtools moduleNoel Grandin
Change-Id: I62fe3345aebe148010971bc8c487d96fa601d420 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88164 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07loplugin:unusedmethodsNoel Grandin
Change-Id: I7296b2fc2862d0ad1f68658b19b2a25cb7609df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-06no FontNameBox exists in any .ui file anymoreCaolán McNamara
Change-Id: I9ca3a4da0cd9bcc2b528d5c761a55efd2a4de2f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06drop unnecessary includeCaolán McNamara
Change-Id: Ifb7e34d5648238a1cf0a893a6713671fa6881161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88066 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06rename SvtFontSizeBox back to FontSizeBoxCaolán McNamara
Change-Id: I2ec0c6dd376f3a192a62dc97f7454af946e2a5ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06drop newly unused FontSizeBoxCaolán McNamara
Change-Id: I8a84ce74888e1d3c468251ddd3633aedf6339a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06weld SvxFontSizeBox_ImplCaolán McNamara
which enables making a native gtk widget a member of a toolbar This widget wants to distinguish between a value getting selected by the menu or not, which is fairly tricky Change-Id: I9014785530bd0d82ffa66842f940feb2d3237e68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06svtlo-FontSizeBox now appears in no .ui fileCaolán McNamara
Change-Id: I711a5d1b7a6ced113ac0c671ea1ba868d70d6346 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88063 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-04tdf#130382 - process key-event handlers synchronously for unipoll.Michael Meeks
Unipoll tries to simplify behavior of the Kit process by processing events in a single thread, more sensibly. We do this for other key events, so it's important that key-derived dispatches eg. SID_BACKSPACE which we use to simulate composition input are also synchronous. Change-Id: I12dbb104419a0aecd184ec312bfadec3a947d48b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87929 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-03make some headers privateCaolán McNamara
as shown with ./bin/find-headers-to-move-inside-modules.py Change-Id: I7662417e76fe00c0fc352957560e104b6c2a3d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03loplugin:unusedmethodsNoel Grandin
Change-Id: I8a2d86145a951bcaae891240b1ed6f539d93634c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87854 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-03loplugin:constantparamNoel Grandin
Change-Id: If2dee122bf07dc179fd8f6e766442ec1891a5f3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87845 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-03rename SvtFontStyleBox back to FontStyleBoxCaolán McNamara
Change-Id: I709f100541964b8740a7d0639a58214b1553458f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03FontStyleBox is unusedCaolán McNamara
Change-Id: I1490c41c86a2f2a51ffc591a4d32499ab7b5faef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87835 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03FontStyleBox does not appear in any .ui files anymoreCaolán McNamara
Change-Id: I8da23000064c475863b3b911207fa220ed662a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87834 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-01make update_pch also consider files in <module>/src/**/incLuboš Luňák
With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-31loplugin:unusedfields improve checking for fields guarded by existence checkNoel Grandin
which resulted in only a couple of real finds, mostly false+ Change-Id: I26058a29c27bff50e9526bedd54fb04589c2934d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87765 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-31loplugin:singlevalfieldsNoel Grandin
Change-Id: I77ccf3f36363e182a644b98cdf720f1381a5cceb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-31clang-tidy modernize-concat-nested-namespaceNoel Grandin
Change-Id: Iab35a8b85b3ba1df791c774f40b037f9420a071a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>