summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2017-08-24remove unused error codes in svtoolsNoel Grandin
which seem to be unused since initial import Change-Id: Id5216bac53fafc1020003de10d8dde381b1121cf Reviewed-on: https://gerrit.libreoffice.org/41491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23convert message box style bits to scoped enumNoel Grandin
and fix harmless bug in ImpSVGDialog::ImpSVGDialog, which there since commit 6456f1d81090dd5fe44455c09ae3ede7ec6ac38a Date: Fri Feb 4 14:52:54 2011 +0100 ka102: added/removed files for SVG import and module cleanup Change-Id: I66b2ec2b029431ab453e54e962863e4ed7d78962 Reviewed-on: https://gerrit.libreoffice.org/41412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22Convert ErrCode area to scoped enumNoel Grandin
Change-Id: Ifa365bbac3c7eb21da9381ec8bb3be6b6785016b Reviewed-on: https://gerrit.libreoffice.org/41402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22convert WB_QUICK_SEARCH/WB_FORCE_MAKEVISIBLE to bool fieldsNoel Grandin
Change-Id: Ic297d97911a6c0356d24ffe4b58442dfe866139f Reviewed-on: https://gerrit.libreoffice.org/41407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-20svtools: rename function to match it's effect.Jochen Nitschke
nYoffsNodeBmp went with commit 9e61a951374a3f7705de67295e406e929c603a42 Date: Tue Jun 20 15:59:42 2017 +0200 loplugin:unusedfields in svtools Change-Id: I959829c64242b2d021497f828e24bb23119d8e24 Reviewed-on: https://gerrit.libreoffice.org/41363 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-08-20svtools: remove function with unused return valueJochen Nitschke
and inline only functionality Change-Id: I79b0ec29dcc35e9dc92aaac9fb191c882a9b0621 Reviewed-on: https://gerrit.libreoffice.org/41362 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18use o3tl::enumarray for m_aNodeAndEntryImagesNoel Grandin
Change-Id: I508c77562ec92b078d15d2a557af474a93b940de Reviewed-on: https://gerrit.libreoffice.org/41294 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18WB_RADIOSEL is deadNoel Grandin
since commit 37229126c0a821a925839bbca4b6ec7245f861e9 Make WB_RADIOSEL style behaviour as default. Change-Id: I606a01f4c8a84780af96265493372bb0df3fc40d Reviewed-on: https://gerrit.libreoffice.org/41297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18WB_TOPBORDER,WB_3DTAB are deadNoel Grandin
since commit 8ab086b6cc054501bfbf7ef6fa509c393691e860 initial import Change-Id: Icbbf01de92c6dab4f9f94052cda784326a051ad8 Reviewed-on: https://gerrit.libreoffice.org/41295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18WB_RANGESELECT,WB_MULTISELECT in Calendar is deadNoel Grandin
since commit 6c759da0442f5123a4a4355e8dc9c926a49d25d7 delete workben Change-Id: Ib9db62ea3fb064b70912318eda2528590c307295 Reviewed-on: https://gerrit.libreoffice.org/41287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18WB_BOLDTEXT,WB_FRAMEINFO,WB_WEEKNUMBER are deadNoel Grandin
since commit 6c759da0442f5123a4a4355e8dc9c926a49d25d7 "delete workben" Change-Id: Ie1f399a7a8179c7727491f4ab7b4b2772fd130b8 Reviewed-on: https://gerrit.libreoffice.org/41286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18convert ExtendedWinBits to a single bool flagNoel Grandin
Change-Id: I2ff15a7f485ffdfb78eaabd529d19065faeb4c53 Reviewed-on: https://gerrit.libreoffice.org/41277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18Rename flag to less generic name to prepare adding more flagsUlrich Gemkow
Change-Id: I27663a42890bbae3279847a7da971cd367335cb3 Reviewed-on: https://gerrit.libreoffice.org/40736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-08-18loplugin:unnecessaryparenNoel Grandin
look for statements like return (function()); Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3 Reviewed-on: https://gerrit.libreoffice.org/41260 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18Fix typosAndrea Gelmini
Change-Id: I795059109e23800987cda6f04c58ab18c488ad07 Reviewed-on: https://gerrit.libreoffice.org/41242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-17implementing callback for ruler invalidationAditya Dewan
adding commands to fetch and changee ruler state '.uno:RulerState' and '.uno:RulerStateChange' Change-Id: I66107039a7ae5893691feb45c8ab2e4aa476ea76 Reviewed-on: https://gerrit.libreoffice.org/40727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-08-17remove unnecessary use of OUString::getStrNoel Grandin
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4 Reviewed-on: https://gerrit.libreoffice.org/38114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from integer constants in initialiser/call expressionsNoel Grandin
Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300 Reviewed-on: https://gerrit.libreoffice.org/41214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from shift-by-constant expressionsNoel Grandin
Change-Id: Ia470f643e3eefeccc14183133603db260460bd53 Reviewed-on: https://gerrit.libreoffice.org/41212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16tdf#39468 Translate German comments/termsJens Carl
Change-Id: I3c8d8ba10de007429b1cdf26f5e8b207f7cc5eea Reviewed-on: https://gerrit.libreoffice.org/41201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-15tdf#111696 No macro security dialog with High settingNoel Grandin
Regression from commit 528632660b72b105345945c13c5b68060d94a91b "convert ErrCode to strong typedef" Why this is necessary I don't know. Only the change in ehdl.cxx is necessary to fix the reported bug, bug fixing the other one too because it operates in the same way. I know that the other arrays that get passed here look like: { NC_("RID_UUI_ERRHDL", "....."), ErrCode(sal_uInt32(ERRCODE_UUI_IO_ABORT) & ERRCODE_RES_MASK) }, but RID_ERRHDL in svtools/inc/errtxt.hrc does not, it looks like: { NC_("RID_ERRHDL", "...."), ErrCode(ERRCODE_SFX_MACROS_SUPPORT_DISABLED) }, I'm guessing that somehow before my conversion somehow the code was stripping the top bits off the error codes? And why we need to strip the top half of the error code off at all is also a mystery. Change-Id: Iebca026ddf80e24ed74802410693adf90ea36047 Reviewed-on: https://gerrit.libreoffice.org/41172 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-13fix some ErrCode IgnoreWarning() usageNoel Grandin
In some places I used the new IgnoreWarning() method, and that was not a faithful translation of the previous code. Regression from commit 528632660b72b105345945c13c5b68060d94a91b "convert ErrCode to strong typedef" Change-Id: Ie53f7a6b1830e5977510a0c32926e0c70c42dcd3 Reviewed-on: https://gerrit.libreoffice.org/41105 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-11convert std::map::insert to std::map::emplace IINoel Grandin
Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331 Reviewed-on: https://gerrit.libreoffice.org/41019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-10loplugin:unusedenumconstantsNoel Grandin
Change-Id: I54c0c1fca8ea5c89e71c6cd1110fad081ed3d334 Reviewed-on: https://gerrit.libreoffice.org/40953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-09autoformat dialog can draw 'None' invisible sometimesCaolán McNamara
if you switch from an entry which last draws white text, i.e. the "Gray" entry, to "None" then the white text color is persistent and the preview appears to be missing. Instead of getting and resetting the Font to keep the output device font unchanged, push/pop the font and text color setting Change-Id: Ia3a8f0120f8df4b1ec57217e8e6071b0113b3a93 Reviewed-on: https://gerrit.libreoffice.org/40919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-08loplugin:unusedmethodsNoel Grandin
Change-Id: Id66cf12e3a59aeed1b9a7a111b841e30b248635b Reviewed-on: https://gerrit.libreoffice.org/40876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-08loplugin:constantparamNoel Grandin
Change-Id: Ib92aba17c46a4ada75c2a0630f281759d995f32e Reviewed-on: https://gerrit.libreoffice.org/40843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-07tdf#39468: Translate some random German comments and termsJens Carl
Change-Id: I05912b89d059256b20233a0fac244630544d5b0a Reviewed-on: https://gerrit.libreoffice.org/40800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-04rename Anz->Cnt in svlNoel Grandin
Change-Id: Ibe9ad8c1bfbb336ee1f02edf0f619220cfcee375 Reviewed-on: https://gerrit.libreoffice.org/40744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-03tdf#111074: fix AddDays in calendarJulien Nabet
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=fcd0361d6be8d088be12e500f0120afd7995d1ac In calendar.cxx, aLastDate -= nWeekDay; was converted with aLastDate.AddDays( nWeekDay ); Change-Id: I8df8d288b0f5cfae66d798b1a96b5033c12d6503 Reviewed-on: https://gerrit.libreoffice.org/40696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-02remove unnecessary use of 'this->'Noel Grandin
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02split out VclBuilder static methodsCaolán McNamara
Change-Id: Ic94b39351c9a6131fb61883a98ae9e3ee60ad119
2017-08-02normalize resource locale ctor construction mechanismsCaolán McNamara
make them all the same and share std::locales more various OModuleClient, etc, classes go away Change-Id: I7e3ff01a69332eeacd22e3078f66a60318de62d5 Reviewed-on: https://gerrit.libreoffice.org/40634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-01move resmgr to unotoolsCaolán McNamara
and the vast majority of translations is to the ui language so default ctor with that arg and now drop OModuleResourceClient Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
2017-08-01loplugin:checkunusedparamsNoel Grandin
the "check for taking address of function" part was generating false+ Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f Reviewed-on: https://gerrit.libreoffice.org/40613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31make IntlWrapper arg to GetPresentation non-implicit and non-optionalCaolán McNamara
which requires explicitly adding null in 1) SdrItemBrowserControl::SetAttributes(const SfxItemSet* pSet, const SfxItemSet* p2ndSet) where SdrItemBrowserControl is only used by SdrItemBrowser and the only use of that is within DBG_UTIL in SdrPaintView 2) SwCursorShell::GetContentAtPos( const Point& rPt, within a #ifdef DBG_UTIL block in 3) SvxSearchDialog::BuildAttrText_Impl( OUString& rStr, bool bSrchFlag ) const where the other branch uses SvxResId 4) SfxPoolItem::dumpAsXml(xmlTextWriterPtr pWriter) const 5) XFillStyleItem::dumpAsXml(xmlTextWriterPtr pWriter) const looks very much like all uses (outside the dumpers) are intended to be in the ui locale results in that INetContentTypes::GetPresentation always called with UI Locale Change-Id: I5a110c107838b4db3c355476426d6532f2b6ce52 Reviewed-on: https://gerrit.libreoffice.org/40538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-31svtools: Mark arrays as constantTakeshi Abe
Change-Id: I46df79ababe4ed0f22f015e41f9f855c12776a8d Reviewed-on: https://gerrit.libreoffice.org/40597 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31loplugin:oncevarNoel Grandin
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-30tdf#109309 Currency dropdown is misplaced under WaylandMaxim Monastirsky
- Base SvxCurrencyToolBoxControl on PopupWindowController, so we still allow tearoff, but without marking the window as self-decorated (unless actually teared-off). - Add support for toggle state to PopupWindowController. Change-Id: I60e004e6ada3efe092352cb93be5aae346073f83 Reviewed-on: https://gerrit.libreoffice.org/40557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-07-28loplugin:constparams handle constructorsNoel Grandin
had to change the structure of the plugin considerably, was too messy to structure it to do the calculations on a per-function basis Change-Id: I4edee7735f726101105c607368124a08dba21086 Reviewed-on: https://gerrit.libreoffice.org/40516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27correct some Date related typesJochen Nitschke
signature of Date and Date::DateToDays is (sal_uInt16 d, sal_uInt16 m, sal_Int16 y) same types as css::util::Date members Day, Month and Year Change-Id: Ifa35574d2d335f7bf816dd5209988f4eaf7c5ac2 Reviewed-on: https://gerrit.libreoffice.org/40462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25Resolves: tdf#109331 stupid looking cast was relied upon to do useful thingCaolán McNamara
originally as... sal_uInt32 nErrIdx = aEr.FindIndex((sal_uInt16)(sal_uInt32)lErrId); prior to commit 00657aef09d854c74fb426a935a3e8b1fc390bb0 Date: Sun Jun 11 20:56:30 2017 +0100 migrate to boost::gettext Change-Id: I283f5398ebb81c7183c9013589c326c129787840
2017-07-25Convert IMG_ constants to scoped enumNoel Grandin
Change-Id: I4cb65be468422f3cfbf88a6b9ef39fc370fd1a08 Reviewed-on: https://gerrit.libreoffice.org/40408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25convert UNO event ids to scoped enumNoel Grandin
I'm fairly sure there are more simplifications that could be make here. It seems like we have both an ID and a string name for all of these events, and we could probably get by with just one of those, or alternately, centralise the name<->id mapping somewhere Change-Id: I978073822ddbebce94ac5b560fea675bea905a35 Reviewed-on: https://gerrit.libreoffice.org/40392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25use more comphelper::InitAnyPropertySequenceNoel Grandin
Found with: git grep -n -A10 'Sequence.*Any' -- *.cxx | grep -B5 -w PropertyValueProvider and: git grep -n 'Sequence.*Any.*( *&' Change-Id: Icb18c98bdd3f8352817e443ff78de5df042859ad Reviewed-on: https://gerrit.libreoffice.org/40389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-24Export to PNG: use selection if Selection is selectedEike Rathke
The SelectionOnly property from the export file dialog was not passed down from GraphicExportFilter::filter() to DocumentToGraphicRenderer so that always passed a component model instead of a selection object to the implementation of XRenderable (getRendererCount(), getRenderer(), render()) Also have GraphicExportDialog consider the selection so the DocumentToGraphicRenderer at its GraphicExportOptionsDialog calls XRenderable the same. Change-Id: I976bf16cf87cf5ca2678bdba7adfaf61c2063168 Reviewed-on: https://gerrit.libreoffice.org/40380 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-23coverity#1415610 avoid Unchecked dynamic_castCaolán McNamara
Change-Id: Id37e121d3f0de9067fdce8462db7162f3e80d1ac
2017-07-21Eliminate Date::operator+=() and -=() and replace with Date::AddDays()Eike Rathke
Clarifies code and gets rid of explicitly casting the operand to sal_Int32. Also in preparation of removing DateTime::operator+=(sal_Int32) that is confusingly similar to DateTime::operator+=(double) and just depends on type. Change-Id: I83422e2940fbb017978db9b5734b4966228af3de Reviewed-on: https://gerrit.libreoffice.org/40248 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-15 12:47:11 +0000