summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2018-11-01tdf#121030 invalidate referenced FontInstancesJan-Marek Glogowski
This sets the FreetypeFont pointer of the FreetypeFontInstances to nullptr when clearing the cache. And it changes the interface functions of SalLayoutGlyphs to some variant different from std::vector. I don't know if we should prefer the mutable or the const font instance. With mutable at least one can invalidate the font instance when checking the IsValid(), so we can get rid of our referenced font instance. Change-Id: I6070cfcb3c549dbad3383bd4ec2b05b30645b753 Reviewed-on: https://gerrit.libreoffice.org/62688 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-01drop LISTBOX_ERRORNoel Grandin
almost nobody checks it, so rather just assert Change-Id: Ic3ad4c04c4f6013db3e8757559d3a773df020a1d Reviewed-on: https://gerrit.libreoffice.org/62684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-30svtools: fix up misleading indentationMiklos Vajna
The intention was to only conditionally warn. Thanks Noel for spotting my mistake. Change-Id: Iaa035dba1f834c13a179ef66c3f39777f3843bdb Reviewed-on: https://gerrit.libreoffice.org/62641 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-30svtools: fix lost replacement grpahic when updating it via OLE failsMiklos Vajna
How to reproduce the problem: 1) Create an ODT file which has an OLE object, where the native data i an OLE2 container, containing a Package stream, containing a DOCX file. 2) Install some external application on Windows which registers itself as a handler for the DOCX CSLID [ this is where writing a testcase for this bug is challenging ]. 3) Load the ODT file in hidden mode, e.g. connect to a ./soffice "--accept=socket,host=localhost,port=9999;urp;StarOffice.ServiceManager" process from remote Java, load the file with Hidden=true in the Arguments parameter of loadComponentFromURL(). 4) Save it in a format that reads the replacement graphic of OLE objects, like HTML or DOC. Expected result: the replacement graphic is there. Actual result: the <img> tag has no src attribute (HTML case). The root cause is that in case the document is loaded in hidden mode then the IDataObject::GetData() call in OleComponent::getTransferData() fails, so the OLE objects enters a state where it no longer has its old replacement graphic, but it doesn't have a new one, either. Fix the problem by making this update more transactional in svt::EmbeddedObjectRef::GetReplacement(), so the "document conversion" scenario (load in one format in hidden frame, save in other format) works. Change-Id: I624c372baea56a85fb949bd99046f3af1f258c36 Reviewed-on: https://gerrit.libreoffice.org/62549 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-28tdf#119209: Windows share has inappropriate server suggestionXisco Fauli
Follow the same logic as HostDetailsContainer Change-Id: I3de8b2fc07b9caef6b4d20ab89242137d738c522 Reviewed-on: https://gerrit.libreoffice.org/60732 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-26tdf#42949 Fix IWYU warnings in include/unotools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444c43b9d549977039f25bec2b5bf666c3e15e0e Reviewed-on: https://gerrit.libreoffice.org/62041 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-26loplugin:singlevalfields improvementNoel Grandin
look for any kind of types, not just POD types, helps to find smart pointer fields that are only assigned nullptr Change-Id: I2d887e98db012f03b646e1023985bcc196285abc Reviewed-on: https://gerrit.libreoffice.org/62382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-25loplugin:unusedmethodsNoel Grandin
Change-Id: I1f9ac5f8a090f365d9a21486029e1c13d721a4a4 Reviewed-on: https://gerrit.libreoffice.org/62338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24weld AdvancedSettingsDialogCaolán McNamara
make run virtual and fold executes into it, so GenericUnoDialog can call run on tabdialogs to do the right thing, and allows Start_Impl to be private again Change-Id: Ic457edfbdc7457f4c49d4e8ad679903f38ad9b42 Reviewed-on: https://gerrit.libreoffice.org/62227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24clang-tidy performance-unnecessary-copy-init in sfx2..svtoolsNoel Grandin
Change-Id: I1e92472b4aaeca1eb1372bd18d10cc9e0766dc39 Reviewed-on: https://gerrit.libreoffice.org/62251 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-23tdf#117348: Change default grid color to a darker grayMuhammet Kara
For Impress and Draw Change-Id: I8c7854062ae061ba2f7cd968ffd608b8d9b0ca5b Reviewed-on: https://gerrit.libreoffice.org/62025 Tested-by: Jenkins Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-23weld SpecialSettingsPage and GeneratedValuesPageCaolán McNamara
Change-Id: I3b4c2a4d553032128efe25c008df30d6f1f77628 Reviewed-on: https://gerrit.libreoffice.org/61018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22pvs-studio: V794 The assignment operator should be protectedCaolán McNamara
Change-Id: Ia443a0e61a091d877c8da26bf7d45bf4261f8669 Reviewed-on: https://gerrit.libreoffice.org/62166 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22loplugin:unusedfields improvemementsNoel Grandin
treat fields touched in operator== as not being important, which finds some more stuff (but also adds some false+) Change-Id: I3f5d504d7dec7945a917afbcd58c92df74f03645 Reviewed-on: https://gerrit.libreoffice.org/62020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-22loplugin:staticvar in soltools..svxNoel Grandin
Change-Id: Ie9f36eb0e00aaee34a27f136ed903f8f87e52dcc Reviewed-on: https://gerrit.libreoffice.org/61916 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-20Turn LanguageTag::ScriptType into scoped enumStephan Bergmann
...to avoid -Werror,-Wshadow from Clang trunk with <https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators", warning about shadowing of UNKNOWN in e.g. enum ESCHER_BlibType in include/filter/msfilter/escherex.hxx Change-Id: Id6608474e76730be4c439f480c31f661b8b5748e Reviewed-on: https://gerrit.libreoffice.org/62013 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-19clang-tidy readability-container-size-emptyNoel Grandin
Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422 Reviewed-on: https://gerrit.libreoffice.org/61967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19clang-tidy readability-misleading-indentationNoel Grandin
Change-Id: I4673fc7c694924b41d048a1918ddb8b0e0af1f79 Reviewed-on: https://gerrit.libreoffice.org/61935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18tdf#119847 - Can now autoselect font size on first clickNickson
Change-Id: Id49f4d039f0eb7c4efccecda91bd656c1c31d497 Reviewed-on: https://gerrit.libreoffice.org/60784 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-17clang-tidy readability-redundant-smartptr-getNoel Grandin
redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17loplugin:singlevalfieldsNoel Grandin
tighten up the handling of binary operators Change-Id: I262ec57bf7142fa094d240738150a94d83fd15ee Reviewed-on: https://gerrit.libreoffice.org/61777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16drop LazyDeletorCaolán McNamara
Change-Id: I7d2e00466f321994a46b0529d645e342f229c929 Reviewed-on: https://gerrit.libreoffice.org/61718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15weld ChartTypeDialog and SchLayoutTabPageCaolán McNamara
Change-Id: I101c56b855d0bdc43559ca4561d298fa4ad92572 Reviewed-on: https://gerrit.libreoffice.org/61797 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15loplugin:staticconstfield improvementsNoel Grandin
And fix ScXMLCachedRowAttrAccess::Cache which was never setting its mnTab field, and hence would never be hit. And fix oox::xls::CellBlockBuffer, which was never setting mnCurrRow. Change-Id: I2c46aa050b9ebe3c2dc2e52579555f97945dd61c Reviewed-on: https://gerrit.libreoffice.org/61772 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15restore RemoveItem mnHighItemId handlingCaolán McNamara
Change-Id: I9aa094d50f7bc52fd379fa2e315037b81bb53df2 Reviewed-on: https://gerrit.libreoffice.org/61796 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-15add SvStream::TellEndNoel Grandin
and simplify callsites to use it instead of the current "seek to end, find pos, seek back to original pos" pattern Change-Id: Ib5828868f73c341891efc759af8bd4695ae2f33c Reviewed-on: https://gerrit.libreoffice.org/61738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-12Resolves: tdf#119739 switch date field input to NF_EVALDATEFORMAT_FORMAT_INTLEike Rathke
To evaluate date input against date acceptance patterns in the order first format locale, if any, then formatter (system) locale. The slight drawback is when the field has no content there is no indication of that the format's locale's patterns would be preferred, whereas the old NF_EVALDATEFORMAT_INTL_FORMAT preferred the default locale's patterns. The big advantage is that editing a date actually uses the patterns associated with the presented display string. Change-Id: Id3f11e26a0e32b95f26b69a681433deb87b7c6b0 Reviewed-on: https://gerrit.libreoffice.org/61726 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-12drop some unused headersCaolán McNamara
Change-Id: If7cedab43231103f7435ce57a0eb3a4d047becb4 Reviewed-on: https://gerrit.libreoffice.org/61714 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12coverity#1440241 silence Dereference after null checkCaolán McNamara
Change-Id: I6c4f4b626c02de3cd69c32dcb4ffea282c0ebff5 Reviewed-on: https://gerrit.libreoffice.org/61683 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11Revert "tdf#120158: fix ImplGetParameterString for typename"Stephan Bergmann
This reverts commit 40e22f1e1bd44a1aa56ff77b82f1306ed1076ebf. See the commit message of <https://gerrit.libreoffice.org/61684> "tdf#120158: Base CMimeContentType on INetMIME::scanContentType" why that change is considered a superior fix compared to the reverted one. Change-Id: I1a0d77edee5bb18a98890d2021c777bc4c148a26 Reviewed-on: https://gerrit.libreoffice.org/61686 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-10tdf#120158: fix ImplGetParameterString for typenameJulien Nabet
since type name might also contain unacceptable characters, encode all of them See comments 8/9/10 and 11 (bt here) of bugtracker + add SAL_WARN in catch (which would have avoided me to waste a lot of time chasing the root cause) Change-Id: If8555bba8cda011218206621216e0405615229eb Reviewed-on: https://gerrit.libreoffice.org/61601 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-10optimize adding a block of entries at one timeCaolán McNamara
Change-Id: I9a59154fa445cf3c44ede3ceb1d09f408d906530 Reviewed-on: https://gerrit.libreoffice.org/61618 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-08tdf#42949 Fix IWYU warnings in include/comphelper/[m-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I04c5ba277d5b3398c07de6ae66713d977636088d Reviewed-on: https://gerrit.libreoffice.org/61347 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-06make OGenericUnoDialog take an awt::XWindowCaolán McNamara
Change-Id: I7c63397d0579306f4ade1947ce5bf9e1866bf876 Reviewed-on: https://gerrit.libreoffice.org/61469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05give SvFilterOptionsDialog a proper parentCaolán McNamara
Change-Id: Ie6545844546dc78d14e1fabdf28f4e1938cf2dd4 Reviewed-on: https://gerrit.libreoffice.org/61413 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05weld ExportDialogCaolán McNamara
Change-Id: I9d0f21a10708edcc7f5da14f83944da58c33b1d9 Reviewed-on: https://gerrit.libreoffice.org/61408 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04sal_False -> false in commentLionel Elie Mamane
Change-Id: I3344af4ce28bd2b94725ea9336ce1b1ab9c98554
2018-10-04drop SvMemoryStream::GetBufferNoel Grandin
since it does the same thing as GetData() Change-Id: I18d35aa4e67ad7775987160c021863d0de90179b Reviewed-on: https://gerrit.libreoffice.org/61350 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03Resolves: tdf#93372 format table in base is ignoredCaolán McNamara
since... commit b4bbb5e5d7b31caad2fbcc00382ad27df3c81001 Date: Sun May 17 22:56:46 2015 +0900 refactor how font, fg. and bg. are applied in widgets/controls revert the relevant piece, in this case there are two Windows/Contexts getting their settings manipulated, rather than the usual one Change-Id: I0a228aee6aaf1f58b2235fccf14dc63ffa96dd2d Reviewed-on: https://gerrit.libreoffice.org/61317 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03no need to call empty() before clear()Noel Grandin
found with git grep -A2 -nP '!.*\.empty()' | grep -B1 -w clear Change-Id: I87013eab9c6988048b891d20577e1f7efbce1b6c Reviewed-on: https://gerrit.libreoffice.org/61295 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:unusedmethodsNoel Grandin
Change-Id: I7db0c27ff2213210ed4b46ebbadc1a2f74a18257 Reviewed-on: https://gerrit.libreoffice.org/61249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:constfields in svtoolsNoel Grandin
Change-Id: I91553f89d8f5ee42afa52d196bf86f8a92011850 Reviewed-on: https://gerrit.libreoffice.org/61186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-30weld SvxLineEndDefTabPageCaolán McNamara
Change-Id: I3e947511bbffae4cd48388b17a8fb9a13d453bab Reviewed-on: https://gerrit.libreoffice.org/61139 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30add GetFileImageId and check if there is no parentCaolán McNamara
Change-Id: I80fdcb800642dbb850072a259d0f742e8c6cbb20 Reviewed-on: https://gerrit.libreoffice.org/61071 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-25loplugin:useuniqueptr in SvImpLBoxNoel Grandin
Change-Id: I59aa026217ed250fab68afc4aa0086d4d1300eac Reviewed-on: https://gerrit.libreoffice.org/60627 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-25inline SvxIconChoiceCtrlEntryList_impl typedefNoel Grandin
and simplify usage in SvxIconChoiceCtrl_Impl Change-Id: If72d14be66cdf3135ad4edf5502a478a0857d7dd Reviewed-on: https://gerrit.libreoffice.org/60951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-23loplugin:unusedmethodsNoel Grandin
Change-Id: I9dac9260af9955dc4a66b34c33265c6e36094322 Reviewed-on: https://gerrit.libreoffice.org/60911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-22weld AlignmentTabPageCaolán McNamara
Change-Id: I253a01b053efe836b0657f9a711cecd060b6782b Reviewed-on: https://gerrit.libreoffice.org/60883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-21coverity#1401334 Uncaught exceptionCaolán McNamara
Change-Id: I2a74e0bcba46b730067b5baca5e934f95ba265ce Reviewed-on: https://gerrit.libreoffice.org/60854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-28 10:33:53 +0000