Age | Commit message (Collapse) | Author |
|
Regression from:
286e2f5c6ec829bc0987b1be7016699f7ef03e5e
Sometimes SdrGrafObj import the image file just as a
preview (with low resolution) and late when the real
picture is needed it just throws this preview and tries
to load the image again.
This preview works only with package URL so in this
case we should not forget that URL.
Plus two other related potential image loss situation:
- SetUserData() is called with empty image URL
- Image preview is thrown when we actually have no
package URL from we can import the image again.
Change-Id: Ib21f400eb6d28133e8598e6b201209e5dd1a976f
|
|
Change-Id: I3b2a4e69a1c86d9b9ce9f51d6f321bda9e18f8b5
|
|
Now the graphic cache settings shows the real memory usage for
the users, so we can bequeth the decision of the limit to them.
Default is 200 MB.
See also:
dbdacc73ae154237314d599194cc686bd738a9bf
Change-Id: I463d31254f6f1836e1584d5acd692f38a97bfe39
|
|
Change-Id: I34c4a44d4fbe8d721a3a0bda5dbe35c68fe15c13
|
|
Change-Id: I7b15220568717e159f119e79da0016cbc88873cf
|
|
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
|
|
Change-Id: Id6c096d09b984039d54a1d152cf0da594aaf203d
|
|
See:
c454a0cd0cc7b315b1353b151a2e95654df72c69
and
46eb0952f1e2d75b427bdcd553c33027f1e44e8f
Change-Id: I811f1c52f8a9fba28bc4f38fd1ad34826b2bd45e
|
|
Change-Id: I3f7e0ccd5697a4ca6026bec60210e24af25fb92f
|
|
Change-Id: I90c559c59b307aac6f7adac49ea38b0d9b68ad58
|
|
Implementation uses a multiplicator of ten. I guess the intention
here was that to calculate cache size based on the size of the inserted
images and not based on the real memory usage (potentionally more
instances of one image), which seems a bad idea because it covers the
real memory usage from the users (who will be suprised when LO's memory
usage increases tenfold of the set value).
It seems better to use the exact value in the implementation and increase
the default value on the user interface instead.
Change-Id: Ie3c0568d3518922d3a9931f894eebb9e7e5515ed
|
|
Change-Id: Ifc7377fe1bb68b21e462818248706f53347b39b1
|
|
Change-Id: I82570a716a0dba6c466bc754ce66ac53e7c17efa
|
|
Change-Id: I55d6d1d403622e5ec04c29dd407274cf9db20c40
|
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
Change-Id: Id4b01f02d5d90215164c07b8076498df65978fa3
|
|
Change-Id: Iff0942b9b545f27dd74b73bee3f8ac785539867d
|
|
Change-Id: I839435338f4acf80c40896b6c86f7ef122f5449d
|
|
doesn't seem to matter too much, I guess its only the top left
corner that really matters for tooltips.
This is the vertical scrollbar as used in e.g. writer->view->datasources
Change-Id: I5bd6e563a9f02edae9ca166f073556c55878826c
|
|
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
And remove the tools/fract.hxx include.
grep -l -r fract.hxx workdir/Dep/*Object* |wc -l
before: 4569
after: 1851
Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3:
libvcllo.so by 473k (0.35%)
libswlo.so by ~1Mb (sadly that is just 0.2%)
Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
|
|
Change-Id: I5dcbd2289fc853bad2c0969fb3b202a1e7398a5a
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e
Reviewed-on: https://gerrit.libreoffice.org/12333
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I1a930a413c071d4d0c8855315dc85339e01b7d9b
Reviewed-on: https://gerrit.libreoffice.org/12322
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
|
|
and make the two categories of constants non-overlapping, we
really don't need to risk confusion in order to save 6 bits in
a data structure like this.
Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
|
|
Change-Id: I6b9f5f9c4a0bc87376a469835a50dc2cf598479e
|
|
Store used size as a member so we don't need to recalculate it
all the time and no need to use a size map.
Change-Id: I1f929c5d3a56f545cef123bda087ecaf8ca0be4a
|
|
Change-Id: Ia599644ff1f7591ac84bdca988883eaf5860297e
|
|
This means more things:
* Graphic won't swap out itself, so those classes which uses
Graphic without GraphicObject won't need to deal with swapping.
* When a Graphic is queried from GraphicObject the caller won't
need to deal with swapping, because GraphicObject swaps it in
before return.
* GraphicObject will swap in the Graphic always when a swapping
dependent data is queried (e.g. whole graphic, transformed graphic
or AnimationNotifyHdl)
Change-Id: I2bf6e37291ec94146f10aac4a35084682437ed16
|
|
Painting via GraphicObject is obsolete.
See fdo#68927 where the problem was the quality of svg
graphics, it seems a good idea to extend this improvement
to all graphic type.
Change-Id: I57a26d4fcfea8e4f666504a90281365e8a9a7e1d
|
|
Change-Id: I7a8ad7814231f129d5d1146ceb36eb2c22b2aff1
|
|
Change-Id: I75f17ab5e55119965fcede2b220979cefc1e26ab
|
|
Change-Id: I09b8d11027f4a1e8470b81677388d4a573b372a6
|
|
Before an image data is used GraphicObject should be swapped in.
When a GraphicObject is swapped in auto swapping mechanism
is triggered which can swap out some of the images.
We should avoid to swap out the same image on which the swap
in method was called before because the caller code assumes that
the image data is there.
Change-Id: Ia4addc370742aea5fbf185cf87e3c062a5ebf5be
|
|
So we can be sure it is always called when user data changed.
Change-Id: If107907afffb85a7a57817f5807847a5c028416c
|
|
When ImpGraphic::ImplSwapOut() is called with null
pointer it was assumed that it is becase the graphic is
a link and so we don't need to swap out it actually (we can
load it anytime using the link), only clear the graphic's
internal data.
The problem with that it can happen that ImplSwapOut()
is called with null pointer accidentally on a non-link
graphic object which leads to that we loose the graphic.
Seems more robust to use an explicit indicator
(GRFMGR_AUTOSWAPSTREAM_LINK) for links swapout.
indicator
Change-Id: Icf31524a192c7866278ba6a13eb85648aa69f554
|
|
Call it inside ImplAssignGraphicData() which assign
GraphicObject members using Graphic's data. With that
ImplAfterDataChange() method also called in constructors.
It's important to call ImplAfterDataChange(), because this
will trigger the auto swaping mechanism.
Change-Id: I45af91f8df2fb5b0143fcc5eb05e82e4d408d0bc
|
|
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
|
|
Change-Id: Ic79bd1931ee291746b6dae138b3181d4baddbe3e
|
|
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
|
|
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
|
|
Change-Id: I282b874c22c373e078007a29bcbbe74b175a70d3
|
|
Sinchronize colors from colorcfg.cxx with settings.cxx
Change-Id: If3a9c7ac2593e5a452a57590189ad787b807b83c
Reviewed-on: https://gerrit.libreoffice.org/12199
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.
Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
|
|
Change-Id: I0d7a93461f37d5ca18605cd94b630d70d871adfb
|
|
Change-Id: I64c0d1cb4c3182c03a7d7660c4736f665fc5f3dc
|
|
and
coverity#1250407 Division or modulo by float zero
coverity#1250408 Division or modulo by float zero
Change-Id: I77e4483356f7c0b287a29637cf6b958ee665ffec
|
|
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a
Reviewed-on: https://gerrit.libreoffice.org/12179
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
|