summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2016-08-22tdf#89329: use unique_ptr for pImpl in roadmapArnold Dumas
Change-Id: I1683b258d72c1ec4b29110203e8af7ff2596ebb0 Reviewed-on: https://gerrit.libreoffice.org/28283 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-19Resolves: coverity#705366 Mixing enum typesCaolán McNamara
and coverity#705367 Mixing enum types coverity#705371 Mixing enum types coverity#982694 Mixing enum types coverity#1027717 Mixing enum types coverity#1371228 Mixing enum types coverity#1371242 Mixing enum types coverity#1371280 Mixing enum types coverity#1371310 Mixing enum types MapUnit and SfxMapUnit share the same values and are freely cast from one to the other. Now that commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527 Date: Thu Aug 11 15:02:19 2016 +0200 loplugin:unusedenumconstants in package..svtools removed the SfxMapUnit entries that were directly unused, they don't match anymore and casting from one to the other is dangerous. Why there was two of these anyway escapes me, get rid of SfxMapUnit and just use MapUnit universally Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e Reviewed-on: https://gerrit.libreoffice.org/28234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-18coverity#1371121 Unchecked return valueCaolán McNamara
Change-Id: I1413b62112922af8d6872de413ca7decc0d75875
2016-08-18cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I61ab542f4cc777ecd8f8393c7bcbb681e529de5f
2016-08-18screenshots: add new global make targetArmin Le Grand
Up to now the screenshot creation was added/dependent of target slowcheck. Since quite some modules have added screenshot creations now, I added an own target 'screenshot' to allow to keep current slowcheck and screenshot creation separated Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for svtoolsArmin Le Grand
All *.ui files create a screenshot, but not all look useful Change-Id: I7a7a6c3ab38e8890404082dd359ff5f4f1ebf9fd
2016-08-16GSoC notebookbar: icon size switchingSzymon Kłos
+ added entry in the Options > View + changed sfxlo-SidebarToolBox to sfxlo-NotebookbarToolBox in the Notebookbar ui files Change-Id: Id5719953be9830b650af96d54e63936c553cda74 Reviewed-on: https://gerrit.libreoffice.org/28169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2016-08-16Resolves: tdf#101540 add Silesian [szl-PL] to language listEike Rathke
Change-Id: I7f73a6286d080a5ebf1b7a1bb834a06f51be6529
2016-08-16new loplugin to check for static OUStringsNoel Grandin
that are better declared as OUStringLiteral Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567 Reviewed-on: https://gerrit.libreoffice.org/27377 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-12loplugin:unusedenumconstants in package..svtoolsNoel Grandin
Change-Id: I8136b93b9303ebecafd791159e813c335b1bc172 Reviewed-on: https://gerrit.libreoffice.org/28052 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11loplugin:constantparamNoel Grandin
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886 Reviewed-on: https://gerrit.libreoffice.org/28016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11loplugin:countusersofdefaultparams in svl..unodevtoolsNoel Grandin
Change-Id: Ie3d2cf29e99b8a51b80246aafa23a92e6c3404b2 Reviewed-on: https://gerrit.libreoffice.org/28017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-08loplugin:unnecessaryvirtualNoel Grandin
Change-Id: If25d9307efda5f57b0f80a0cf5c2c5cab6a752d6 Reviewed-on: https://gerrit.libreoffice.org/27981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-03Resolves: tdf#96873 include template image to make it available in helpCaolán McNamara
alternatively move it into the helpimg dir and change the usage in helpcontent2, but do it this way to keep it together with the others Change-Id: I84c6b10aed948a5fea835dc86bade5a4390c716b
2016-08-02Related: tdf#101196 prompt to restart after OpenGL config changesCaolán McNamara
Change-Id: If0ade12ed4cf360bdac8cfbec7bb09c9a640fc6d
2016-08-01tdf#93845: Style Preview Checkbox for Styles & Formatting sidebarSusobhan Ghosh
Change-Id: Id5862339bbe0c80002dfd99cbf19d981d1d42682 Reviewed-on: https://gerrit.libreoffice.org/27706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-29Related: tdf#99324 accel underlines don't appear in hyperlink dialogCaolán McNamara
Change-Id: Ib16b239c88b1d1157fc18bc62b5f01c52e896a48
2016-07-29Related: tdf#99324 accel underlines don't appear in options dialogCaolán McNamara
Change-Id: I47cb6df2118ea86dea7225842dcdc4c1dafc439f
2016-07-29this NOCOMMAND is never definedCaolán McNamara
Change-Id: I6a2ae90182eaeb534176dd0a2591bfe0c2242a5c
2016-07-29loplugin:countusersofdefaultparams in store..svtoolsNoel Grandin
Change-Id: I15b4400bddc5a4d0e3de5dfffe18b7e493f97df6 Reviewed-on: https://gerrit.libreoffice.org/27580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-28Resolves: tdf#94940 don't load font history if option is disabledCaolán McNamara
Change-Id: I70348b4e4bb85850331044e901c03aabb0d22ef8
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-22Fix --disable-pdfimport buildMiklos Vajna
Change-Id: Ida06b892aea92cfe26fd62372e21ca611d8838d3 Reviewed-on: https://gerrit.libreoffice.org/27447 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-18Resolves: tdf#100823 crash during PopupMenu dtorCaolán McNamara
Change-Id: I6d9aed05a76311a13470c9072543609f5a87501d
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-13Resolves: tdf#100340 make compress graphic dialog less wideCaolán McNamara
'regression' seems harsh, its not so wide it didn't fit on a reasonable sized screen or look particularly horrific. Change-Id: I20d55b8aac609ee0d683eb9a1c2b173aa0c9d8da
2016-07-13Resolves: tdf#59570 scrollbar used instead of sliderCaolán McNamara
Change-Id: I14241c8a4418e8356a590a32b661f283b606f9fa
2016-07-10ditch the font/screen-scaling thingCaolán McNamara
its of limited utility wrt the vcl layout work and optimal size widgets, and its confuses people looking for hidpi settings Change-Id: I37d21b480446f9fe2845b3a2d9fd59cdeddf1a93
2016-07-08Resolves: tdf#100452 class Date full (BCE,CE) proleptic Gregorian calendarEike Rathke
... implementing signed years with year 0 gap. Date(31,12,-1) last day BCE Date(1,1,1) first day CE New class Date member functions: * AddYears(sal_Int16) to be used instead of aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap. * convenience GetNextYear() to be used insted of GetYear()+1 * convenience GetPrevYear() to be used insted of GetYear()-1 * AddMonths(sal_Int32) * operator=(const css::util::Date&) New class DateTime member functions: * operator=(const css::util::DateTime&) Made some conversion ctors explicit, specifically Date(sal_Int32) Adapted hopefully all places that used a sal_uInt16 year to use sal_Int16 where appropriate. Eliminated some quirks in date handling found on the fly. Added era handling to i18npool icu calendar setting interface, which missing was responsible for 0001-01-01 entered in Calc being set as -0001-01-01, hence subtracting one day resulted in -0002-12-31. Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f Reviewed-on: https://gerrit.libreoffice.org/27049 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann
Change-Id: I3b52f6a392b6f6dcc8e3d528dc61bf49c510737d
2016-07-07FloatWinPopupFlags::NoFocusClose is only set, never readCaolán McNamara
Change-Id: Ide67b9279b626d3427c93891d27378ffd1f004cc
2016-07-06restore loplugin:vclwidget checking for calling clear() on VclPtr fieldsNoel Grandin
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405 Reviewed-on: https://gerrit.libreoffice.org/26806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05when disposing popup menus, don't leave dangling pointersNoel Grandin
Change-Id: Ia1b49937ba0693a567097367b99b75a3011666bf Reviewed-on: https://gerrit.libreoffice.org/26960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-05merge svt::StoreString with svt::StoreContentURLNoel Grandin
Change-Id: I6f2a7102c697cecc96e8b950b499bc9b0f91240e Reviewed-on: https://gerrit.libreoffice.org/26904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04remove comphelper::string::removeNoel Grandin
and replace it with OUString/OString::replaceAll Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a Reviewed-on: https://gerrit.libreoffice.org/26850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin
convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-01fix mis-mergeStephan Bergmann
Change-Id: I529b7abff98e38e503ffbcb39946e30d12a053cc
2016-07-01GSoC possibility to change icon size in the SidebarToolBoxSzymon Kłos
+ Added registy entry to store icon size + Added UI to change settings: Tools -> Options... -> View + Loading last settings in the SidebarToolBox + Settings update listener Update icon code from: framework/source/uielement/toolbarmanager.cxx Change-Id: I1d713c50fccfc19e1c8ea82eba68556ddb76cd3c Reviewed-on: https://gerrit.libreoffice.org/26362 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-29vcl: handle PDF data in Read/WriteImpGraphic()Miklos Vajna
Initially I wrote the test to cover f7d6f3e4e3fda3cd4936880918e2831246634a3e (svtools: survive swapout/in of graphic with embedded pdf, 2016-06-28), but as it turns out the actual swapin/out code is in vcl, so extend that as well to support pdf data. Change-Id: I320ea729dce9440b84a5089607807322ea7b0b04 Reviewed-on: https://gerrit.libreoffice.org/26755 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-28loplugin:singlevalfields in variousNoel Grandin
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28svtools: survive swapout/in of graphic with embedded pdfMiklos Vajna
Use case is to insert a pdf file in Impress, then choose Save from the context menu of the image. On one hand, for some reason only bitmap images can be saved, so add an exception for the graphic-with-pdf case. SVG is not affected, as it counts as bitmap with its PNG replacement image, it seems. On the other hand, copying the GraphicObject around triggers swapout/swapin of the graphic, and there the original pdf data was lost, fix that. Change-Id: I8b4b67cd951e39b0250a101766f487ddb1088cab Reviewed-on: https://gerrit.libreoffice.org/26739 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-27Clean up uses of Any::getValue() in svtoolsStephan Bergmann
Change-Id: Id11dc4724fed4e43981534ffac5ec5358f9387b2
2016-06-24clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: I1660e3ed5eb5fac276f3715fe1ffa2308408f1b5
2016-06-24loplugin:singlevalfields in vcl(part1)Noel Grandin
Change-Id: I0031199937cc95793951a070c4b3d8910933e69f Reviewed-on: https://gerrit.libreoffice.org/26595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-24loplugin:singlevalfields in svtoolsNoel Grandin
Change-Id: I80fe1d4646af2b8d8e6362a25f6cda4b7ac29eab Reviewed-on: https://gerrit.libreoffice.org/26603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23VclPtr: svtools error message dialog doesn't disposeCaolán McNamara
Change-Id: I83640cc60d5e0239d228c749c32f896df5e2d9f2
2016-06-23tdf#46279 Show restart message after extension installationirem
Change-Id: I91feab63b77055b8f73d0fb481a76586b249160c Reviewed-on: https://gerrit.libreoffice.org/24595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>