summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2020-07-08let spinbutton stretch to fill areaCaolán McNamara
Change-Id: I5411fe7cf49a1c9fdc1d9090347ca82736ba4e7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98324 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-07let browsebox entry stretch to fit allocated spaceCaolán McNamara
Change-Id: I7b09fd8cebed503c86b3df131eb2d7b1a07ef21c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-06weld DbNumericField itemCaolán McNamara
Change-Id: I96b7945cdf9f00c3d0a4e043ee77666e19c8a072 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-06split off key processingCaolán McNamara
so we can explicitly call it rather than let implicit PreNotify process it Change-Id: I5f27b8c34a0be7239303307a2d5e93e5de4f4c2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98172 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-06clarify that the parent is always a BrowserDataWinCaolán McNamara
Change-Id: I64aac74902c631e41fd54d7e198276885e2c4378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-06expose that GetDataWindow is always a BrowserDataWinCaolán McNamara
Change-Id: I63e29131dc5186dcb72b06f6425479271f191b0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98170 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-04tdf#134479 allow disable font preview to work on existing font comboboxesCaolán McNamara
not just newly created one. you can only restore back to a text-only view, not a text+(icon/whatever) view Change-Id: Ic3becd7a942ee6b1dbabb57eebf1e25d1b626fdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-04Removed executable permission on cxx fileAndrea Gelmini
Change-Id: Id2139b19566a69e0e6e95346cab85dee6ef90943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97812 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-07-03rename FormattedEntry to EntryFormatterCaolán McNamara
Change-Id: I96079720f60b789f0b8d5483973150cb050e87e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97859 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03change FormattedEntry to not own the Entry it operates onCaolán McNamara
Change-Id: I5b5753312a5bbfed3dbcdc47cc1781cbcf168750 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03drop some unnecessary includes and forward declaresCaolán McNamara
Change-Id: I05bf82e3fc295d6f3f42287763c53b8e21da4b67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97824 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03loplugin:unusedenumconstantsNoel Grandin
Change-Id: I6dde54ddc2a2be4a9bbe11cdb52550de7f6a1023 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03RESTART_REASON_OPENGL is deadNoel Grandin
since commit 9dc7b88f5d3a3af0307b4ae39a01247677907d80 Date: Mon May 4 11:50:03 2020 +0200 remove checkboxes for enabling OpenGL Change-Id: I0b787d6d3ea235fa75b537c90b1d9e74837647c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-02Hardcode script for "Noto" CJK fonts & add USCRIPT_JAMODaeHyun Sung
1. Hardcode script for "Noto" CJK fonts. The "Noto" CJK fonts support to Simplified Chinese, Traditional Chinese, Traditional Chinese HK, Japanese, and Korean (Pan-CJK fonts). Nowadays, Noto CJK Fonts are shown '简繁'. Noto font's KR(Korean, 한국어/한글) & JP(Japanese,日本語) represent Korean(KR, It shows '한글') and Japanese(JP, It shows '日本語'), respectively. These are not expressed in Chinese fonts, such as Simplified Chinese(简) and Traditional Chinese(繁). Also, Both TC(Traditional Chinese) and HK(Hong Kong) represent 繁. It don't shown 简繁. so, SC(Simplified Chinese) represent 简, It don't shown 简繁 So, I fixed Font select option's Noto CJK-series font Examples on LibreOffice Noto Sans CJK HK 简繁 -> Noto Sans CJK HK 繁 Noto Sans CJK JP 简繁 -> Noto Sans CJK JP 日本語 Noto Sans CJK KR 简繁 -> Noto Sans CJK KR 한글 Noto Sans CJK SC 简繁 -> Noto Sans CJK SC 简 Noto Sans CJK TC 简繁 -> Noto Sans CJK TC 繁 Noto Sans Mono CJK HK 简繁 -> Noto Sans Mono CJK HK 繁 Noto Sans Mono CJK JP 简繁 -> Noto Sans Mono CJK JP 日本語 Noto Sans Mono CJK KR 简繁 -> Noto Sans Mono CJK KR 한글 Noto Sans Mono CJK SC 简繁 -> Noto Sans Mono CJK SC 简 Noto Sans Mono CJK TC 简繁 -> Noto Sans Mono CJK TC 繁 Noto Serif CJK JP 简繁 -> Noto Serif CJK JP 日本語 Noto Serif CJK KR 简繁 -> Noto Serif CJK KR 한글 Noto Serif CJK SC 简繁 -> Noto Serif CJK SC 简 Noto Serif CJK TC 简繁 -> Noto Serif CJK TC 繁 check the Noto CJK Fonts https://github.com/googlefonts/noto-cjk 2. add USCRIPT_JAMO It related with commit, ff0ed60c769da6f46acd9388e46922987e321d06 "change USCRIPT_JAMO language value for Unicode" Jamo(자모/字母) is composition elements of Korean Alphabet, Hangul Syllable(음절) Example] 각 Decomposition of hangul syllable Unicode code point: U+AC01 Hangul(한글) ‘각’ jamo(자모/字母): ‘ᄀ’ plus ‘ᅡ’ plus ‘ᆨ’ choseong(초성/初聲):ㄱ (codepoint: U+1100) jungseong(중성/中聲):ㅏ(codepoint: U+1161) jongseong(종성/終聲):ᆨ (codepoint: U+11A8) Change-Id: I9ad14ce14a2168a4c3ac4e7cb6c7e5cfbaad39ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97344 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-02weld FormattedControlCaolán McNamara
by using the newly split out Formatter to do the number formatting but input/output to/from a weld::Entry Change-Id: Ic9e619dc5d1ed2fae87e2d89a40dc51f3881468f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-02Upcoming improved loplugin:staticanonymous -> redundantstatic: svtoolsStephan Bergmann
Change-Id: I947b8def12bf27093dc9ad95077c0718dec959a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97696 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01weld EditControl for browseboxCaolán McNamara
Change-Id: I8f21c12f7ee10e1b9ba883a8ff01bb5252429f09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-29make browser rows slightly tallerCaolán McNamara
Change-Id: I6a466bfd43bb38cafa4cea0c1e68ed788922b53f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97405 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-28decouple IEditImplementation from Edit moreCaolán McNamara
Change-Id: Ie01373ca40d519c179485bd1a4b6616d5929fa5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97328 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26update some pchesCaolán McNamara
Change-Id: I54b734062d94a59c2651827c02349d9562ac6cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26weld FixedTextControlCaolán McNamara
Change-Id: I0a2983aa4d389aa0e65aa117d576295d02460b4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97236 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26weld FixedImageControlCaolán McNamara
Change-Id: I13f3480794232a9c203ae047a4fcad372988b8b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97235 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26weld SpinfieldControlCaolán McNamara
Change-Id: I1696105ead648c86076f05f50f6286e9a3a932d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26vcl: split off QueueInfo to own filesChris Sherlock
Change-Id: Ib2904066edd371229c5daa09b81b210e99853895 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96251 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-24use more std::container::insert instead of std::copyNoel Grandin
which is both more compact code, and more efficient, since the insert method can do smarter resizing Change-Id: I17f226660f87cdf002edccc29b4af8fd59a25f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-21weld DateField Calendar floating windowCaolán McNamara
Change-Id: I8d839a09b787e2b8ac1389633a39a3cd969fb1c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96816 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-14Related: tdf#132966 scrollbar not tracking valueset cursor positionCaolán McNamara
Change-Id: I408d872f89da67cd91f0282c1624fd33ddc6c538 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96298 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-14Resolves: tdf#132966 flag scrollbar to reformat when QueueReformat calledCaolán McNamara
Change-Id: I0fbb6eeab86b6ea43b271975eacad5faf7205246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96297 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-14bundle copies of the same ValueSet pattern together as a methodCaolán McNamara
Change-Id: Iea3c1de70ca840371aaffa3de678a622aa450c74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96296 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-12Language list: + Aka (CAR); Yaka -> Yaka (Congo), + Yaka (DRC) [yaf-CD]Eike Rathke
Change-Id: I4bf1e1affa046fcc9c7f06c8bbf6a40fc9c26cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96167 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-06-12weld checklistmenuCaolán McNamara
rework the "menu" to be a treeview using hover selection instead of a custom set of widgetry, and drop the newly unused custom a11y code Change-Id: Ie7d9b7875ce00843b3f262882816cebb472bf681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-07tdf#129537 call it none_line_button not none_color_buttonCaolán McNamara
Change-Id: I8b4c7028b7622d98531b1a0276d1047f47205368 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-06tdf#129537 duplicate context in two different modulesCaolán McNamara
Change-Id: I39c710c224081175d62a0d419e6cbece5576a7a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-05Upcoming loplugin:elidestringvar: svtoolsStephan Bergmann
Change-Id: I950ae6fd44cc346af8be6669c8c5432fc0aa9ceb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95571 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03loplugin:simplifypointertobool improveNoel Grandin
to look for the x.get() != null pattern, which can be simplified to x I'll do the x.get() == nullptr pattern in a separate patch, to reduce the chances of a mistake Change-Id: I45e0d178e75359857cdf50d712039cb526016555 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-30loplugin:simplifybool extend to expression like !(a < b || c > d)Noel Grandin
mostly to catch stuff from the flatten work, but I think this looks good in general Change-Id: I7be5b7bcf1f3d9f980c748ba20793965cef957e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92493 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-22Related: tdf#133189 values not updated when units changedCaolán McNamara
do it for all of them, not just the writer one. A braver move. Change-Id: Ib1f635ccc6a70c1ef00f82449bd351c82da7a13d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94707 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22tdf#133043 explicitly set the combobox edit textCaolán McNamara
because earlier we set it to "" rather that set_active(-1) so its still at the same active pos with the wrong text so setting a new active pos that's the same as the old active pos is a nop from the vcl case the original code used Edit::SetText so leave the logic as it is traditionally rather than try to change that Change-Id: I520d1c0371579850d073d37295ccc7d852298aaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94699 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22move InterimItemWindow to vclCaolán McNamara
Change-Id: If0a4a14708810c44d087b51961f2ecb3fda4df23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22remove Size arg from Window::Draw and depend on GetSizePixelCaolán McNamara
90% of cases pass GetSizePixel as the Size arg already and this aligns Window::Draw with how Window::PaintToDevice works Change-Id: If5b024179a4b7a3b099177c2f6d4b1fb006b95ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21tweak to narrow stretchable widget defaultsCaolán McNamara
Change-Id: Idcaea1fbd9df0389e2182f1014e8d3ed45d1b2f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94604 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21center vertically the interactive cell widgets if they won't fitCaolán McNamara
Change-Id: Iae7cc83ece1707e9fd38708e4f0911e529565f23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21use for-range on Sequence in sfx2..swNoel Grandin
Change-Id: I09806869f2fdbae61f4c5d5c9db6859202bb63b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-21weld ListBoxControlCaolán McNamara
Change-Id: I5a8c7d68e4c147eb938b0217dc6368c832e465c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94154 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-20weld ComboBoxControlCaolán McNamara
Change-Id: Ie862bb782b4c3e203af88d45c850ce0cab60f2e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94123 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-19Related: tdf#132536 limit to ~25 pre-rendered font previews for nowCaolán McNamara
The font caches look b0rked, the massive charmaps are ~never swapped out, and don't count towards the size of a font in the font cache and if the freetype font cache size is set experimentally very low then we crash, so there's an awful lot to consider there. Change-Id: I0e322109c02b00cfb6aff88b4fa650ac3cb1f178 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94466 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-15Resolves: tdf#132461 set color on mouse release, not pressCaolán McNamara
and rearrange to allow dnd to drop the currently selected color, not the one seen by SelectHdl which is now called on mouse release which allows the dnd from color bar to gradiant tool to work as expected Change-Id: Ib54850ff8f73dc3a0d08c76060309a7a74d2cc8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-13loplugin:unusedmethodsNoel Grandin
Change-Id: Id813d95a90fdbb360dfc8670c0b55b635f633965 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10new loplugin:simplifypointertoboolNoel Grandin
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>