summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)Author
2014-01-24coverity#708304 Uninitialized scalar fieldCaolán McNamara
Change-Id: If82964036862e309dc1c90036df59942a24fd7d6
2014-01-24coverity#1158253 Dereference before null checkCaolán McNamara
Change-Id: If653cc6dc0b53f66728500d779460ee352924947
2014-01-23coverity#1158464 Uninitialized scalar fieldCaolán McNamara
Change-Id: I73fc73421ab1abcc801bb4372e9584fcbf381bcf
2014-01-22Only allow approved border styles in cell borders.Kohei Yoshida
Line styles such as inset, outset, embossed etc are not supportable in Calc. So, don't show them in the UI. Change-Id: Ie7be74193d01e13a79132a979e2d9a2e4d06de3f
2014-01-22remove SvStream::operator<< methodsNoel Grandin
.. and convert the last few places still using those methods. Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd Reviewed-on: https://gerrit.libreoffice.org/7495 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22convert more SvStream::operator<< callsNoel Grandin
.. to more explicit SvStream::Write* calls This was done using another run of the clang rewriter, and then a lot of hand tweaking to fix all the places where the rewriter did not play nice with various macros. Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18 Reviewed-on: https://gerrit.libreoffice.org/7494 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22Introduce static inline cppu::acquire(), and make use of that.Jan Holesovsky
This is much better approach compared to the callback function, as it allows passing arguments to the c++ constructor directly, while still allowing some additional initialization after having acquired the instance. Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-22bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-21Change _get_implementation()'s not to do initialization directly.Jan Holesovsky
Many of the initalizations (in eg. framework) have to be done on an acquire()'d object, so instead of doing the initialization directly, return the initialization member function back to the createInstance() / createInstanceWithContext() / ... and perform the initialization there. As a sideeffect, I belive the calling initialize() from servicemanager is not that much a hack any more - whoever converts the implementation to be constructor-base has the choice to provide the callback, or still initialize through XInitialization, where the callback is preferred by servicemanager when it exists. Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-21bool improvementsStephan Bergmann
Change-Id: Id1a0df17a28372f9d7c3a88424cf7656fed46f9a
2014-01-21bool improvementsStephan Bergmann
Change-Id: I85faf4e3fcab6763af11eb6a4082820e88bea1ca
2014-01-21boradcast->broadcastCaolán McNamara
Change-Id: I96720843f815bf6d499eb424c3e4ff579c2bbe23
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-20Removed unused solar.h reference in svtoolsAlexandre Vicenzi
Change-Id: Ic1dc7c32bb749888bc8751d4d488ba76e46b155f Reviewed-on: https://gerrit.libreoffice.org/7517 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-20Better pixelization of dashed lines for screen rendering.Kohei Yoshida
Now the dashed lines are evenly placed on screen. For now, horizontal lines only. I'll work on vertical lines later. Change-Id: I474e9c8214e5f079ea2cfca12b35381d8fcf2ae1
2014-01-20Revert "svt: Use constructor feature for FilePicker and FolderPicker..."Jan Holesovsky
It does not make a real sense to use constructor for implementations that act as a trampoline; instead, we should do a constructor for the real implementations that hide behind it. This reverts commit 2fbb47156773b2e300fc987efc2da85c66e567d1. This reverts (part of) commit 58ea27124af27bfac21a796b0d13d72354bd0dd3. This reverts (part of) commit 194bdbde25dd70988c94ff5e1af43b530d47d94b. This reverts (part of) commit df002e39f7518036ae1c1d2afec7a525ef902327. This reverts (part of) commit eb89c6f7dcd613cda6a9eee6f7897225e0334a25. This reverts (part of) commit bdeb57c23973f3ef79020847b2fe39f312cf3c0b. This reverts (part of) commit 4337a0664f4fb73f9e1be74f2a632847871da402. Change-Id: Ibd9b1066f3b6ea215d8da9f491d5f026cd75b029
2014-01-20Minimize the constructor functions to a bare minimum.Jan Holesovsky
Most of the constructors are supposed to be only a call of new TheInstance(arguments) or an equivalent; so let's just change the constructor caller accordingly, to accept unacquired new instance. If there are exceptions that need to do more heavy lifting, they do not have to use the constructor feature, or there can be a wrapper for the real implementation, doing the additional work in their (C++) constructor. Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
2014-01-20Remove unused Window parameter from SystemSettingsChangingChris Sherlock
This took a bit of code archaelogy for me to track down. It turns out that as part of an effort to optimize startup, the line of code in this function was commented out, presumably to be rewritten later. This happened in commit ee3351d78c in July 2001 (!). About three years later, in February 2004, the function was rewritten in commit 189c2388d80. As it turns out, the only two functions that used the Window parameter were vcl/source/window/window.cxx (which passed itself in, but of course this did nothing) and vcl/source/window/winproc.cxx. Furthermore, winproc only ever passed in the first frame, so it didn't really do anything either. Consequently, the function as it stands *now* only notifies the application that system settings have been changed. It doesn't care which window it tells. Therefore, I have excised this parameter from the function. I don't think it made sense when it was implemented anyway, so there is no net loss. After removing the unneeded parameter, I was also able to remove the Window parameter from winproc.cxx's ImplHandleSalSettings function as it was only ever used to set the top level window, which is now irrelevant. Change-Id: I84f2c5c5ff8969387da3af81e4a9c7f9ac6237e1 Reviewed-on: https://gerrit.libreoffice.org/7541 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-20Related: #i56998# use FUNIT_PERCENT on fields that allow relative valueTsutomu Uchino
(cherry picked from commit fc6fc5b576b972a8ea0551091cc57aa1cfe1334d) Conflicts: svtools/source/control/ctrlbox.cxx svx/source/dialog/relfld.cxx Change-Id: Ic8f0f550dbbcab0678fbeb9bf45a478b0cea642d
2014-01-18Unify ctor functions for component implementations.Matúš Kukan
There is no need to use different styles for writing the same thing. It also makes it easier in future to use search & replace. But of course, there are also some more complicated functions. Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
2014-01-18Window::PreNotify should return boolStephan Bergmann
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-17Revise the line patterns further. Now they look satisfactory to my eye.Kohei Yoshida
Change-Id: I27f4e11bceac25c10de28a866bdcec9576027582
2014-01-17Apply dashing without consulting current map unit.Kohei Yoshida
Using scaling is sufficient. Change-Id: If976bec3940772432d814a77681170d7c99306d2
2014-01-17More fine-tuned stroke patterns.Kohei Yoshida
Only the pixel map mode is visually inspected. Change-Id: Ia8ac978a0d3049d7e7162f1157822b85d475dfdf
2014-01-17Remove STYLE_* and use css::table::BorderLineStyle instead.Kohei Yoshida
Change-Id: I187511dbf85ecdfe0c5d05c6f77cf4ac93363051
2014-01-17Window::Notify should return boolStephan Bergmann
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17removed some unused code (svx, svtools, unotest)Petr Vorel
Change-Id: I1250581d69423030bd0a93a1529458b8d424ce3e Reviewed-on: https://gerrit.libreoffice.org/7329 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-17Pass initialize arguments directly into ODocumentCloser' ctor.Matúš Kukan
Change-Id: I1bcfe6d59230a4137b0f78d072c895e596ff6f15
2014-01-16fdo#71511: reload ColorConfig after tweaking relevant a11y settingsBjoern Michaelsen
note that the autodetect HC option is somewhat broken anyway: it resets the icon theme hard, so there are not simple roundtrips enableing/disabling it for that, but those havent been there before either. Change-Id: Ia35a41717224dfb7437054bb885c61d7e0b189d7
2014-01-16fdo#71511: in autodetected a11y HC mode, pull background color from themeBjoern Michaelsen
- dark theme default to high contrast - as per fdo#35365, having a dark document background is inconvenient for non-a11y endusers - a11y standard require the (rather ugly) background for a11y - thus, when "automatically detect high contract mode of operating system" in Tools->Options->a11y is enabled, use the dark document background by default, otherwise use a white default Change-Id: Id8ad1eb3d57b3708ac5a241092208e3a8d98ade0
2014-01-16convert SvStream::operator<< overloads to more explicit methodsNoel Grandin
This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16fdo#54938: Convert svtools to cppu::supportsService...Marcos Paulo de Souza
...final part Conflicts: svtools/source/filter/SvFilterOptionsDialog.cxx Change-Id: Ie4a0a7ea8ec65b3e632d06627bba40a26c9a7a91
2014-01-16svt: Use constructor feature for OAddressBookSourceDialogUno.Matúš Kukan
Change-Id: Ie046b43f40bd704090bbca4d14ea5321ff7639d9
2014-01-16svt: Use constructor feature for GObjectImpl.Matúš Kukan
Change-Id: I324dd00205319fe4e8f7b0b352ed2ab6422fcbbd
2014-01-16svt: Use constructor feature for Wizard.Matúš Kukan
Change-Id: I25e31c57c58e26e4de9d0ccc63ae1f6f0c86505b
2014-01-16svt: Use constructor feature for SvFilterOptionsDialog.Matúš Kukan
Also fix the implementation name. Change-Id: Ic7c8c77b819c0368cfbc95f16f6cce09a6a3de16
2014-01-15Use const& arguments parameter for ctor functions.Matúš Kukan
Change-Id: I19ce8bd1a23123ac9a62a7fc95cd54fea5315221
2014-01-15Initialize constructor based implementations in one place.Matúš Kukan
Change-Id: I324f25bb5ec7d792c3e015815f2a11b08f519764
2014-01-14fdo#51180 reset (Multi)Selection on Clear()Lionel Elie Mamane
Change-Id: I06dde63093eab4e5e1c692f6363aca70b89de96a
2014-01-14longparas: drop STRING_MAXLEN use nowCaolán McNamara
Change-Id: Iaaca13e732c234e9051be0ab66a7625f9c106eea
2014-01-13longparas: STRING_LEN is intended here to expand to string lenCaolán McNamara
so just expand it on entry instead Change-Id: Ieb9c7501dccf9da91c7b8377ad75739cbe1c3609
2014-01-13remove _STRING_HXX gibbereshCaolán McNamara
Change-Id: I618aa9a2752014d392516a578e454bf6443fc6ba
2014-01-13SvTreeListBox::ExpandingHdl should return boolStephan Bergmann
Change-Id: I39a854910299ab2e7c64beabda381bb9f0bd2891
2014-01-13disentangle CalcSizeCaolán McNamara
Change-Id: I42248ff611dbe7c109076da5d548717898341be3
2014-01-12cppcheck: Add missing right parenthesisJulien Nabet
Change-Id: I960ac0348bda310652edf36c0acc08f26c328946
2014-01-11longparas: convert GetMaxVisChars from xub_StrLen to sal_Int32Caolán McNamara
Change-Id: I25fcfc3ae5a599bbd7ebef3071895ec9dbf2949e
2014-01-10Use boolStephan Bergmann
Change-Id: I2f1c543b106e24ff49f876dbb3d8e94f4ebf03ba
2014-01-10Use proper bool operationsStephan Bergmann
Change-Id: I758a84205044e51f1af6b18f145e2033f32921e1
2014-01-10EndDialog takes long nResult, not boolStephan Bergmann
Change-Id: I04210f48f091a652b7867754484a9c5dd6b19471
2014-01-10SfxPoolItem::operator ==, != should return boolStephan Bergmann
...and SfxEnumItemInterface::HasBoolValue, too. Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
generated by cgit (git 2.34.1) at 2025-01-15 08:13:01 +0000