summaryrefslogtreecommitdiff
path: root/svx/inc
AgeCommit message (Collapse)Author
2016-09-13loplugin:dllprivateStephan Bergmann
Change-Id: I1fe70a39c50aba8b84c117653185fc37dbbfeab0
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13Remove nonsense comments: // bitfieldTor Lillqvist
Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-09-09loplugin:constantparam in svxNoel Grandin
Change-Id: Id08850b90a0e286ff837dd6b0c1691fa7dc793fa Reviewed-on: https://gerrit.libreoffice.org/28746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-02loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I2ed581e58523ac8b52aa520f7a02f69f408665fe Reviewed-on: https://gerrit.libreoffice.org/28587 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-30coverity#1371300 Missing move assignment operatorCaolán McNamara
Change-Id: I4add8d1f0e1f007d247d4fe9f6fa2048b792c1b0
2016-08-25convert E3dDragConstraint to typed_flags_setNoel Grandin
Change-Id: Idd6d3e1ed0248b54247b2d86ce771ac5f5bb7c41
2016-08-25convert SgaObjKind to scoped enumNoel Grandin
Change-Id: I1bc1244646db661f181d4224d81f12d613976362
2016-08-23convert SdrHdlKind to scoped enumNoel Grandin
Change-Id: Ib0a06d94f8b51cce1f29f20d1c00d54be939c076
2016-08-23convert SdrHelpLineKind to scoped enumNoel Grandin
Change-Id: I640fc5497571f93068f613dff2f02e12848124f0
2016-08-19Resolves: coverity#705366 Mixing enum typesCaolán McNamara
and coverity#705367 Mixing enum types coverity#705371 Mixing enum types coverity#982694 Mixing enum types coverity#1027717 Mixing enum types coverity#1371228 Mixing enum types coverity#1371242 Mixing enum types coverity#1371280 Mixing enum types coverity#1371310 Mixing enum types MapUnit and SfxMapUnit share the same values and are freely cast from one to the other. Now that commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527 Date: Thu Aug 11 15:02:19 2016 +0200 loplugin:unusedenumconstants in package..svtools removed the SfxMapUnit entries that were directly unused, they don't match anymore and casting from one to the other is dangerous. Why there was two of these anyway escapes me, get rid of SfxMapUnit and just use MapUnit universally Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e Reviewed-on: https://gerrit.libreoffice.org/28234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-11loplugin:countusersofdefaultparams in svl..unodevtoolsNoel Grandin
Change-Id: Ie3d2cf29e99b8a51b80246aafa23a92e6c3404b2 Reviewed-on: https://gerrit.libreoffice.org/28017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27loplugin:countusersofdefaultparams in svxNoel Grandin
Change-Id: Ic46a0dcce477c8b27aa2d4771c48fd45ad73718c Reviewed-on: https://gerrit.libreoffice.org/27574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-20svx: rotate drawn (non-bitmap) handles with the objectTomaž Vajngerl
Change-Id: Id0cad502fd99737a35d894109deae4f26df36d06
2016-07-14tdf#62525 vcl: use cow_wrapper for ImpXPolyPolygonXisco Fauli
Change-Id: Ida272942d2fdb0a4a7d4906bbbc2423b459591ac Reviewed-on: https://gerrit.libreoffice.org/27170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13tdf#62525 vcl: use cow_wrapper for ImpXPolygonXisco Fauli
Change-Id: If3596f7b2b546f360774e995867d18c9ba543737 Reviewed-on: https://gerrit.libreoffice.org/26785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-12new loplugin fragiledestructorNoel Grandin
fix up a small number of places that it finds Change-Id: Iedc91e141edfb28f727454f698cd2155a7fd5bf4 Reviewed-on: https://gerrit.libreoffice.org/26566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30tdf#89616 Find toolbar: Activate search arrows when input has textSamuel Mehrbrodt
Not only when input is modfified Change-Id: Ic6b94dbfba34ec6eb88c9c385aaa36a7bac19de7 Reviewed-on: https://gerrit.libreoffice.org/26782 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-28loplugin:singlevalfields in svxNoel Grandin
Change-Id: I7a2d11e1343f6382c3556c4536fc8ae40e210b74 Reviewed-on: https://gerrit.libreoffice.org/26710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-27GSoC notebookbar: switching tabs depending on contextSzymon Kłos
+ sfx2::sidebar::EnumContext moved to the vcl module + TabPage contains vector with context values + vcl builder reads control's contexts from the "class" mark + ContextTabControl shows tabs depending on context Change-Id: I661b0d3f35d46ace2a2e8eb1d374148f0c60017d Reviewed-on: https://gerrit.libreoffice.org/26447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-25loplugin:privatebaseMarkus Mohrhard
Change-Id: Ide542c847304087e555b1742274e509184a0edce
2016-06-25uitest: add wrapper for special character windowMarkus Mohrhard
Change-Id: I22acd9da3570e967f427207e242638f2bfd6ffb7
2016-06-10loplugin:mergeclasses SdrItemBrowserNoel Grandin
Change-Id: I90c6006be05f182fd442ce8d3641f4f17cdb6793
2016-06-06remove unused constants in HRC filesNoel Grandin
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1 Reviewed-on: https://gerrit.libreoffice.org/25817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26loplugin:unusedmethodsNoel Grandin
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda Reviewed-on: https://gerrit.libreoffice.org/25431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-19loplugin:unusedmethods in svxNoel Grandin
Change-Id: Ia22e8b55d263224dbb85169b6165a5c116e163aa Reviewed-on: https://gerrit.libreoffice.org/25088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16convert GALLERY_ITEM to scoped enumNoel Grandin
Change-Id: I7b3b2b72baf58cd7713418ea36d6a2fe6e0e12e9 Reviewed-on: https://gerrit.libreoffice.org/24962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11sd: remove pointless micro-optimizationMichael Stahl
Change-Id: Ib5c9e79d21969922feeed5cd1908f238608401e4
2016-04-14loplugin:passstuffbyref in svxNoel Grandin
Change-Id: I7d405830785cb12aaceb65d6ed03dda04aa90fd8
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I85135c3fa5e6fe823491739c3c1ab601505f0626
2016-04-07Avoid reserved identifiersStephan Bergmann
Change-Id: I438a7f28ba6bc68ec4e6244a4343e4040ab1b997
2016-04-05convert src line width popup to .ui formatCaolán McNamara
Change-Id: I39e8bfd89538c36c97afb3e4e86c3ba9156274e0
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17loplugin:constantparam in svxNoel Grandin
Change-Id: I50fa7e4c7525d2f8107a11d8203957a47680eb80 Reviewed-on: https://gerrit.libreoffice.org/23303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07expand src templatesDavid Tardon
Change-Id: Id35caa8b8ed0c2f7e4d868f5c87a2a0f331cb352
2016-03-07expand src templates only used in a single placeDavid Tardon
Change-Id: Ic18e4c0a1617f0284b7ffcfb8859cdced4949471
2016-02-29crashtesting: sync PageProperties::SetStyleSheet with GetStyleSheetCaolán McNamara
PageProperties::GetStyleSheet returns 0 so PageProperties::SetStyleSheet should do nothing Change-Id: If627ba3e31b14ff5178f45125f0ce6e4dbf93ec0
2016-02-28Unused resourcesMaxim Monastirsky
Change-Id: I35396812b07e077440698a4e862762aeada0785e
2016-02-28Revert "Unused resources"Maxim Monastirsky
Why it doesn't fail in my local build? This reverts commit cd98e0725ea9b8389297b80d6c8620f4b63f482d. Change-Id: I1cf8c037cdaaf43f8fe2d42c9e2c8bd40d3608f6
2016-02-28Unused resourcesMaxim Monastirsky
Change-Id: I92cfdca70924ea3397b2c940bc35f153c3c5de89
2016-02-28Kill sfx2 menu supportMaxim Monastirsky
Change-Id: I340a066881b1962a4bcd5a2b7d9a0425d8b9557c
2016-02-22loplugin:write only fieldsNoel Grandin
Change-Id: I45895e9845a9037da207f001fece427452ed499f
2016-02-21tdf#93837 Convert RID_FM_TEXTATTRIBUTE_MENU to xmlMaxim Monastirsky
Change-Id: Ic37bfb9e25eba9b03b2c896c904823aec478355e
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>