summaryrefslogtreecommitdiff
path: root/svx/source/customshapes
AgeCommit message (Collapse)Author
2014-09-01Consistency around SvxB3DVectorItem in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I7f2348d82c76f6f231e34f0dfc4b6ee6fddffe55
2014-09-01Consistency around SvxColorItem in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: If26ab3229871d2d6a7e4e7e8f79f4cb927b96930
2014-09-01Consistency around SfxUInt16Item in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I2e467df03a34d694214e0560476cb7fd76ef0735
2014-09-01Consistency around SfxBoolItem in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I3253b4cc5657a7d6b960ee892584109d373eed3d
2014-08-25Remove unnecessary invalid downcastsStephan Bergmann
Change-Id: I04a6fa07ef4dfd2609b466c7c8ff9ba925c9683c
2014-08-22Point and Rectangle coordinates are long, not sal_Int32Stephan Bergmann
Change-Id: I0f97d12f55e506af699976bf81f4dcf956195aab
2014-08-19svx: Cleanup ASCII art and useless commentsChris Laplante
Change-Id: I5399362056276f324fd43eda05d3f606dc6f8c71 Reviewed-on: https://gerrit.libreoffice.org/11011 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-18drop unnecessary shl.hxx includesCaolán McNamara
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-16Reserve vector capacity in advanceMatteo Casalin
Change-Id: I2ee5913a274eecf86ad6bbf19b99e1fe61f0ade7
2014-08-16Consistently use size_t and SAL_MAX_SIZEMatteo Casalin
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-08Cleanup OUStrings in CustomShapesJoren De Cuyper
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, removing stray left-over sSecondLightDirection declaration Change-Id: I5c7f5c956b70adad953b52be3d456775b0f5fbc1
2014-08-05Consistency around SdrOnOffItem in svx/sdshitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Id712c222034ef807ea2d7bc459e78882e948aca6
2014-07-25coverity#1209371 Division or modulo by float zeroCaolán McNamara
Change-Id: I8834b81b71746daaf97f7b62d09421d5165fa707
2014-07-20vcl consitent use of long for corrdinateNorbert Thiebaud
most of length in vcl are calculated in 'long' but array of X position tend to be in sal_Int32. As a prep work to be able to support 'double' as the base type of Device Coordinate, harmonize the use of 'long' for non-float coordinate. Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-19XFillStyle -> css::drawing::FillStyleMiklos Vajna
Change-Id: I6b2fabd72fd34f4ac1b3a18f386c90794bc39ce4
2014-07-04coverity#704499-501 Division by zeroNorbert Thiebaud
Change-Id: I5f082f10cb6822707a279d5b38ef2936ad2e5c41
2014-06-17svx: fix VML export of rectangles imported from drawingMLMiklos Vajna
This wasn't a problem before, as EnhancedCustomShapeTypeNames wasn't involved for the export of rectangles, as those were handled in sw directly. CppunitTest_sw_ooxmlsdrexport's testFdo69636 is a reproducer for this problem, the VML fallback part was empty due to this. Change-Id: Ib2622fe05ddaa66bb3231977e30a8a1ca8748001
2014-05-30coverity#705256 Missing break in switchCaolán McNamara
Change-Id: I173926b7966d0d75b51652a3983d73923fa2e575
2014-05-27reportdesign: Fix applying the last used colorMaxim Monastirsky
The last used color is stored inside SvxColorToolBoxControl, so we must call its Select method to do that. (This also fixes using the last shape, See commit ce842113ae728e8995c7c5398204a20d0707e843 for a fix of exactly the same problem in chart2.) For the font color, there was also another problem: The SID used for that button is SID_ATTR_CHAR_COLOR2. The problem is that SvxColorToolBoxControl::Select actually calls for that SID the ".uno:CharColorExt" command instead of ".uno:FontColor" (which activates in writer the format paintbrush mode). Given that since commit 584b415924bba22db23a4258062e54973de0ed7c this command also receives the last used color as argument, the easiest solution is to register ".uno:CharColorExt" here as well. Change-Id: I2db25a7fb537ce10dfec7b1c2d049dd77d9f8f6b
2014-05-26coverity#705254 Missing break in switchCaolán McNamara
Change-Id: I5dc24b0f811042732a31f1d0fff42bf400505a1a
2014-05-26coverity#705253 Missing break in switchCaolán McNamara
Change-Id: I372299fa9f4fb5a41fed88cba8b23557be24eb3b
2014-05-10coverity#708341 Uninitialized scalar fieldCaolán McNamara
Change-Id: I1169024f243e447f315f796fdc9c53e8b9006602
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-04-21remove comments why a file gets includedThomas Arnhold
also remove some commented out code Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-15svx: sal_Bool->boolNoel Grandin
Change-Id: I464eba5fd5521c31868c6fc8a2137f17428d421e
2014-04-11coverity#708341 Uninitialized scalar fieldCaolán McNamara
Change-Id: If053235eea2d8f003021de733ea73783cf34ed6d
2014-04-05fdo#43157 : clean up OSL_DEBUG_ONLYMichaël Lefèvre
Change-Id: Ic92b64cfaec41bf4104cede5f26579d86543b9a8 Reviewed-on: https://gerrit.libreoffice.org/8804 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2014-04-03remove unnecessary scope qualifier from sal_Bool usesNoel Grandin
i.e. convert "::sal_Bool" to "sal_Bool" Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03sfx2/tbxctrl.hxx: sal_Bool->boolNoel Grandin
and clean up the mess around the two different Select methods which just led to confusion in the overriding classes. Change-Id: Iea0ea85752180d0dc50d2b4ddb3d861e8447fb0a
2014-03-29coverity#1194928 allocation too small for typeCaolán McNamara
Change-Id: I4d1a3838ef95906b69bf52ba0d04c56859201db8
2014-03-27Second batch of adding SAL_OVERRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-11svx: sal_Bool->boolNoel Grandin
Change-Id: Ia7db5746fa5d8f60111d10d09865120981956947
2014-03-11svx: sal_Bool->boolNoel Grandin
Change-Id: I1b692a9ca5f2580b0815b881a33f3eded7267ac1
2014-03-11svx: sal_Bool->boolNoel Grandin
Change-Id: I78da39fc553b2e5040ee6665377ea51a1c4d04d7
2014-03-11svx: sal_Bool->boolNoel Grandin
Change-Id: I64d9c1bbe6ed85108783bf6a97329fcdc167ca62
2014-03-11svx: sal_Bool->boolNoel Grandin
Change-Id: I41f3935a468f38c59bfbce7096bb086daf6190a3
2014-03-11svx: sal_Bool->boolNoel Grandin
and optimise some methods in bmpmask.hxx - they were unconditionally returning true, so convert them to void return type. Change-Id: If8b092a857ab80ead93112b0d627e41d5ccb3cf9
2014-03-05Operators for Point are only overloaded for long, not doubleStephan Bergmann
...so no use giving double arguments that are implicitly cast to long anyway. Change-Id: I26b9059fc5ab0d55c3f320e2b2f55502423541a9
2014-03-05made ListBox handle more than 64k elements, fdo#61520 relatedEike Rathke
ListBox and related now handle up to sal_Int32 elements correctly. sal_Int32 instead of sal_Size or size_t because of UNO and a11y API. Also disentangled some of the mess of SvTreeList and other containers regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures. Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a Reviewed-on: https://gerrit.libreoffice.org/8460 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from svxAlexander Wilms
Change-Id: I56497d953b0500ba0967fddb36ca8bbbe86c62ad Reviewed-on: https://gerrit.libreoffice.org/8321 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30fdo#63154 Removed unused solar.h ref. in linguc., sfx2, starmath, svl and svxAlexandre Vicenzi
Change-Id: I241661119371b75804fcf9215ff5e5da2a5b9265 Reviewed-on: https://gerrit.libreoffice.org/7732 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-28bool improvementsStephan Bergmann
Change-Id: Ic32faa81bfbb66a9d8632fb3db187e33c31188ed
2014-01-22Introduce static inline cppu::acquire(), and make use of that.Jan Holesovsky
This is much better approach compared to the callback function, as it allows passing arguments to the c++ constructor directly, while still allowing some additional initialization after having acquired the instance. Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-21Change _get_implementation()'s not to do initialization directly.Jan Holesovsky
Many of the initalizations (in eg. framework) have to be done on an acquire()'d object, so instead of doing the initialization directly, return the initialization member function back to the createInstance() / createInstanceWithContext() / ... and perform the initialization there. As a sideeffect, I belive the calling initialize() from servicemanager is not that much a hack any more - whoever converts the implementation to be constructor-base has the choice to provide the callback, or still initialize through XInitialization, where the callback is preferred by servicemanager when it exists. Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-20Minimize the constructor functions to a bare minimum.Jan Holesovsky
Most of the constructors are supposed to be only a call of new TheInstance(arguments) or an equivalent; so let's just change the constructor caller accordingly, to accept unacquired new instance. If there are exceptions that need to do more heavy lifting, they do not have to use the constructor feature, or there can be a wrapper for the real implementation, doing the additional work in their (C++) constructor. Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
2014-01-18Unify ctor functions for component implementations.Matúš Kukan
There is no need to use different styles for writing the same thing. It also makes it easier in future to use search & replace. But of course, there are also some more complicated functions. Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
generated by cgit (git 2.34.1) at 2025-01-24 05:27:57 +0000