summaryrefslogtreecommitdiff
path: root/svx/source/customshapes
AgeCommit message (Collapse)Author
2014-01-30fdo#63154 Removed unused solar.h ref. in linguc., sfx2, starmath, svl and svxAlexandre Vicenzi
Change-Id: I241661119371b75804fcf9215ff5e5da2a5b9265 Reviewed-on: https://gerrit.libreoffice.org/7732 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-28bool improvementsStephan Bergmann
Change-Id: Ic32faa81bfbb66a9d8632fb3db187e33c31188ed
2014-01-22Introduce static inline cppu::acquire(), and make use of that.Jan Holesovsky
This is much better approach compared to the callback function, as it allows passing arguments to the c++ constructor directly, while still allowing some additional initialization after having acquired the instance. Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-21Change _get_implementation()'s not to do initialization directly.Jan Holesovsky
Many of the initalizations (in eg. framework) have to be done on an acquire()'d object, so instead of doing the initialization directly, return the initialization member function back to the createInstance() / createInstanceWithContext() / ... and perform the initialization there. As a sideeffect, I belive the calling initialize() from servicemanager is not that much a hack any more - whoever converts the implementation to be constructor-base has the choice to provide the callback, or still initialize through XInitialization, where the callback is preferred by servicemanager when it exists. Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-20Minimize the constructor functions to a bare minimum.Jan Holesovsky
Most of the constructors are supposed to be only a call of new TheInstance(arguments) or an equivalent; so let's just change the constructor caller accordingly, to accept unacquired new instance. If there are exceptions that need to do more heavy lifting, they do not have to use the constructor feature, or there can be a wrapper for the real implementation, doing the additional work in their (C++) constructor. Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
2014-01-18Unify ctor functions for component implementations.Matúš Kukan
There is no need to use different styles for writing the same thing. It also makes it easier in future to use search & replace. But of course, there are also some more complicated functions. Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
2014-01-15WaE: busted codeCaolán McNamara
Change-Id: Ida6183eea365f7354f69d2b4e55cd97d2424e558
2014-01-15more xub_Strlen->sal_Int32Caolán McNamara
Change-Id: I9bab4c8c0e5b62eace308b90a43800c21c9cba41
2014-01-15Unify ctor functions to have _get_implementation suffix.Matúš Kukan
Change-Id: I07fe0671d0633ef9480a4f3431df6a64c7902db8
2014-01-15Use const& arguments parameter for ctor functions.Matúš Kukan
Change-Id: I19ce8bd1a23123ac9a62a7fc95cd54fea5315221
2014-01-15Initialize constructor based implementations in one place.Matúš Kukan
Change-Id: I324f25bb5ec7d792c3e015815f2a11b08f519764
2013-12-31svx: Constructor feature for last implementations in svx component.Matúš Kukan
Change-Id: Ifc021eabce9ae3dbd1a54edefda7d3ae3eb67b53
2013-12-20Revert "svx: split into direct implementation getFactories"Matúš Kukan
Also reverts "These services are in fact implemented in svxcore library." This reverts commit 090674dcb085cd41f4628e4f07c9a2268a18e862 and commit 4a969ac35174520f1ffeb4f919f5d7bb6d99a628. This is embarrassing; needs more work.
2013-12-20svx: split into direct implementation getFactoriesMatúš Kukan
Change-Id: I888f10a923dc2b97247b2a66cc6bd116eee280a7
2013-12-18vcl get rid of xub_StrLen and STRING_LEN in outdev3Norbert Thiebaud
a new log section (sal.rtl.xub) is used to display alert in case of suspicious len == 0xFFFF (aka STRING_LEN) Change-Id: I3ed2aa7896e12592be9e003580dd6c8eda4add5e Reviewed-on: https://gerrit.libreoffice.org/7117 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-11-27Integrate branch of IAccessible2Steve Yin
Change-Id: I8327fb4ba2a86d4caa52b875221175b80464842a
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OUString::matchAsciiL callsNoel Grandin
Convert code like: defaultValue.matchAsciiL( RTL_CONSTASCII_STRINGPARAM( "nextval(" ) ); to: defaultValue.startsWith( "nextval(" ); Change-Id: I77bdcbf46bec6ded3c16a8248634b1424a1eb4f0
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: I6dc5e1b5e4be546a837b959ab03f248140aeafbf
2013-10-30fdo#54938: Convert svx to use cppu::supportsServiceMarcos Paulo de Souza
Change-Id: I3ab178924cb1c4240511f08625f244dac54e3913 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-28fixincludeguards.sh: svxThomas Arnhold
Change-Id: I885bbc431322ee233f8e67ec2bb5701af909046c
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-08Smiley face now smiles!Ahmad H. Al Harthi
Change-Id: I5f74c866327bfc51c31694db93a9f7f2dad79858 Reviewed-on: https://gerrit.libreoffice.org/6161 Reviewed-by: Faisal al-otaibi <fmalotaibi@kacst.edu.sa> Tested-by: Faisal al-otaibi <fmalotaibi@kacst.edu.sa> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: I4feed2237f71ab4baeee44ca1404072f52e5eca4
2013-10-01convert remnants of String in SVX to StringNoel Grandin
Change-Id: I66fd6387c3fcd33c6ae0b431810abf6679345767
2013-09-09Resolves: #i122777# Corrected texture mapping for 3D CustomShapesArmin Le Grand
(cherry picked from commit d747eabca2eab1032fd16257c9a502eaaa98c5d4) Change-Id: I19139af9e9530214d581720963da6739afd1b987
2013-09-05convert svx/source/customshapes/*.cxx from String to OUStringNoel Grandin
Change-Id: Ie66bbb6280d050d908e0522cc2cb7a1efe627a6a
2013-08-28XubString->OUStringCaolán McNamara
Change-Id: I7b76026012af2b57861ec8d3dfd285d9e871d74c
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-15Better fix for msvc 2012 build fix.Thorsten Behrens
Don't sprinkle code base with random defines, this is all done in sal/config.hxx. Nominally, that file needs to always be included first. Change-Id: Iafa851ea6fd1ba5457dab497566d39d0226e5ecb
2013-08-14Fix Windows build for Visual Studio 2012Jesús Corrius
For more information see: http://msdn.microsoft.com/en-us/library/4hwaceh6(v=vs.110).aspx Also it looks like limits includes math somehow so move the include lower. Change-Id: Ifec3a59370f7ad0e4bdc58c470e4f14f7db33660 Reviewed-on: https://gerrit.libreoffice.org/5423 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-08-14fix warning: multi-line comment [-Werror=comment]Michael Stahl
Change-Id: Ifec7cdefb48bca1a6e025cdd3e5f0c9285c5fb95
2013-08-14bnc#654532: Make a regular octagon loaded from .ppt actually regularTor Lillqvist
See source code for extensive comment. Change-Id: Ic6ce18ca8aec95d2ffb480ae403a1c10cb8980e7
2013-07-17Move hasBigImages() from ToolboxController to SfxToolBoxController.Jan Holesovsky
We want to decide whether the images are big or not based on the real (underlying) ToolBox, not on the global setting, because we can have both toolbars with large as well as small icons visible at the same time (small in sidebar, large in toolbars). Change-Id: I046a12a495f2038df9a571f5779794a639bae6dc
2013-06-13Introduce O[U]String::toUInt32Stephan Bergmann
...which has become necessary since bd60d41176da540b01d7583cfe00637431967f39 "Handle oveflow in O(U)String::toInt() functions" reduces values in the range (SAL_MAX_INT32 .. SAL_MAX_UINT32] to zero, but some calls of toInt32(16) relied on getting a correct (unsigned) value for the whole input range ["0" .. "FFFFFFFF"] (see libreoffice-4-1 commit 9bf6c83367cedb7be81bf67f30d2147d26c7a8c3 "Revert overflow checks in O[U]String::toInt{32,64} again"). Audited all uses of toInt32/64 with non-decimal radix. (There is still a TODO comment in oox/source/helper/attributelist.cxx, and stoc/source/typeconv/convert.cxx will still need some love and test code.) Change-Id: Iadaca1c0e41dab553687d0ce41c20c10cd657a95
2013-06-03#121437# Added patch from Regina which implements QuadraticBezier segemnts ↵Armin Le Grand
to CustomShapes Patch by: Regina Review by: ALG (cherry picked from commit 4faa46872cad4ed779b07803b7f616b32d800284)
2013-06-03Revert "#121437# Added patch from Regina which implements QuadraticBezier ↵Fridrich Štrba
segemnts to CustomShapes" This reverts commit 76bbe5ff357406ac1e0f212373c9fd4132b0d178.
2013-06-03#121437# Added patch from Regina which implements QuadraticBezier segemnts ↵Armin Le Grand
to CustomShapes Patch by: Regina Review by: ALG (cherry picked from commit 4faa46872cad4ed779b07803b7f616b32d800284)
2013-05-31Resolves: #i119631# Teardrop shape cannot be shown correctly in pptxZhe Wang
* subversion/main/filter/inc/filter/msfilter/escherex.hxx * subversion/main/filter/source/msfilter/escherex.cxx []check whether one shape is default shape of ppt by shape type * subversion/main/svx/inc/svx/msdffdef.hxx * subversion/main/oox/source/drawingml/customshapegeometry.cxx * subversion/main/svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx []add definition and declaration for tear drop * subversion/main/svx/source/customshapes/EnhancedCustomShapeGeometry.cxx []the content of tear drop shape which incudes "path, adjust value, handle" Patch by: Ma Bingbing <jiazema@gmail.com> Suggested by: Wang Zhe <kingwisemmx@gmail.com> Found by: Zong Dongjun <zongdongjun@gmail.com> Review by: Wang Zhe <kingwisemmx@gmail.com> (cherry picked from commit 26218ac2472838d63485c3c6b4dc2f1aa0bdd0f6) Conflicts: filter/inc/filter/msfilter/escherex.hxx oox/source/drawingml/customshapegeometry.cxx svx/inc/svx/msdffdef.hxx Change-Id: I8347832bc842cca8b944c28e807af7f45a7da5b0
2013-05-19Related: #i120569# Corrected 3D object creationsArmin Le Grand
(cherry picked from commit 753dd9ee0c8101ce613cdc7e1a68141e0f8561d3) Change-Id: Ic7534a310b8d8c526b2639243c9d734e26b55560
2013-05-19Resolves: #i120569# Enhanced 3D visualisation of line custom shapesArmin Le Grand
(cherry picked from commit aa4649b8feb28c250cbbab65c749ae01524726fe) Conflicts: svx/inc/svx/sdr/primitive2d/sdrattributecreator.hxx Change-Id: I642428e988e7bed9a5c1d2d2db0f95fe775f06cf
2013-05-19Resolves: #i119443# Import lines from ppt as one point connectorsArmin Le Grand
Patch by: Jianjuan Li Review by: alg (cherry picked from commit acd62709ad0d1d54764f00aabbd6c59ccb41a409) Change-Id: I1978444641d5f7c053dfae815096e7f2bacce15a
2013-05-19WaE: 0x80000000 -> MIN_INT32Caolán McNamara
Change-Id: Ifc892a5c0e436cce345a329bcef10b875eeb839f
2013-05-19#119881# fix the"RingInside" fontwork display incorrectly when open .ppt fileSun Ying
Reported by: Li Feng Wang Patch by: Ying Sun Review by: Jian Yuan Li(cherry picked from commit 4904b17b657750e565e30d56810da513057fba39)
2013-05-19Related: #120556# fix the "RingOutside" fontwork display incorrectly...Sun Ying
when open .ppt file Reported by: Li Feng Wang Patch by: Ying Sun Review by: Jian Yuan Li (cherry picked from commit 3473dbf606f525d95b898a08072259018eb4056f) Conflicts: svx/source/customshapes/EnhancedCustomShapeGeometry.cxx Change-Id: I356bf0b5af720765e8ca60ae79bd04e449ff6e18
2013-05-18Resolves: #i119755# A new custom shape ellipse ribbon is added and usedArmin Le Grand
Patch by: Jianyuan Li Review by: alg (cherry picked from commit 462656d2f30fade52e38094dcc2392f75b28ef79) Conflicts: svx/inc/svx/EnhancedCustomShape2d.hxx svx/inc/svx/EnhancedCustomShapeGeometry.hxx svx/source/customshapes/EnhancedCustomShape2d.cxx Change-Id: Ifd1fdf1b79db8229b52db43b3c30f109a9930988
2013-05-15Resolves: #i119519# Fixed import of closed borders from PPT...Andre Fischer
when an ellipse is involved. Reported by: liupingtan Patch by: Jianyuan Li Review by: Andre Fischer (cherry picked from commit da2c3ed52ae631dba11821f201a2fce49bf18c86) Change-Id: Iff8195365823b60a70641b9efeb9c9f6c86d5341
2013-05-10resolved fdo#35756 import more than 64k HTML table cellsEike Rathke
Enhanced EditEngine to be able to hold more than 64k paragraphs. Used also in RTF import Calc and Writer, so that could benefit as well. * changed all EditEngine,Outliner,... related paragraph index/count variables from sal_uInt16 to sal_Int32 * sal_Int32 instead of sal_uInt32 to match accessibility API * matched some Outliner methods' paragraph parameters from sal_uLong to sal_Int32 * containers capable to hold size_t nevertheless are limited to a maximum of sal_Int32 * changed definition of EE_PARA_NOT_FOUND and EE_PARA_ALL to SAL_MAX_INT32 + added EE_PARA_MAX_COUNT and EE_TEXTPOS_MAX_COUNT to initialize ESelection with what previously were hard coded 0xFFFF all over the place + for similar reason added EE_TEXTPOS_ALL corresponding to EE_PARA_ALL to initialize an ESelection spanning all available text like aSel(0,0,EE_PARA_ALL,EE_TEXTPOS_ALL) Change-Id: I62d1b9c399cd709a4f93dbac31b219a61c46ec00 Reviewed-on: https://gerrit.libreoffice.org/3838 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-05-10Resolves: #i122208# introduce rtl::CStringHash and rtl::CStringEqualHerbert Dürr
unify the various c-string compares and hashes. (cherry picked from commit b7e3470a154538a92f0a21b14e726d75723f4a92) Conflicts: oox/inc/oox/export/shapes.hxx oox/source/export/shapes.cxx sal/inc/rtl/string.hxx sdext/source/minimizer/pppoptimizertoken.cxx svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx vcl/source/glyphs/gcach_ftyp.cxx writerfilter/source/resourcemodel/TagLogger.cxx xmloff/source/draw/EnhancedCustomShapeToken.cxx Change-Id: Ib742744077bfb4d38a462d88b44bdef45601b4ae
2013-05-06remove usage of RTL_CONSTASCII_USTRINGPARAMLuboš Luňák
Mechanical removal of usage together with OUString ctor, done by compiler plugin. Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-04-13Resolves: #i119974# Ellipse shape too large in MS office pptZhe Wang
(cherry picked from commit 1330e0eed32d5d6fee532a0538efada306822810) Conflicts: svx/source/customshapes/EnhancedCustomShape2d.cxx Change-Id: If0b17bf110306b500cd7142a6a7fa4c343db68ff