summaryrefslogtreecommitdiff
path: root/svx/source/engine3d
AgeCommit message (Collapse)Author
2015-04-17Revert "WaE: unused variables"Tor Lillqvist
See 3ac1584549364c573d4d4e3baed9ad39ad6ce8e4. This reverts commit 7bcf9131032cbcdb162f33d03230e43d4f1db2aa. This reverts commit 063aec33f029f1fbdd1b1ee274e94a00f256465e.
2015-04-17WaE: unused variablesTor Lillqvist
Change-Id: I3b0ed8a6c8e5d13b9236ee1a1337820c3cbce9ac
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-13Resolves: tdf#90583 3D pie-chart missing guide handlesCaolán McNamara
partial revert of commit db1d2af02861b49e4f53d726d59cd71c20cee9b1 Author: Armin Le Grand <alg@apache.org> Date: Tue Feb 18 21:18:13 2014 +0000 Resolves: #i123539# some optimizations for 3D chart... geometry creation using UNO API (cherry picked from commit bbe35be767d76d08891c4f3d3600d80e0e6805f2) Change-Id: If35f05fb62230e90cfc43a0beac053e8a87820d4
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann
Change-Id: Ic90647cc4da716b54b00520b683cee027a664c22
2015-03-24convert SfxChildAlignment to enum classNoel Grandin
Change-Id: I9013bc6dace79421b0a9ad0401a4fb59365d4dcf
2015-03-21svx: nObAnz -> nObjCountMiklos Vajna
Change-Id: I964d02b94f63ee5c3aea7375b0d833ea7ba99105 Reviewed-on: https://gerrit.libreoffice.org/14939 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2015-03-12svx: PVS-Studio V603 The object was created but it is not being usedMichael Stahl
Seems the values in the default ctor don't matter much, it'll all be overwritten by assignment later. Change-Id: Ie59546176c8bf9eecafd94d417fd8e5da2262a1a
2015-03-11V668 no sense in testing the result of new against nullCaolán McNamara
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-03-09V801: Decreased performanceCaolán McNamara
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-03-04V813: Decreased performanceCaolán McNamara
Change-Id: Ica2563d9e8da15e19eb38246d4de54a1fcb75655
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-14fdo#39440 svx: reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I800242bbac3092d2dbaa9098fc6355fe675872e1 Reviewed-on: https://gerrit.libreoffice.org/13906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-05Some loplugin:revisibility clean-upStephan Bergmann
Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2014-12-30convert RID_SVXFLOAT_3D docking window to .uiCaolán McNamara
This is an epic dialog with lots of moving parts Change-Id: I4e53580ac5b01f4a717d2fe594a18c8e83b45a6f
2014-12-04ooo#93212 avoid slicing during construction of SdrPageDavid Tardon
Also hide copy ctor and assignment operator of all derived classes, to ensure that Clone() is the only method to make copies of them. Change-Id: Icb3b50c63b086abe8c9add32e3041fe19692d20b
2014-11-23fdo#85486 - Clean up unnecessary enumerations from xenum.hxxRadu Ioan
Removed XLineStyle Reviewed on: https://gerrit.libreoffice.org/13029 Change-Id: I583575a04988ccf932374e411672ba14a3f3cb2f
2014-11-04coverity#735632 division by zeroDavid Tardon
Change-Id: I756a701744998c306cc9630b604c20c44750e3b5
2014-11-04coverity#735631 division by zeroDavid Tardon
Change-Id: I3082395b89c0ecc2ac754cf845ea7892ffea0a9b
2014-11-04coverity#735629 coverity#735630 division by zeroDavid Tardon
Change-Id: Ic243df16a59bcb9a90a655a70d2e21cae54ef930
2014-11-04coverity#735627 coverity#735628 division by zeroDavid Tardon
Change-Id: If5a1f749ffb57cd4f2f8d53094317c96a787bb33
2014-11-04rename nWink->nAngleNoel Grandin
Change-Id: I3a4cec65307c517684d4f8a291ca73b6a212a857
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-28Move these headers from include to svx; they are not used outside svx.Kohei Yoshida
Change-Id: I8685b451a39e890250a3309ddb70346bac4084b2
2014-10-27cid#735507 Logically dead codeNoel Grandin
Change-Id: Ie251bca3e4fa7c67aa84c8ff3ae451b0aaa57f44
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: If50022b55a558c4124d71acbbe0ef5eb48801d0b
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-06loplugin: cstylecastNoel Grandin
Change-Id: Id2b5b2510fb13f77592d7a0455f34ccd8a20c2d7
2014-10-02coverity#1242814 Result is not floatingCaolán McNamara
Change-Id: I56f9c9d995880bf328f021930b3fcfcb69f7a4c9
2014-10-02coverity#1242815 Result is not floating-pointCaolán McNamara
Change-Id: Ie50e89862ba4168c05cde385158bf82cf7aede62
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-01Consistency around SvxB3DVectorItem in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I7f2348d82c76f6f231e34f0dfc4b6ee6fddffe55
2014-09-01Consistency around SvxColorItem in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: If26ab3229871d2d6a7e4e7e8f79f4cb927b96930
2014-09-01Missing Clone overridesStephan Bergmann
Change-Id: I0dda3dc849fce9ba994baa82f7e25497ea995c75
2014-09-01Consistency around SfxUInt16Item in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I2e467df03a34d694214e0560476cb7fd76ef0735
2014-09-01Consistency around SfxBoolItem in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I3253b4cc5657a7d6b960ee892584109d373eed3d
2014-09-01Consistency around SfxUInt32Item in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I3193eab34a34c051002adeedd8b368e26f55f7a3
2014-08-19svx: Cleanup ASCII art and useless commentsChris Laplante
Change-Id: I5399362056276f324fd43eda05d3f606dc6f8c71 Reviewed-on: https://gerrit.libreoffice.org/11011 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-18drop unnecessary shl.hxx includesCaolán McNamara
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-16Consistently use size_t and SAL_MAX_SIZEMatteo Casalin
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16bDoInvalidate is always falseMatteo Casalin
Change-Id: I0e22f509b90acc9d4c3d7efb5a428f15bd21317d
2014-08-16Simplify loopMatteo Casalin
Change-Id: I100344543a6008f6f466d0cc5716001e5b6c1ddd
generated by cgit (git 2.34.1) at 2024-12-26 09:19:32 +0000