summaryrefslogtreecommitdiff
path: root/svx/source/form
AgeCommit message (Collapse)Author
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-22callcatcher: update unused codeCaolán McNamara
Change-Id: I96b4d44e44389245f3ccc4a08198676461c6a38b
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: If50022b55a558c4124d71acbbe0ef5eb48801d0b
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: Idb6337bed1c32444f9644d54eba5240f09c13ef6
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13fdo#82980: Cancel FmXFormView::OnStartControlWizard when breaking creationStephan Bergmann
The problem is that SdrCreateView::EndCreateObj (svx/source/svdraw/svdcrtv.cxx) first calls FmFormObj::EndCreate (svx/source/form/fmobj.cxx) -> FmXFormView::onCreatedFormObject (svx/source/form/fmvwimp.cxx) -> Application::PostUserEvent( LINK( this, FmXFormView, OnStartControlWizard ) ), and only then, upon bPntsEq, calls FmFormObj::BrkCreate (svx/source/form/fmobj.cxx), which does not cancel the posted OnStartControlWizard link. The fix is apparently not perfect, though, as afterwards the text document goes back to text input mode (cursor blinking, mouse pointer has I-beam shape) even though the "List Box" icon is still selected. Change-Id: I3137110a88885b04c8dde5377265b1dee91ed6ac
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-04coverity#704031 Unchecked return valueNorbert Thiebaud
Change-Id: I2db8f517f27ab9c8abe5aa473fad159a1506c06c
2014-10-02fdo#84315 quick fixLionel Elie Mamane
In mergedlib case, load ourselves (that is, mergedlib). Fixes bug symptoms, while waiting for fully clean solution, which is killing svx/dbtoolsclient completely. Change-Id: Ib8ad34ee4697f89bdc6bbe64d406053f9e7f7521 Reviewed-on: https://gerrit.libreoffice.org/11738 Reviewed-by: Matúš Kukan <matus.kukan@collabora.com> Tested-by: Matúš Kukan <matus.kukan@collabora.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29svx: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: Ib70d974817bcdd9a582e9be28d28b007cdc3a7a7
2014-09-26fix build & better name for ERROR_INVALID_TABLELionel Elie Mamane
Change-Id: Ic7253575859766f18869159e4a8dd6b3d715850d
2014-09-26svx: fix up c10225762ce2c242d21126b5730b1d60f0150edMichael Stahl
Change-Id: Ib810a512f5a88af88901c53025cdf132f95b2ddc
2014-09-26rip out all remaining uses of svxform::OTypeConversionClient and remove itLionel Elie Mamane
It just wraps around dbtools, which is linked directly now. Change-Id: If8d281962018a48a54858421e3490f5032658691
2014-09-25connectivity: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I796dc05d1846f140a56b5a6f14a69a239324ae5b
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-17Typo: excatly->exactlyJulien Nabet
Change-Id: Ica1e1399bc4a9b9ca61d09cf26e8c47e2368f644
2014-09-12svx: sal_Bool -> boolStephan Bergmann
Change-Id: I5b9b730d7060ec146ed0f54c7fe7eb0ca09f7d9c
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-11Avoid ODR-violating name clashStephan Bergmann
Change-Id: I69c3b11b01d520a485b07c8e5397a7f971210af2
2014-09-10Replace uses of old SFX_ITEM_AVAILABLE alias with SFX_ITEM_DEFAULTStephan Bergmann
Change-Id: I88eeac06413fc3935cbbdb357ff8bf9acaa383a8
2014-09-08coverity#1237353 Unchecked dynamic_castCaolán McNamara
Change-Id: If25d29eaa788e70972fd0cbbf3d03f4d05862f24
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-02fdo#44081 don't remove 'edit' pop-up menu entry from form in design modeLionel Elie Mamane
Change-Id: I009b0e1a155c298bd7f461547125df4ba76805d9 Reviewed-on: https://gerrit.libreoffice.org/11230 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-09-01Revert "fdo#44081 don't remove 'edit' pop-up menu entry from form in design ↵Miklos Vajna
mode" This reverts commit 15cea073e7ed4970e60967fe036fc492e2052203. I overlooked the fact during review that this introduces an svx <-> sfx2 circular dependency.
2014-09-01fdo#44081 don't remove 'edit' pop-up menu entry from form in design modeLionel Elie Mamane
Change-Id: I9700d0d729a8f2d1255fcd03a07e05799e21f8d0 Reviewed-on: https://gerrit.libreoffice.org/11152 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-08-25convert MessBox with custom buttons to .uiCaolán McNamara
Change-Id: I05704746ce5f098a2caaafafdc574009b279e458
2014-08-25convert RID_QRY_SAVEMODIFIED with custom buttons to .uiCaolán McNamara
Change-Id: I782ca0f7e60f92e65e1a93bb8d1d38eded941cbb
2014-08-25QueryBox RID_QRY_REMOVE_* -> MessageDialog + stringCaolán McNamara
Change-Id: Ife33eeaf38daf1aebc1ea35634ca56fae5c89d34
2014-08-25set names on a bunch more threads...Michael Stahl
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-22Remove some useless tools/debug.hxx includesMarcos Paulo de Souza
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h header was necessary in some cases because of a macro or a typedef that was needed. Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9 Reviewed-on: https://gerrit.libreoffice.org/11075 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-19svx: Cleanup ASCII art and useless commentsChris Laplante
Change-Id: I5399362056276f324fd43eda05d3f606dc6f8c71 Reviewed-on: https://gerrit.libreoffice.org/11011 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-18drop unnecessary shl.hxx includesCaolán McNamara
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18ErrorBox->MessageDialogCaolán McNamara
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-16Consistently use size_t and SAL_MAX_SIZEMatteo Casalin
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16Consistently use size_t and SAL_MAX_SIZEMatteo Casalin
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on. Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as return value in case of failure and in the related tests. Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
2014-08-15ErrorBoxes from datanavi to StringThomas Arnhold
Change-Id: Ibb3b11da89468822d64c4c2bc2463ea82339f8af
2014-08-15convert datanavigator sport to .uiCaolán McNamara
Change-Id: I14f9f8d8df9fc8246e7fc8c0b6762ca51dad67d9
2014-08-07coverity#735867 Dereference after null checkCaolán McNamara
Change-Id: I6dce94b0f6ad68e9e748b258cd511119201245b9
2014-07-26Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'Matteo Casalin
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-18coverity#1226494 Uninitialized pointer fieldCaolán McNamara
Change-Id: I88d0414ea6188e807aa347dce4567821e0b7c6f3
2014-07-18inline unnecessary typedefNoel Grandin
Change-Id: Ie33e6b9038d6c18482c2ba7aa47f62d23973ab08
2014-07-11RID_SVX_XFORMS_TABPAGES conversion to .uiSzymon Kłos
Change-Id: I0f3647e95b2150eb8753aa333eeb492fee76bd2a Reviewed-on: https://gerrit.libreoffice.org/10192 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>