summaryrefslogtreecommitdiff
path: root/svx/source/gallery2
AgeCommit message (Collapse)Author
2020-07-17svx: refactoring of GalleryTheme GetModel(), InsertModel()Aditya
Introduce readModel(), readModelStream(), insertModel(), insertModelStream() in Gallery Binary Engine because these deal with file reading stuff. Move ImplGetURL() to galmisc for now because GalleryTheme and GalleryBinaryEngine both use it. Separate InsertModel() into two parts - one dealing with Sot Storage stream, the other adding object to gallery list. Move first part to Gallery Binary Engine, the second stays. Separate InsertObject() into two parts. Move CreateThemeEntry() to Binary Engine. Change-Id: Id3b4091db27b5b88bcf025f9fd94ad86169505d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98492 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-10svx:Refactoring of GalleryTheme members to GalleryBinaryEngineAditya
Moving of aSvDrawStorageRef into the binary engine and consequent changes Change-Id: I7262c77ec8730fbbe516f9fb205c25c4e1f15ff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96764 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-26tdf#134285 select the item before dragging itCaolán McNamara
so we don't get the previously selected item Change-Id: Ifd6e46d97f1de0de86403b9c237ee8d2cd3a6cd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97187 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-23svx:Refactor members of GalleryTheme class to GalleryBinaryEngineAditya
Move those data members and functions in GalleryTheme that deal with reading and writing of binary files to the new class GalleryBinaryEngine. These internal changes must not reflect any change in the behaviour. Functions moved in this patch: ImplReadSgaObject(), ImplWrite(), ImplCreateUniqueURL() Change-Id: Ifd30bc7920f31007dfe7fe2ffdc539dfc43976ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96541 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-17don't highlight the row under the searched for pointCaolán McNamara
Change-Id: I6f3bfdb25c335735a70bc78c5167e88d5dbb4ddb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17svx: Refactor GalleryTheme classAditya
Change-Id: I60ce3b5a9ca5a28e499015c3ac118d2f6a091f16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96527 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-15svx:move functions from GalleryThemeEntry to GalleryBinaryEngineAditya
These functions deal with reading and writing of binary files. They need to be moved because code is being refactored. This change should not result in any change in the external behaviour. Change-Id: Ib21f8df8d1f038993af4f7142cac5a25f0eac87e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96253 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-14Removed executable permission on filesAndrea Gelmini
Change-Id: I3e399ec1fe38e3dac7638f59bb242324f446e834 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96265 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-13svx: Gallery code refactoringAditya
Older classes like Gallery, GalleryTheme, GalleryThemeEntry have reading and writing data members and member functions included in the classes which makes the code unclear and less organized. Introduce new class Gallery Binary Engine that would deal with these member functions in such a way that older classes will have no knowledge about reading and writing. Only change the internal structure of the project and no change in behaviour of output must be there. Change-Id: Ia05eb3c692976b775a3d00e7d09fecc861bced2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95922 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-05Upcoming loplugin:elidestringvar: svxStephan Bergmann
Change-Id: Ia7b4f69361b6cc29f6e5c0093b13cf0b48e25ba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95576 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-10compact namespace in svxNoel Grandin
Change-Id: I9229775999aa70c2b37c0527ba1c332143f9f2cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93877 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-25rename SvtValueSet back to ValueSetCaolán McNamara
Change-Id: I51ab96ffef7acc0d416d13ac8e380e49381f4d1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-24final ctor arg of PanelLayout ctor is always true nowCaolán McNamara
Change-Id: I40cb888c13cb49aa0e20b5be5ceb1c15cf7a346c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-16loplugin:buriedassign in svtools..svxNoel Grandin
Change-Id: I04bc97effddb213e9c1ac613b61d3a0bc38522ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15add an IsEmpty method to tools::Size and use itNoel Grandin
Change-Id: I7f5201e2ea6c74329336e16bf219630e38ff92cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29tdf#131532:Blurry thumbnails when small shapes added to gallery themeAditya
When small shape is added to gallery theme using drag and drop method, their thumbnail is rendered improperly and as a result they are blurry. This change renders the thumbnails normally without getting blurred. Change-Id: Ibba7e93ba09a42b0d1bf4a1a833f3fe17c8557f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91319 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-23tdf#124176: Use pragma once instead of include guardsHarshit Jain
Change-Id: Ia4a6b35a9a734e9fa1dc9dea702fc1ec370021f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90901 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-13Revert "loplugin:constfields in svx"Noel Grandin
This reverts commit 1a6397030381a45f27ab7a2a02e6e6d0f9987c84. Change-Id: Iaa706bb4ea3144ef57ab359b982400abc589b97e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90454 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-28weld calc navigatorCaolán McNamara
note: non-standard dnd via parent so the treeview triggers the dnd but doesn't itself strictly speaking drive the dnd, see copying a range from the navigator where the calc main edit window shows the outline where the copy of the range from the calc main window will go Change-Id: Ideecbe779e3d9bb5b392357a93ec25f625180ba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-24tdf#42949 Fix IWYU warnings in svx/source/[f-m]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I103c5c7f1a74e8c3a021a91c7a96ebc87cb19efd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89263 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-28drop unnecessary vcl.builder includeCaolán McNamara
Change-Id: Id13e566320ddc98e47558a0610a3a8ea85fba7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87562 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-27tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesMehmet Emin Başoğlu
Change-Id: I5c25999a17ed64cc5a2fa586cd7d986d233a67f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87455 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-26remove some unused local varsNoel Grandin
found by a more aggressive variant of loplugin:unusedvariables. This is my first pass, committing the simplest and most obviously unnecessary vars Change-Id: I9676a6e39a101937097788548764506c93811c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87414 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-24no need for these to be heap-allocatedNoel Grandin
Change-Id: I50a4350198e3c2b8eb669b43fb40e4b01dcb67ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87291 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-23loplugin:unusedmethodsNoel Grandin
Change-Id: Ic2212a502bbd42217934884f4fce49f6f8d4765c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87236 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-23weld SvxFontWorkDialogCaolán McNamara
Change-Id: If9da7ad6a834d22f1bcab8d41ce7fe1f80168946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84774 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21drop unneeded includesCaolán McNamara
Change-Id: I0da7be0983f0dba87dbb3b8f335e27b0305d88fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87108 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21make gallery listview seem faster to populateCaolán McNamara
Change-Id: I25b692c9594d73be9d81ff12df6b61a44c5a8256 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87107 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21weld gallery panelCaolán McNamara
Change-Id: I4aebb3f90e9943044d106a507972c39434988f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17drop unused GALLERY_USE_CLIPBOARD undefCaolán McNamara
Change-Id: Ic06d08d9316b079e89081de75fbb550e73c276cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17flush out unused Font objectsCaolán McNamara
Change-Id: Ifd6379b2cb6e5945ff509be8dc61c61bd70724c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15clang-tidy modernize-concat-nested-namespace in svxNoel Grandin
Change-Id: I8a00f2823aa956afb995ee68c9f995bf08ad5239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86824 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-01tdf#75280 Convert inappropriate use of sal_uIntPtr to better integer typesYusuf Keten
Change-Id: I5a1bbbc677f41fec342484b5244a32ce3a624bd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86049 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-31tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesKemal Ayhan
Change-Id: If89f71675c4fbfaf0a4a2d24133ee3d3167d0836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85964 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-23sal_Char->char in svxNoel Grandin
Change-Id: If7fb907575640b95399419beee5af6cfbd5fafb2 Reviewed-on: https://gerrit.libreoffice.org/85714 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-14loplugin:expandablemethodsNoel Grandin
Change-Id: Ia8192e03feda9e8ae70e29d8dc98d995f015f9ce Reviewed-on: https://gerrit.libreoffice.org/85135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-09drop newly unused SfxFloatingWindowCaolán McNamara
Change-Id: I8ac3957579c76a89b9692bdb50cbe7a56e1693e3 Reviewed-on: https://gerrit.libreoffice.org/84444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-28loplugin:stringadd improve detectionNoel Grandin
if one side of the expression is a compile-time-constant, we don't need to worry about side-effects on the other side Change-Id: Iee71ea51b327ef244bf39f128f921ac325d74e2b Reviewed-on: https://gerrit.libreoffice.org/81589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-17Rename OUStringLiteral1 to OUStringCharStephan Bergmann
It started out as a wrapper around character literals, but has by now become a wrapper around arbitrary single characters. Besides updating the documentation, this change is a mechanical for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f Reviewed-on: https://gerrit.libreoffice.org/80892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-18tdf#39593 use isUnoTunnelId in sdArkadiy Illarionov
Rename SdrModel::getUnoTunnelImplementationId() Change-Id: I364a05efe8ddc04b2b2ca393416c9b974ded43df Reviewed-on: https://gerrit.libreoffice.org/79108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-07remove some unnecessary castsNoel Grandin
Change-Id: I16aa2cdc3e92c3ea2661ebf0a528f72cbe193df9 Reviewed-on: https://gerrit.libreoffice.org/78716 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-03loplugin:constmethod in svxNoel Grandin
Change-Id: I6ae7c04479e3ea8ecd7535c33224a5e7095b64bb Reviewed-on: https://gerrit.libreoffice.org/78396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-27loplugin:referencecasting find more redundant static_castNoel Grandin
Change-Id: I3a51812bbd3fcdc6b11e47cb12962f0d4fa7a2ae Reviewed-on: https://gerrit.libreoffice.org/78191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-20loplugin:constvars in svxNoel Grandin
Change-Id: I42d04c84c87a792456f36013e1f05159ccf7cd1e Reviewed-on: https://gerrit.libreoffice.org/77808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15loplugin:sequenceloop in svtools..svxNoel Grandin
Change-Id: I81b54f6db69491492b2bc16f48b2296ad96e137d Reviewed-on: https://gerrit.libreoffice.org/77529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-08tdf#126722 Deleted svxcommands.h file and replaced defines by their valuesSzabolcs Toth
Change-Id: I9347add59fcd7c8c4bbd08f6190405ad39131046 Reviewed-on: https://gerrit.libreoffice.org/77143 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-24cid#1448545 silence Wrapper object use after freeCaolán McNamara
Change-Id: Ia1b3137916ae37ed73ac9923af847aa15978dc86 Reviewed-on: https://gerrit.libreoffice.org/76228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20loplugin:referencecasting in svxNoel Grandin
Change-Id: I2f6bc2467fa7689d186bc2bc45d2071ea0a38e63 Reviewed-on: https://gerrit.libreoffice.org/75998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19cid#1448484 Unchecked return valueCaolán McNamara
Change-Id: I4e06228665c90820e88c72bfe4e462af9a0074e9 Reviewed-on: https://gerrit.libreoffice.org/75897 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-13 17:05:11 +0000