summaryrefslogtreecommitdiff
path: root/svx/source/gallery2
AgeCommit message (Collapse)Author
2015-02-16add GetSelectEntryData to ListBox and ComboBoxNoel Grandin
to reduce code clutter like pLbSelect->GetEntryData(pLbSelect->GetSelectEntryPos()) since this is a fairly frequent operation. Change-Id: I41daf30fdeda2442ad1ac829e12f553233bae184 Reviewed-on: https://gerrit.libreoffice.org/14472 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-05cppcheck: Returning/dereferencing 'pEntry' after it is deallocated / releasedJulien Nabet
Change-Id: If96b66d5bbfcf4426bb602909599cd36e1f3c994
2015-01-15convert sal_uIntPtr to longNoel Grandin
Change-Id: I662f51d8d7c88a6c6f7306c344d99841a3102bb4
2015-01-14fdo#39440 svx: reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I8c63a767c62b3a666ad445a0a3095d1bb1224f5e Reviewed-on: https://gerrit.libreoffice.org/13908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-12Resolves: fdo#79975 toggle checkered background back onCaolán McNamara
Change-Id: Id856d8dbf437acb7e528e60b4d1b012102ff0557
2015-01-12convert SETTINGS_ #defines to 'enum class'Noel Grandin
and dump the ones that nothing is listening to Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
2015-01-12fdo#84938: replace DATACHANGED_ constants with 'enum class'Noel Grandin
and drop DATACHANGED_DATETIME because no-one is using it Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-07fdo#84938: convert COMPRESSMODE_ #defines to 'enum class'Noel Grandin
Change-Id: Ica501fc73e7e5f9dbd30dd9da3f337b2dc7e6f02
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-02Remove unnecessary comphelper::string::getTokenStephan Bergmann
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
2014-12-27de-resource RID_SVXDLG_GALLERYBROWSERCaolán McNamara
Change-Id: I33df0c65d230ed13a5121555c8cf26a7bd27969a
2014-12-01fdo#84938: replace EVENT_ constants with enumTobias Madl
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f Reviewed-on: https://gerrit.libreoffice.org/13134 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13coverity#1078470 Unchecked return valueCaolán McNamara
Change-Id: I2dab114efc8c98a17561f1694acf63918e68620d
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-08Fix thinko. Thanks to vmiklos for noticingTor Lillqvist
Change-Id: Id4e65908cc73978205bc0858a3a809b882864b62
2014-10-08Don't try to create cdefghij.klm inside the app bundle on OS X when sandboxedTor Lillqvist
Actually, we check HAVE_FEATURE_READONLY_INSTALLSET and not HAVE_FEATURE_MACOSX_SANDBOX, but in practice we set the former only for the latter case. We could do this test cross-platform but I didn't bother now. Nobody uses --enable-readonly-installset when building for Linux or Windows anyway, I think. (There must be more places where we could and should check HAVE_FEATURE_READONLY_INSTALLSET.) Change-Id: Ie54f436616a1db3119b0bc0148149784127b156d
2014-10-06loplugin: cstylecastNoel Grandin
Change-Id: Id2b5b2510fb13f77592d7a0455f34ccd8a20c2d7
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt32Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-21Remove dead codeSamuel Mehrbrodt
Change-Id: I0bbfdbdc7ef4674260771f15b9c2aa40c4bf5f36
2014-09-21Improve gallery look for small width (Sidebar)Samuel Mehrbrodt
* Remove the path column in details view * Only show the theme name next to the view switch buttons * Only show the horizontal scrollbar when necessary Change-Id: Ia3f5d854217e883275b1a7056489dba9fac6aabb
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-08-27callcatcher: update unused codeCaolán McNamara
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-24fdo#73151 Make better use of the sidebarSamuel Mehrbrodt
The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery) Changes: * Show the sidebar by default in Writer & Impress * Remove the Gallery floating window (Gallery now always opens in the sidebar) * Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer (since they have an icon in the sidebar and the sidebar is shown by default now) * When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151 Change-Id: I3a0461d1472711da7121801000af294b432fccb1 Reviewed-on: https://gerrit.libreoffice.org/11077 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-22Remove some useless tools/debug.hxx includesMarcos Paulo de Souza
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h header was necessary in some cases because of a macro or a typedef that was needed. Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9 Reviewed-on: https://gerrit.libreoffice.org/11075 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-07-26Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'Matteo Casalin
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-18coverity#1215318 Uncaught exceptionCaolán McNamara
Change-Id: I784198cacba86fe1778e49ceebe574b9cbd6888b
2014-07-16coverity#707280 Uncaught exceptionCaolán McNamara
Change-Id: I764f6472903e6aebef55af1e96c4941e8429d18f
2014-06-27OSL_ENSURE->assert where guaranteed deref followsCaolán McNamara
Change-Id: I6e007cc3a9fd222c1c1381c8b4f890966c05cbab
2014-06-27remove SFX_APP() macro that was a mer wrapper for SfxGetApp()Norbert Thiebaud
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-26Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: Idbb2318a51ba9f39c20deb036975a8e85e8d231f
2014-06-25Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: I1a566a870a3bde91a527ac454fc9946e99a2593e
2014-06-21Resolves: fdo#80327 Sound list box when non-English UIJulien Nabet
Fallback strings are in English wheresas ImplGetThemeEntry expects localized strings Let's put localized strings in fallback to make ImplGetThemeEntry happy Change-Id: I27dd992bac4f5aaf6e0e6237fe59dac990f11c92
2014-06-19fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-01fdo#68849: Add header guards to all include filesJens Carl
Added header guards to files in directory svx/ Change-Id: I1c2006bccf03c3057daf6ea2711c52a8c1f455f3 Reviewed-on: https://gerrit.libreoffice.org/9586 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-26coverity#1215317 Uncaught exceptionCaolán McNamara
Change-Id: Idada0fbd80f55f67bd62cb7d31dcc7457e4a18d5
2014-05-08typosThomas Arnhold
Change-Id: I2e7676ddec446dfdb72018a1039d6271f963376c
2014-04-24add missing modelines to cxx and hxx filesThomas Arnhold
some of them have no copyright header Change-Id: I9c2c0c859dabe231cb29af29290847e7b4aa46a3
2014-04-17More generic way to disable avmediaTor Lillqvist
Introduce a configure option --disable-avmedia. For non-desktop, avmedia is always disabled (for now), and for desktop enabled by default. Add AVMEDIA to BUILD_TYPE when enabled. Don't build avmedia when disabled. Add HAVE_FEATURE_AVMEDIA to <config_features.h>. Bypass avmedia-related code when disabled. Change-Id: I919c6e199bff87d9f142d55dff6373f0ed217f39
2014-04-15svx: sal_Bool->boolNoel Grandin
Change-Id: I464eba5fd5521c31868c6fc8a2137f17428d421e
2014-04-14remove static stringsThomas Arnhold
2014-04-11coverity#708359 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ic65d9682fa145198c6ce663dc655d56570388638