Age | Commit message (Collapse) | Author |
|
Nothing obvious that would speak against converting from the original
SvStringsDtor to plain std::vector<...> instead of slavishly sticking to
boost::ptr_vector<boost::nullable<...>>. Also, prevents a false -fsanitize=null
warning about "reference binding to null pointer of type 'rtl::OUString'" in
boost::void_ptr_iterator<...>::operator*() during ~SvxClipboardFmtItem_Impl().
Change-Id: I08d8fc573ff99a5bddd67c0d2be4e7ea38025958
|
|
Change-Id: I4791f064f223487ce57e68f8e0b1e3d74e66e868
|
|
Change-Id: I5f4029fc583952ae6392dbf2d478155982ccecef
|
|
Change-Id: Ic90647cc4da716b54b00520b683cee027a664c22
|
|
of which there are several.
There are some issues here I am unsure of
- the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids
Perhaps I should change them to use the common values and create new enum values where necessary?
- the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff
numeric values to the underlying code, but perhaps further fixing is necessary?
Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
|
|
.. in favour of just using the underlying constants from
css::util::NumberFormat
Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
|
|
also tranlated some error messages
Change-Id: Ia5035c7c2f5379a0b419fc5514a288368e687c83
Reviewed-on: https://gerrit.libreoffice.org/14382
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I8ed7028f865bd4a6425859ab3b57ed8e928a78e4
|
|
i.e lots now able to be detected after...
commit b44cbb26efe1d0b0950b1e1613e131b506dc3876
Author: Noel Grandin <noel@peralex.com>
Date: Tue Jan 20 12:38:10 2015 +0200
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
|
|
Change-Id: I54931168bfc18c9ce41babdcf535ebc1bcc72c5e
|
|
Change-Id: Ia012f2bec767cd7e7d2be9502062bea0b085fea0
|
|
Change-Id: Ibecd561c1d27e129ad1f481bdb7f8a7bb4d0f8d8
|
|
Change-Id: I17b52c277ab6ec8b15e88729feee0a269b75087d
|
|
LO 4.3.2.2 is evidently able to export an ODF document that violates
XML Well-formedness constraint: Unique Att Spec.
<draw:enhanced-geometry
draw:mirror-horizontal="false"
draw:mirror-vertical="false"
svg:viewBox="0 0 21679 2134682997"
draw:text-areas="0 0 ?f3 ?f2"
draw:mirror-vertical="true"
draw:type="ooxml-rect"
draw:enhanced-path="M 0 0 L ?f3 0 ?f3 ?f2 0 ?f2 Z N">
Not sure how to reproduce this, but the attributes there are apparently a
serialization of SdrCustomShapeGeometryItem's aPropSeq,
retrieved from a "CustomShapeGeometry" property, so add some input
validation and assertions there.
Change-Id: I91151365b507779a4bdc9cce2057d34f2376f005
|
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
and remove SV_NUMBERFORMATTER_VERSION_ADDITIONAL_I18N_FORMATS
Change-Id: I63f341e74a1eb7172dbb024a5cef66435a46e1df
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: If50022b55a558c4124d71acbbe0ef5eb48801d0b
|
|
Change-Id: Ia3055b00c20a885dfa0584f864f0e91ccad1e9c9
|
|
Change-Id: I0ccdd2ce18336afea67a3f296b26b2de50f14808
|
|
Change-Id: Id2b5b2510fb13f77592d7a0455f34ccd8a20c2d7
|
|
Change-Id: I88a106081b7413bff6313d1e07f53e39d8350002
|
|
Change-Id: Ib98a81a04f721917ee3c1fdd19d23a37c5d2c481
|
|
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
|
|
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
|
|
left over from our conversion of the SvStream output operators
to more specific methods
Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
|
|
Change-Id: I5399362056276f324fd43eda05d3f606dc6f8c71
Reviewed-on: https://gerrit.libreoffice.org/11011
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Id5ba28d7862590e11cca24fc8e25ca68fae1d5a8
|
|
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
|
|
since none of the call sites specify it
Change-Id: I9c15f0e042e21f6f78560c1962a533112d588c90
|
|
since all two of the actual call-sites only care about whether
it is a valid presentation or not, not what kind of presentation it is.
Change-Id: I75717c88878d37b2897741b0c833ff283b3fee59
|
|
Change-Id: I88efc4be6ff869ef97a2b398d43f7b7914debfc6
|
|
Change-Id: I231218ab7a7984943470b62339e34801fb5fb9e3
|
|
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
|
|
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
|
|
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done
Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
|
|
some of them have no copyright header
Change-Id: I9c2c0c859dabe231cb29af29290847e7b4aa46a3
|
|
Change-Id: I7b6c04d99c41360ff49be774afcb4447a829d31c
|
|
Change-Id: I2cab3d18913e7d7a4e5c89a391e5d9158effc037
|
|
Change-Id: I31871db6f344e90c54ed9efb51b9576cd36d9fa8
|
|
Change-Id: I7a32bc6391630266eb548c4fa2c7b9dedec3697c
|
|
Change-Id: I464eba5fd5521c31868c6fc8a2137f17428d421e
|
|
Change-Id: Ib689e35b417e0e9016cd6a239c986e0603a99d62
Reviewed-on: https://gerrit.libreoffice.org/8837
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I7e7bdce5c3ddb7871b9c1fbfe93dc7f7c254f1bb
|
|
and optimise some methods in bmpmask.hxx - they were unconditionally
returning true, so convert them to void return type.
Change-Id: If8b092a857ab80ead93112b0d627e41d5ccb3cf9
|
|
Change-Id: I9e55dbfea39abfbe335036af910c3a8bc916d6b9
|
|
Change-Id: Ib936712a8dd49a7130057aebf0ba529e65eb2c66
|
|
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.
Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Valgrind is capable of detecting such bugs. No need for extra macros.
Change-Id: I9f2ab3703feb5c49a831da124e161f98cb1bb3ab
Reviewed-on: https://gerrit.libreoffice.org/8419
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|