summaryrefslogtreecommitdiff
path: root/svx/source/sidebar
AgeCommit message (Collapse)Author
2015-08-20tdf#78111 Sane preferred width for the color mode comboboxMaxim Monastirsky
Don't let long strings (in some languages) make it request so much space. Change-Id: I5b2af9d7cc54d1ba772ae75971cfff27bee31a05 (cherry picked from commit d2f218f54369c6d7fb38d0b701aa86fdf5aae843) Reviewed-on: https://gerrit.libreoffice.org/17778 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-30tdf#88290 Adapt the numbering popup to more than 8 itemsMaxim Monastirsky
The items count of NumberingTypeMgr is limited by 8, but some languages have more items, so remove that limitation. Also fix the behavior of the 10th item. The old sidebar popup had a "None" item, whose id was 10 (defined by DEFAULT_NONE from include/svx/nbdtmg.hxx), and that causes now the 10th item to behave as on/off toggle. Since we don't have a "None" item anymore, get rid of that behavior completely. Conflicts: include/svx/nbdtmg.hxx (cherry picked from commit 71b35212265bb93b10ca35ab964a36e6b6cc552b) Change-Id: I5546ca637f9951cc093a7bbf8fda11dc35341d4e Reviewed-on: https://gerrit.libreoffice.org/16337 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-14Resolves: tdf#90384 queue_resize needs to Invalidate the optimal cache sizeCaolán McNamara
but the PanelLayout didn't (cherry picked from commit b39a6449d5debc7cdf55c3f967b441f3de4d50f3) Conflicts: svx/source/sidebar/PanelLayout.cxx vcl/source/window/dockwin.cxx vcl/source/window/syswin.cxx Change-Id: I38a8975f1488fa2a2ffe91b66745e1a1c6c48a28 Reviewed-on: https://gerrit.libreoffice.org/15215 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-01-30Resolves: tdf#88740 parse with locale decimal separatorEike Rathke
And use a proper string to double conversion and early bail out conditions. (cherry picked from commit 1884c0bbd40f0ded41d7a1656cb64fb1f6368c36) tdf#88740 fix sidebar angle rotation i18n (cherry picked from commit 9a7bf47098fe69b5c6069372708918ef94a9d597) use a less ugly string to double conversion, tdf#88740 follow-up And check string length before accessing characters.. (cherry picked from commit 3ba5ac834780fc2565aff99e42dd8c3b2202fba3) 30355f3aaf77b1952e21050e3593e575571d7aaa ac3c2bf2f67f0cc7fc106515a875512771676e01 f97a25cd2cab0dccf2154465da7c1235ef3ca8c6 Backport: added vcl/settings.hxx Change-Id: I6c89dd850405ad74ebd175800131cdcac19a8c86 Reviewed-on: https://gerrit.libreoffice.org/14243 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-28tdf#82524: Mismatch of ValueSet and metric field valuesKatarina Behrens
Regression from commit ab50bc9d4a72193c1fefcbf0652938995094bc41 which adds space separator between value and unit. As metric fields now output values with separator, LineWidthValueSet items must be adjusted accordingly, otherwise they'll never match Change-Id: I55778c9c0cc36d968a061e5e35b6db3f2a159977 (cherry picked from commit 8fd9c25ac66dd238d4c68be3974241a18cb21705) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2014-11-27sidebar: Try to fix initial spacing valuesMaxim Monastirsky
Process SID_ATTR_METRIC status before any other, and call SetMax methods before SetValue, so indent values won't be truncated by a wrong max value. Change-Id: I36d8c0cce9561902aa2c4d531740f56c80207012 (cherry picked from commit 9a410f9cedbce5276aea48479812ff68210712b0)
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-09Synchronize bullets listsMaxim Monastirsky
The default bullets list is defined in two more places: svx/source/dialog/svxbmpnumvalueset.cxx cui/source/tabpages/numpages.cxx in both cases there is no separate RTL list. (And since we're using SvxNumValueSet also for the popup, we must sync it, so the shown bullet would be always the applied one.) There is lots of code similarity/duplication in this area (primarily introduced by the sidebar), and I hope to clean this at some point. Change-Id: Ifcc216101ed2f105a40fb483aa1b96a9e93d00e0
2014-11-09Reset prefix and suffix for bulletsMaxim Monastirsky
It seems needed in Impress, when applying a bullet using the popup after a numbering with prefix/suffix was applied. Change-Id: I0faf8149b3564de9b08fb8107d7a639ae41d2133
2014-11-09More cleanupMaxim Monastirsky
Change-Id: I1f900029cb6a0fb389617c153dd187cf63ed2c7b
2014-11-09fdo#85804 Use the new popups in the sidebar tooMaxim Monastirsky
Change-Id: Ib4767eeef1dc6c404bb36068f806c42ccc1086b6
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05callcatcher: update unused codeCaolán McNamara
Change-Id: I792c007541d4d703f17c8cdcd2d441ca505acc52
2014-11-05WaE: unused variable 'UNO_LINESPACING'Tor Lillqvist
Change-Id: Ica6d417b18136f0645d69a54a86ecddd255e17c1
2014-11-04line spacing: Final cleanup.Jan Holesovsky
Change-Id: Ide0e653493759e7583fbebb2b3d23d614bdb803c
2014-11-04line spacing: Correct way of detecting the currently used units.Jan Holesovsky
Change-Id: I208c54f948ecfc0a47d9b26c83acd0bbfdc2070f
2014-11-04line spacing: Enable/disable also the value's label, looks more natural.Jan Holesovsky
Change-Id: Ifc0e26008b5b5a5bcc8343ee37b87cda3fdb6114
2014-11-04line spacing: Unused.Jan Holesovsky
Change-Id: Icf93aff540da480c7e1a66abe8a639dc6cd0ead0
2014-11-04line spacing: Finally use the reworked line spacing popup in the sidebar too.Jan Holesovsky
Change-Id: I7f33a25903dec7e5aa0dc878ff5dea7f35935863
2014-11-04line spacing: Honor the current setting of units.Jan Holesovsky
Plus fixes of some warnings. Change-Id: I877e08e4b60c1b654e371c6786cc3ad33e79c583
2014-11-04line spacing: Setup the Custom value according to the current state.Jan Holesovsky
Change-Id: I16d34d501385c57ba32dece1eb8032ff38d5f4a6
2014-11-04line spacing: Kill lots of unused stuff. Rename some member variables.Jan Holesovsky
Change-Id: Ia424ea0b71e64bb1133d2a02becb79d6a5ace639
2014-11-04line spacing: Kill the "Last value" button. Close popup when used via buttons.Jan Holesovsky
Change-Id: I48eabbe5e1f41f5ed015d2fa95ade5376576cac9
2014-11-04line spacing: Make the buttons work - they set the line spacing now.Jan Holesovsky
Change-Id: Ib0a08ebedbab5bfe4db196a4d22d4a08fec15f60
2014-11-04line spacing: Convert the ParaLineSpacingControl to .ui.Jan Holesovsky
Change-Id: I81dd0d541e7f7dd3e3fb881c2c318f9adc733fde
2014-11-04line spacing: Change the implementation so that it can be used in toolbars.Jan Holesovsky
Before it was only sidebar-specific, duplicating most the sfx2 framework, and making it impossible to be used from the toolbars. Change-Id: Ibb382633395157602dd806052824e5275503c3e0
2014-11-03Related: fdo#84844 Get rid of ColorControl and ColorPopupMaxim Monastirsky
Change-Id: Ie2d00cfbccefd69c8e46381b712620def655a798
2014-10-30Whitespace (and other) cleanup.Jan Holesovsky
Change-Id: I6af10899a3e22c45b973439fd8c8ec6c8faac904
2014-10-29tools: remove DBG_ERRORFILE and replace all callersMichael Stahl
Change-Id: Ic76ccc49b9291fe82c56974eb6237cd3b85d91c8
2014-10-27fdo#84844 Sidebar: Use SvxColorToolBoxControl for fill colorMaxim Monastirsky
Change-Id: I0aa9dbef960391334097b68c980064724435db38
2014-10-26fdo#84844 Sidebar: Use SvxColorToolBoxControl for line colorMaxim Monastirsky
Change-Id: I266cfd8c80088f698ec36662357477bb456a96fe
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-22fdo#84844 Sidebar: Use SvxColorToolBoxControl for paragraph colorMaxim Monastirsky
Change-Id: I0231a52288ca9a8a2a5e5cdb13fdff772b989640
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-20loplugin: cstylecastNoel Grandin
Change-Id: If50022b55a558c4124d71acbbe0ef5eb48801d0b
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09HAS_IA2 is never definedAndras Timar
Change-Id: Ib71e98d1250e6d077c593801993b88c2963459b7
2014-10-06fdo#73151 Always open Styles&Formatting dialog in the sidebarSamuel Mehrbrodt
Change-Id: I05b63dc00023945d92fd837bd64042135d3f9aed Reviewed-on: https://gerrit.libreoffice.org/11648 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-25Revert "fdo#73151 Always open Styles&Formatting dialog in the sidebar"Stephan Bergmann
This reverts commit 473ed449a4b6f550dc1af47a07c6e0ef243a98b2, which made JunitTest_toolkit_unoapi fail, as AccessibleDropDownListBox.createTestEnvironment (qadevOOo/tests/java/mod/_toolkit/AccessibleDropDownListBox.java) was no longer able to find its AccessilbeRole.COMBO_BOX AccessibleDropDownListBox, which it apparently expected to find in a docked stylist (cf. DesktopTools.dockStylist in AccessibleDropDownListBox.initialize).
2014-09-24fdo#73151 Always open Styles&Formatting dialog in the sidebarSamuel Mehrbrodt
This removes the floating window for Styles&Formatting as discussed in fdo#73151. Change-Id: I352d27a4d30632dcfda8963c23629e62ab850524 Reviewed-on: https://gerrit.libreoffice.org/11253 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537