summaryrefslogtreecommitdiff
path: root/svx/source/sidebar
AgeCommit message (Collapse)Author
2022-06-27tdf#149690 fix shapespanel bar width of impressxuenhua
Change-Id: I18afc90943e38bc79f0515d60f06f81b0eb5dd28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136344 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-24tdf#128150 Properly show/hide widgets when "use slide background" is selectedSamuel Mehrbrodt
And cleanup the logic a bit Change-Id: I9d866fd63ea622ac5eb706185b3277c21f40d7cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136301 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-23tdf#128150 Disable UseSlideBackground item when setting style back to NoneSamuel Mehrbrodt
from Sidebar Change-Id: I883330ac7323c4758ca8cbd46f4567a2ea780fc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136290 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-22tdf#128150 Adapt sidebar to new "use slide background" propertySamuel Mehrbrodt
Change-Id: Idce049a7498f98b0079c708236cfeff7fddd6e95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135963 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-19tdf#68335 Increase default para spacing before/after to 56 cmGabor Kelemen
and fixed line spacing as well. These may be set to 1584 pt in Word, but the UI incorrectly showed even the correctly imported values as 10 cm. Turns out this is only a UI limitation, so lift it for UX interop. Save/reload already works fine to odt, docx, doc, rtf formats. Change-Id: I69a772e860ad24a1b317dc041b0c55f0a9d461de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136102 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-06-13Fix commentSamuel Mehrbrodt
No need to mention gerrit URLs in code comments Change-Id: I445f94211a3e660aa6e3482352f56ded7465e008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135692 Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-05-2550 null derefs seen in crashreporting reportCaolán McNamara
Change-Id: I42f1179ad1d60ac70ccda5362590853a69fd3712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-03Just use Any ctor instead of makeAny in svxStephan Bergmann
Change-Id: I59b1b3f817a9028f132456ea5094f38f88674d00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133768 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-27[ Edit Chart ] -> [ Edit Object ]Mike Kaganski
This button was introduced in commit 376cd2ceaeedd12a8050c5acd142cd9b9d5e731a Author Muhammet Kara <muhammet.kara@collabora.com> Date Wed Nov 20 15:30:01 2019 +0300 Add Edit Chart button for online's mobile view It is shown for any kind of OLE object, including Math. So make its text more neutral. Possibly it could make sense to construct the name from the OLE object's proper name in a follow-up. Change-Id: Ied2e9b10db3bcbfab4328a1f65f812cd52f85004 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133426 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-04-15sc: introduce SparklineShell and Sparkline contextTomaž Vajngerl
Having a separate sparkline context is very useful, so we can add a custom UI when the user has the cursor over a sparkline. This will allow a "Sparkline" tab for NotebookBar and its own deck in Sidebar, activated only when the sparkline is present. Also the pop-up menu can be customized specifically for the sparkline, but this may be less useful. For the sparkline context we need a custom shell - SparklineShell where now all the UNO commands can be implemented (not done in this commit). Change-Id: Idca2ad946af3afdd1b494744b80c9c093eec602c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133022 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-02loplugin:stringviewparam convert methods using indexOfNoel Grandin
.. and lastIndexOf, which convert to find and rfind Change-Id: I6c4156cf904774c0d867f85a4c2785dba7593f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132445 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-14add TypedWhichId version of QueryStateNoel Grandin
Change-Id: I95b86fc081847da01e06f50a1b2c7e7f5456c638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-04cid#1500667 Explicit null dereferencedCaolán McNamara
I can't see how destroyingthe widget is a good idea here Change-Id: Ie4b2dcf9136568b01b5f4b85bcc849ad1c0504a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130992 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-03Recheck modules sv* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I25779cbfb1aa93c31d6e12ac95e136b3bdbbc058 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130403 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-04Resolves: tdf#146997 use sal_Int64 instead of sal_Int32 for spinbutton valuesCaolán McNamara
for these cases where draw wants to massively scale the units the underlying "metric conversion" are already using sal_Int64 anyway Change-Id: I94e120d72644319548f75b2f68cfe60d4829a2e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-03SID_ATTR_GRAF_TRANSPARENCE and SID_ATTR_GRAF_MODE have conflicting typesNoel Grandin
Meant to be SfxUInt16Item, until the below commit accidentally introduced SfxInt16Item usage. commit 4d814ec1518c98d2ca251a5a10287f40a427ea6e Author: Armin Le Grand <alg@apache.org> Date: Wed Apr 24 09:50:54 2013 +0000 Related: #i122111# Adapted pState usages in NotifyItemUpdate methods Change-Id: I2aff5cc1eea9257186b4da12a73f928503bc233c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129353 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-01related tdf#111733 svx: SfxVoidItem != SvxKerningItemJustin Luth
When selecting text containing several different kerning values, the pItem returned is a VoidItem. This was showing up as random numbers in the TextCharacterSpacingControl spinbutton. Change-Id: I94cfc566daa42e0d8c3d403eb08af659f01e6d5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129270 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-02-01tdf#111733 TextCharacterSpacingControl::GrabFocus kerning spinbuttonJustin Luth
When the kerning menu opens, it defaulted to very tight, regardless of what the current setting was. However, the current value can easily be connected to the menu options, so lets do that. This depends on increasing the spinbutton range beyond -2.0, done via LO 7.4 commit 2334561bf15ec9b061636919efbd0e2a7b89e29b Change-Id: I0be0956bf1cc3604faecc691aeac70a5bbba807b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128909 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-01-29no need to call GetWhich on these SID_ valuesNoel Grandin
none of them are remapped (via the SfxItemfo stuff in the pool) Change-Id: Iefd38f1aac55e6059e2c57d102efb508bd1572b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-07remove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enumNoel Grandin
We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is in the right range. Which exposes some dodgy code in DrawViewShell::GetMenuStateSel SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) || SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) || which has been there ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b Date: Mon Sep 18 16:07:07 2000 +0000 initial import just remove that. In SwFEShell::ImpEndCreate() move some logic around to avoid using an out-of-range SdrObjKind value Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-29use comphelper::WeakComponentImplHelper in svx::sidebar::SelectionChangeHandlerNoel Grandin
Change-Id: I7f60374710f5768efef07ee993757558a225c111 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127698 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-24use comphelper::WeakComponentImplHelper in PanelFactoryNoel Grandin
Change-Id: I936fd58fdb626d6707cf672f188cd8570269bc44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-30tdf#30709 sw Style Inspector: show section and parent metadataLászló Németh
Show text:section RDF metadata under the node "Sections" in the Style Inspector. Also show parent metadata of nested annotated text ranges (and sections) at the cursor position, not only metadata of the innermost. Show metadata fields (text:meta-field) and annotated text ranges (text:meta) under the new category "Fields" instead of at "Character Direct Formatting". Put section and other metadata in front of the other style settings text. Hide their empty categories "Sections", "Bookmarks" and "Fields", if there is no associated RDF metadata. Follow-up of commit db7ef0a9ed21b0271345249b97a7a10d60d259e6 "tdf#30709 sw Style Inspector: show bookmark data". Change-Id: Ibfd2c5dfb1597afaa8038b497977505914bed76d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126065 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-11-26loplugin:stringliteraldefine in svxNoel Grandin
Change-Id: I2375ebfe9791c43063ffbc8ddbe1bd365499a576 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125868 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-22Use less DegreeN::get()Mike Kaganski
Change-Id: I97b8d6282c72307cc29a913af221d283523f2fae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125653 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-19Use MsLangId::getConfiguredSystemLanguage()Eike Rathke
Change-Id: I298f762ac7f3298aa9cb9621ad1f8cae50527b24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123790 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-16Simplify vector initialization in svxJulien Nabet
Change-Id: I139776f74fb93f90dae787eeae18e4a2a2ed7351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123700 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-04loplugin:constmethodNoel Grandin
Change-Id: I56af10be5f1155db4c7f2190495fe036a9b4236a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123054 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-26Typo: *Transparanc*->*Transparenc*Julien Nabet
Change-Id: Ia9325a397b89c09dac4b6c76e4a0521bbdbf5db5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122655 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-03clang-tidy:readability-redundant-member-initNoel Grandin
Change-Id: I47cc5416e853260d92b8b2c57b1c223d1f21df0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121544 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-24tdf#143990: writer: default value for SetIncludeUpperLevels is 1Vasily Melenchuk
Same as in e08fba90 for tdf#143858: zero for SetIncludeUpperLevels has no practical sense, since actually this value is amount of levels to display. Default and minimal value is 1 (current level), zero used only in cases when there should be no numbering. Change-Id: I303386339a9e13944e11d0287c933523c7410b6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120863 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-22don't store vcl::Font with unique_ptrNoel Grandin
it is already a COW object, so just use std::optional Change-Id: I5ced54dbf3dc222316d9bcf3581b36e0f6e6e270 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120818 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-20New loplugin:unusedcapturedefaultStephan Bergmann
In sc/qa/unit/ucalc_formula.cxx, dropping the capture-default from the lExpectedinF lambda revealed that MSVC in C++17 mode (i.e., when building without --with-latest-c++) requires ROW_RANGE (a local const int variable from the enclosing TestFormula::testTdf97369) to be captured, even though all uses of that variable within the lambda body are constant expressions. That is still true at least for the latest Visual Studio 2019 version 16.11.1. (This is not an issue for the lExpectedinH and lExpectedinI lambdas a few lines further down, as they, in addition to using that ROW_RANGE, also use the local const double variables SHIFT1 and SHIFT2, whose uses are not constant expressions, so they are implicitly captured and loplugin:unusedcapturedefault does not suggest dropping those lambdas' capture-defaults in the first place.) Change-Id: Iee7efb485187cbe8eba6a2d470afca4993eb1816 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120693 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-20Convert AreaTransparencyGradientPopup to WeldToolbarPopupSzymon Kłos
Change-Id: I3cbb17de9953281e884f6c1b2984bc4865a56227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118471 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120700 Tested-by: Jenkins
2021-08-18jsdialog: sidebar: do relayouting not too oftenSzymon Kłos
To avoid jumping in Online avoid not needed relayouting. Change-Id: I4a59a9aa077de60ffd0486bb843fd2ce5b4174d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118936 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120628 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-18jsdialog: dont use popular id for glow colorSzymon Kłos
to avoid confusing it on updates Change-Id: I2b19dc41a17e070ac1c8869d478c3b0b09a54223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118692 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120614 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-11convert some LogicToLogic calls to use o3tl::convert insteadTomaž Vajngerl
If a LogicToLogic uses fixed units, we can use o3tl::convert instead. We can also do the same for all other cases where LogicToLogic is used, but that needs additional investigation to determine if it is safe to do so. Note: MapUnit::Pixel is converted to o3tl::Length::pt because it assumed 72 PPI for a logical pixel, which corresponds with the conversion rate of a point (72 PPI). Today, 96 PPI is standard, which is also used for o3tl::Length:px. Change-Id: I29126df38bfcfda74b5d83d4cb880a378aecd18b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120230 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-05Pass context and resource string down to boost::locale separatelyNoel Grandin
because this is often on a hot path, and we can avoid the splitting and joining of strings like this. Change-Id: Ia36047209368ca53431178c2e8723a18cfe8260a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-02convert #defines to OUStringLiteralNoel Grandin
mostly by doing $ git grep -l '#define.*\"' -- *.cxx | xargs perl -pi -e 's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 = u\2;/g' Change-Id: Idface893449b0ef2a3c5254865a300585d752fbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119669 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-29rtl::Static -> static localNoel Grandin
Change-Id: Ib8d9a24659a37e6b94237d98f030cd2be00bcb39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119665 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-29sidebar: unify LineWidthPopup with other WeldToolbarPopupsSzymon Kłos
Change-Id: I9dd0d2b223972683a9066f0069e055175349526f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118023 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119654 Tested-by: Jenkins
2021-07-28use officecfg for SvtCJKOptionsNoel Grandin
and remove some unused options Change-Id: I487a233de4f7414012e5405f2c2e1f9c8b8fb4f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119554 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-27drop SvtLanguageOptions classNoel Grandin
since it is just a wrapper over SvtCJKOptions and SvtCTLOptions. Later I will replace those two with the equivalent officecfg calls Change-Id: I61c5667a05f75d42643175f2c28c29d7a590b15c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-20Use some forward declarations in <editeng/editobj.hxx>Mike Kaganski
Change-Id: Ic6c36d4e0da53324ada9ff8a91e715d52ac24394 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119292 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-30fix a size warningLuboš Luňák
d7855213ae60d79f converted this incorrectly, the code right above may set the size as (0,0), and before the commit the invalid size was only negative. Change-Id: I198d025f5c02780ae509f97782bc41ac77fa3407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-06-29new ODF numbered list parameter loext:num-list-formatVasily Melenchuk
Instead of style:num-prefix and style:num-suffix new list format is much more flexible for storing list multilevel numberings. Now it is possible to have not just prefix/suffix but any random separators between levels, arbitrary levels order, etc. Internal LO format for list format is changed: instead of placeholders like %1, %2, etc we right now use %1%, %2%... Reason: for ODT documents, having more than 9 levels there is ambiguity in "%10": it is "%1" followed by "0" suffix, or "%10"? Aux changes: * removed zero width space hack: since format string is always defined this hack is interfering with standard list numbers printing (see changes in ooxmlexport14.cxx, ww8export3.cxx tests) * changed cross-references values to lists: they are now including full list label string: previously this was bit self-contradictory (see changes in odfexport.cxx and check_cross_references.py tests) Change-Id: I9696cc4846375c5f6222539aeaadbca5ae58ce27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117156 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-28loplugin:indentation improve checks for brace alignmentNoel Grandin
Change-Id: I333100fda7e181f68f36b03279b3fbb8cb768310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-18tdf#141311: Rotation spinbox in sidebar used to have 2 decimal placesKatarina Behrens
regression from weld-ing (c85fcc6e1994eb8e079aaca85066ab4d67149c15) Change-Id: Iad0725fd4542ecdddb65092846dbf9d103016d9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117408 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2021-06-18tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)
Rename ::StateChanged methods using SfxItemState to allow better analysis of SfxItemState/SfxPoolItem usage(s), discussion see tdf#130428 comment 30 Change-Id: I736be0160ad7a9b7882c1c8a4cc05d9396ee3305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117366 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-15editengine-columns: add sidebar property panelMike Kaganski
Change-Id: I90aefc10f9ddddeb64a65799480777bc4287abae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117107 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>