summaryrefslogtreecommitdiff
path: root/svx/source/sidebar
AgeCommit message (Collapse)Author
2017-01-08unused mpToolBoxFontColorSwCaolán McNamara
Change-Id: Ic1902a4160589cb9937f938f4a98484f0be487bc
2017-01-08TextPropertyPanel cleanupMaxim Monastirsky
Change-Id: If9fe62643ad33c2d832b146a5dc7248dbba32f1a
2016-12-23merge svx::sidebar::BulletsSettings with svx::sidebar::BulletsSettings_ImplNoel Grandin
Change-Id: I7cf6bb4cf3aa532718753904c2100882b0df6775 Reviewed-on: https://gerrit.libreoffice.org/32373 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21Useless namespace around a #defineStephan Bergmann
Change-Id: Ife6c034a2303ff7cd3ece615b690a14dc8ac3463
2016-12-21convert EnumContext::Context to scoped enumNoel Grandin
Change-Id: I16ec63beb801073e5d604d852892c2fd6e8d8fc3 Reviewed-on: https://gerrit.libreoffice.org/32272 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21convert EnumContext::Application to scoped enumNoel Grandin
Change-Id: Ia289a7b63bf8797085315218785e2a2a4c45d232 Reviewed-on: https://gerrit.libreoffice.org/32230 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-20Result of css::ui::ContextChangeEventMultiplexer::get cannot be nullStephan Bergmann
Change-Id: I00fba6c2a79404c824feaa5bb302d37c4158f9a3
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-02loplugin:unnecessaryoverride (dtors) in svxStephan Bergmann
Change-Id: Icc4d9919cedadc00f1420939564dd095fab74cca
2016-11-24vcl: rename Window::Notify to EventNotifyMichael Stahl
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-21convert inventorId to scoped enumNoel Grandin
SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07Revert "Reverts a commit series that cripple windows ci."Caolán McNamara
with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-05Reverts a commit series that cripple windows ci.Norbert Thiebaud
Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
2016-11-04unify color selectorsCaolán McNamara
Note: this removes the use of auto-color from writer's asian text grid, because its always invisible as far as I can see in practice. Change-Id: Ie850790d740a4d56c43015e493e093678cef3b4e
2016-11-02loplugin:unusedfieldsNoel Grandin
Change-Id: I96634c18ba6600f8f7d5d04a162dcd7e1e312923 Reviewed-on: https://gerrit.libreoffice.org/30474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31loplugin:oncevar in svl..svxNoel Grandin
Change-Id: I80b11a7b698de4b84d7a2f4c7dc62b2e4fd8bb01 Reviewed-on: https://gerrit.libreoffice.org/30438 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-27loplugin:expandablemethods in svxNoel Grandin
Change-Id: I0d193ddf07cc0ddc89b6ce2df6eb71d44e49b631 Reviewed-on: https://gerrit.libreoffice.org/30295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20loplugin:expandablemethodds in svxNoel Grandin
Change-Id: I45447b6f5cf7e17d6e81e8c931b07b26d41b9a8c Reviewed-on: https://gerrit.libreoffice.org/30057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18loplugin:unusedmethodsNoel Grandin
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-17tdf#100180: Band-aid fix for non-editable chart sidebarKatarina Behrens
no way should sfx2 sidebar controller be used in a base class, it just wreaks havoc in chart which inherits from this class, but uses its own controller. Since those NotifyResize calls were introduced to prevent cropped widgets on switching between different shape fills, try to make up for that with other means in .ui file Change-Id: I5a40e4d413b583b1de1e3f751493d65d41ff8465 Reviewed-on: https://gerrit.libreoffice.org/29813 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-12de-src empty panel placeholder widgetryCaolán McNamara
Change-Id: I99a292cd76f40159f12cb98b362559e4109121c3
2016-10-06no ValueSetWithTextControls are loaded from src filesCaolán McNamara
Change-Id: If19daf643a9dfcebe57d5d4860f1f4282b39e5fa
2016-10-06drop now unused sfx2/sidebar/ResourceDefinitions.hrcCaolán McNamara
Change-Id: I151a37a37435a44e7331d957bd9d36f84cdf8677
2016-10-06drop unused hids and hrcsCaolán McNamara
Change-Id: Id9a49391de6283ee15cb6e12564c3f57762ddffc
2016-10-06convert AreaTransparencyGradientPopup to .uiCaolán McNamara
and 1) merge with AreaTransparencyGradientControl 2) grab focus for keyboard a11y like similar popups 3) use degree symbol instead of "degrees" text and it now grows nicely to fit everything in correctly Change-Id: I326f3393165f7a098d739be70b644b29dd5238f0
2016-10-06drop empty ItemBitmap fieldCaolán McNamara
Change-Id: If59c1a2bda49229ff48f8ec28c23491e6d9c8c83
2016-10-05NoAppFocusClose is for menus that have submenusCaolán McNamara
and don't want the parent menu to be auto popped down when the submenu gains focus. or floating windows that explicitly don't want to go away when they lose focus, which all these popups aren't Change-Id: I53f1f3ac586ff295597c4b9046032d3d976d053e
2016-10-05remove various unused hrc defines and headersCaolán McNamara
Change-Id: If0b47fbe1f01d84697a0c25b82ca031c32fca66e
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-04can now remove both PopupContainer copiesCaolán McNamara
the recently unused svx one, and the forgotten not-built sfx2 one Change-Id: I1a4ede49dc74bb71f250ee3eee999d1a3dfbee57
2016-10-04These are just floating windows, no need for all the special intrastructureCaolán McNamara
get rid of the roundabout way that these popups are popup controllers (of a kind) for real popups for the moment keeping them as loaded from resources Change-Id: I083e8609ab133e3dc4a036daf8bfb44c08a6719f
2016-10-04remove PopupControl as an intermediate stepCaolán McNamara
Change-Id: I31438860511af6ae00bf7a94fb29326c3ed1a10c
2016-09-26convert eNBOType constants to scoped enumNoel Grandin
and remove unused constants, which means we can remove the GraphicBulletsTypeMgr and MixBulletsTypeMgr classes Change-Id: I395691b48987543355379708e2c60d0de438d72c
2016-09-26convert eNBType to scoped enumNoel Grandin
Change-Id: I99340449d99ce6a6b45c91c913357bcdbbb9a946
2016-09-20loplugin:unusedfieldsNoel Grandin
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24 Reviewed-on: https://gerrit.libreoffice.org/29078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13Graphyic->GraphicCaolán McNamara
Change-Id: Id405e6a41d8c8ed56471ec058633a21ee4346737
2016-09-13coverity#1371335 Self assignmentCaolán McNamara
these copy ctors are seriously confused Change-Id: I07b2d8cc16ba983cd74782207260b3057f8e7d7d
2016-09-13Remove nonsense comments: // bitfieldTor Lillqvist
Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-09-12Page size popup converted to use outside sidebarSzymon Kłos
Change-Id: Ia9c4c03a9780dca146adda8f1a126197d3e38643 Reviewed-on: https://gerrit.libreoffice.org/28816 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-09loplugin:constantparam in svxNoel Grandin
Change-Id: Id08850b90a0e286ff837dd6b0c1691fa7dc793fa Reviewed-on: https://gerrit.libreoffice.org/28746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-05convert GradientStyle to scoped enumNoel Grandin
Change-Id: Ib740da708612df7a5f4b8c82262b9b1bd436604d
2016-08-30convert RECT_POINT to scoped enumNoel Grandin
Change-Id: I3f0304d69d5d638230b64135c73497192dc00cb3
2016-08-26tdf#101672 non-split underline buttonMaxim Monastirsky
Change-Id: Ib20dc0d0036f594adb83a50c2e3da66f565b2db8 Reviewed-on: https://gerrit.libreoffice.org/28356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-08-25cid#1371331 Misused comma operatorNoel Grandin
Change-Id: I729c90f7873a7735eb59805e336f4dd337dea69b
2016-08-25cid#1371335 Misused comma operatorNoel Grandin
Change-Id: I05d330f4326304645aa75014c15a98d57e9039a1
2016-08-24convert ViewType to scoped enumNoel Grandin
Change-Id: I4904ceae765f3452d8695adcf73043a4a42bbf0b
2016-08-24convert ControlType to scoped enumNoel Grandin
Change-Id: I0b307045c477ea50bd596c491b501b7e8ae91cd4