summaryrefslogtreecommitdiff
path: root/svx/source/svdraw
AgeCommit message (Collapse)Author
2015-08-31there might be no modelCaolán McNamara
Change-Id: I9c384587c127ca077803bf8aae63d0e54eda6aaf (cherry picked from commit be95c7430d2fd9858f41ee8e8882d987a5bbe749) Reviewed-on: https://gerrit.libreoffice.org/18027 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-08fix deselect of textbox on slides with images in underlying masterCaolán McNamara
The original work of tdf#55430 tries to select an object under another one on the second click, but these images are unselectable so this fails. Red Hat has a whole new shiny bunch of templates which have such images in their masters. Check if the object is selectable before continuing (cherry picked from commit abbe4f9d64073d77c4be93b7c89c03d0651bacef) (cherry picked from commit 4189530530320a82adc785a4426735423a1188c1) Change-Id: I182abaf50e8bb1084c5819dc9e1ffd8b386a9e93 Reviewed-on: https://gerrit.libreoffice.org/16742 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-06-10tdf#78854 do not crash when undoing layout changeDavid Tardon
It turns out that the ordinal number adjustment that was added for fdo#34548 is no longer necessary. Change-Id: I2c491a008500b6a269b6f05a2a72f5aa70edecb2 (cherry picked from commit c0117fcb3dbd6c2a8d5e7679ee8d6fb29264ff6b) Reviewed-on: https://gerrit.libreoffice.org/16152 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-28Resolves tdf#67712 form controls and draw objectsHenry Castro
anchored to cell but changes position after reopening Also included tdf#68797 "FILEOPEN lost position of lines anchored to cell". It was marked as duplicate but the step to reproduce are different. Conflicts: sc/qa/unit/subsequent_filters-test.cxx Conflicts: sc/qa/unit/subsequent_export-test.cxx Reviewed-on: https://gerrit.libreoffice.org/15523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 487880b6882ec01c1b4679eae60bec484272a86b) Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: Ia1c4010f118749256077a0ecad6ca16b867d22f7
2015-04-28loplugin:externandnotdefinedStephan Bergmann
Change-Id: I94271681ea4ec7617eaf706fb443ebb9d1b0bc15 (cherry picked from commit cb3518f331a99ff9a3187286e9e2b695df1c0292)
2015-02-26Resolves: rhbz#1193971 clear hard-coded char props in table cells...Caolán McNamara
like we do already for shapes. So now when attempting to set replacement char properties on the entire cell, clear any hard-coded sub ranges within the existing paragraphs. This extends the effort of commit a217f3cb2dce71a4322f78ceb45edb6f171b2b65 Author: Matúš Kukan <matus.kukan@collabora.com> Date: Tue Aug 26 10:16:34 2014 +0200 bnc#770711: Make changing table text color in impress always work to encompass all character properties, not just color Change-Id: If8b426c3531b4678868d8351426db32c3c558650 (cherry picked from commit b14259b946686c753c0df42c519fc2537e871601) Reviewed-on: https://gerrit.libreoffice.org/14539 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-13tdf#60910 don't lose fontwork objectsDavid Tardon
This reverts commit 0685b2e73e48adb84cd01355d45551ab478ebcd5. (cherry picked from commit ecf0c4ba89e27cbb8cf7c7dd904cdd0b87dd5f52) Change-Id: I843dce1f9551529d125435e5e8eb9fa759a5af23 Reviewed-on: https://gerrit.libreoffice.org/14461 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-07Assume that as long as the model is the same, the shape doesn't change.Lionel Elie Mamane
Even if it is moved from not a page to a page or vice-versa. This allows assumptions made in the Base Form wizard to hold, namely that if one: 1) Creates controls (and their associated shapes) 2) Groups the shapes (in a GroupShape) Then all the shapes still remember their associated control and vice-versa. Change-Id: I31975970e7ea2f7978aea7f753de88ecd8e55234 Reviewed-on: https://gerrit.libreoffice.org/13559 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-12-25Copying linked graphic between components is brokenZolnai Tamás
IsLinkedGraphic() is better to use here. Reproducer steps: -Insert an image to Impress as a link. -Copy this image (CTRL+C & CTRL+V) to Writer. Result: Image is not displayed. Change-Id: Iaf9b686b5c87caf5a0cc15425f8c5988f857bfe6 (cherry picked from commit 3650b66c366177877d30f6aae83a33bf683d3457) Reviewed-on: https://gerrit.libreoffice.org/13609 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-12-05ooo#93212 avoid slicing during construction of SdrPageDavid Tardon
Also hide copy ctor and assignment operator of all derived classes, to ensure that Clone() is the only method to make copies of them. Change-Id: Icb3b50c63b086abe8c9add32e3041fe19692d20b (cherry picked from commit 9638e6207c7fc48712b1b238177462c00f5011e8)
2014-12-03Linked graphic is not displayedZolnai Tamás
Regression from: 17475638138c92162be1c0f34cf1f9cc95c63579 Change-Id: Ie2d484fbe065c24d19938c8c9c68818bd1076f2d (cherry picked from commit 02b17c1bbdd19a978b9de646c0dacdad179c60de)
2014-11-24Revert "show pointer_move arrow when passing over an object boundary"Caolán McNamara
revert on 4-4 until figured out the extra piece needed to get this working nicely with table boundaries This reverts commit 961ed635515a346a4395b4abf29675e121ddd8ab.
2014-11-22fdo#86573: Impress does not show pictures anymoreZolnai Tamás
Regression from: 286e2f5c6ec829bc0987b1be7016699f7ef03e5e Sometimes SdrGrafObj import the image file just as a preview (with low resolution) and late when the real picture is needed it just throws this preview and tries to load the image again. This preview works only with package URL so in this case we should not forget that URL. Plus two other related potential image loss situation: - SetUserData() is called with empty image URL - Image preview is thrown when we actually have no package URL from we can import the image again. Change-Id: Ib21f400eb6d28133e8598e6b201209e5dd1a976f (cherry picked from commit f0b28806eebb1477066d44de49b5d1d61a8e84cf)
2014-11-21More fixes after SdrMetricItem changesStephan Bergmann
...like e0c2ea6bde31bd68e1794154b72fddcd40dda7f9 "Consistency around SdrMetricItem in svx/sderitm.hxx," similar to recent c3a9a9542b018f781ee12e6c8c943d4f19641afe "that's not right anyway, using the Distance as a which-id." Should all be found and fixed now with the removal of the unnecessary but harmful default value from the two-argument SdrMetricItem ctor. Change-Id: I6eaeb6633c9a350b18e02d476d2c8794a733cea8 (cherry picked from commit 226e0abd2c5ebd9fd591966b584d04e4ab5cd171)
2014-11-19Move SdrObjPlusData out of SdrObject's header.Kohei Yoshida
It is only used locally within svx. Change-Id: Iae53de3d1cb2b1f5f2ba5cede2794f08dfef972c
2014-11-19loplugin:unreffunStephan Bergmann
Change-Id: I648b91e1124fcdad16ccd5d619192b72e4c8ec3f
2014-11-19Move SdrObjUserDataList out of the header.Kohei Yoshida
It's only used within SdrObject. This also eliminates the need to include boost's ptr_vector in the header file. Change-Id: I5ba9b424be21c5ee3280364de1d73b0fa3921129
2014-11-18show pointer_move arrow when passing over an object boundaryCaolán McNamara
which removes the guessing you have to do when trying to find the edge of a pres_obj in impress after text has been filled in and there is no visible border anymore Change-Id: I470caec90cdeaa681da70f8ec3044c1d6d232a82
2014-11-17-Werror,-Wunused-variableStephan Bergmann
...since 286e2f5c6ec829bc0987b1be7016699f7ef03e5e "Related fdo#82953: Forget package URL of image after it is loaded" Change-Id: If4cc941353b72f555dee26d158aee7b15b359a9c
2014-11-16Logically dead code related to embedded stream name in SwGrfNode\SdrGrafObjZolnai Tamás
See also: 286e2f5c6ec829bc0987b1be7016699f7ef03e5e Since embedded URL exists until the first swap in these lines are not needed anymore. Change-Id: Ie6bf8efe7808cf42f20f7b4b3f8cb927555c0ea8
2014-11-16Related fdo#82953: Forget package URL of image after it is loadedZolnai Tamás
It causes problems if we handle those imported images differently which are identified by a package URL, so after the first load remove this URL and handle images on the same way as inserted images. Some related bugs: * #i44367# * #i124946# * #i114361# * fdo#73270 The image in the test document has a special ID which is different from that one which is generated by LO internally so after ODF export the new generated image URL is different from the imported one. Change-Id: I4e7d3490674c5f86bec5c7c6e1c975dcafd7c265
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-13Realy->ReallyCaolán McNamara
that's really bugging me Change-Id: Id15bd4dc42748b3cb24eb891741195499c5df9c3
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-10callcatcher: unused codeCaolán McNamara
Change-Id: I2ead5d998c3b1b3cde1222fee6f072bf09ab0021
2014-11-10coverity#1251167 Logically dead codeCaolán McNamara
Change-Id: I8294eaf8109ab5b8bc7972da1e5fa2ba9ad819fb
2014-11-08coverity#1251168 Logically dead codeCaolán McNamara
Change-Id: I92776d7a96c13b3d0b4c74d2b928320f9182d17f
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-07More unused swapping related methods / member of SdrPageZolnai Tamás
Change-Id: I4a979dd09418df4526409d9026d6abb98c6bf954
2014-11-07ForceSwap{In,Out}Objects methods are unused nowZolnai Tamás
They are called only by themselves recuirsively, but not from outside. Change-Id: I1cde392c95bbc60ac7937d0bf3cd4b0fd062568b
2014-11-07SdrUndoDelObj: one more manual swap out callZolnai Tamás
This thing seems a good optimization to me, but it would be good to hide all of this swapping thing inside GraphicObject class, to make our code more robust (e.g. no image loss because of missing manual swap in / swap out call). Auto swapping mechanism will take care of that, anyway. Change-Id: I933dafd95597ffff038dc6aeb0a64fcaa3941bd8
2014-11-07Make SetSwapState() an internal methodZolnai Tamás
So we can be sure it is always called when user data changed. Change-Id: If107907afffb85a7a57817f5807847a5c028416c
2014-11-05changed some timer to idleJennifer Liebel
Change-Id: Ifd5e2d87732d3e537c7754e52be24ef768ecb8d9
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04coverity#735635 Division or modulo by float zeroCaolán McNamara
and coverity#735636 Division or modulo by float zero Change-Id: Ib9c93ea843f63d38bdb8b0e5107f48afc2bdec52
2014-11-04Avoid re-constructing chart shapes when it's not in visible range.Kohei Yoshida
The re-construction will be deferred until it becomes visible again. Change-Id: I364ea8d38d48078dfd803b0e5bb20bfc8a2913ba
2014-11-04Remove com::sun::star.Kohei Yoshida
Change-Id: Id656f1ef1cdfb695bcfcb35e393def3682e8c556
2014-11-04Remove indirection...Kohei Yoshida
Change-Id: Ia01ed40391a4d5725a9f9e22817406216020c0d2
2014-11-04Apply pimpl to SdrPageWindow.Kohei Yoshida
Change-Id: I54554a229c03ff87096782344a728a49636c1de1
2014-11-04Create a variant of MakeNewObject that takes snap rectangle.Kohei Yoshida
And absorb 2 special cases from SvxDrawPage::_CreateSdrObject(). Change-Id: I8e400794b9aef4b229b6760835b80dffd56cbc8d
2014-11-04Rename aRect -> maRect for a member variable.Kohei Yoshida
Conflicts: svx/source/svdraw/svdoashp.cxx svx/source/svdraw/svdocirc.cxx svx/source/svdraw/svdograf.cxx svx/source/svdraw/svdoole2.cxx svx/source/svdraw/svdorect.cxx svx/source/svdraw/svdotext.cxx svx/source/svdraw/svdotxdr.cxx svx/source/svdraw/svdotxtr.cxx Change-Id: I12dc6c12ee44753c63b15f03276cdaa24e57d395
2014-11-04rename nWink->nAngleNoel Grandin
Change-Id: I3a4cec65307c517684d4f8a291ca73b6a212a857
2014-11-04some random renaming of Wink fields -> AngleNoel Grandin
Change-Id: Icd4df8610072f5283276738896cb5c01762838ea
2014-11-04rename nHdlWink->nHdlAngleNoel Grandin
Change-Id: Id8ddf1888c7a8517eced5f0f3209e91bda59a96f
2014-11-04rename nWink1->nAngle1Noel Grandin
Change-Id: I8cc5c9e16e8e0ebea1ea532c762e560e68f029a9
2014-11-04rename nWink0->nAngle0Noel Grandin
Change-Id: I19a2c367064f6b6f2656ec645d1a79144b479df9
2014-11-04rename TakeWinkStr->TakeAngleStrNoel Grandin
Change-Id: I464505c8d52c2e12e4c0d7ed3512039f0bc4f789
2014-11-04rename nTmpWink->nTmpAngleNoel Grandin
Change-Id: Ie6b3af93633f17e8aaa90252348488b67446f6ee
2014-11-04rename nNeuWink->nNewAngleNoel Grandin
Change-Id: Ic0b63a516d56ffc12e08e25d33c874162ce19d69
generated by cgit (git 2.34.1) at 2024-06-23 08:53:40 +0000