summaryrefslogtreecommitdiff
path: root/svx/source/svdraw
AgeCommit message (Collapse)Author
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-02coverity#1242476 Dereference null return valueCaolán McNamara
Change-Id: I1895537459bca9341d1e97bad7ca38813bdfa2fe
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-26remove unnecessary casts'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
2014-09-23loplugin: cstylecast, update PTR_CAST macro to use static_castNoel Grandin
I introduce a template method into the PTR_CAST machinery to maintain constness. There is now a FIXME in sd/../docshell.cxx because I needed to use a dynamic_cast there to work around the games it appears to be playing with OLE in-place activation. Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, dropping the GCC-extension, unnecessary use of typeof from tools/rtti.hxx Change-Id: Iba5ace1aa27e02b34fcc91af1e658c43371afd03
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-19fdo#84061 Fix setting text style sheet listeners in SdrTextObjTobias Lippert
The code in SdrTextObj::ImpSetTextStyleSheetListeners is obviously not working correctly. The families of the stylesheets are appended to the name of the family for further usage. An encoded string looks like "STYLE_NAME|3 " The family is then extracted by copying the first (length-6) bytes, e.g., "STYLE_NAME" in this example. Then another copy starting a position 1 is created, e.g., "TYLE_NAME". This string is cast to an Int32. Since this is not possible, 0 is returned, and the originally stored family is lost. This patch corrects this behavior, and adds a unit test. Change-Id: I60c0add6e4b670acbbc264cc77672452f282f737 Reviewed-on: https://gerrit.libreoffice.org/10818 Reviewed-by: Matúš Kukan <matus.kukan@collabora.com> Tested-by: Matúš Kukan <matus.kukan@collabora.com>
2014-09-18fdo#82577: Handle FontNoel Grandin
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-13coverity#704830 Dereference after null checkCaolán McNamara
Change-Id: Ifb9e226b848bfcba593bc54558680738158adc36
2014-09-123D charts: Update the 3D charts when a value changes.Jan Holesovsky
Change-Id: I9c4052108446959ff6f5215d704b496e7a8e6aee
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-07cppcheck: Logical disjunction always evaluates to trueJulien Nabet
Change-Id: I527c010a49210ccaa4840ea142525643944b642d
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-03Remove (misleading) EditEngine::QuickRemoveCharAttribsMatúš Kukan
Change-Id: I7a0be4e204a239dfdd9c184b3d54a69debe8a208
2014-09-01Consistency around SvxB3DVectorItem in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I7f2348d82c76f6f231e34f0dfc4b6ee6fddffe55
2014-09-01Consistency around SvxColorItem in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: If26ab3229871d2d6a7e4e7e8f79f4cb927b96930
2014-09-01Consistency around SfxUInt16Item in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I2e467df03a34d694214e0560476cb7fd76ef0735
2014-09-01Consistency around SfxBoolItem in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I3253b4cc5657a7d6b960ee892584109d373eed3d
2014-09-01Consistency around SfxUInt32Item in svx/svx3ditems.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I3193eab34a34c051002adeedd8b368e26f55f7a3
2014-08-29Make opengl chart window always activeZolnai Tamás
Fortunately there is a special ole object group with the MS_EMBED_ACTIVATEWHENVISIBLE flag which define this behaviour. Problem is that both Aspect and EmbedMisc are MS specific enums so we can't use them directly for non-MS objects. But we can handle opengl charts the same as this ole object group. Change-Id: I49abeffce319cbb775709a72ba198a1f76b65374
2014-08-29ChartHelper::IsChart is uselessZolnai Tamás
EmbeddedObjectRef has an own IsChart method with the same behavior. Change-Id: Ib06699186466bf3da2bd67d7c631a5216463fb14
2014-08-28Avoid unnecessary, potentially invalid downcasts from SdrObject to SdrObjGroupStephan Bergmann
Change-Id: If00b4a11ce5e568b9e4ff00038dc9e1f068cfd79
2014-08-27Resolves: fdo#83062 infinite recursionCaolán McNamara
regression from commit 7c03fc2fe77f9b1f910f4ab395923e52648c32b5 Date: Mon Sep 2 14:30:09 2013 +0000 Related: #i123048# Corrected connector layout after reload verified that #i123048# continues to work Change-Id: If5fce4b7a88d4d0972f52705334e4b9b48425cca
2014-08-25Consistency around SdrMetricItem in svx/sderitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I4a0715b18bc3aa032779252cad2450c905a467a4
2014-08-25set names on a bunch more threads...Michael Stahl
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-25Consistency around SdrAngleItem in svx/inc/sxraitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: If88f88cfe0144b83b3228650a34d9bf2c468b936
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23fdo#82577, fdo#82579: Handle CursorTor Lillqvist
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor typedef and some ancient Carbon (?) Cursor typedef on OS X. Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
2014-08-22Point and Rectangle coordinates are long, not sal_Int32Stephan Bergmann
Change-Id: I0f97d12f55e506af699976bf81f4dcf956195aab
2014-08-22Consistency around SfxStringItem in svx/inc/sxonitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I694c42a53cb9041b51ef876416f0f61963b89f86
2014-08-22Consistency around SdrYesNoItem in svx/sxmspitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: If7a3c3834f63bd0b358da4d05e9510c3f695c5d0
2014-08-22Rectangle coordinates are long, not sal_Int32Stephan Bergmann
Change-Id: I2f4bd53bbf94ea439e774ea85e61adcdb920c497
2014-08-22Avoid invalid downcastsStephan Bergmann
Change-Id: Iea1688213cc0ebb8fcb3d3e3c862fd31275b9b38
2014-08-19svx: Cleanup ASCII art and useless commentsChris Laplante
Change-Id: I5399362056276f324fd43eda05d3f606dc6f8c71 Reviewed-on: https://gerrit.libreoffice.org/11011 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-18Consistency around XColorItem in svx/sdshcitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I7ecf827a0713efaecb4b0eb49f9f8c06f8c59091
2014-08-18Consistency around SdrPercentItem in svx/sdshtitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I4e98c362f811c19f03766d0c78f10c795d3ac79d
2014-08-18Consistency around SdrOnOffItem in svx/sdtcfitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: Ib461b5d3702e00a9d7cef3229c44e3328c776e1d
2014-08-18Consistency around SdrMetricItem in svx/sdsxyitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I3734cb14b6ed8f556af85b234968682a55ac8a4c
2014-08-16Simplify by early bail-outMatteo Casalin
Change-Id: Id3789fd994b54813b6f72857a625b496c7a6eef0
2014-08-16Consistently use size_t and SAL_MAX_SIZEMatteo Casalin
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16Remove repeated checkMatteo Casalin
Change-Id: I2ed6326f97bf6c0eefb3d309405261ffd30681b9
2014-08-16Just copy the boolean valueMatteo Casalin
Change-Id: I158f4e9eddf7ea666613d56a79d014dd3cbf9931
2014-08-16Remove pnMarkNum parameter: either NULL or pointed data is not readMatteo Casalin
Change-Id: I213a097616275765478a5f21a5f8e9645470a1e8
2014-08-16Consistently use size_t and SAL_MAX_SIZEMatteo Casalin
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on. Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as return value in case of failure and in the related tests. Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
2014-08-14Go even further in the scope reduction, we are 100% sure mpClone is NULL.Jan Holesovsky
Change-Id: Id5facbc817ecc0b89689dcba30672a6538e70945
2014-08-14Massive scope level reduction by early bail-out.Kohei Yoshida
Change-Id: Ie620208f02bf74844f9b7cb904f9c5abbb10ca07
2014-08-12Consistency around SdrOnOffItem in svx/sxcaitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I1a88c73c8e4c764a6beadb8bb54910d868a12d93
generated by cgit (git 2.34.1) at 2025-01-08 18:46:06 +0000