summaryrefslogtreecommitdiff
path: root/svx/source
AgeCommit message (Collapse)Author
2018-04-02weld SvxPasswordDialogCaolán McNamara
Change-Id: I2e51f1a0a96eb042a4460bb9591b63a169eb6de2 Reviewed-on: https://gerrit.libreoffice.org/52258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-02tdf#116596 Dynamically size Findbar searchlabelJim Raykowski
Change-Id: I74d09d439ada6d92fca396ac45c60340cb55e668 Reviewed-on: https://gerrit.libreoffice.org/52043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-01fix some openoffice bugzilla linksdennisroczek
* remove redirects * use https links * replace old attchment links with working ones Change-Id: Ic9a154f46e142138f0adea7d7b8be3b6cfe8af18 Reviewed-on: https://gerrit.libreoffice.org/52224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-01Fix typoAndrea Gelmini
Change-Id: Ie9492b3e76d3a425269cf281d426040df896d8cb Reviewed-on: https://gerrit.libreoffice.org/52195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-31loplugin:unusedfieldsNoel Grandin
Change-Id: Id2dea1d3a56d5d3be03c5a2a4f2ef530a05f9b19 Reviewed-on: https://gerrit.libreoffice.org/52185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-30weld SvxCharacterMap dialogCaolán McNamara
and SmSymDefineDialog There's a whole bunch of interrelated stuff which needs to work at the same time. add menu support, keyboard support, better mouse support, a gtk scrollable adaptor to support pseudo scrolling drawing bodge, plugable uitest support for custom widgets, plugable a11y support for custom widgets via the existing atk_object_wrapper_new wrapper for XAccessible In this specific case, change SvxCharacterMap from something that has an internal scrollbar to a scrolledwindow where the scrollbar is external, which drops the need for the a11y impl of SvxCharacterMap to emulate being a scrolled window and internal table and just needs the table a11y impl Change-Id: Ia2743d6958021c525a1900154dcbb69ae33fc400 Reviewed-on: https://gerrit.libreoffice.org/52084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: I7805ac9bc6f8c0aa5ba4804777e7d7c2c29a78f3 Reviewed-on: https://gerrit.libreoffice.org/52066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29Allow URL-Check for non-selected TableTextArmin Le Grand
The part to detect a hit on a TableObjectText in Draw/Impress for a non-selected Table was setting the HitType to SdrHitKind::TextEditObj. This prevents the latter happeing check for URL (see below). Not directly setting to TextEditObj is okay, this is determined and set later. I checked various possible changes to keep the behaviour as for 'normal' SdrObjects, so please be careful when doing changes in the HitTest code Change-Id: I326a73b88fc56fd902b5052cc3a2ddecf3c3ba61 Reviewed-on: https://gerrit.libreoffice.org/52016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-03-29loplugin:virtualdown in svxNoel Grandin
Change-Id: I953780a4b2879266c415a3c4e8992c8be74dced4 Reviewed-on: https://gerrit.libreoffice.org/52001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28Translate German variable namesJohnny_M
Akt -> Current in svdraw (Other occurrences will be done separately.) Change-Id: I5dc6b52678b4ce4e875f8c1aaf68e7367bf6e922 Reviewed-on: https://gerrit.libreoffice.org/51799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-28tdf#63438 Toggle highlight color to no fill if the same value is activeDaniel
Change-Id: I7553bc7bffeb0a8d1275aadc44bf2813564087b5 Reviewed-on: https://gerrit.libreoffice.org/51794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-27tdf#81925 Make messages show in Findbar searchlabel overflow toolbarJim Raykowski
...and add a bit more horizontal space for messages Change-Id: I4a310d7a4a649860a36ce12b775bb6b275cd6ef5 Reviewed-on: https://gerrit.libreoffice.org/51523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-26tdf#112997 multiple animated gif only one frameNoel Grandin
Not sure what the problem is, but using a vector and just making sure we insert into the right spot for the sorting fixes it. Change-Id: I11c08e08a14c98ba7eb6a5d925c75bab891ecf63 Reviewed-on: https://gerrit.libreoffice.org/51829 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-25clang-tidy modernize-use-equals-default in XPolygonJochen Nitschke
Change-Id: I82a4a56bf02c6ff2495bd7a6058640d77e8c0b73 Reviewed-on: https://gerrit.libreoffice.org/51832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-24Fix typosAndrea Gelmini
Change-Id: I6c515e716b232fecfe1750b806f0a5624f648de5
2018-03-23a11y crash with no chars selected in character mapCaolán McNamara
type gibberish in character map search box, click character map widget, crash Change-Id: Ifa3e4bce2d7e0b84cf3c5033eb819c73076daabe Reviewed-on: https://gerrit.libreoffice.org/51773 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-23Typo: ImplGetSelectEntryPos -> ImplGetSelectedEntryPosSamuel Mehrbrodt
Change-Id: I19233d37b2d72bef73659ddbb6d116d2632145c1 Reviewed-on: https://gerrit.libreoffice.org/51748 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-23ofz#7065 Integer-overflowCaolán McNamara
Change-Id: Ic8837d21d64dc6fd3623ab5d32bc902e6c34dd21 Reviewed-on: https://gerrit.libreoffice.org/51746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-23Typo: GetSelectEntryPosLBB -> GetSelectedEntryPosLBBSamuel Mehrbrodt
Change-Id: Id1706d11143ee60216322db1ac51207e658000e1 Reviewed-on: https://gerrit.libreoffice.org/51749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23Typo: GetSelectItemId -> GetSelectedItemIdSamuel Mehrbrodt
Change-Id: Ieebb50b73f1f341c924693f3966f8cd2b09a136b Reviewed-on: https://gerrit.libreoffice.org/51750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23Typo: GetSelectLanguage -> GetSelectedLanguageSamuel Mehrbrodt
Change-Id: Ia283812d4e9df87d875559af5366c2e36b19eab2 Reviewed-on: https://gerrit.libreoffice.org/51747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23Typo: SplittTable -> SplitTableSamuel Mehrbrodt
Change-Id: I6c5947964b3765ea05debe8837bd2f3dc57ae6ed Reviewed-on: https://gerrit.libreoffice.org/51745 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-22tdf#83877 Move SignatureLineDialog to svxSamuel Mehrbrodt
To prepare using from Calc Change-Id: I102ecf2c956922dd1458c99bd7cd7be30f6f5ec4 Reviewed-on: https://gerrit.libreoffice.org/51726 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-21support both vcl and weld in genericunodialog for interimCaolán McNamara
Change-Id: Ife85dd7a4bd27260514b390ca3928152db0d688f Reviewed-on: https://gerrit.libreoffice.org/51699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20tdf#116482: Fix for Crash on drawingMohammed Abdul Azeem
Making the drawing layer import to use fastParser. Change-Id: I4ff05d65de525aef3e50676072a79c9c329e6afc Reviewed-on: https://gerrit.libreoffice.org/51673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-19coverity#1430074 Uncaught exceptionCaolán McNamara
and coverity#1430066 Uncaught exception coverity#1430095 Uncaught exception Change-Id: Idca2e12d3911e3ea768a2a9fb8e7f3b03a2c887f Reviewed-on: https://gerrit.libreoffice.org/51567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19remove unused ucbstreamhelper includesJochen Nitschke
and a few vclunohelper includes Change-Id: I4803605766d155fe5044c2a65c0444631146831c Reviewed-on: https://gerrit.libreoffice.org/51496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-17OperationSmiley: Corrected shadowing of local variablesArmin Le Grand
Change-Id: I7826c7d80ca822cd8211cbf9444f21c3bcfaf6aa
2018-03-17OperationSmiley: Corrected shadowing of local variablesArmin Le Grand
Change-Id: I7826c7d80ca822cd8211cbf9444f21c3bcfaf6aa
2018-03-17OperationSmiley: Removed unused param from SdrPathObj constructorArmin Le Grand
Change-Id: Ia69e822c698ea13650d868472ba63744727ff886
2018-03-17OperationSmiley: Secured quite some places using CustomShapeArmin Le Grand
Changed quite some places of SdrObjCustomShape usage to use references instead of pointers, thus forcing to more secure handling. Changed some test and change methods, even found a memory leak by doing so. Added some incudes/predefines for linux builds. Change-Id: Iba76037a3c54af50bb05e6bd63d7ad04624665a7
2018-03-17OperationSmiley: Secured quite some places using CustomShapeArmin Le Grand
Changed quite some places of SdrObjCustomShape usage to use references instead of pointers, thus forcing to more secure handling. Changed some test and change methods, even found a memory leak by doing so. Change-Id: Iba76037a3c54af50bb05e6bd63d7ad04624665a7
2018-03-17OperationSmiley: Added support for using same FillGeometryArmin Le Grand
It is now possible to use a single FillGeometry to fill objects that are made of multiple filled objects (e.g. CustomShapes) so that they look as using a single fill. This is used for CustomShapes, but may later be 'extended' to be used for more cases. The basic functionality was already in the primitives, but had to be added to SDrObject due to these being used for CustomShapeVisualization (currently - would be better to change this to primitives, too). Change-Id: I1d9fb158191a9ec663e46f3911213be2f3d88986
2018-03-17OperationSmiley: Remove brightness from SdrPathObjArmin Le Grand
There was a member at SdrPathObj called mdBrightness only for holding a blend value during creation of SdrPathObjs for CustomShape visualization. This has nothing to do on the model data, move it to where it belongs Change-Id: Iee101f90a1275ce1ed97e8e8d0ccf7084c83d4f6
2018-03-16don't bother dithering for 256bit displaysNoel Grandin
which surely are a minority by now Also drop the GetColorCount() method on OutputDevice and clean up the remaining call sites to use GetBitCount() Change-Id: I4e2c6f2523796f7df7f54eb005f1539e34d9ea40 Reviewed-on: https://gerrit.libreoffice.org/51389 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-16remove some GraphicObject URL funct. from GraphicImportHelperTomaž Vajngerl
GraphicImportHelper is an implementation of XGraphicObjectResolver which is mostly used to "resolve" a GraphicObject URL to the internal storage URL (and save the graphic to the storage in the process). Most of the GraphicObject URL functionality was removed so the required overrides from XGraphicObjectResolver interface now return an empty result or do nothing. Change-Id: Iee6bb71b15411d03ef82ab4d20d234ff0e834425 Reviewed-on: https://gerrit.libreoffice.org/51331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16use more TypedWhichId in sfxsidsNoel Grandin
Change-Id: I136427319ce2f1117501517efec2f03019bbf71e Reviewed-on: https://gerrit.libreoffice.org/51339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-15weld sort dialogCaolán McNamara
rework huge language listbox into a combobox see https://gitlab.gnome.org/GNOME/gtk/issues/94 and the lack of typeahead/search for lists Change-Id: I4a3af695d86bbcb92e5cdd500c4acb7cfaf37f41 Reviewed-on: https://gerrit.libreoffice.org/51340 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-15move some GDI import code from svx to vclNoel Grandin
part of making ScopedWriteAccess an internal detail of vcl Change-Id: I916f2ca05c9d7c17b62c91e113df6d8454bb4351 Reviewed-on: https://gerrit.libreoffice.org/51283 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-14loplugin:constantparamNoel Grandin
Change-Id: I3ce653c0d9e517229dbbe32cc8d3ec3c206e364d Reviewed-on: https://gerrit.libreoffice.org/51273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-13SDI: don't #define/#undef names of actual classes for slot headersMike Kaganski
Visual Studio 2015/2017 cannot handle that correctly, and emits a lot of intellisense errors. So, just prepend the define with "ShellClass_" Change-Id: I473ceb7e0a88e114b92e6342fd4ae63015cafd3e Reviewed-on: https://gerrit.libreoffice.org/51135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in svdibrow Change-Id: I3a3a87fdba179ad927226097c53c4f07d36095e8 Reviewed-on: https://gerrit.libreoffice.org/51033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13Translate German variable namesJohnny_M
Akt -> Current in svdedtv2 Change-Id: Iae43ec7ccd0a220b0296780bafecd5b4d232c3d5 Reviewed-on: https://gerrit.libreoffice.org/51032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-12loplugin:redundantfcast look for redundant copies in return statementsNoel Grandin
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008 Reviewed-on: https://gerrit.libreoffice.org/50996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-11weld color pickerCaolán McNamara
Change-Id: I487b9a0cc13b2b60a0f1e28667773b5d3b5c66cc Reviewed-on: https://gerrit.libreoffice.org/51001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-11Move (and rename) graphic stuff from svtools to vclTomaž Vajngerl
This is preparing to change how GraphicManager works where it won't base itself around GraphicObject anymore but Graphic. No functional or cosmetic change was made to the classes, only changes that were needed because of the move and rename. The only thing that wasn't moved is the GraphicRenderer as it is not needed in vcl for now (but makes sense to move it in the future to keep graphic stuff together). grfmgr was renamed to GraphicObject as the GraphicManager will be changed a lot and most likely moved out, so the name grfmgr won't make any sense anymore. All the UNO implementations were renamed with a prefix Uno and used the same name as the class name. This is made to be more specific which are the Uno objects (for example graphic.cxx contained the implementation of XGraphic, which is similar to graph.cxx contains Graphic). Change-Id: I54a2fa6c7e997469aaa7770db05244adb9f64137 Reviewed-on: https://gerrit.libreoffice.org/51068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-11svx: convert XBitmap directly to XGraphicTomaž Vajngerl
Change-Id: If2bd8419d9073625f0392f59f671d70193bf990c Reviewed-on: https://gerrit.libreoffice.org/51048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-10xmloff: embedded objects can still use GraphicObject URLTomaž Vajngerl
The embedded graphic object don't seem to use the uniqueID of a graphic object, but seem to have the same URL prefix. Let's leave this in for now. Change-Id: I48d9ad2c3b1eca745911f03221988c46c0fdb8d2 Reviewed-on: https://gerrit.libreoffice.org/51041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-10remove references to {Header,Footer,Para}GraphicURLTomaž Vajngerl
Change-Id: I559f25ee99f7b8b49545390479cbb06d3c601d3c Reviewed-on: https://gerrit.libreoffice.org/50982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>