summaryrefslogtreecommitdiff
path: root/svx/source
AgeCommit message (Collapse)Author
2018-09-11loplugin:simplifyconstruct in svtools..svxNoel Grandin
Change-Id: Ia20fac7cec01ac658a903f8b001807b2e72dbf3e Reviewed-on: https://gerrit.libreoffice.org/60316 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:unusedmethodsNoel Grandin
Change-Id: I34009aabf0befb346470b5c0d96ad8fc476b7c4e Reviewed-on: https://gerrit.libreoffice.org/60300 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11weld SvxBitmapPickTabPageCaolán McNamara
Change-Id: I4c5fd94356f3640b150ef9fec48a166457f3b70b Reviewed-on: https://gerrit.libreoffice.org/60266 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-11loplugin:constantparamNoel Grandin
Change-Id: Ia11bf93768d5f722b7fe62df15f24809cb7e7f04 Reviewed-on: https://gerrit.libreoffice.org/60280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11clang-tidy bugprone-copy-constructor-initNoel Grandin
Change-Id: Idd435b3a4d081f6d3af26ff8add69ad4af50db57 warning: calling a base constructor other than the copy constructor Reviewed-on: https://gerrit.libreoffice.org/60239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-10weld SvxBulletPickTabPageCaolán McNamara
Change-Id: I0b3e48cc63984208c8e4a090d6630dd5325d776e Reviewed-on: https://gerrit.libreoffice.org/60257 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10No more need for extra local variablesStephan Bergmann
...after 453fde35bb838febf73bfda0bd981ee270c9b12e "BitmapFilter::execute can be const". This reverts the call-site changes of bce47223099bb3349d96af9d6b1fe88bcdd539df "clang-tidy bugprone-use-after-move in BitmapFilter::Filter" again. Change-Id: I5ce4eb7ddce90fb779ddfb1c5864fd4785708175 Reviewed-on: https://gerrit.libreoffice.org/60255 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-10clang-tidy bugprone-virtual-near-miss in RecoveryDialogNoel Grandin
warning: method 'svx::DocRecovery::RecoveryDialog::execute' has a similar name and the same signature as virtual method 'Dialog::Execute'; did you mean to override it? Change-Id: I42eadd96069ff23c44fedc76d800161767313e77 Reviewed-on: https://gerrit.libreoffice.org/60240 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-10tdf#42949 Fix IWYU warnings in include/cppuhelper/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45 Reviewed-on: https://gerrit.libreoffice.org/59297 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-09weld SvxShadowTabPageCaolán McNamara
Change-Id: I5447641216c8cba3d275d76c00bf7306df8acf19 Reviewed-on: https://gerrit.libreoffice.org/60221 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-09weld SvxGridTabPageCaolán McNamara
Change-Id: I04c2ead288547ecd0fba22a7a95a2497ab8dc768 Reviewed-on: https://gerrit.libreoffice.org/60217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08weld FontFeaturesDialogCaolán McNamara
Change-Id: I67ab7388593aceb00b660e4d40904a4eef247620 Reviewed-on: https://gerrit.libreoffice.org/60148 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08Replace find_if with proper quantifier algorithmsArkadiy Illarionov
Missed in 085269d25a705b656436feac47149296b4b4b35d Change-Id: I3cfab57232908b48d090658e0fbc948d62b3fc6f Reviewed-on: https://gerrit.libreoffice.org/60180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-07weld SvxCharEffectsPageCaolán McNamara
Change-Id: I067b7a8c93e997fd554558f334a2968bf27965c6 Reviewed-on: https://gerrit.libreoffice.org/60147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07weld writer page style dialog and SvxBorderBackgroundDlgCaolán McNamara
writer, format page is complete Change-Id: I09f6e4354461c4374cdb0d0e0754dfee35415b45 Reviewed-on: https://gerrit.libreoffice.org/60058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07tdf#75341: fix condition to approve row (form)Julien Nabet
Considering rColInfo.nNullable != ColumnValue::NO_NULLS is ok to approve row isn't sufficient in the case the field is "Input required" in form. Change-Id: I27c57fe8ce5afac97eb0650f93703333c85f1421 Reviewed-on: https://gerrit.libreoffice.org/60109 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-09-06clang-tidy bugprone-use-after-move in BitmapFilter::FilterNoel Grandin
which necesitated changing the API and hence the call sites Change-Id: Id417a235bf9b2bf1a3d152dc6600c0635486cafa Reviewed-on: https://gerrit.libreoffice.org/60086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-06rename back now originals are fully replacedCaolán McNamara
Change-Id: I1911055f9bf6bd636561209cadfb1dbf5650affa Reviewed-on: https://gerrit.libreoffice.org/60057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06weld SwColumnPage and SwColumnDialogCaolán McNamara
Change-Id: Ia649785047db2551044b4d765881309f83b5c838 Reviewed-on: https://gerrit.libreoffice.org/60044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06tdf#108351 - Default list of paragraph styles in drop down menuheiko tietze
Sort order adjusted Change-Id: I09109ac4aa21d8fa77da5c5930682dcf7a4f542a Reviewed-on: https://gerrit.libreoffice.org/60020 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-09-06tdf#91837: fix deinitializeControls (forms)Julien Nabet
m_bControlsInitialized wasn't ever resetted to false Change-Id: I9f7bd6504ccaa0a41c9cb075c1ba33436f0f97dc Reviewed-on: https://gerrit.libreoffice.org/60059 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-09-05weld SvxBorderTabPageCaolán McNamara
Change-Id: I33f12f160ac5fea14c9a53c3846c6d31c7fd0084 Reviewed-on: https://gerrit.libreoffice.org/59954 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-05default focus colorset on popover gaining focusCaolán McNamara
Change-Id: Icb731c4c9544d754bb3ad88ecf15ffc04f216294 Reviewed-on: https://gerrit.libreoffice.org/60006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-05loplugin:useuniqueptr in svxNoel Grandin
Change-Id: Iba9ceb0b86b175ef599f4de7b06bf0dccc2ba997 Reviewed-on: https://gerrit.libreoffice.org/60005 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-05loplugin:useuniqueptr in ViewObjectContactOfPageObjNoel Grandin
Change-Id: I4f7af7bb8da2b4bfb27ab7cf748677fc3fa6fdbc Reviewed-on: https://gerrit.libreoffice.org/60004 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-05clang-tidy performance-inefficient-vector-operationNoel Grandin
Change-Id: Iebcaea7b08c5284946d83b6b6b9ed26b218025d4 Reviewed-on: https://gerrit.libreoffice.org/59992 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-05pdfium: replace FPDFTextObj_CountChars/GetTextProcessed patches with backportMiklos Vajna
Change-Id: I9c198ff0cd31de064fcc4a3bb0ed92066f38e4c5 Reviewed-on: https://gerrit.libreoffice.org/60007 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-04tdf#118967 Batch all a11y notificationsPaul Trojahn
Currently all a11y notifications get send out immediately, which often ends up formatting the document before it is ready. With the current EnterBlockNotifications()/LeaveBlockNotifications() system it is difficult to find all places that need blocking and any change in the a11y code might require additional blocking in unpredictable places. By queueing all notifications by default and only sending them out when the document is ready, we can make sure that it can't be corrupted. Change-Id: I9599c7b57eb5b8f8f0575de57fcc8bab171f78ff Reviewed-on: https://gerrit.libreoffice.org/58703 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03weld SvxAreaTabPageCaolán McNamara
which itself has 5 sub tab pages Change-Id: If71e91248b5771af4845ad6dba997ac4c7841b5d Reviewed-on: https://gerrit.libreoffice.org/56112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-03pass SdrUndoAction around by std::unique_ptrNoel Grandin
convert the LINK we use here to std::function, since LINK does not currently handle std::unique_ptr Change-Id: I9df80352e612445e5f5ca513d7d4196d65589778 Reviewed-on: https://gerrit.libreoffice.org/59804 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-01tdf#119611 Use generic SetAll() in SdrPageView ctor.Regina Henschel
The LayerAdmin has invalid values in case of charts. In consequence a bitfield with only zeros was generated, meaning all is invisible and not printable. Change-Id: I59d341ac8742f81b5f9afb28dc9add459a01525f Reviewed-on: https://gerrit.libreoffice.org/59895 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-08-31Fix syntaxJulien Nabet
Change-Id: I21cca2e5cd81ee58a59fda077ed40ba02d9f1df3 Reviewed-on: https://gerrit.libreoffice.org/59844 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-08-30weld SvxHeaderPage/SvxHeaderPageCaolán McNamara
Change-Id: I86f14a38c32baf46ccb5674005192fea2665719d Reviewed-on: https://gerrit.libreoffice.org/59801 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-30rename GetMarkedObjModel to CreateMarkedObjModelNoel Grandin
and return std::unique_ptr Not that it helps much, the ownership quickly becomes complex once it hits the TransferableHelper. Change-Id: I3c6bd72072e092b71b32e4105fe859fdcea956af Reviewed-on: https://gerrit.libreoffice.org/59777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29match preview buffer device mapmode and pixel sizeCaolán McNamara
Change-Id: Ie5ac758b788357e1d54ea3dc5abd233ff9e4abf0 Reviewed-on: https://gerrit.libreoffice.org/59762 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29Replace find_if with proper quantifier algorithmsArkadiy Illarionov
Change-Id: Icc820a47ac891c358883f9c01224f676c58fdd11 Reviewed-on: https://gerrit.libreoffice.org/59744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29remove 1 pixel white band in XRectPreviewCaolán McNamara
Change-Id: I3089f9305b8142e2c78405a4f9ae6a2066e90cfa Reviewed-on: https://gerrit.libreoffice.org/59725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29loplugin:constantparam (1)Noel Grandin
Change-Id: I25077e391ecca1b678062d261a83d88daadf0a58 Reviewed-on: https://gerrit.libreoffice.org/59701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29pdfium: replace FPDFTextObj_GetFontName() patch with backportMiklos Vajna
Change-Id: I36d86e7ccca66b09f2f49e401d77deb52fbf742a Reviewed-on: https://gerrit.libreoffice.org/59738 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-28tdf#119122 first (5%) pattern initially drawn with too many black cellsCaolán McNamara
pattern of area tab, pattern subtab of e.g. format page and in the pattern editor the 5% style is shown wrong, clicking ona different pattern and then back may make it draw correct a problem since... commit 6fbb6d80fe6203ff6f84ee85ca625b6e60bf5bae Date: Fri Feb 16 16:13:38 2018 +0200 use std::array in createHistorical8x8FromArray to make the assumption about the size of the array obvious in the code. Change-Id: I882384a13dedc7a14b63b3b8a9b764a4367b7cc6 Reviewed-on: https://gerrit.libreoffice.org/59724 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-27tdf#119531: use correct conversion directionMike Kaganski
Regression from commit 8c48d69f06ddb3cb6c807a1e7db62dddb9778ded Change-Id: I302a210ab6c502e3938487ee02a08fc334cd3289 Reviewed-on: https://gerrit.libreoffice.org/59666 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-27tdf#101242 Support draw:display and draw:protect attributes of ODFRegina Henschel
LibreOffice writes the properties visible, printable and locked of layers into items in the subfile settings.xml and handles them as properties of the view. ODF handles them as property of the layer. To become more ODF conform as a first step these properties are now read and written. They are used to initialize the view in case they are missing in settings.xml, which is the case for foreign documents. The ODF properties are written in addition to the items in settings.xml, so that older versions will notice no difference with such documents. SdModelTestBase is changed to handle odg as Draw document. Change-Id: I190ecc51fc6ee91ec4b96d06bb216ce517bdfcfe Reviewed-on: https://gerrit.libreoffice.org/59269 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-08-24pass DelFormats around using std::vectorNoel Grandin
instead of an array and a separate count Change-Id: Ia12a549da7e35092da2db35f8b2b9fc6a9e9c2be Reviewed-on: https://gerrit.libreoffice.org/59506 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22new loplugin:conststringfieldNoel Grandin
Look for const string fields which can be static, and mostly convert them to OUStringLiteral And add a getLength() method to OUStringLiteral to make the transition easier. Remove dead code in XclExpRoot::GenerateDefaultEncryptionData, default password is never empty. Change-Id: Iae75514d9dbb87289fd5b016222f640abe755091 Reviewed-on: https://gerrit.libreoffice.org/59204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-21tdf#119282 Area tab, Pattern color changeNoel Grandin
regression from commit ccd316d1cb310734848bd20244f509024b549b8c use VirtualDevice in createHistorical8x8FromArray Move the code inside vcl so we don't need to expose BitmapWriteAccess. I tried to detect this thing by counting the number of independent colors in the bitmap, but that didn't work. It is used from more than one place, and appears to be very determined that it needs a 2-color palette to work properly. Change-Id: Id11dd9ea78e5e522a6083d6a799e801cac81fd5b Reviewed-on: https://gerrit.libreoffice.org/59331 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-08-21loplugin:useuniqueptr in FmXGridCellNoel Grandin
Change-Id: I4783b59f5fe83354fb47d081a60a81c9cebfac71 Reviewed-on: https://gerrit.libreoffice.org/59354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-21loplugin:useuniqueptr in GalleryThemeCacheEntryNoel Grandin
Change-Id: Ib9f3e604ca889a938cd41dbf3f59dfa7131fe4da Reviewed-on: https://gerrit.libreoffice.org/59352 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-20Simplify containers iterations, tdf#96099 follow-upArkadiy Illarionov
Use range-based loop or replace with std::any_of, std::find and std::find_if where applicable. Change-Id: I2f80788c49d56094c29b102eb96a7a7c079567c6 Reviewed-on: https://gerrit.libreoffice.org/59143 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-20return weld widgets by std::unique_ptr from builderNoel Grandin
Change-Id: I20c007b13dae2d1155034711ad1ad48bfdfd0ba8 Reviewed-on: https://gerrit.libreoffice.org/59288 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-17tdf#105998: Enhanced fix for MetafileToBitmap at better placeArmin Le Grand
Change-Id: I220bdbe196a68ef2df25885dceee70e15b760410 Reviewed-on: https://gerrit.libreoffice.org/59220 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
generated by cgit (git 2.34.1) at 2024-07-16 00:05:07 +0000