summaryrefslogtreecommitdiff
path: root/svx/source
AgeCommit message (Collapse)Author
2020-01-29bInterim is always trueCaolán McNamara
Change-Id: Id9f72fdb94a766ef58a44b3653a36f22335b5718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28lok: create marking overlay object, but add no objects to itMichael Meeks
null mpMarkObjOverlay was used for a number of other reasons. Change-Id: I0681d9c544f0cd3f93e991eb048b97bd58f94787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87409 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-28tdf#96505: Get rid of cargo cult long integer literalsOnur Yilmaz
I checked return values. Long variables didn't affect the calculation. Change-Id: I0c33c20b872ff6b1dc6c87c4032ccf19705db8e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87503 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28tdf#96505: Get rid of cargo cult long integer literalsOnur Yilmaz
I checked return values. Long variables didn't affect the calculation. Change-Id: I1d5b5cffa291c20f7940dc14efa05cc64f3ff1ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87499 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesBurak Bala
Change-Id: I9280d8ec3a789535ff83357e4c311a2f0f8e7fcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87477 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28weld LineListBoxCaolán McNamara
Change-Id: I143d0886f68e7ce50a998b2597730895afa99564 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28drop some unneeded vcl/builderfactory.hxx includesCaolán McNamara
Change-Id: I3a6f4756a01a35825e6efaa7de33fcc863b5aaf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28drop unnecessary vcl.builder includeCaolán McNamara
Change-Id: Id13e566320ddc98e47558a0610a3a8ea85fba7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87562 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28weld FontworkAlignmentWindowCaolán McNamara
Change-Id: Ib686407bae900cefa35294249fc02458a7992d8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87553 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28weld FontworkCharacterSpacingWindowCaolán McNamara
Change-Id: Idb049b2b7461c4f8206e0ded3c0bd36390df3682 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28tdf#75280 Convert inappropriate use of sal_uIntPtr to better integer typesEda Nur Var
Change-Id: I2829cccb526084590889d0618bc89a921aa8cdf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87475 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28New loplugin:unsignedcompareStephan Bergmann
"Find explicit casts from signed to unsigned integer in comparison against unsigned integer, where the cast is presumably used to avoid warnings about signed vs. unsigned comparisons, and could thus be replaced with o3tl::make_unsigned for clairty." (compilerplugins/clang/unsignedcompare.cxx) o3tl::make_unsigned requires its argument to be non-negative, and there is a chance that some original code like static_cast<sal_uInt32>(n) >= c used the explicit cast to actually force a (potentially negative) value of sal_Int32 to be interpreted as an unsigned sal_uInt32, rather than using the cast to avoid a false "signed vs. unsigned comparison" warning in a case where n is known to be non-negative. It appears that restricting this plugin to non- equality comparisons (<, >, <=, >=) and excluding equality comparisons (==, !=) is a useful heuristic to avoid such false positives. The only remainging false positive I found was 0288c8ffecff4956a52b9147d441979941e8b87f "Rephrase cast from sal_Int32 to sal_uInt32". But which of course does not mean that there were no further false positivies that I missed. So this commit may accidentally introduce some false hits of the assert in o3tl::make_unsigned. At least, it passed a full (Linux ASan+UBSan --enable-dbgutil) `make check && make screenshot`. It is by design that o3tl::make_unsigned only accepts signed integer parameter types (and is not defined as a nop for unsigned ones), to avoid unnecessary uses which would in general be suspicious. But the STATIC_ARRAY_SELECT macro in include/oox/helper/helper.hxx is used with both signed and unsigned types, so needs a little oox::detail::make_unsigned helper function for now. (The ultimate fix being to get rid of the macro in the first place.) Change-Id: Ia4adc9f44c70ad1dfd608784cac39ee922c32175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28remove some unused local varsNoel Grandin
found by my new aggressive unused var plugin. these are unused return values from function calls Change-Id: I3359c583f535828f192cb833762dfedc008d82f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-27tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorMehmet Emin Başoğlu
Change-Id: Iffb8512c530b33f87076aec9f85b45219c7d07e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87528 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorBatuhan Taskaya
Change-Id: Ic2013a741fc1288ff04f7cfc3617fd4689a7db0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87497 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesMehmet Emin Başoğlu
Change-Id: I5c25999a17ed64cc5a2fa586cd7d986d233a67f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87455 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27weld ExtrusionDepthWindowCaolán McNamara
Change-Id: I62f7ebb1c2f6b882fdd59825a52b9b308ccafd34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-27weld ExtrusionSurfaceWindowCaolán McNamara
Change-Id: I13b61c8e4ef0a251472b02061fa150451a7b03a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87530 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-27weld ExtrusionLightingWindowCaolán McNamara
Change-Id: I3078ca8315f84f03431a07630987687144857818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87527 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-27weld ExtrusionDirectionWindowCaolán McNamara
Change-Id: I94f6d602f489d34f9b35ee2ec20e7fdf62e50adf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87519 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-27tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesEfdal İncesu
Change-Id: I1f9c143eee8da149d87668063cc2da16d22312db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87464 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesCanberk TURAN
Change-Id: I4e3e11a89e4f04d804cfb75e8eec53f59ad1cc89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87446 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27tdf#75280: Use sal_uLong instead of sal_uIntPtrBatuhan Taskaya
Change-Id: I05f91b0a0ee2782b9a7cc4b6815d17a70c542111 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87443 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesSarper Akdemir
Change-Id: Ifa5991296bda4c4b3f86f01c3713b5a5f8f9acb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87471 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesPelin Kuran
Change-Id: I760f294c5ef38879a95fe94dce25801108c969ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87459 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-27tdf#124176: Use pragma once instead of include guardsBurak Bala
Change-Id: I70591a80d9cb46cd94cfe69e34d9936f1ac5ea0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87478 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27tdf#130197 give paragraph and table panels column widths of 5 toolbutton widthsCaolán McNamara
Change-Id: Iae4f10eef6b293731d22eec8dcbb85a07d3e6c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87462 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-26restore fix of tdf#83320 Hide vertical text commands earlyCaolán McNamara
Change-Id: I738776028af90e2711418f922ff6e77a5cce14c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87423 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-26remove some unused local varsNoel Grandin
found by a more aggressive variant of loplugin:unusedvariables. This is my first pass, committing the simplest and most obviously unnecessary vars Change-Id: I9676a6e39a101937097788548764506c93811c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87414 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-26rename some local variablesNoel Grandin
mostly to make the job of my very aggressive unused local vars plugin easier Change-Id: Ifc21a920841f8589f8b7e10de39dba6622a5d501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-25Resolves: tdf#130159 hide writedirection unless CTL is enabledCaolán McNamara
rework as ToolboxControllers registered in Controller.xcu Change-Id: I3e7fea09fe83d1ed6400218c41384f82b38b07a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87419 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-25tdf#130157 Line Sidebar width, color, transparency, etc didn't workCaolán McNamara
Change-Id: I705e4ada386300ed626688b4e898227b60bff6a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-25Related: tdf#128942 remove the scrolledwindow frames from all the dialcontrolsCaolán McNamara
Change-Id: I445753ad1eb4d441e5a5e909ae450bda6013a6b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87352 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-25silence pesky gtk warnings on close of floating 3d windowCaolán McNamara
Change-Id: Ica301dec5f2744dc9fcc78974c3f9b3ed5c9d3b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87359 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-25loplugin:makeshared in svl..svxNoel Grandin
Change-Id: I067ea2f3cb651fdc5c3d1a09b0c55583618b9d1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87355 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-24Area Sidebar same grid and better spacingandreas kainz
Change-Id: I9d891f6d3c59ce047c7ec001c5facbbec4804a38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87313 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-24no need for these to be heap-allocatedNoel Grandin
Change-Id: I50a4350198e3c2b8eb669b43fb40e4b01dcb67ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87291 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-24rename PreviewControl3D back to Svx3DPreviewControlCaolán McNamara
Change-Id: I90791c4d87da465fbf486014cefe755985b600b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24rename LightControl3D back to Svx3DLightControlCaolán McNamara
Change-Id: I3e62bd55f195e9f652ddc21bff74f529a8678b5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87337 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24Svx3DLightControl is unusedCaolán McNamara
Change-Id: Ibd884eea366d3a66f786fc9e52323883f2dbca89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87299 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24rename LightCtl3D back to SvxLightCtl3DCaolán McNamara
Change-Id: I2cf5d019324643b048eea432753705af485720a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24remove some unused includes and update pchCaolán McNamara
Change-Id: I481e3431ce50618cc64b744303734a1763c51e57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87301 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24Svx3DPreviewControl is now unusedCaolán McNamara
Change-Id: I5ab6783cd0e36718798b0e7075f46a4e28e11761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87300 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24SvxLightCtl3D is now unusedCaolán McNamara
Change-Id: I4aca00692184a91ce969feb909a75dff897fe5e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87298 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24weld Svx3DWinCaolán McNamara
Change-Id: I472a4edb5ac7a8039d21128256c204e2969acc6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87296 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24set title of Color Replacer dialogCaolán McNamara
Change-Id: I79ae929e12b844c738eb62660d363fbd4699ed15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-24this wants to be UNO_QUERY_THROWNoel Grandin
based on the comment above it. It has been this way since commit fd069bee7e57ad529c3c0974559fd2d84ec3151a Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: I53fe66432639482018c57c04fcd6e7a4645a00cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87324 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-23lok: add id information to the selected graphicHenry Castro
When the graphic is selected it is necessary to send the id so the SVG background can be cached. Change-Id: I13afcad61c2f059f409484ea4af089dd199d1242 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87165 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87285 Tested-by: Jenkins
2020-01-23weld SvxBmpMaskCaolán McNamara
Change-Id: Ied627a0c6b1c85bac8fd0cafc21ae1acceaf2bcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87281 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-23Remove redundant redefinition of RULER_TAB_RTLStephan Bergmann
...which is already defined (with the same value) in include/svx/ruler.hxx (which is unconditionally included here). (This conditional definition had been introduced with 80204d8fcf35c14168a75765360eb61977653162 "MWS_SRX644: migrate branch mws_srx644 -> HEAD", for reasons that are likely lost to history by now.) Change-Id: Ib9293d4077ca07e0253c584ba8d91ec4d683f509 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87280 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-05 10:04:18 +0000